fix(backup): log missing db config instead of raising

- Use module logger in backup/db.py
- Skip db dump when no databases.csv entry is present
- Apply black/formatting cleanup across backup/restore/tests

https://chatgpt.com/share/69519d45-b0dc-800f-acb6-6fb8504e9b46

src/baudolo/backup/app.py

@@ -51,7 +51,9 @@ def is_image_ignored(container: str, images_no_backup_required: list[str]) -> bo
     return any(pat in img for pat in images_no_backup_required)
 
 
-def volume_is_fully_ignored(containers: list[str], images_no_backup_required: list[str]) -> bool:
+def volume_is_fully_ignored(
+    containers: list[str], images_no_backup_required: list[str]
+) -> bool:
     """
     Skip file backup only if all containers linked to the volume are ignored.
     """
@@ -178,6 +180,8 @@ def main() -> int:
     print("Finished volume backups.", flush=True)
 
     print("Handling Docker Compose services...", flush=True)
-    handle_docker_compose_services(args.compose_dir, args.docker_compose_hard_restart_required)
+    handle_docker_compose_services(
+        args.compose_dir, args.docker_compose_hard_restart_required
+    )
 
     return 0

src/baudolo/backup/cli.py

@@ -2,7 +2,7 @@ from __future__ import annotations
 
 import argparse
 import os
-from pathlib import Path
+
 
 def parse_args() -> argparse.Namespace:
     dirname = os.path.dirname(__file__)
@@ -25,7 +25,7 @@ def parse_args() -> argparse.Namespace:
 
     p.add_argument(
         "--repo-name",
-        default='backup-docker-to-local',
+        default="backup-docker-to-local",
         help="Backup repo folder name under <backups-dir>/<machine-id>/ (default: git repo folder name)",
     )
     p.add_argument(

src/baudolo/backup/compose.py

@@ -10,7 +10,9 @@ def hard_restart_docker_services(dir_path: str) -> None:
     subprocess.run(["docker-compose", "up", "-d"], cwd=dir_path, check=True)
 
 
-def handle_docker_compose_services(parent_directory: str, hard_restart_required: list[str]) -> None:
+def handle_docker_compose_services(
+    parent_directory: str, hard_restart_required: list[str]
+) -> None:
     for entry in os.scandir(parent_directory):
         if not entry.is_dir():
             continue

src/baudolo/backup/db.py

@@ -5,9 +5,12 @@ import pathlib
 import re
 
 import pandas
+import logging
 
 from .shell import BackupException, execute_shell_command
 
+log = logging.getLogger(__name__)
+
 
 def get_instance(container: str, database_containers: list[str]) -> str:
     if container in database_containers:
@@ -15,7 +18,9 @@ def get_instance(container: str, database_containers: list[str]) -> str:
     return re.split(r"(_|-)(database|db|postgres)", container)[0]
 
 
-def fallback_pg_dumpall(container: str, username: str, password: str, out_file: str) -> None:
+def fallback_pg_dumpall(
+    container: str, username: str, password: str, out_file: str
+) -> None:
     cmd = (
         f"PGPASSWORD={password} docker exec -i {container} "
         f"pg_dumpall -U {username} -h localhost > {out_file}"
@@ -34,7 +39,8 @@ def backup_database(
     instance_name = get_instance(container, database_containers)
     entries = databases_df.loc[databases_df["instance"] == instance_name]
     if entries.empty:
-        raise BackupException(f"No entry found for instance '{instance_name}'")
+        log.warning("No entry found for instance '%s'", instance_name)
+        return
 
     out_dir = os.path.join(volume_dir, "sql")
     pathlib.Path(out_dir).mkdir(parents=True, exist_ok=True)
@@ -68,6 +74,9 @@ def backup_database(
                 execute_shell_command(cmd)
             except BackupException as e:
                 print(f"pg_dump failed: {e}", flush=True)
-                print(f"Falling back to pg_dumpall for instance '{instance_name}'", flush=True)
+                print(
+                    f"Falling back to pg_dumpall for instance '{instance_name}'",
+                    flush=True,
+                )
                 fallback_pg_dumpall(container, user, password, cluster_file)
             continue

src/baudolo/backup/docker.py

@@ -37,7 +37,9 @@ def change_containers_status(containers: list[str], status: str) -> None:
 def docker_volume_exists(volume: str) -> bool:
     # Avoid throwing exceptions for exists checks.
     try:
-        execute_shell_command(f"docker volume inspect {volume} >/dev/null 2>&1 && echo OK")
+        execute_shell_command(
+            f"docker volume inspect {volume} >/dev/null 2>&1 && echo OK"
+        )
         return True
     except Exception:
         return False

src/baudolo/backup/volume.py

@@ -13,7 +13,9 @@ def get_storage_path(volume_name: str) -> str:
     return f"{path}/"
 
 
-def get_last_backup_dir(versions_dir: str, volume_name: str, current_backup_dir: str) -> str | None:
+def get_last_backup_dir(
+    versions_dir: str, volume_name: str, current_backup_dir: str
+) -> str | None:
     versions = sorted(os.listdir(versions_dir), reverse=True)
     for version in versions:
         candidate = os.path.join(versions_dir, version, volume_name, "files", "")
@@ -37,6 +39,8 @@ def backup_volume(versions_dir: str, volume_name: str, volume_dir: str) -> None:
         execute_shell_command(cmd)
     except BackupException as e:
         if "file has vanished" in str(e):
-            print("Warning: Some files vanished before transfer. Continuing.", flush=True)
+            print(
+                "Warning: Some files vanished before transfer. Continuing.", flush=True
+            )
         else:
             raise