refactor!: port shell scripts to Python package

Bash scripts were untestable and duplicated device/LUKS/mount logic;
the lim/ package centralizes it behind one subprocess wrapper and a
YAML image catalog (single point of truth).

BREAKING CHANGE: scripts/*.sh removed. Use `lim --type <cmd>`; new
types mount/umount/single-boot/raid1-boot/lock/unlock/import/export
replace direct script calls. --extra is deprecated and ignored.

- distributions.yml + lim/catalog.py hold the image catalog (PyYAML)
- pytest suite: 102 tests with mocked subprocess (tests/unit) and a
  250-line max file-length guard (tests/lint)
- ruff strict (select ALL), GitHub Actions CI, Dependabot; Travis gone
- Makefile: install (symlink ~/.local/bin/lim) and test targets
- fixes over bash: SUDO_USER-aware chown, mmcblk/nvme partition paths,
  sha512 checksum support, whole-pipeline failure detection, blkid
  UUID fallback for pre-mounted images, conditional fstab seeding for
  PARTUUID/LABEL images, clean errors for missing binaries
This commit is contained in:
Kevin Veen-Birkenbach
2026-07-14 11:27:49 +02:00
parent c420dd164d
commit ccdef065df
77 changed files with 3402 additions and 1614 deletions

92
tests/unit/test_runner.py Normal file
View File

@@ -0,0 +1,92 @@
"""Tests against the real runner module (no fake) using harmless commands."""
import subprocess
import pytest
from lim import runner, ui
from lim.errors import LimError
MISSING = "lim-definitely-missing-binary-x"
class TestMissingBinaries:
def test_run_raises_lim_error(self):
with pytest.raises(LimError, match="Command not found"):
runner.run([MISSING])
def test_run_tolerates_when_check_is_false(self):
result = runner.run([MISSING], check=False)
assert result.returncode == runner.COMMAND_NOT_FOUND
def test_output_raises_lim_error(self):
with pytest.raises(LimError, match="Command not found"):
runner.output([MISSING])
def test_output_tolerates_when_check_is_false(self):
assert runner.output([MISSING], check=False) == ""
def test_succeeds_returns_false(self):
assert runner.succeeds([MISSING]) is False
def test_tolerated_paths_emit_a_warning(self, monkeypatch):
warnings = []
monkeypatch.setattr(ui, "warning", warnings.append)
runner.run([MISSING], check=False)
runner.output([MISSING], check=False)
runner.succeeds([MISSING])
assert len(warnings) == 3
assert all("Command not found" in text for text in warnings)
def test_pipeline_raises_lim_error(self):
with pytest.raises(LimError, match="Command not found"):
runner.pipeline(["echo", "x"], [MISSING])
def test_pipeline_raises_when_first_member_is_missing(self):
with pytest.raises(LimError, match=f"Command not found: {MISSING}"):
runner.pipeline([MISSING], ["cat"])
def test_pipeline_reaps_started_members(self, monkeypatch):
spawned = []
original_popen = subprocess.Popen
def spying_popen(*args, **kwargs):
process = original_popen(*args, **kwargs)
spawned.append(process)
return process
monkeypatch.setattr(subprocess, "Popen", spying_popen)
with pytest.raises(LimError, match="Command not found"):
runner.pipeline(["sleep", "60"], [MISSING])
assert len(spawned) == 1
assert spawned[0].poll() is not None # killed and reaped, not running
assert spawned[0].stdout.closed
def test_run_prefers_explicit_error_message(self):
with pytest.raises(LimError, match="custom message"):
runner.run([MISSING], error_msg="custom message")
def test_output_prefers_explicit_error_message(self):
with pytest.raises(LimError, match="custom message"):
runner.output([MISSING], error_msg="custom message")
class TestHappyPath:
def test_run_returns_completed_process(self):
assert runner.run(["true"]).returncode == 0
def test_run_raises_on_nonzero_exit(self):
with pytest.raises(LimError, match="Command failed with code 1"):
runner.run(["false"])
def test_output_returns_stripped_stdout(self):
assert runner.output(["echo", "hello"]) == "hello"
def test_succeeds_reflects_exit_code(self):
assert runner.succeeds(["true"]) is True
assert runner.succeeds(["false"]) is False
def test_pipeline_runs_and_checks_every_member(self):
runner.pipeline(["echo", "x"], ["cat"]) # must not raise
with pytest.raises(LimError, match="Pipeline failed"):
runner.pipeline(["false"], ["cat"])