2025-12-05 19:32:42 +01:00
|
|
|
# tests/unit/pkgmgr/installers/test_makefile_installer.py
|
|
|
|
|
|
|
|
|
|
import os
|
|
|
|
|
import unittest
|
2025-12-08 11:05:08 +01:00
|
|
|
from unittest.mock import patch, mock_open
|
2025-12-05 19:32:42 +01:00
|
|
|
|
Refactor: Restructure pkgmgr into actions/, core/, and cli/ (full module breakup)
This commit introduces a large-scale structural refactor of the pkgmgr
codebase. All functionality has been moved from the previous flat
top-level layout into three clearly separated namespaces:
• pkgmgr.actions – high-level operations invoked by the CLI
• pkgmgr.core – pure logic, helpers, repository utilities,
versioning, git helpers, config IO, and
command resolution
• pkgmgr.cli – parser, dispatch, context, and command
handlers
Key improvements:
- Moved all “branch”, “release”, “changelog”, repo-management
actions, installer pipelines, and proxy execution logic into
pkgmgr.actions.<domain>.
- Reworked installer structure under
pkgmgr.actions.repository.install.installers
including OS-package installers, Nix, Python, and Makefile.
- Consolidated all low-level functionality under pkgmgr.core:
• git helpers → core/git
• config load/save → core/config
• repository helpers → core/repository
• versioning & semver → core/version
• command helpers (alias, resolve, run, ink) → core/command
- Replaced pkgmgr.cli_core with pkgmgr.cli and updated all imports.
- Added minimal __init__.py files for clean package exposure.
- Updated all E2E, integration, and unit tests with new module paths.
- Fixed patch targets so mocks point to the new structure.
- Ensured backward compatibility at the CLI boundary (pkgmgr entry point unchanged).
This refactor produces a cleaner, layered architecture:
- `core` = logic
- `actions` = orchestrated behaviour
- `cli` = user interface
Reference: ChatGPT-assisted refactor discussion
https://chatgpt.com/share/6938221c-e24c-800f-8317-7732cedf39b9
2025-12-09 14:20:19 +01:00
|
|
|
from pkgmgr.actions.repository.install.context import RepoContext
|
|
|
|
|
from pkgmgr.actions.repository.install.installers.makefile import MakefileInstaller
|
2025-12-05 19:32:42 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
class TestMakefileInstaller(unittest.TestCase):
|
|
|
|
|
def setUp(self):
|
|
|
|
|
self.repo = {"name": "test-repo"}
|
|
|
|
|
self.ctx = RepoContext(
|
|
|
|
|
repo=self.repo,
|
|
|
|
|
identifier="test-id",
|
|
|
|
|
repo_dir="/tmp/repo",
|
|
|
|
|
repositories_base_dir="/tmp",
|
|
|
|
|
bin_dir="/bin",
|
|
|
|
|
all_repos=[self.repo],
|
|
|
|
|
no_verification=False,
|
|
|
|
|
preview=False,
|
|
|
|
|
quiet=False,
|
|
|
|
|
clone_mode="ssh",
|
|
|
|
|
update_dependencies=False,
|
|
|
|
|
)
|
|
|
|
|
self.installer = MakefileInstaller()
|
|
|
|
|
|
|
|
|
|
@patch("os.path.exists", return_value=True)
|
|
|
|
|
def test_supports_true_when_makefile_exists(self, mock_exists):
|
|
|
|
|
self.assertTrue(self.installer.supports(self.ctx))
|
|
|
|
|
mock_exists.assert_called_with(os.path.join(self.ctx.repo_dir, "Makefile"))
|
|
|
|
|
|
|
|
|
|
@patch("os.path.exists", return_value=False)
|
|
|
|
|
def test_supports_false_when_makefile_missing(self, mock_exists):
|
|
|
|
|
self.assertFalse(self.installer.supports(self.ctx))
|
|
|
|
|
|
Refactor: Restructure pkgmgr into actions/, core/, and cli/ (full module breakup)
This commit introduces a large-scale structural refactor of the pkgmgr
codebase. All functionality has been moved from the previous flat
top-level layout into three clearly separated namespaces:
• pkgmgr.actions – high-level operations invoked by the CLI
• pkgmgr.core – pure logic, helpers, repository utilities,
versioning, git helpers, config IO, and
command resolution
• pkgmgr.cli – parser, dispatch, context, and command
handlers
Key improvements:
- Moved all “branch”, “release”, “changelog”, repo-management
actions, installer pipelines, and proxy execution logic into
pkgmgr.actions.<domain>.
- Reworked installer structure under
pkgmgr.actions.repository.install.installers
including OS-package installers, Nix, Python, and Makefile.
- Consolidated all low-level functionality under pkgmgr.core:
• git helpers → core/git
• config load/save → core/config
• repository helpers → core/repository
• versioning & semver → core/version
• command helpers (alias, resolve, run, ink) → core/command
- Replaced pkgmgr.cli_core with pkgmgr.cli and updated all imports.
- Added minimal __init__.py files for clean package exposure.
- Updated all E2E, integration, and unit tests with new module paths.
- Fixed patch targets so mocks point to the new structure.
- Ensured backward compatibility at the CLI boundary (pkgmgr entry point unchanged).
This refactor produces a cleaner, layered architecture:
- `core` = logic
- `actions` = orchestrated behaviour
- `cli` = user interface
Reference: ChatGPT-assisted refactor discussion
https://chatgpt.com/share/6938221c-e24c-800f-8317-7732cedf39b9
2025-12-09 14:20:19 +01:00
|
|
|
@patch("pkgmgr.actions.repository.install.installers.makefile.run_command")
|
2025-12-08 11:05:08 +01:00
|
|
|
@patch(
|
|
|
|
|
"builtins.open",
|
|
|
|
|
new_callable=mock_open,
|
|
|
|
|
read_data="install:\n\t@echo 'installing'\n",
|
|
|
|
|
)
|
2025-12-05 19:32:42 +01:00
|
|
|
@patch("os.path.exists", return_value=True)
|
2025-12-08 11:05:08 +01:00
|
|
|
def test_run_executes_make_install_when_target_present(
|
|
|
|
|
self, mock_exists, mock_file, mock_run_command
|
|
|
|
|
):
|
2025-12-05 19:32:42 +01:00
|
|
|
self.installer.run(self.ctx)
|
2025-12-08 11:05:08 +01:00
|
|
|
|
|
|
|
|
# Ensure we checked the Makefile and then called make install.
|
|
|
|
|
mock_file.assert_called_once_with(
|
|
|
|
|
os.path.join(self.ctx.repo_dir, "Makefile"),
|
|
|
|
|
"r",
|
|
|
|
|
encoding="utf-8",
|
|
|
|
|
errors="ignore",
|
|
|
|
|
)
|
|
|
|
|
|
2025-12-05 19:32:42 +01:00
|
|
|
cmd = mock_run_command.call_args[0][0]
|
|
|
|
|
self.assertEqual(cmd, "make install")
|
|
|
|
|
self.assertEqual(
|
|
|
|
|
mock_run_command.call_args[1].get("cwd"),
|
|
|
|
|
self.ctx.repo_dir,
|
|
|
|
|
)
|
|
|
|
|
|
Refactor: Restructure pkgmgr into actions/, core/, and cli/ (full module breakup)
This commit introduces a large-scale structural refactor of the pkgmgr
codebase. All functionality has been moved from the previous flat
top-level layout into three clearly separated namespaces:
• pkgmgr.actions – high-level operations invoked by the CLI
• pkgmgr.core – pure logic, helpers, repository utilities,
versioning, git helpers, config IO, and
command resolution
• pkgmgr.cli – parser, dispatch, context, and command
handlers
Key improvements:
- Moved all “branch”, “release”, “changelog”, repo-management
actions, installer pipelines, and proxy execution logic into
pkgmgr.actions.<domain>.
- Reworked installer structure under
pkgmgr.actions.repository.install.installers
including OS-package installers, Nix, Python, and Makefile.
- Consolidated all low-level functionality under pkgmgr.core:
• git helpers → core/git
• config load/save → core/config
• repository helpers → core/repository
• versioning & semver → core/version
• command helpers (alias, resolve, run, ink) → core/command
- Replaced pkgmgr.cli_core with pkgmgr.cli and updated all imports.
- Added minimal __init__.py files for clean package exposure.
- Updated all E2E, integration, and unit tests with new module paths.
- Fixed patch targets so mocks point to the new structure.
- Ensured backward compatibility at the CLI boundary (pkgmgr entry point unchanged).
This refactor produces a cleaner, layered architecture:
- `core` = logic
- `actions` = orchestrated behaviour
- `cli` = user interface
Reference: ChatGPT-assisted refactor discussion
https://chatgpt.com/share/6938221c-e24c-800f-8317-7732cedf39b9
2025-12-09 14:20:19 +01:00
|
|
|
@patch("pkgmgr.actions.repository.install.installers.makefile.run_command")
|
2025-12-08 11:05:08 +01:00
|
|
|
@patch(
|
|
|
|
|
"builtins.open",
|
|
|
|
|
new_callable=mock_open,
|
|
|
|
|
read_data="all:\n\t@echo 'nothing here'\n",
|
|
|
|
|
)
|
|
|
|
|
@patch("os.path.exists", return_value=True)
|
|
|
|
|
def test_run_skips_when_no_install_target(
|
|
|
|
|
self, mock_exists, mock_file, mock_run_command
|
|
|
|
|
):
|
|
|
|
|
self.installer.run(self.ctx)
|
|
|
|
|
|
|
|
|
|
# We should have read the Makefile, but not called run_command().
|
|
|
|
|
mock_file.assert_called_once_with(
|
|
|
|
|
os.path.join(self.ctx.repo_dir, "Makefile"),
|
|
|
|
|
"r",
|
|
|
|
|
encoding="utf-8",
|
|
|
|
|
errors="ignore",
|
|
|
|
|
)
|
|
|
|
|
mock_run_command.assert_not_called()
|
|
|
|
|
|
2025-12-05 19:32:42 +01:00
|
|
|
|
|
|
|
|
if __name__ == "__main__":
|
|
|
|
|
unittest.main()
|