test(integration): add unittest-based repository layout contract test
Some checks failed
Mark stable commit / test-unit (push) Has been cancelled
Mark stable commit / test-integration (push) Has been cancelled
Mark stable commit / test-env-virtual (push) Has been cancelled
Mark stable commit / test-env-nix (push) Has been cancelled
Mark stable commit / test-e2e (push) Has been cancelled
Mark stable commit / test-virgin-user (push) Has been cancelled
Mark stable commit / test-virgin-root (push) Has been cancelled
Mark stable commit / codesniffer-shellcheck (push) Has been cancelled
Mark stable commit / codesniffer-ruff (push) Has been cancelled
Mark stable commit / mark-stable (push) Has been cancelled

- Add integration test using unittest to verify canonical repository paths
- Assert pkgmgr repository satisfies template layout (packaging, changelog, metadata)
- Use real filesystem without mocks or pytest dependencies

https://chatgpt.com/share/693eaa75-98f0-800f-adca-439555f84154
This commit is contained in:
Kevin Veen-Birkenbach
2025-12-14 13:26:18 +01:00
parent db9aaf920e
commit 84b6c71748

View File

@@ -1,11 +1,9 @@
# tests/integration/test_repository_paths_exist.py
from __future__ import annotations from __future__ import annotations
import os import os
import unittest
from pathlib import Path from pathlib import Path
import pytest
from pkgmgr.core.repository.paths import resolve_repo_paths from pkgmgr.core.repository.paths import resolve_repo_paths
@@ -13,7 +11,7 @@ def _find_repo_root() -> Path:
""" """
Locate the pkgmgr repository root from the test location. Locate the pkgmgr repository root from the test location.
This assumes the standard layout: Assumes:
repo_root/ repo_root/
src/pkgmgr/... src/pkgmgr/...
tests/integration/... tests/integration/...
@@ -25,40 +23,43 @@ def _find_repo_root() -> Path:
raise RuntimeError("Could not determine repository root for pkgmgr integration test") raise RuntimeError("Could not determine repository root for pkgmgr integration test")
def test_pkgmgr_repository_paths_exist() -> None: class TestRepositoryPathsExist(unittest.TestCase):
"""
Integration test: pkgmgr is the TEMPLATE repository.
All canonical paths resolved for pkgmgr must exist.
""" """
Integration test: verify that the pkgmgr repository provides all
canonical files defined by RepoPaths.
pkgmgr acts as the TEMPLATE repository for all other packages. def test_pkgmgr_repository_paths_exist(self) -> None:
Therefore, every path resolved here is expected to exist.
"""
repo_root = _find_repo_root() repo_root = _find_repo_root()
paths = resolve_repo_paths(str(repo_root)) paths = resolve_repo_paths(str(repo_root))
missing: list[str] = [] missing: list[str] = []
def _require(path: str | None, description: str) -> None: def require(path: str | None, description: str) -> None:
if not path: if not path:
missing.append(f"{description}: <not resolved>") missing.append(f"{description}: <not resolved>")
return return
if not os.path.isfile(path): if not os.path.isfile(path):
missing.append(f"{description}: {path} (missing)") missing.append(f"{description}: {path} (missing)")
# Core metadata (must always exist) # Core metadata
_require(paths.pyproject_toml, "pyproject.toml") require(paths.pyproject_toml, "pyproject.toml")
_require(paths.flake_nix, "flake.nix") require(paths.flake_nix, "flake.nix")
# Human-facing changelog (pkgmgr must provide one) # Human changelog
_require(paths.changelog_md, "CHANGELOG.md") require(paths.changelog_md, "CHANGELOG.md")
# Packaging files (pkgmgr is the reference implementation) # Packaging files (pkgmgr defines the template)
_require(paths.arch_pkgbuild, "Arch PKGBUILD") require(paths.arch_pkgbuild, "Arch PKGBUILD")
_require(paths.debian_changelog, "Debian changelog") require(paths.debian_changelog, "Debian changelog")
_require(paths.rpm_spec, "RPM spec file") require(paths.rpm_spec, "RPM spec file")
if missing: if missing:
pytest.fail( self.fail(
"pkgmgr repository does not satisfy the canonical repository layout:\n" "pkgmgr repository does not satisfy the canonical repository layout:\n"
+ "\n".join(f" - {item}" for item in missing) + "\n".join(f" - {item}" for item in missing)
) )
if __name__ == "__main__":
unittest.main()