Add ShellCheck and Ruff code sniffers to CI and release workflows
Some checks failed
Ruff (Python code sniffer) / codesniffer-ruff (push) Has been cancelled
ShellCheck / codesniffer-shellcheck (push) Has been cancelled
Mark stable commit / test-unit (push) Has been cancelled
Mark stable commit / test-integration (push) Has been cancelled
Mark stable commit / test-env-virtual (push) Has been cancelled
Mark stable commit / test-env-nix (push) Has been cancelled
Mark stable commit / test-e2e (push) Has been cancelled
Mark stable commit / test-virgin-user (push) Has been cancelled
Mark stable commit / test-virgin-root (push) Has been cancelled
Mark stable commit / codesniffer-shellcheck (push) Has been cancelled
Mark stable commit / codesniffer-ruff (push) Has been cancelled
Mark stable commit / mark-stable (push) Has been cancelled

- Introduce dedicated ShellCheck workflow for Bash scripts
- Add Ruff as Python code sniffer for src/ and tests/
- Integrate both sniffers into main CI pipeline
- Require successful sniffer runs before marking a release as stable
- Ensure consistent code quality checks across CI and release workflows

https://chatgpt.com/share/693d5b26-293c-800f-999d-48b2950b9417
This commit is contained in:
Kevin Veen-Birkenbach
2025-12-13 13:24:58 +01:00
parent 71a4e7e725
commit ea84c1b14e
4 changed files with 53 additions and 0 deletions

View File

@@ -27,3 +27,9 @@ jobs:
test-virgin-root:
uses: ./.github/workflows/test-virgin-root.yml
codesniffer-shellcheck:
uses: ./.github/workflows/codesniffer-shellcheck.yml
codesniffer-ruff:
uses: ./.github/workflows/codesniffer-ruff.yml

24
.github/workflows/codesniffer-ruff.yml vendored Normal file
View File

@@ -0,0 +1,24 @@
name: Ruff (Python code sniffer)
on:
push:
pull_request:
jobs:
codesniffer-ruff:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.12"
- name: Install ruff
run: pip install ruff
- name: Run ruff
run: |
ruff check src tests

View File

@@ -0,0 +1,15 @@
name: ShellCheck
on:
push:
pull_request:
jobs:
codesniffer-shellcheck:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install ShellCheck
run: sudo apt-get update && sudo apt-get install -y shellcheck
- name: Run ShellCheck
run: shellcheck -x $(find scripts -type f -name '*.sh' -print)

View File

@@ -29,8 +29,16 @@ jobs:
test-virgin-root:
uses: ./.github/workflows/test-virgin-root.yml
codesniffer-shellcheck:
uses: ./.github/workflows/codesniffer-shellcheck.yml
codesniffer-ruff:
uses: ./.github/workflows/codesniffer-ruff.yml
mark-stable:
needs:
- codesniffer-shellcheck
- codesniffer-ruff
- test-unit
- test-integration
- test-env-nix