16a9d55d4f
References: - Current ChatGPT conversation: https://chatgpt.com/share/6935d6d7-0ae4-800f-988a-44a50c17ba48 - Extended discussion: https://chatgpt.com/share/6935d734-fd84-800f-9755-290902b8cee8 Summary: This commit performs a major cleanup and modernization of the installation pipeline: 1. Introduced a new capability-detection subsystem: - Capabilities (python-runtime, make-install, nix-flake) are detected per installer/layer. - Installers run only when they add new capabilities. - Prevents duplicated work such as Python installers running when Nix already provides the runtime. 2. Removed deprecated pkgmgr.yml manifest installer: - Dependency resolution is now delegated entirely to real package managers (Nix, pip, make, distro build tools). - Simplifies layering and avoids unnecessary recursion. 3. Reworked OS-specific installers: - Arch PKGBUILD now uses 'makepkg --syncdeps --cleanbuild --install --noconfirm'. - Debian installer now builds proper .deb packages via dpkg-buildpackage + installs them. - RPM installer now builds packages using rpmbuild and installs them via rpm. 4. Switched from remote GitHub flakes to local-flake execution: - Wrapper now executes: nix run /usr/lib/package-manager#pkgmgr - Avoids lock-file write attempts and improves reliability in CI. 5. Added bash -i based integration test: - Correctly sources ~/.bashrc and evaluates alias + venv activation. - ‘pkgmgr --help’ is now printed for debugging without failing tests. 6. Updated unit tests across all installers: - Removed references to manifest installer. - Adjusted expectations for new behaviors (makepkg, dpkg-buildpackage, rpmbuild). - Added capability subsystem tests. 7. Improved flake.nix packaging logic: - The entire project source tree is copied into the runtime closure. - pkgmgr wrapper now executes runpy inside the packaged directory. Together, these changes create a predictable, layered, capability-driven installer pipeline with consistent behavior across Arch, Debian, RPM, Nix, and Python layers.
130 lines
4.2 KiB
Python
130 lines
4.2 KiB
Python
#!/usr/bin/env python3
|
|
# -*- coding: utf-8 -*-
|
|
|
|
"""
|
|
Installer for Debian/Ubuntu packages defined via debian/control.
|
|
|
|
This installer:
|
|
|
|
1. Installs build dependencies via `apt-get build-dep ./`
|
|
2. Uses dpkg-buildpackage to build .deb packages from debian/*
|
|
3. Installs the resulting .deb files via `dpkg -i`
|
|
|
|
It is intended for Debian-based systems where dpkg-buildpackage and
|
|
apt/dpkg tooling are available.
|
|
"""
|
|
|
|
import glob
|
|
import os
|
|
import shutil
|
|
|
|
from typing import List
|
|
|
|
from pkgmgr.context import RepoContext
|
|
from pkgmgr.installers.base import BaseInstaller
|
|
from pkgmgr.run_command import run_command
|
|
|
|
|
|
class DebianControlInstaller(BaseInstaller):
|
|
"""
|
|
Build and install a Debian/Ubuntu package from debian/control.
|
|
|
|
This installer is responsible for the full build + install of the
|
|
application on Debian-like systems.
|
|
"""
|
|
|
|
# Logical layer name, used by capability matchers.
|
|
layer = "os-packages"
|
|
|
|
CONTROL_DIR = "debian"
|
|
CONTROL_FILE = "control"
|
|
|
|
def _is_debian_like(self) -> bool:
|
|
"""Return True if this looks like a Debian-based system."""
|
|
return shutil.which("dpkg-buildpackage") is not None
|
|
|
|
def _control_path(self, ctx: RepoContext) -> str:
|
|
return os.path.join(ctx.repo_dir, self.CONTROL_DIR, self.CONTROL_FILE)
|
|
|
|
def supports(self, ctx: RepoContext) -> bool:
|
|
"""
|
|
This installer is supported if:
|
|
- we are on a Debian-like system (dpkg-buildpackage available), and
|
|
- debian/control exists.
|
|
"""
|
|
if not self._is_debian_like():
|
|
return False
|
|
|
|
return os.path.exists(self._control_path(ctx))
|
|
|
|
def _find_built_debs(self, repo_dir: str) -> List[str]:
|
|
"""
|
|
Find .deb files built by dpkg-buildpackage.
|
|
|
|
By default, dpkg-buildpackage creates .deb files in the parent
|
|
directory of the source tree.
|
|
"""
|
|
parent = os.path.dirname(repo_dir)
|
|
pattern = os.path.join(parent, "*.deb")
|
|
return sorted(glob.glob(pattern))
|
|
|
|
def _install_build_dependencies(self, ctx: RepoContext) -> None:
|
|
"""
|
|
Install build dependencies using `apt-get build-dep ./`.
|
|
|
|
This is a best-effort implementation that assumes:
|
|
- deb-src entries are configured in /etc/apt/sources.list*,
|
|
- apt-get is available on PATH.
|
|
|
|
Any failure is treated as fatal (SystemExit), just like other
|
|
installer steps.
|
|
"""
|
|
if shutil.which("apt-get") is None:
|
|
print(
|
|
"[Warning] apt-get not found on PATH. "
|
|
"Skipping automatic build-dep installation for Debian."
|
|
)
|
|
return
|
|
|
|
# Update package lists first for reliable build-dep resolution.
|
|
run_command("sudo apt-get update", cwd=ctx.repo_dir, preview=ctx.preview)
|
|
|
|
# Install build dependencies based on debian/control in the current tree.
|
|
# `apt-get build-dep ./` uses the source in the current directory.
|
|
builddep_cmd = "sudo apt-get build-dep -y ./"
|
|
run_command(builddep_cmd, cwd=ctx.repo_dir, preview=ctx.preview)
|
|
|
|
def run(self, ctx: RepoContext) -> None:
|
|
"""
|
|
Build and install Debian/Ubuntu packages from debian/*.
|
|
|
|
Steps:
|
|
1. apt-get build-dep ./ (automatic build dependency installation)
|
|
2. dpkg-buildpackage -b -us -uc
|
|
3. sudo dpkg -i ../*.deb
|
|
"""
|
|
control_path = self._control_path(ctx)
|
|
if not os.path.exists(control_path):
|
|
return
|
|
|
|
# 1) Install build dependencies
|
|
self._install_build_dependencies(ctx)
|
|
|
|
# 2) Build the package
|
|
build_cmd = "dpkg-buildpackage -b -us -uc"
|
|
run_command(build_cmd, cwd=ctx.repo_dir, preview=ctx.preview)
|
|
|
|
# 3) Locate built .deb files
|
|
debs = self._find_built_debs(ctx.repo_dir)
|
|
if not debs:
|
|
print(
|
|
"[Warning] No .deb files found after dpkg-buildpackage. "
|
|
"Skipping Debian package installation."
|
|
)
|
|
return
|
|
|
|
# 4) Install .deb files
|
|
install_cmd = "sudo dpkg -i " + " ".join(os.path.basename(d) for d in debs)
|
|
parent = os.path.dirname(ctx.repo_dir)
|
|
run_command(install_cmd, cwd=parent, preview=ctx.preview)
|