b4e0594901
Repository-wide mechanical cleanup so `ruff check src tests` has a chance of passing; no behavioural changes. - Add `from __future__ import annotations` where PEP 604 unions are used. This has to come first: pyproject declares requires-python >= 3.9, where `X | None` is not evaluable at runtime unless annotations are stringified. - Replace typing.List/Dict/Tuple/Set with the builtin generics and Optional[X] with X | None, then drop the imports that became unused. The four actions/*/__init__.py files needed this by hand because ruff leaves unused imports in __init__.py alone (possible re-exports). - Strip shebangs from 72 importable modules. None of them are executable or invoked directly; the entry points are console_scripts and runpy. - Flatten nested `with` blocks, collapse needless-bool returns, and apply the remaining mechanical ruff fixes (PIE810, FLY002, PERF102, FURB192, RUF059, I001). - Pass check=False explicitly to the four subprocess.run() calls that inspect returncode themselves. That is the existing default. Two rewrites are visible to mocks, so their tests move with them: subprocess.run(stdout=PIPE, stderr=PIPE) became capture_output=True, and open(path, "r", ...) lost the redundant mode. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
74 lines
2.3 KiB
Python
74 lines
2.3 KiB
Python
"""
|
|
Integration tests for the `pkgmgr make` command.
|
|
|
|
We exercise the wrapper around `make` using the pkgmgr repository as
|
|
the standard target, but only in --preview mode to avoid side effects.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import runpy
|
|
import sys
|
|
import unittest
|
|
|
|
from test_version_commands import _load_pkgmgr_repo_dir
|
|
|
|
|
|
class TestIntegrationMakeCommands(unittest.TestCase):
|
|
"""
|
|
E2E tests for the pkgmgr `make` wrapper.
|
|
"""
|
|
|
|
@classmethod
|
|
def setUpClass(cls) -> None:
|
|
# Reuse the helper from the version tests to locate the pkgmgr repo
|
|
cls.pkgmgr_repo_dir = _load_pkgmgr_repo_dir()
|
|
|
|
def _run_pkgmgr_make(self, extra_args: list[str]) -> None:
|
|
"""
|
|
Run `pkgmgr make ...` with the given extra args, from inside
|
|
the pkgmgr repository.
|
|
|
|
Any non-zero exit code is treated as test failure.
|
|
"""
|
|
cmd_repr = "pkgmgr " + " ".join(extra_args)
|
|
original_argv = list(sys.argv)
|
|
original_cwd = os.getcwd()
|
|
|
|
try:
|
|
os.chdir(self.pkgmgr_repo_dir)
|
|
sys.argv = ["pkgmgr"] + extra_args
|
|
|
|
try:
|
|
runpy.run_module("pkgmgr", run_name="__main__")
|
|
except SystemExit as exc:
|
|
code = exc.code if isinstance(exc.code, int) else str(exc.code)
|
|
if code != 0:
|
|
print("[TEST] SystemExit caught while running", cmd_repr)
|
|
print(f"[TEST] Working directory: {os.getcwd()}")
|
|
print(f"[TEST] Exit code: {code}")
|
|
raise AssertionError(
|
|
f"{cmd_repr!r} failed with exit code {code}. "
|
|
"Scroll up to inspect the output printed before failure."
|
|
) from exc
|
|
# exit code 0 is success
|
|
|
|
finally:
|
|
os.chdir(original_cwd)
|
|
sys.argv = original_argv
|
|
|
|
def test_make_install_pkgmgr_preview(self) -> None:
|
|
"""
|
|
Run: pkgmgr make pkgmgr install --preview
|
|
|
|
- 'pkgmgr' is used as the standard repository identifier.
|
|
- '--preview' ensures that no destructive make commands are
|
|
actually executed inside the container.
|
|
"""
|
|
self._run_pkgmgr_make(["make", "install", "--preview", "pkgmgr"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|