d4b00046d3
- Introduce explicit CLI layer model (os-packages, nix, python, makefile) and central InstallationPipeline to orchestrate installers. - Move installer orchestration out of install_repos() into pkgmgr.actions.repository.install.pipeline, using layer precedence and capability tracking. - Add pkgmgr.actions.repository.install.layers to classify commands into layers and compare priorities. - Rework PythonInstaller to always use isolated environments: PKGMGR_PIP override → active venv → per-repo venv under ~/.venvs/<identifier>, avoiding system Python and PEP 668 conflicts. - Adjust NixFlakeInstaller to install flake outputs based on repository identity: pkgmgr/package-manager → pkgmgr (mandatory) + default (optional), all other repos → default (mandatory). - Tighten MakefileInstaller behaviour, add global PKGMGR_DISABLE_MAKEFILE_INSTALLER switch, and simplify install target detection. - Rewrite resolve_command_for_repo() with explicit Repository typing, better Python package detection, Nix/PATH resolution, and a library-only fallback instead of raising on missing CLI. - Update flake.nix devShell to provide python3 with pip and add pip as a propagated build input. - Remove deprecated/wip repository entries from config defaults and drop the unused config/wip.yml. https://chatgpt.com/share/69399157-86d8-800f-9935-1a820893e908
89 lines
2.9 KiB
Python
89 lines
2.9 KiB
Python
# tests/unit/pkgmgr/installers/test_makefile_installer.py
|
|
|
|
import os
|
|
import unittest
|
|
from unittest.mock import patch, mock_open
|
|
|
|
from pkgmgr.actions.repository.install.context import RepoContext
|
|
from pkgmgr.actions.repository.install.installers.makefile import MakefileInstaller
|
|
|
|
|
|
class TestMakefileInstaller(unittest.TestCase):
|
|
def setUp(self):
|
|
self.repo = {"name": "test-repo"}
|
|
self.ctx = RepoContext(
|
|
repo=self.repo,
|
|
identifier="test-id",
|
|
repo_dir="/tmp/repo",
|
|
repositories_base_dir="/tmp",
|
|
bin_dir="/bin",
|
|
all_repos=[self.repo],
|
|
no_verification=False,
|
|
preview=False,
|
|
quiet=False,
|
|
clone_mode="ssh",
|
|
update_dependencies=False,
|
|
)
|
|
self.installer = MakefileInstaller()
|
|
|
|
# @patch("os.path.exists", return_value=True)
|
|
# def test_supports_true_when_makefile_exists(self, mock_exists):
|
|
# self.assertTrue(self.installer.supports(self.ctx))
|
|
# mock_exists.assert_called_with(os.path.join(self.ctx.repo_dir, "Makefile"))
|
|
|
|
@patch("os.path.exists", return_value=False)
|
|
def test_supports_false_when_makefile_missing(self, mock_exists):
|
|
self.assertFalse(self.installer.supports(self.ctx))
|
|
|
|
@patch("pkgmgr.actions.repository.install.installers.makefile.run_command")
|
|
@patch(
|
|
"builtins.open",
|
|
new_callable=mock_open,
|
|
read_data="install:\n\t@echo 'installing'\n",
|
|
)
|
|
@patch("os.path.exists", return_value=True)
|
|
def test_run_executes_make_install_when_target_present(
|
|
self, mock_exists, mock_file, mock_run_command
|
|
):
|
|
self.installer.run(self.ctx)
|
|
|
|
# Ensure we checked the Makefile and then called make install.
|
|
mock_file.assert_called_once_with(
|
|
os.path.join(self.ctx.repo_dir, "Makefile"),
|
|
"r",
|
|
encoding="utf-8",
|
|
errors="ignore",
|
|
)
|
|
|
|
cmd = mock_run_command.call_args[0][0]
|
|
self.assertEqual(cmd, "make install")
|
|
self.assertEqual(
|
|
mock_run_command.call_args[1].get("cwd"),
|
|
self.ctx.repo_dir,
|
|
)
|
|
|
|
@patch("pkgmgr.actions.repository.install.installers.makefile.run_command")
|
|
@patch(
|
|
"builtins.open",
|
|
new_callable=mock_open,
|
|
read_data="all:\n\t@echo 'nothing here'\n",
|
|
)
|
|
@patch("os.path.exists", return_value=True)
|
|
def test_run_skips_when_no_install_target(
|
|
self, mock_exists, mock_file, mock_run_command
|
|
):
|
|
self.installer.run(self.ctx)
|
|
|
|
# We should have read the Makefile, but not called run_command().
|
|
mock_file.assert_called_once_with(
|
|
os.path.join(self.ctx.repo_dir, "Makefile"),
|
|
"r",
|
|
encoding="utf-8",
|
|
errors="ignore",
|
|
)
|
|
mock_run_command.assert_not_called()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|