skills/tests/test_lock.py

"""Validate skills-lock.json: shape, required fields, and hash format."""

from __future__ import annotations

import importlib.util
import json
import re
import subprocess
import sys
import unittest
from pathlib import Path

REPO_ROOT = Path(__file__).resolve().parents[1]
LOCK_FILE = REPO_ROOT / "skills-lock.json"
BUDGET = REPO_ROOT / "scripts" / "budget.py"
SPEC = importlib.util.spec_from_file_location("budget", BUDGET)
budget = importlib.util.module_from_spec(SPEC)
SPEC.loader.exec_module(budget)

HASH_RE = re.compile(r"^[0-9a-f]{64}$")
REQUIRED_FIELDS = ("source", "sourceType", "skillPath", "computedHash")


class TestSkillsLock(unittest.TestCase):
    def setUp(self):
        self.lock = json.loads(LOCK_FILE.read_text(encoding="utf-8"))

    def test_version_is_supported(self):
        self.assertEqual(self.lock.get("version"), 1)

    def test_skills_present(self):
        self.assertTrue(self.lock.get("skills"), "lock holds no skills")

    def test_every_skill_is_complete(self):
        for name, entry in self.lock["skills"].items():
            with self.subTest(skill=name):
                for field in REQUIRED_FIELDS:
                    self.assertTrue(
                        str(entry.get(field, "")).strip(),
                        f"{name}: missing or empty field '{field}'",
                    )
                self.assertRegex(
                    entry["computedHash"],
                    HASH_RE,
                    f"{name}: computedHash is not a sha256 hex digest",
                )
                self.assertTrue(
                    entry["skillPath"].endswith("SKILL.md"),
                    f"{name}: skillPath must point to a SKILL.md",
                )

    def test_skills_sorted_ascending(self):
        names = list(self.lock["skills"].keys())
        self.assertEqual(
            names,
            sorted(names),
            f"skills must be sorted ascending; expected {sorted(names)}",
        )

    def test_first_party_skills_have_valid_frontmatter(self):
        for skill_md in sorted((REPO_ROOT / "skills").glob("*/SKILL.md")):
            with self.subTest(skill=skill_md.parent.name):
                text = skill_md.read_text(encoding="utf-8")
                self.assertTrue(text.startswith("---\n"), "missing frontmatter")
                frontmatter = text.split("---", 2)[1]
                self.assertIn("name:", frontmatter, "frontmatter missing name")
                self.assertIn(
                    "description:", frontmatter, "frontmatter missing description"
                )

    def test_descriptions_fit_the_listing_budget(self):
        found = budget.counts(REPO_ROOT, index=False)
        for name, words in found.items():
            with self.subTest(skill=name):
                self.assertLessEqual(words, budget.DESCRIPTION_WORDS)
        self.assertLessEqual(sum(found.values()), budget.LISTING_WORDS)

    def test_skill_files_fit_the_word_cap(self):
        for name, words in budget.skill_sizes(REPO_ROOT).items():
            with self.subTest(skill=name):
                self.assertLessEqual(
                    words, budget.SKILL_WORDS, "move details into a side file the skill reads on demand"
                )

    def test_budget_script_reports_the_total_and_the_longest(self):
        result = subprocess.run(
            [sys.executable, str(BUDGET), "--repo", str(REPO_ROOT), "--top", "3"],
            capture_output=True, text=True, check=False,
        )
        self.assertEqual(result.returncode, 0, result.stdout)
        self.assertRegex(result.stdout, r"^total \d+/\d+ words in \d+ skills\n")
        self.assertEqual(len(result.stdout.splitlines()), 4)
        self.assertEqual(budget.words("---\nname: x\ndescription: >\n  one two three\n---\n"), 3)

    def test_first_party_skills_do_not_shadow_locked_skills(self):
        locked = set(self.lock["skills"].keys())
        for skill_dir in sorted((REPO_ROOT / "skills").glob("*/")):
            self.assertNotIn(
                skill_dir.name.rstrip("/"),
                locked,
                f"first-party skill '{skill_dir.name}' collides with a locked skill",
            )


if __name__ == "__main__":
    unittest.main()