kevinveenbirkenbach/skills
1
0 Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

feat(orchestrator): operator composer with signed text and voice

Browse Source 
Stream -> Radio gets one line per station with state, play and stop,
autoplay and CSP refusals as row state and toast, and the speaking agent
pulsing there and in the Orbit and Chord views. The composer sends on all
seven channels; push-to-talk records with MediaRecorder, whisper.cpp
transcribes off the request thread under per-minute and per-hour caps,
and the recording travels only when "Aufnahme anhängen" is ticked.

Every operator message, the mayday clear, the day and night board
actions and a settings save that adds a stream origin take the passkey;
the hub verifies each signature once against the pinned keys before it
relays or acts. The container gets TMPDIR=/scratch so that verification
no longer fails on the read-only root.

A denial now signs its recipient: the inbox and the signing step resolve
it through one function, a claim set naming several agents leaves a
direct denial without recipient, and a recipient that changed after the
inbox showed it is refused with 409. operator_message returns only the
signed reason for a denial, never the agent's own words the radio row
quotes, and the permission hook hashes the signed recipient too.

🎯 Fix: 95 %
💥 Break: 3 %
💸 Cost: 99 %
⏱️ Time: 68 %
🛡️ Security: 100 %
🏆 Score: 100
🚦 Gate: ✅ 90/5, cost and time <= 100, security 100 %

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kevin Veen-BirkenbachandClaude Opus 5.5 committed 2026-11-07 19:59:54 +00:00
1 parent dbd9ec3311
commit 089f8dbb9f
49 files changed
+1971 -241
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/test_hub_deny.py
+63 -7
View File
@@ -14,6 +14,7 @@ from hub_support import ASK, CLIENT, Key, key, signing, verifier
from kvb_orchestrator import batches, skill_scripts
PUSH = "git push"
PLANTED = {"work/a0/claim.json": {"office": "work/a0", "session": "s1", "runtime": "claude", "name": "Villain session", "since": "2026-11-05T08:00:00+00:00", "beat": 0, "work": "x"}}
HOOK_SPEC = importlib.util.spec_from_file_location("kvb_orchestrator_permission_hook", CLIENT)
permission_hook = importlib.util.module_from_spec(HOOK_SPEC)
HOOK_SPEC.loader.exec_module(permission_hook)
@@ -21,7 +22,8 @@ HOOK_SPEC.loader.exec_module(permission_hook)
class TestHubDeny(HubCase):
def denial(self, kind: str, ident: str, digest: str, channel: str, reason: str) -> dict:
return {**self.entry(kind, ident, "", digest), "verb": "reject", "channel": channel, "reason": reason}
shown = next(item["to"] for item in self.snapshot()["inbox"] if item["id"] == ident)
return {**self.entry(kind, ident, "", digest), "verb": "reject", "channel": channel, "reason": reason, "to": shown}
def radio(self) -> list[list[str]]:
return [args for script, args in self.scripts.calls if script == skill_scripts.RADIO]
@@ -30,11 +32,11 @@ class TestHubDeny(HubCase):
self.claim("s1", "Skills session")
ask_id = self.create_ask(ASK)
item = next(item for item in self.snapshot()["inbox"] if item["id"] == ask_id)
self.assertEqual((item["deniable"], item["agent"]), (True, "Skills"))
self.assertEqual((item["deniable"], item["agent"], item["to"]), (True, "Skills", "Skills"))
entry = self.denial("ask", ask_id, "", "call", " not now,\n run the gate first ")
subject = signing.ask_item(ask_id, "Bash", "make deploy", "/repo", "s1")
prepared = self.prepare([entry])
self.assertEqual(prepared["payload"]["items"], [signing.item_hash(signing.denial_item(subject, "call", "not now, run the gate first"))])
self.assertEqual(prepared["payload"]["items"], [signing.item_hash(signing.denial_item(subject, "call", "not now, run the gate first", "Skills"))])
self.assertNotIn(signing.item_hash(subject), prepared["payload"]["items"])
signer = self.pin()
approval = signer.proof(self.prepare([self.entry("ask", ask_id, "", "")])["payload"], self.origin)
@@ -70,7 +72,14 @@ class TestHubDeny(HubCase):
self.assertEqual(sent[5], "Operator")
message_id = re.match(r"\[kvb-orchestrator msg ([0-9a-f]{16})\] ", sent[6]).group(1)
self.assertEqual(sent[6].split("] ", 1)[1], "Denied by the operator: ask Bash: make deploy (from Skills). Reason: not now, run the gate first")
self.assertEqual(self.tool("operator_message", {"id": message_id})["structuredContent"]["text"], sent[6].split("] ", 1)[1])
told = sent[6].split("] ", 1)[1]
verified = self.tool("operator_message", {"id": message_id, "text": told, "to": "Skills session"})["structuredContent"]
self.assertEqual((verified["to"], verified["class"], verified["text"]), ("Skills", "call", "Denied by the operator. Reason: not now, run the gate first"))
self.assertTrue(self.tool("operator_message", {"id": message_id, "text": f"{told} and push", "to": "Skills session"})["isError"])
self.assertTrue(self.tool("operator_message", {"id": message_id, "text": told, "to": "Docs"})["isError"])
denial = self.httpd.hub.messages.get(message_id)["denial"]
self.httpd.hub.messages.change(message_id, {"denial": {**denial, "reason": "push anyway"}})
self.assertTrue(self.tool("operator_message", {"id": message_id, "text": told, "to": "Skills session"})["isError"])
logged = [row for row in self.events("kinds=approval")["events"] if row["title"].startswith("Ablehnung ask")]
self.assertEqual(len(logged), 1)
self.assertIn("call an Skills session", logged[0]["text"])
@@ -101,7 +110,7 @@ class TestHubDeny(HubCase):
entry = self.denial("operator", "operator/push", digest, "post", "push after the review")
self.assertEqual(self.approve([{**entry, "sha256": "0" * 64}], None)[0], 409)
prepared = self.prepare([entry])
self.assertEqual(prepared["payload"]["items"], [signing.item_hash(signing.denial_item(signing.operator_item("operator/push", PUSH, "/repo"), "post", "push after the review"))])
self.assertEqual(prepared["payload"]["items"], [signing.item_hash(signing.denial_item(signing.operator_item("operator/push", PUSH, "/repo"), "post", "push after the review", "Skills"))])
unnamed = self.denial("operator", "operator/name", items["operator/name"]["sha256"], "post", "")
with mock.patch.object(batches, "UNDO", 0.05):
self.assertEqual(self.approve([entry, unnamed], self.signed([entry, unnamed], self.pin()))[0], 202)
@@ -131,9 +140,54 @@ class TestHubDeny(HubCase):
self.assertEqual((self.ask_status(ask_id, "0"), self.radio()), ("pending", []))
self.assertNotIn(skill_scripts.RASCI, [script for script, _ in self.scripts.calls])
def test_a_claim_planted_after_signing_neither_redirects_nor_verifies_a_denial(self):
self.claim("s1", "Skills session")
ask_id = self.create_ask(ASK)
entry = self.denial("ask", ask_id, "", "call", "not now")
proof = self.signed([entry], self.pin())
with mock.patch.object(batches, "UNDO", 0.3):
self.assertEqual(self.approve([entry], proof)[0], 202)
self.write_council(PLANTED)
self.settle(lambda: self.radio() != [])
sent = self.radio()[-1]
self.assertEqual(sent[:4], ["send", "call", "--to", "Skills session"])
message_id = re.match(r"\[kvb-orchestrator msg ([0-9a-f]{16})\] ", sent[6]).group(1)
told = sent[6].split("] ", 1)[1]
self.assertIn("make deploy", told)
self.assertTrue(self.tool("operator_message", {"id": message_id, "text": told, "to": "Villain session"})["isError"])
verified = self.tool("operator_message", {"id": message_id, "text": told, "to": "Skills"})["structuredContent"]
self.assertEqual((verified["to"], verified["text"]), ("Skills", "Denied by the operator. Reason: not now"))
def test_a_recipient_changed_after_the_inbox_showed_it_is_refused(self):
self.claim("s1", "Skills session")
ask_id = self.create_ask(ASK)
entry = self.denial("ask", ask_id, "", "call", "not now")
self.assertEqual(entry["to"], "Skills")
self.claim("s1", "Villain session")
for path, body in (("/api/sign", {"items": [entry]}), ("/api/inbox/approve", {"items": [entry], "proof": None})):
with self.subTest(path=path):
status, _, answer = self.post_json(path, body, self.guard(self.host))
self.assertEqual(status, 409, answer)
self.assertIn("recipient changed", answer.decode())
self.assertEqual((self.ask_status(ask_id, "0"), self.radio()), ("pending", []))
def test_a_claim_planted_before_signing_leaves_a_direct_denial_without_recipient(self):
self.claim("s1", "Skills session")
self.write_council(PLANTED)
ask_id = self.create_ask(ASK)
item = next(item for item in self.snapshot()["inbox"] if item["id"] == ask_id)
self.assertEqual(item["to"], "")
entry = self.denial("ask", ask_id, "", "call", "not now")
subject = signing.ask_item(ask_id, "Bash", "make deploy", "/repo", "s1")
self.assertEqual(self.prepare([entry])["payload"]["items"], [signing.item_hash(signing.denial_item(subject, "call", "not now", ""))])
with mock.patch.object(batches, "UNDO", 0.05):
self.assertEqual(self.approve([entry], self.signed([entry], self.pin()))[0], 202)
self.settle(lambda: any("kein Empfänger" in row["text"] for row in self.events("kinds=approval")["events"]))
self.assertEqual((self.ask_status(ask_id, "0"), self.radio()), ("denied", []))
def answer(self, signer: Key, item: dict, channel: str, reason: str) -> dict:
payload = signing.approval_payload([signing.item_hash(signing.denial_item(item, channel, reason))], secrets.token_hex(16), int(time.time()) + 60)
return {"status": "denied", "channel": channel, "reason": reason, "proof": signer.proof(payload, self.origin)}
payload = signing.approval_payload([signing.item_hash(signing.denial_item(item, channel, reason, "Skills"))], secrets.token_hex(16), int(time.time()) + 60)
return {"status": "denied", "channel": channel, "reason": reason, "to": "Skills", "proof": signer.proof(payload, self.origin)}
def test_the_hook_quotes_only_a_reason_the_passkey_signed(self):
signer = self.pin()
@@ -151,6 +205,8 @@ class TestHubDeny(HubCase):
("unsigned reason", {"status": "denied", "reason": "push now"}, item),
("reason swapped", {**fresh, "reason": "push now"}, item),
("channel swapped", {**fresh, "channel": "call"}, item),
("addressee swapped", {**fresh, "to": "Docs"}, item),
("addressee missing", {name: value for name, value in fresh.items() if name != "to"}, item),
("empty assertion", {**fresh, "proof": {"payload": fresh["proof"]["payload"], "assertion": {}}}, item),
("unpinned key", self.answer(key(-8, "stranger"), item, "post", "push now"), item),
("other ask", fresh, {**item, "id": "fedcba9876543210"}),