From 374fcaa8649f7540cf35f0de8cb20d2cdeb5e014 Mon Sep 17 00:00:00 2001 From: Kevin Veen-Birkenbach Date: Fri, 13 Nov 2026 15:32:02 +0000 Subject: [PATCH] test(kvb-check-score): let requirement documents name the former labels MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 006's label test scanned docs/requirements too, but the 006 requirement has to name Cost and Time to describe their rename, so the test failed once the requirement and the code met on the unify branch. The test now skips docs/requirements, and the 006 acceptance line says so. 🎯 Fix: 96 % 💥 Break: 1 % 💸 Cost: 100 % ⏱️ Time: 100 % 🛡️ Security: 100 % 🏆 Score: 95 🚦 Gate: ✅ 90/5, cost and time <= 100, security 100 % Co-Authored-By: Claude Opus 5.5 --- docs/requirements/006-score-metric-overlays.md | 3 ++- tests/test_score_journal.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/requirements/006-score-metric-overlays.md b/docs/requirements/006-score-metric-overlays.md index 3055ebf..d87b2e3 100644 --- a/docs/requirements/006-score-metric-overlays.md +++ b/docs/requirements/006-score-metric-overlays.md @@ -69,7 +69,8 @@ flowchart TD - [ ] `score.py --message-block`, the line and the table print `Tokens` and `Velocity`, never `Cost` or `Time`. - [ ] `grep -rnE "💸 Cost|⏱️ Time" skills/ docs/` finds nothing outside the - aliases in `labels.json`. + aliases in `labels.json` and the requirement documents under + `docs/requirements/`, which describe the rename. - [ ] A test that changes a label in a temporary `labels.json` sees it in `score.py`'s output. diff --git a/tests/test_score_journal.py b/tests/test_score_journal.py index ba228b4..116f879 100644 --- a/tests/test_score_journal.py +++ b/tests/test_score_journal.py @@ -22,6 +22,7 @@ from score_fixture import git_env REPO_ROOT = Path(__file__).resolve().parents[1] SKILL = REPO_ROOT / "skills" / "kvb-check-score" +REQUIREMENTS = REPO_ROOT / "docs" / "requirements" SCORE = SKILL / "scripts" / "score.py" EFFICIENCY = REPO_ROOT / "skills" / "kvb-check-efficiency" / "scripts" NOFOLLOW = REPO_ROOT / "skills" / "kvb-org-organize" / "scripts" / "nofollow.py" @@ -116,7 +117,7 @@ class TestScoreLabels(ScoreCase): f"{path.relative_to(REPO_ROOT)}:{number}" for top in ("skills", "docs") for path in sorted((REPO_ROOT / top).rglob("*")) - if path.is_file() and path.suffix != ".pyc" + if path.is_file() and path.suffix != ".pyc" and REQUIREMENTS not in path.parents for number, line in enumerate(path.read_text(encoding="utf-8", errors="replace").splitlines(), 1) if FORMER.search(line) ]