feat(hub): Controls page switches MCP servers, plugins and Artifacts
The Firewall page becomes Controls with three tabs: Tools lists every MCP server, plugin and feature switch of ~/.claude/settings.json with each other settings file that sets it differently, Rules keeps the settings lists and the hub rule form, Groups the groups and sets. A flip stages a change in one shared Apply bar; Apply shows the diff and signs it with the passkey as before. The signer writes deniedMcpServers rules, enabledPlugins entries and switches only in the own file and refuses wrong types and no-op flips; switching, the capability views and the per-item checks are one function each. 🎯 Fix: 88 % 💥 Break: 6 % 💸 Tokens: – ⏱️ Velocity: – 🛡️ Security: 100 % 🏆 Score: 83 🚦 Gate: ⛔ fix 88 % < 90, break 6 % > 5 Created-with: https://s.veen.world/skills Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
78f2fec339
commit
50363b1a33
16 files changed
+645
-78
No files matched your search
@@ -26,7 +26,7 @@ WIDTHS = ((1920, 1080), (1366, 768), (390, 844))
|
||||
VIEWS = ("orbit", "chord", "swimlane", "tree", "3d")
|
||||
TASK_VIEWS = ("list", "board", "rasci", "gantt", "burn", "3d")
|
||||
SCREENS = ["home", "stream", "tasks/operator", "tasks/match", "stream/rules", *(f"{tab}/{view}" for tab in ("agents", "artifacts") for view in VIEWS), "agents/hierarchy", *(f"tasks/{view}" for view in TASK_VIEWS), "resources"]
|
||||
SUBS = ["Firewall"]
|
||||
SUBS = ["Controls"]
|
||||
TABS = ["Home", "Stream", "Agents", "Artifacts", "Tasks", "Resources"]
|
||||
HELPERS = """
|
||||
const sleep = (ms) => new Promise((resolve) => setTimeout(resolve, ms));
|
||||
|
||||
@@ -23,6 +23,9 @@ SECRET = ORIGINAL["env"]["EXAMPLE_FLAG"]
|
||||
ASKED = ["Bash(make deploy:*)", "Bash(make clean:*)", "Bash(git push:*)"]
|
||||
SHOW = """(async () => {@HELPERS@
|
||||
await screenShown(8000);
|
||||
const tabs = () => all('#main [role="tab"]').map((node) => [node.dataset.tab, node.getAttribute("aria-selected"), document.getElementById(node.getAttribute("aria-controls")).hidden]);
|
||||
const first = tabs();
|
||||
document.querySelector('#main [role="tab"][data-tab="rules"]').click();
|
||||
const ready = await until(() => all("#main table.fw-table tbody[data-source]").length > 1, 10000);
|
||||
if (!ready) {
|
||||
return {error: text(document.getElementById("main"))};
|
||||
@@ -45,6 +48,7 @@ SHOW = """(async () => {@HELPERS@
|
||||
await sleep(100);
|
||||
return {
|
||||
title: text(document.querySelector("#main h2.title")),
|
||||
tabs: {first, picked: tabs()},
|
||||
subs: all("#tabs .subtabs button").map(name),
|
||||
sources,
|
||||
folded,
|
||||
@@ -75,7 +79,7 @@ SIGN = """(async () => {@HELPERS@
|
||||
form.requestSubmit();
|
||||
await sleep(100);
|
||||
const staged = all('#main [aria-label="Staged changes"] li').map((node) => node.dataset.staged);
|
||||
document.querySelector('#main button[aria-label="Review and sign"]').click();
|
||||
document.querySelector("#main .apply-bar button[data-apply]").click();
|
||||
const diff = await until(() => document.querySelector('.sheet-box [aria-label="Diff"] pre.fw-diff'), 8000);
|
||||
if (!diff) {
|
||||
return {error: "no diff", toasts: all("#toasts .toast").map(text)};
|
||||
@@ -90,6 +94,47 @@ SIGN = """(async () => {@HELPERS@
|
||||
shown.wide = document.documentElement.scrollWidth > innerWidth + 1;
|
||||
return shown;
|
||||
})()"""
|
||||
TOOLS = """(async () => {@HELPERS@
|
||||
await screenShown(8000);
|
||||
const rowOf = (name) => document.querySelector(`#main .tool-row[data-tool="${name}"]`);
|
||||
const flip = async (name, staged) => {
|
||||
rowOf(name).querySelector("input.switch").click();
|
||||
return until(() => rowOf(name).hasAttribute("data-staged") === staged, 4000);
|
||||
};
|
||||
if (!await until(() => rowOf("blender"), 10000)) {
|
||||
return {error: text(document.getElementById("main"))};
|
||||
}
|
||||
const rows = () => all("#main .tool-row").map((node) => [node.closest("[data-list]").dataset.list, node.dataset.tool, node.dataset.on, node.hasAttribute("data-staged")]);
|
||||
const bar = () => document.querySelector("#main .apply-bar");
|
||||
const found = {before: rows(), hidden: bar().hidden};
|
||||
await flip("blender", true);
|
||||
await flip("caveman@caveman", true);
|
||||
await flip("caveman@caveman", false);
|
||||
await flip("enableArtifact", true);
|
||||
found.staged = {rows: rows(), apply: text(bar().querySelector("button[data-apply]")), hidden: bar().hidden, list: all("li code", bar()).map(text)};
|
||||
found.wide = document.documentElement.scrollWidth > innerWidth + 1;
|
||||
found.unlabelled = all("#main input.switch").filter((node) => !node.getAttribute("aria-label")).length;
|
||||
if (!@SIGN@) {
|
||||
bar().querySelector('button[aria-label="Discard"]').click();
|
||||
found.discarded = {hidden: bar().hidden, rows: rows()};
|
||||
return found;
|
||||
}
|
||||
bar().querySelector("button[data-apply]").click();
|
||||
const diff = await until(() => document.querySelector('.sheet-box [aria-label="Diff"] pre.fw-diff'), 8000);
|
||||
if (!diff) {
|
||||
return {...found, error: "no diff", toasts: all("#toasts .toast").map(text)};
|
||||
}
|
||||
const lines = (cls) => all(`span.${cls}`, diff).map((node) => node.textContent.trim());
|
||||
found.added = lines("add");
|
||||
found.removed = lines("del");
|
||||
document.querySelector('.sheet-box button[aria-label="Sign and apply"]').click();
|
||||
const done = await until(() => document.querySelector(".sheet-box [data-result]"), 30000);
|
||||
found.result = done ? done.dataset.result : null;
|
||||
found.after = await until(() => rowOf("blender") && rowOf("blender").dataset.on === "false" && !rowOf("blender").hasAttribute("data-staged") && rows(), 15000);
|
||||
found.barAfter = bar().hidden;
|
||||
found.secret = document.documentElement.innerHTML.includes("fixture-secret");
|
||||
return found;
|
||||
})()"""
|
||||
GROUP_RULE = """(async () => {@HELPERS@
|
||||
const prompts = [];
|
||||
new MutationObserver((records) => records.forEach((record) => record.addedNodes.forEach((node) => {
|
||||
@@ -244,7 +289,8 @@ class TestFirewallE2E(HubCase):
|
||||
shown, signed = data["results"][2 * index : 2 * index + 2]
|
||||
with self.subTest(width=width):
|
||||
self.assertNotIn("error", shown, shown)
|
||||
self.assertEqual((shown["title"], shown["subs"]), ("Firewall", base.SUBS))
|
||||
self.assertEqual((shown["title"], shown["subs"]), ("Controls", base.SUBS))
|
||||
self.assertEqual(shown["tabs"], {"first": [["tools", "true", False], ["rules", "false", True], ["groups", "false", True]], "picked": [["tools", "false", True], ["rules", "true", False], ["groups", "false", True]]})
|
||||
self.assertEqual(shown["sources"], ["hub", str(self.settings), str(self.outside / "demo" / ".claude" / "settings.json")])
|
||||
self.assertEqual(shown["folded"], {"expanded": ["false"] * 3, "rows": 0})
|
||||
self.assertEqual(shown["opened"], ["true"] * 3)
|
||||
@@ -280,6 +326,36 @@ class TestFirewallE2E(HubCase):
|
||||
backups = sorted(self.settings.parent.glob("settings.json.before-firewall-*"))
|
||||
self.assertEqual((len(backups), self.settings.stat().st_mode & 0o777), (3, 0o640))
|
||||
|
||||
def test_chromium_switches_tools_stages_them_in_the_apply_bar_and_signs_them_at_three_widths(self):
|
||||
home = self.settings.parent.parent
|
||||
(home / ".claude.json").write_text(json.dumps({"mcpServers": {"blender": {"command": "fixture-secret-command"}}, "claudeAiMcpEverConnected": ["claude.ai Google Drive"]}), encoding="utf-8")
|
||||
(home / ".claude" / "plugins").mkdir()
|
||||
(home / ".claude" / "plugins" / "installed_plugins.json").write_text(json.dumps({"plugins": {"caveman@caveman": []}}), encoding="utf-8")
|
||||
self.settings.write_text(json.dumps({**ORIGINAL, "enabledPlugins": {"caveman@caveman": True}}, indent=2) + "\n", encoding="utf-8")
|
||||
verifier.write_private(self.spool / "view.json", self.writer.view())
|
||||
authenticator = self.authenticator()
|
||||
self.beside(self.host_unit)
|
||||
steps = [{"width": width, "height": height, "url": f"{self.page_url}?{width}#stream/rules", "wait": 1500, "probe": probe(TOOLS, {"SIGN": "true" if width == 390 else "false"}), "shot": str(OUT / f"chromium-{width}-controls-tools.png")} for width, height in base.WIDTHS]
|
||||
data = self.drive(steps, authenticator)
|
||||
(OUT / "chromium-controls-tools.json").write_text(json.dumps(data, indent=1), encoding="utf-8")
|
||||
self.assertEqual(data["errors"], [])
|
||||
before = [["deniedMcpServers", "blender", "true", False], ["deniedMcpServers", "claude.ai Google Drive", "true", False], ["enabledPlugins", "caveman@caveman", "true", False], ["switches", "enableArtifact", "true", False]]
|
||||
staged = [["deniedMcpServers", "blender", "false", True], before[1], before[2], ["switches", "enableArtifact", "false", True]]
|
||||
for (width, _), found in zip(base.WIDTHS, data["results"], strict=True):
|
||||
with self.subTest(width=width):
|
||||
self.assertNotIn("error", found, found)
|
||||
self.assertEqual((found["before"], found["hidden"]), (before, True))
|
||||
self.assertEqual(found["staged"], {"rows": staged, "apply": "Apply (2)", "hidden": False, "list": ["Block server blender", "Turn off Artifacts"]})
|
||||
self.assertEqual((found["wide"], found["unlabelled"]), (False, 0))
|
||||
if width != 390:
|
||||
self.assertEqual(found["discarded"], {"hidden": True, "rows": before})
|
||||
signed = data["results"][-1]
|
||||
self.assertTrue(any('"serverName": "blender"' in line for line in signed["added"]), signed["added"])
|
||||
self.assertTrue(any('"enableArtifact": false' in line for line in signed["added"]), signed["added"])
|
||||
self.assertEqual((signed["result"], signed["after"], signed["barAfter"], signed["secret"]), ("done", [[*row[:3], False] for row in staged], True, False), signed)
|
||||
written = json.loads(self.settings.read_text(encoding="utf-8"))
|
||||
self.assertEqual(written, {**ORIGINAL, "enabledPlugins": {"caveman@caveman": True}, "deniedMcpServers": [{"serverName": "blender"}], "enableArtifact": False})
|
||||
|
||||
def test_chromium_names_a_group_and_signs_a_rule_for_it(self):
|
||||
authenticator = self.authenticator()
|
||||
steps = [{"width": 1366, "height": 768, "url": f"{self.page_url}#stream/rules", "wait": 1500, "probe": probe(GROUP_RULE, {}), "shot": str(OUT / "chromium-1366-firewall-group-rule.png")}]
|
||||
|
||||
@@ -206,7 +206,7 @@ class TestOrchestratorE2E(base.OrchestratorE2ECase):
|
||||
self.assertEqual(actions["ambience"], ["sky-look", "music-toggle", "leitstand", "notify"])
|
||||
self.assertEqual((actions["settingsUnlabelled"], actions["popupUnlabelled"]), (0, 0))
|
||||
self.assertEqual((actions["sections"], actions["radioFields"]), (["Ambience", "Location", "Appearance", "Music", "Notifications", "Passkey"], 0))
|
||||
for tool in ("Radio …", "Cancel mayday", "Priority …", "Drain", "Suspend", "Resume", "Firewall …", "Settings …", "Look at the sky", "Toggle control room", "Enable notifications"):
|
||||
for tool in ("Radio …", "Cancel mayday", "Priority …", "Drain", "Suspend", "Resume", "Controls …", "Settings …", "Look at the sky", "Toggle control room", "Enable notifications"):
|
||||
with self.subTest(tool=tool):
|
||||
self.assertTrue(any(tool in entry for entry in actions["palette"]), actions["palette"])
|
||||
self.assertEqual(actions["popup"], [["post", True], ["call", False]])
|
||||
|
||||
@@ -189,7 +189,7 @@ class TestWorkbenchOperatorTasks(HubCase):
|
||||
self.assertEqual(feedback["labels"], {"float": [], "menu": [], "sheet": []})
|
||||
with self.subTest(browser=browser, width=width):
|
||||
self.assertNotIn("error", tasks, tasks)
|
||||
self.assertEqual((tasks["hash"], tasks["tabs"], tasks["subs"], tasks["streamInbox"], tasks["current"]), ("#tasks/operator", base.TABS, ["Firewall"], False, ["Tasks"]))
|
||||
self.assertEqual((tasks["hash"], tasks["tabs"], tasks["subs"], tasks["streamInbox"], tasks["current"]), ("#tasks/operator", base.TABS, ["Controls"], False, ["Tasks"]))
|
||||
self.assertRegex(tasks["badge"] or "", r"^[1-9][0-9]*$")
|
||||
self.assertEqual((tasks["kinds"], tasks["boxes"]), (["k-review", "k-operator", "k-ask"], [True, True, True]))
|
||||
operator = tasks["operator"]
|
||||
|
||||
@@ -132,7 +132,7 @@ class TestHubContextMenu(unittest.TestCase):
|
||||
self.assertEqual(self.data["operator"], "agents")
|
||||
|
||||
def test_a_sub_screen_takes_the_items_of_its_tab(self):
|
||||
self.assertEqual(self.data["rules"], [["stream", "Stream", ["View: Stream › Firewall", "Stream: For you", "Stream: Mine", "Firewall …"]], ["general", "General", GENERAL]])
|
||||
self.assertEqual(self.data["rules"], [["stream", "Stream", ["View: Stream › Controls", "Stream: For you", "Stream: Mine", "Controls …"]], ["general", "General", GENERAL]])
|
||||
|
||||
def test_every_palette_item_has_a_scope_and_the_palette_still_lists_them_all(self):
|
||||
palette = self.data["palette"]
|
||||
|
||||
@@ -240,6 +240,54 @@ class TestHubFirewall(HubCase):
|
||||
self.assertEqual(status, 400, body)
|
||||
self.assertIn(reason, body.decode("utf-8"))
|
||||
|
||||
def test_the_tools_tab_switches_servers_plugins_and_features_of_the_own_file_only(self):
|
||||
capabilities = {"deniedMcpServers": [{"serverName": "blender"}], "enabledPlugins": {"caveman@caveman": True, "ponytail@ponytail": False}}
|
||||
project_tools = {"deniedMcpServers": [{"serverName": "kvb-orchestrator"}], "enabledPlugins": {"ponytail@ponytail": True, "caveman@caveman": True}, "enableArtifact": False}
|
||||
files = [{**self.home_view(), "own": True, "settings": {**self.home_view()["settings"], **capabilities}}, {"path": PROJECT_FILE, "exists": False, "sha256": "", "error": "", "settings": project_tools, "own": False}]
|
||||
known = {"servers": ["blender", "kvb-orchestrator", "hid\u200bden", 5], "plugins": ["caveman@caveman", "tokeneconomizer@tokeneconomizer", "no id"]}
|
||||
(self.state / "firewall" / "view.json").write_text(json.dumps({"written": time.time(), "files": files, "known": known}), encoding="utf-8")
|
||||
tools = self.firewall()["tools"]
|
||||
overridden = {(group["list"], row["name"]): row["overrides"] for group in tools["groups"] for row in group["rows"] if row["overrides"]}
|
||||
self.assertEqual(overridden, {
|
||||
("deniedMcpServers", "kvb-orchestrator"): [{"file": PROJECT_FILE, "on": False}],
|
||||
("enabledPlugins", "ponytail@ponytail"): [{"file": PROJECT_FILE, "on": True}],
|
||||
("switches", "enableArtifact"): [{"file": PROJECT_FILE, "on": False}],
|
||||
})
|
||||
groups = {group["list"]: (group["off"], [(row["name"], row["on"]) for row in group["rows"]]) for group in tools["groups"]}
|
||||
self.assertEqual(groups, {
|
||||
"deniedMcpServers": ("add", [("blender", False), ("kvb-orchestrator", True)]),
|
||||
"enabledPlugins": ("remove", [("caveman@caveman", True), ("ponytail@ponytail", False), ("tokeneconomizer@tokeneconomizer", False)]),
|
||||
"switches": ("remove", [("enableArtifact", True)]),
|
||||
})
|
||||
changes = [{"list": "deniedMcpServers", "op": "remove", "entry": "blender"}, {"list": "enabledPlugins", "op": "add", "entry": "ponytail@ponytail"}, {"list": "switches", "op": "remove", "entry": "enableArtifact"}]
|
||||
item = {"kind": "settings", "file": HOME_FILE, "base": SHA, "changes": changes}
|
||||
status, body = self.post("/api/firewall/preview", {"items": [item]})
|
||||
self.assertEqual(status, 200, body)
|
||||
changed = {line[0] + line[1:].strip() for line in json.loads(body)["diffs"][0]["diff"].splitlines() if line[:1] in "+-" and line[:3] not in ("+++", "---")}
|
||||
self.assertLessEqual({'-"serverName": "blender"', '-"ponytail@ponytail": false', '+"ponytail@ponytail": true', '+"enableArtifact": false'}, changed)
|
||||
proof = self.pin().proof(self.prepare([item])["payload"], self.origin)
|
||||
self.assertEqual(self.post("/api/firewall/settings", {"items": [item], "proof": proof})[0], 202)
|
||||
project = {"kind": "settings", "file": PROJECT_FILE, "base": "", "changes": [{"list": "deniedMcpServers", "op": "add", "entry": "blender"}]}
|
||||
for name, items, reason in (
|
||||
("project file", [project], "only in ~/.claude/settings.json"),
|
||||
("chained name", [{**item, "changes": [{**changes[0], "op": "add", "entry": "x;rm"}]}], "no valid deniedMcpServers name"),
|
||||
("unknown switch", [{**item, "changes": [{**changes[2], "entry": "hooks"}]}], "no valid switches name"),
|
||||
("already on", [{**item, "changes": [{**changes[1], "entry": "caveman@caveman"}]}], "enabled already"),
|
||||
):
|
||||
with self.subTest(name=name):
|
||||
status, body = self.post("/api/firewall/preview", {"items": items})
|
||||
self.assertEqual(status, 400, body)
|
||||
self.assertIn(reason, body.decode("utf-8"))
|
||||
broken = {**files[0], "settings": {**files[0]["settings"], "enabledPlugins": None, "deniedMcpServers": None}}
|
||||
(self.state / "firewall" / "view.json").write_text(json.dumps({"written": time.time(), "files": [broken], "known": known}), encoding="utf-8")
|
||||
rows = {group["list"]: [row["name"] for row in group["rows"]] for group in self.firewall()["tools"]["groups"]}
|
||||
self.assertEqual(rows["enabledPlugins"], ["caveman@caveman", "tokeneconomizer@tokeneconomizer"])
|
||||
status, body = self.post("/api/firewall/preview", {"items": [{**item, "changes": changes[1:2]}]})
|
||||
self.assertEqual(status, 400, body)
|
||||
self.assertIn("holds the wrong type", body.decode("utf-8"))
|
||||
(self.state / "firewall" / "view.json").write_text(json.dumps({"written": time.time(), "files": [{**files[0], "own": "yes"}], "known": known}), encoding="utf-8")
|
||||
self.assertIsNone(self.firewall()["tools"])
|
||||
|
||||
def test_groups_and_rule_sets_hold_known_agents_and_stored_rules(self):
|
||||
for name, payload, expected in (
|
||||
("unknown session", {"name": "builders", "members": ["s1", "s9"]}, 400),
|
||||
|
||||
@@ -66,7 +66,7 @@ class TestNavModule(unittest.TestCase):
|
||||
cls.data = json.loads(done.stdout)
|
||||
|
||||
def test_the_navigation_has_six_entries_home_first_and_no_inbox_and_stream_keeps_only_the_firewall(self):
|
||||
stream = ["stream", "Stream", [["rules", "Firewall"]]]
|
||||
stream = ["stream", "Stream", [["rules", "Controls"]]]
|
||||
self.assertEqual(self.data["tabs"], [["home", "Home", []], stream, ["agents", "Agents", []], ["artifacts", "Artifacts", []], ["tasks", "Tasks", []], ["resources", "Resources", []]])
|
||||
self.assertNotIn("inbox", json.dumps(self.data["tabs"]))
|
||||
|
||||
|
||||
@@ -461,6 +461,77 @@ class TestSettingsWriter(unittest.TestCase):
|
||||
self.assertEqual((project["exists"], project["sha256"], project["settings"]), (False, "", {}))
|
||||
self.assertNotIn("fixture-value-not-a-secret", json.dumps(view))
|
||||
|
||||
def test_a_signed_tool_switch_changes_only_its_key_of_the_own_file_and_never_a_project_file(self):
|
||||
url = {"serverUrl": "https://mcp.example.org/fixture-token-not-a-secret"}
|
||||
self.settings.write_text(json.dumps({**ORIGINAL, "deniedMcpServers": [url], "enabledPlugins": {"a@m": True, "b@m": False}}), encoding="utf-8")
|
||||
off = [
|
||||
{"list": "deniedMcpServers", "op": "add", "entry": "claude.ai Google Drive"},
|
||||
{"list": "enabledPlugins", "op": "remove", "entry": "a@m"},
|
||||
{"list": "enabledPlugins", "op": "add", "entry": "b@m"},
|
||||
{"list": "switches", "op": "remove", "entry": "enableArtifact"},
|
||||
]
|
||||
self.assertEqual(self.signed(self.item(self.settings, off))["status"], "done")
|
||||
written = json.loads(self.settings.read_text(encoding="utf-8"))
|
||||
self.assertEqual(written, {**ORIGINAL, "deniedMcpServers": [url, {"serverName": "claude.ai Google Drive"}], "enabledPlugins": {"a@m": False, "b@m": True}, "enableArtifact": False})
|
||||
for name, changes in (("blocked twice", off[:1]), ("disabled twice", off[1:2]), ("off twice", off[3:])):
|
||||
with self.subTest(name=name):
|
||||
self.assertIn("already", self.signed(self.item(self.settings, changes))["reason"])
|
||||
back = [{**off[0], "op": "remove"}, {**off[3], "op": "add"}]
|
||||
self.assertEqual(self.signed(self.item(self.settings, back))["status"], "done")
|
||||
self.assertEqual(json.loads(self.settings.read_text(encoding="utf-8")), {key: value for key, value in written.items() if key != "enableArtifact"} | {"deniedMcpServers": [url]})
|
||||
result = self.signed({"file": str(self.project_settings), "base": "", "changes": off[3:]})
|
||||
self.assertEqual((result["status"], result["reason"], self.project_settings.exists()), ("refused", "MCP servers, plugins and switches change only in ~/.claude/settings.json", False))
|
||||
for name, change in (("chained name", {**off[0], "entry": "x;rm -rf /"}), ("hidden character", {**off[0], "entry": "blen\u200bder"}), ("unknown switch", {**off[3], "entry": "hooks"}), ("no plugin id", {**off[1], "entry": "a"})):
|
||||
with self.subTest(name=name):
|
||||
self.assertEqual(self.run_job([self.item(self.settings, [change])], None)["error"], "malformed job: refused, nothing changed")
|
||||
|
||||
def test_the_view_marks_the_own_file_and_names_known_servers_and_plugins_but_no_value(self):
|
||||
config = {
|
||||
"mcpServers": {"user-server": {"env": {"TOKEN": "fixture-secret-one"}}},
|
||||
"projects": {"/p": {"mcpServers": {"project-server": {"command": "run --token fixture-secret-two"}}}, "/q": "junk"},
|
||||
"claudeAiMcpEverConnected": ["claude.ai Google Drive", "hid\u200bden", 5],
|
||||
"oauthAccount": {"key": "fixture-secret-three"},
|
||||
}
|
||||
(self.home / ".claude.json").write_text(json.dumps(config), encoding="utf-8")
|
||||
(self.home / ".claude" / "plugins").mkdir()
|
||||
(self.home / ".claude" / "plugins" / "installed_plugins.json").write_text(json.dumps({"plugins": {"caveman@caveman": [{"installPath": "/x"}], "no id": []}}), encoding="utf-8")
|
||||
capabilities = {"deniedMcpServers": [{"serverName": "blender"}, {"serverUrl": "https://h/fixture-secret-four"}], "enabledPlugins": {"caveman@caveman": True, "x@y": "yes"}, "enableArtifact": False}
|
||||
self.settings.write_text(json.dumps({**ORIGINAL, **capabilities}), encoding="utf-8")
|
||||
view = self.writer.view()
|
||||
self.assertEqual(view["known"], {"servers": ["claude.ai Google Drive", "project-server", "user-server"], "plugins": ["caveman@caveman"]})
|
||||
self.assertEqual([entry["own"] for entry in view["files"]], [True, False])
|
||||
shown = view["files"][0]["settings"]
|
||||
self.assertEqual({name: shown[name] for name in capabilities}, {"deniedMcpServers": [{"serverName": "blender"}], "enabledPlugins": {"caveman@caveman": True, "x@y": None}, "enableArtifact": False})
|
||||
self.assertNotIn("fixture-secret", json.dumps(view))
|
||||
config_file = self.home / ".claude.json"
|
||||
for name, make in (("no json", lambda: config_file.write_text("{not json", encoding="utf-8")), ("fifo", lambda: os.mkfifo(config_file)), ("link to /dev/zero", lambda: config_file.symlink_to("/dev/zero"))):
|
||||
with self.subTest(name=name):
|
||||
config_file.unlink()
|
||||
make()
|
||||
self.assertEqual(self.writer.view()["known"]["servers"], [])
|
||||
|
||||
def test_a_tool_value_of_the_wrong_type_is_refused_in_the_view_as_in_the_file_and_an_unblock_drops_every_copy(self):
|
||||
for name, value, change in (
|
||||
("plugins null", {"enabledPlugins": None}, {"list": "enabledPlugins", "op": "add", "entry": "a@m"}),
|
||||
("plugins list", {"enabledPlugins": []}, {"list": "enabledPlugins", "op": "add", "entry": "a@m"}),
|
||||
("plugin value list", {"enabledPlugins": {"a@m": ["x"]}}, {"list": "enabledPlugins", "op": "add", "entry": "a@m"}),
|
||||
("servers null", {"deniedMcpServers": None}, {"list": "deniedMcpServers", "op": "add", "entry": "blender"}),
|
||||
("switch text", {"enableArtifact": "false"}, {"list": "switches", "op": "remove", "entry": "enableArtifact"}),
|
||||
):
|
||||
with self.subTest(name=name):
|
||||
self.settings.write_text(json.dumps({**ORIGINAL, **value}), encoding="utf-8")
|
||||
shown = self.writer.view()["files"][0]["settings"]
|
||||
for settings in (shown, json.loads(self.settings.read_text(encoding="utf-8"))):
|
||||
with self.assertRaisesRegex(signing.Refused, "holds the wrong type"):
|
||||
signing.apply_changes(settings, [change])
|
||||
self.assertEqual(self.signed(self.item(self.settings, [change]))["status"], "refused")
|
||||
self.settings.write_text(json.dumps({**ORIGINAL, "deniedMcpServers": [{"serverName": "dup"}, {"serverName": "dup"}]}), encoding="utf-8")
|
||||
self.assertEqual(self.signed(self.item(self.settings, [{"list": "deniedMcpServers", "op": "remove", "entry": "dup"}]))["status"], "done")
|
||||
self.assertEqual(json.loads(self.settings.read_text(encoding="utf-8"))["deniedMcpServers"], [])
|
||||
for entry in ("https://u:tok@h/p", "a b", "a ", "x" * 129):
|
||||
with self.subTest(entry=entry):
|
||||
self.assertIsNotNone(signing.change_problem({"list": "deniedMcpServers", "op": "add", "entry": entry}))
|
||||
|
||||
def test_a_missing_directory_shows_in_the_view_as_the_writer_handles_it(self):
|
||||
self.project_settings.parent.rmdir()
|
||||
shown = self.writer.view()["files"][1]
|
||||
|
||||
Reference in new issue
Block a user