kevinveenbirkenbach/skills
1
0 Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

feat(skills)!: S4 night commands become drain, suspend and resume

Browse Source 
Requirement 001 phase 6, S4 (decision 29):

- Skills renamed: kvb-org-evening -> kvb-org-drain, kvb-org-sunset ->
  kvb-org-suspend, kvb-org-sunrise -> kvb-org-resume, kvb-agent-relax
  -> kvb-agent-drain, kvb-agent-sleep -> kvb-agent-suspend,
  kvb-agent-wakeup -> kvb-agent-resume; their text uses the new verbs and
  every reference in skills, README, orchestrator and tests follows.
- night.py takes drain, suspend, resume, resume --alone and status. A
  state file written before the rename keeps working: mode evening reads
  as drain, sunset as suspend, the awake list as resumed and is rewritten
  on the next save; the hub's council.night_mode maps the same values.
  mode: day and handover_night_<session>.md keep their names.
- Orchestrator: the Day/Night menu shows Drain, Suspend and Resume, each
  confirmed, signed through /api/board/sign with the passkey and run as
  the existing argv job; the old action names are refused.
- kvb-skill-cleanup: git rates two renames at 44 and 50 % similarity,
  under its default threshold, so legacy.py detects renames from 40 %.
- tests/test_night_names.py fails on any old name in the tree outside a
  rename record "old ->".

BREAKING CHANGE: the six old skill names and night.py's clear and wake
are gone. Run make install (it reinstalls the orchestrator too), then
kvb-skill-cleanup to remove the old installed copies; until the install,
the running hub calls the old night.py path.

Evidence: make test 679 OK, ruff and markdownlint clean
(/tmp/s4-make-test-1.log); e2e 22 OK in Chromium and Firefox
(/tmp/s4-e2e-3.log); MEDUSA 23 files, the 2 findings are the
byte-identical atomic state write that moved with night.py, already
accepted after a skeptic at its old path, rescan 0 open.

🎯 Fix: 93 %
💥 Break: 4 %
💸 Cost: 100 %
⏱️ Time: –
🛡️ Security: 100 %
🏆 Score: 89
🚦 Gate: ✅ 90/5, cost and time <= 100, security 100 %

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kevin Veen-BirkenbachandClaude Opus 5.5 committed 2026-11-08 23:18:18 +00:00
1 parent 4d88296e47
commit 5c8b69d53d
24 files changed
+420 -176
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/test_night.py
+47 -24
View File
@@ -1,4 +1,4 @@
"""Exercise night.py: set, status per session, clear, and day on a bad state."""
"""Exercise night.py: drain, suspend, status per session, resume, states from before the rename, and day on a bad state."""
from __future__ import annotations
@@ -10,7 +10,7 @@ import unittest
from pathlib import Path
REPO_ROOT = Path(__file__).resolve().parents[1]
NIGHT = REPO_ROOT / "skills" / "kvb-org-sunset" / "scripts" / "night.py"
NIGHT = REPO_ROOT / "skills" / "kvb-org-suspend" / "scripts" / "night.py"
class TestNight(unittest.TestCase):
@@ -37,42 +37,62 @@ class TestNight(unittest.TestCase):
self.assertEqual(result.returncode, 0, result.stderr)
return result.stdout.splitlines()
def _state(self, state: dict) -> None:
self.root.mkdir(exist_ok=True)
(self.root / "night.json").write_text(json.dumps(state), encoding="utf-8")
def test_day_by_default(self):
self.assertEqual(self._out("status", sid="s2"), ["mode: day"])
def test_sunset_keeps_the_caller_active_and_sends_the_others_to_sleep(self):
self.assertEqual(self._out("set", "sunset"), ["s3\tThree", "s2\tTwo"])
def test_suspend_keeps_the_caller_active_and_suspends_the_others(self):
self.assertEqual(self._out("suspend"), ["s3\tThree", "s2\tTwo"])
lines = self._out("status", sid="s2")
self.assertEqual(lines[:2], ["mode: sunset", "active: One s1"])
self.assertEqual(lines[:2], ["mode: suspend", "active: One s1"])
self.assertRegex(lines[2], r"^since: \d{4}-\d\d-\d\dT")
self.assertEqual(lines[3], "you: sleep (kvb-agent-sleep)")
self.assertEqual(lines[3], "you: suspend (kvb-agent-suspend)")
self.assertEqual(self._out("status")[3], "you: active")
self.assertEqual(self._out("status", "--session", "s3", sid=None)[3], "you: sleep (kvb-agent-sleep)")
self.assertEqual(self._out("status", "--session", "s3", sid=None)[3], "you: suspend (kvb-agent-suspend)")
self.assertEqual(len(self._out("status", sid=None)), 3)
def test_evening_relaxes_and_clear_returns_to_day(self):
self._out("set", "evening", sid="s2")
self.assertEqual(self._out("status")[3], "you: relax (kvb-agent-relax)")
self.assertEqual(self._out("clear", sid="s2"), ["s1\tOne", "s3\tThree"])
def test_drain_and_resume_return_to_day(self):
self._out("drain", sid="s2")
self.assertEqual(json.loads((self.root / "night.json").read_text(encoding="utf-8"))["mode"], "drain")
self.assertEqual(self._out("status")[3], "you: drain (kvb-agent-drain)")
self.assertEqual(self._out("resume", sid="s2"), ["s1\tOne", "s3\tThree"])
self.assertEqual(self._out("status"), ["mode: day"])
def test_wake_lifts_one_session_until_the_next_set(self):
self.assertEqual(self._out("wake", sid="s2"), ["mode: day"])
self._out("set", "sunset")
self.assertEqual(self._out("wake", sid="s2"), ["awake: s2"])
self._out("wake", sid="s2")
self.assertEqual(json.loads((self.root / "night.json").read_text(encoding="utf-8"))["awake"], ["s2"])
self.assertEqual(self._out("status", sid="s2")[3], "you: awake")
self.assertEqual(self._out("status", sid="s3")[3], "you: sleep (kvb-agent-sleep)")
self._out("set", "sunset")
self.assertEqual(self._out("status", sid="s2")[3], "you: sleep (kvb-agent-sleep)")
def test_resume_alone_lifts_one_session_until_the_next_suspend(self):
self.assertEqual(self._out("resume", "--alone", sid="s2"), ["mode: day"])
self._out("suspend")
self.assertEqual(self._out("resume", "--alone", sid="s2"), ["resumed: s2"])
self._out("resume", "--alone", sid="s2")
self.assertEqual(json.loads((self.root / "night.json").read_text(encoding="utf-8"))["resumed"], ["s2"])
self.assertEqual(self._out("status", sid="s2")[3], "you: resumed")
self.assertEqual(self._out("status", sid="s3")[3], "you: suspend (kvb-agent-suspend)")
self._out("suspend")
self.assertEqual(self._out("status", sid="s2")[3], "you: suspend (kvb-agent-suspend)")
def test_a_state_from_before_the_rename_keeps_working(self):
for old, new in (("evening", "drain"), ("sunset", "suspend")):
with self.subTest(old=old):
self._state({"mode": old, "active": "s1", "name": "One", "since": "2026-11-08T20:00:00+00:00", "awake": ["s3"]})
self.assertEqual(self._out("status", sid="s2"), ["mode: " + new, "active: One s1", "since: 2026-11-08T20:00:00+00:00", f"you: {new} (kvb-agent-{new})"])
self.assertEqual(self._out("status", sid="s3")[3], "you: resumed")
self.assertEqual(self._out("resume", "--alone", sid="s2"), ["resumed: s2"])
state = json.loads((self.root / "night.json").read_text(encoding="utf-8"))
self.assertEqual((state["mode"], state["resumed"], "awake" in state), (new, ["s3", "s2"], False))
self._state({"mode": "sunset", "active": "s1"})
self.assertEqual(self._out("resume", sid="s2"), ["s1\tOne", "s3\tThree"])
self.assertFalse((self.root / "night.json").exists())
def test_bad_state_means_day(self):
self.root.mkdir()
for text in (
"{not json",
json.dumps({"mode": "noon", "active": "s1"}),
json.dumps(["sunset"]),
json.dumps({"mode": ["suspend"], "active": "s1"}),
json.dumps(["suspend"]),
json.dumps({"mode": "suspend", "active": "s1", "resumed": "s2"}),
json.dumps({"mode": "sunset", "active": "s1", "awake": "s2"}),
):
with self.subTest(text=text):
@@ -82,8 +102,11 @@ class TestNight(unittest.TestCase):
self.assertIn("treated as day", result.stderr)
def test_usage_errors_exit_2(self):
self.assertEqual(self._run("set", "sunset", sid=None).returncode, 2)
self.assertEqual(self._run("set", "noon").returncode, 2)
self.assertEqual(self._run("suspend", sid=None).returncode, 2)
self.assertEqual(self._run("resume", "--alone", sid=None).returncode, 2)
for old in (("set", "sunset"), ("sunset",), ("evening",), ("clear",), ("wake",), ("noon",)):
with self.subTest(command=old):
self.assertEqual(self._run(*old).returncode, 2)
self.assertFalse((self.root / "night.json").exists())