feat(skills)!: S4 night commands become drain, suspend and resume
Requirement 001 phase 6, S4 (decision 29): - Skills renamed: kvb-org-evening -> kvb-org-drain, kvb-org-sunset -> kvb-org-suspend, kvb-org-sunrise -> kvb-org-resume, kvb-agent-relax -> kvb-agent-drain, kvb-agent-sleep -> kvb-agent-suspend, kvb-agent-wakeup -> kvb-agent-resume; their text uses the new verbs and every reference in skills, README, orchestrator and tests follows. - night.py takes drain, suspend, resume, resume --alone and status. A state file written before the rename keeps working: mode evening reads as drain, sunset as suspend, the awake list as resumed and is rewritten on the next save; the hub's council.night_mode maps the same values. mode: day and handover_night_<session>.md keep their names. - Orchestrator: the Day/Night menu shows Drain, Suspend and Resume, each confirmed, signed through /api/board/sign with the passkey and run as the existing argv job; the old action names are refused. - kvb-skill-cleanup: git rates two renames at 44 and 50 % similarity, under its default threshold, so legacy.py detects renames from 40 %. - tests/test_night_names.py fails on any old name in the tree outside a rename record "old ->". BREAKING CHANGE: the six old skill names and night.py's clear and wake are gone. Run make install (it reinstalls the orchestrator too), then kvb-skill-cleanup to remove the old installed copies; until the install, the running hub calls the old night.py path. Evidence: make test 679 OK, ruff and markdownlint clean (/tmp/s4-make-test-1.log); e2e 22 OK in Chromium and Firefox (/tmp/s4-e2e-3.log); MEDUSA 23 files, the 2 findings are the byte-identical atomic state write that moved with night.py, already accepted after a skeptic at its old path, rescan 0 open. 🎯 Fix: 93 % 💥 Break: 4 % 💸 Cost: 100 % ⏱️ Time: – 🛡️ Security: 100 % 🏆 Score: 89 🚦 Gate: ✅ 90/5, cost and time <= 100, security 100 % Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
4d88296e47
commit
5c8b69d53d
24 files changed
+420
-176
No files matched your search
@@ -12,6 +12,17 @@ from pathlib import Path
|
||||
|
||||
REPO_ROOT = Path(__file__).resolve().parents[1]
|
||||
SCRIPT = REPO_ROOT / "skills" / "kvb-skill-cleanup" / "scripts" / "legacy.py"
|
||||
REWORDED = """---
|
||||
name: {name}
|
||||
description: probe
|
||||
---
|
||||
|
||||
The probe keeps this first line as it is.
|
||||
{name}: the first renamed line.
|
||||
{name}: the second renamed line.
|
||||
{name}: the third renamed line.
|
||||
It keeps this closing line as it is too.
|
||||
"""
|
||||
|
||||
|
||||
@unittest.skipUnless(shutil.which("git"), "git not installed")
|
||||
@@ -109,6 +120,24 @@ class TestLegacy(unittest.TestCase):
|
||||
),
|
||||
)
|
||||
|
||||
def test_a_rename_that_rewrites_its_name_throughout_keeps_its_successor(self):
|
||||
(self.repo / "skills" / "night-old").mkdir()
|
||||
(self.repo / "skills" / "night-old" / "SKILL.md").write_text(REWORDED.format(name="night-old"), encoding="utf-8")
|
||||
self._commit(self.repo, "add night-old")
|
||||
self._git(self.repo, "mv", "skills/night-old", "skills/kvb-x-night")
|
||||
(self.repo / "skills" / "kvb-x-night" / "SKILL.md").write_text(REWORDED.format(name="kvb-x-night"), encoding="utf-8")
|
||||
self._commit(self.repo, "rename night-old to kvb-x-night")
|
||||
default = subprocess.run(
|
||||
["git", "diff", "-M", "--diff-filter=R", "--name-only", "HEAD~1", "HEAD"],
|
||||
cwd=self.repo, env=self.env, capture_output=True, text=True, check=True,
|
||||
)
|
||||
self.assertEqual(default.stdout.strip(), "", "the probe must stay below git's default rename similarity")
|
||||
self._skill(self.home / "night-old")
|
||||
result = self._run("--skills-repo", str(self.repo), "--root", str(self.home), "--json")
|
||||
self.assertEqual(result.returncode, 0, result.stderr)
|
||||
rows = {Path(row["path"]).name: (row["verdict"], row["successor"]) for row in json.loads(result.stdout)}
|
||||
self.assertEqual(rows["night-old"], ("legacy", "kvb-x-night"))
|
||||
|
||||
def test_invalid_input_exits_2(self):
|
||||
missing = self._run("--skills-repo", str(self.repo), "--root", str(self.home / "nope"))
|
||||
self.assertEqual(missing.returncode, 2)
|
||||
|
||||
Reference in new issue
Block a user