feat(orchestrator): bulk grant mode, continuous review diff and an inbox denial reason (020)

A Direct/Select switch in the header (ids grant-direct, grant-select; ViewStore approval.mode) decides whether a grant button acts at once or adds its item to a selection that a tray grants under one passkey signature; rules and red gates still act at once. The review sheet shows every file in one scrolling stack whose next file opens as the previous one ends (openOnScroll moves to page-diff.js and serves Match too). The grant bar boots before the header is measured, so --head counts it. The inbox denial sheet takes an optional reason for every requester; it shares page-inbox.js hunks with the selection code, so both land in this one commit.

Fix stays below 90: the header ids and the measure order fix e2e failures of the aborted final run of 2026-11-17 that the master gate has not rerun yet. Accepted MEDUSA false positives (security.py accept after kvb-think-criticize, 2026-11-17): page-inbox.js PQC007 EXA010; page-match.js EXA010.

🎯 Fix: 85 %
💥 Break: 5 %
💸 Tokens: –
⏱️ Velocity: –
🛡️ Security: 100 %
🏆 Score: 81
🚦 Gate: ⛔ fix 85 % < 90

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kevin Veen-BirkenbachandClaude Opus 5.5 committed 2026-11-17 19:09:46 +00:00
1 parent 88a2d88e47
commit 65d00c0d2c
22 files changed
+763 -65

No files matched your search

+5 -2
View File
@@ -33,7 +33,7 @@ INBOX_PICK = """(async () => {@HELPERS@
const send = window.fetch.bind(window);
window.fetch = (path, init) => {
if (["/api/sign", "/api/inbox/approve"].includes(String(path))) {
posted.push([String(path), JSON.parse(init.body).items.map((item) => [item.id, item.verb, item.channel || null])]);
posted.push([String(path), JSON.parse(init.body).items.map((item) => [item.id, item.verb, item.channel || null, item.reason])]);
}
return send(path, init);
};
@@ -62,12 +62,15 @@ INBOX_PICK = """(async () => {@HELPERS@
all("#main .inbox-actions button").find((button) => name(button).startsWith("Deny selection")).click();
await until(() => document.querySelector(".sheet-box .actions"), 4000);
const listed = all(".sheet-box ul.mini > li strong").map(text);
const reason = document.querySelector(".sheet-box .deny-reason textarea");
const reasoned = Boolean(reason && document.activeElement === reason);
reason.value = "rebase first";
const confirm = all(".sheet-box .actions button").find((button) => text(button).startsWith("Deny "));
const label = text(confirm);
const shown = new Set(all("#toasts .toast"));
confirm.click();
const toast = await until(() => all("#toasts .toast").filter((node) => !shown.has(node)).map(text).find((entry) => entry.startsWith("Deny selection")), 15000);
return {title, before, moved: Math.abs(after - before), focused, buttons, listed, label, toast, posted, wide: document.documentElement.scrollWidth > window.innerWidth + 1};
return {title, before, moved: Math.abs(after - before), focused, buttons, listed, label, reasoned, toast, posted, wide: document.documentElement.scrollWidth > window.innerWidth + 1};
})()""".replace("@HELPERS@", HELPERS)
LAYOUT = """(async () => {@HELPERS@@LABELS@
await until(() => document.querySelector("#main .console") && rowOf("Rule request"), 8000);
+1 -1
View File
@@ -324,7 +324,7 @@ CANCELED = """() => {
}"""
JUMPED = {
"hash": "#stream", "focused": True, "tabs": [[tab, True, True] for tab in ("#home", "#stream/inbox", "#agents/orbit", "#artifacts/tree", "#tasks/list", "#resources")], "closed": [True, "false"],
"header": [["radio-open", "Radio", ""], ["bubbles-toggle", "Speech bubbles", ""], ["palette-open", "Commands", ""], ["settings-open", "Settings", ""]], "radioTab": False,
"header": [["grant-direct", "Direct", "Direct"], ["grant-select", "Select", "Select"], ["radio-open", "Radio", ""], ["bubbles-toggle", "Speech bubbles", ""], ["palette-open", "Commands", ""], ["settings-open", "Settings", ""]], "radioTab": False,
}
GEAR_SAVE = """(async () => {@HELPERS@@CLASHES@
const spot = document.getElementById("radio-spot");
+269
View File
@@ -0,0 +1,269 @@
from __future__ import annotations
import html
import json
import os
import shutil
import sys
import unittest
from pathlib import Path
from unittest import mock
HERE = Path(__file__).resolve().parent
sys.path[:0] = [str(HERE.parent), str(HERE)]
import hub_e2e_kit as base
from hub_e2e_kit import WIDTHS
from hub_support import ASK
from kvb_orchestrator import batches
OUT = Path(os.environ.get("E2E_OUT", "/tmp/bulk-grant-shots"))
FILES = ("src/app.py", "src/view.js", "docs/notes.md")
ROWS = 80
COMMON = """
const row = (ref) => document.querySelector(`#main .inbox-list > li[data-ref="${ref}"]`);
const modeButton = (mode) => document.querySelector(`#grant-bar button[data-mode="${mode}"]`);
const tray = () => document.querySelector("#grant-bar .grant-tray");
const count = () => text(document.querySelector("#grant-bar .grant-count"));
const grantOf = (ref) => row(ref) && row(ref).querySelector(".item-actions button.primary");
const wide = () => document.documentElement.scrollWidth > innerWidth + 1;
const switchState = () => [modeButton("direct").getAttribute("aria-pressed"), modeButton("select").getAttribute("aria-pressed"), tray().hidden, Boolean(document.querySelector("#main .inbox-actions"))];
const storedMode = async (mode) => {
const end = Date.now() + 6000;
while (Date.now() < end) {
const view = await (await fetch("/api/view", {cache: "no-store"})).json();
if (view.approval.mode === mode) {
return true;
}
await sleep(200);
}
return false;
};
const key = (value) => document.body.dispatchEvent(new KeyboardEvent("keydown", {key: value, bubbles: true}));
"""
DIFF = """(async () => {@HELPERS@@COMMON@
if (!(await until(() => row("@REVIEW@"), 8000))) {
return {error: text(document.getElementById("main"))};
}
row("@REVIEW@").querySelector(".headline").click();
const stack = await until(() => {
const found = document.querySelector("#sheet .review-stack");
return found && all(".review-file", found).length === 3 ? found : null;
}, 8000);
if (!stack) {
return {error: text(document.getElementById("sheet"))};
}
const files = () => all(".review-file", stack);
const state = () => ({opened: files().map((file) => file.open), marked: all("#sheet .file-entry[aria-current='true']").map((entry) => Number(entry.dataset.index))});
const first = state();
const [one, two] = files();
stack.scrollTop = one.offsetTop + one.offsetHeight - stack.clientHeight + 4;
await until(() => files()[1].open, 4000);
await sleep(300);
const ended = state();
stack.scrollTop = two.offsetTop;
await until(() => state().marked[0] === 1, 4000);
await sleep(200);
const second = state();
document.querySelector('#sheet .file-entry[data-index="2"]').click();
await sleep(400);
const three = files()[2];
const atTop = Math.abs(three.getBoundingClientRect().top - stack.getBoundingClientRect().top) <= 2 || stack.scrollTop >= stack.scrollHeight - stack.clientHeight - 1;
return {first, ended, second, jumped: {...state(), atTop}, wide: wide()};
})()"""
MODE = """(async () => {@HELPERS@@COMMON@
key("Escape");
await until(() => document.getElementById("sheet").hidden, 4000);
const before = switchState();
modeButton("select").click();
const kept = await storedMode("select");
await until(() => !tray().hidden, 4000);
return {before, kept, after: switchState(), wide: wide()};
})()"""
COLLECT = """(async () => {@HELPERS@@COMMON@
const posted = [];
const send = window.fetch.bind(window);
window.fetch = (path, init) => {
if (["/api/sign", "/api/inbox/approve"].includes(String(path))) {
posted.push(String(path));
}
return send(path, init);
};
if (!(await until(() => row("@REVIEW@") && row("@ASK@") && row("@RUN@") && !tray().hidden, 8000))) {
return {error: text(document.getElementById("main"))};
}
const restored = switchState();
const counts = [];
const press = async (ref, expected) => {
grantOf(ref).click();
await until(() => count() === expected, 3000);
counts.push(count());
};
await press("@REVIEW@", "1 selected");
await press("@ASK@", "2 selected");
await press("@REVIEW@", "1 selected");
await press("@REVIEW@", "2 selected");
if (document.activeElement) {
document.activeElement.blur();
}
for (let step = 0; step < 40 && !row("@RUN@").classList.contains("cursor"); step += 1) {
const cursor = document.querySelector("#main .inbox-list > li.cursor");
key(cursor && Number(cursor.dataset.index) > Number(row("@RUN@").dataset.index) ? "k" : "j");
await sleep(60);
}
key("a");
await until(() => count() === "3 selected", 3000);
counts.push(count());
const pressed = ["@REVIEW@", "@ASK@", "@RUN@"].map((ref) => grantOf(ref).getAttribute("aria-pressed"));
const labels = all("#grant-bar .grant-tray button").map(name);
return {restored, counts, pressed, labels, posted, wide: wide()};
})()"""
SHEET = """(async () => {@HELPERS@@COMMON@
all("#grant-bar .grant-tray button").find((button) => name(button) === "Grant selection (3)").click();
await until(() => document.querySelector(".sheet-box .actions"), 4000);
const confirm = all(".sheet-box .actions button").find((button) => text(button).startsWith("Grant "));
return {listed: all(".sheet-box ul.mini > li strong").map(text), label: text(confirm), wide: wide()};
})()"""
CONFIRM = """(async () => {@HELPERS@@COMMON@
navigator.credentials.get = @SIGNS@ ? navigator.credentials.get.bind(navigator.credentials) : () => Promise.reject(new DOMException("The operator canceled.", "NotAllowedError"));
const posted = [];
const send = window.fetch.bind(window);
window.fetch = (path, init) => {
if (["/api/sign", "/api/inbox/approve"].includes(String(path))) {
posted.push([String(path), JSON.parse(init.body).items.map((item) => `${item.kind}:${item.id}:${item.verb}`).sort()]);
}
return send(path, init);
};
const shown = new Set(all("#toasts .toast"));
all(".sheet-box .actions button").find((button) => text(button).startsWith("Grant ")).click();
const toast = await until(() => all("#toasts .toast").filter((node) => !shown.has(node)).map(text).find((entry) => entry.startsWith("Grant selection")), 15000);
await sleep(@SIGNS@ ? 2500 : 300);
return {posted, toast, count: count(), wide: wide()};
})()"""
DIRECT = """(async () => {@HELPERS@@COMMON@
const posted = [];
const send = window.fetch.bind(window);
window.fetch = (path, init) => {
if (String(path) === "/api/sign") {
posted.push(JSON.parse(init.body).items.map((item) => `${item.kind}:${item.id}`));
return Promise.resolve(new Response("held by the e2e", {status: 503}));
}
return send(path, init);
};
modeButton("direct").click();
const kept = await storedMode("direct");
await until(() => tray().hidden && document.querySelector("#main .inbox-actions"), 4000);
const spare = await until(() => grantOf("@SPARE@"), 4000);
const pressed = spare.getAttribute("aria-pressed");
spare.click();
await until(() => posted.length, 4000);
return {kept, after: switchState(), pressed, posted, wide: wide()};
})()"""
def probe(template: str, **values: str) -> str:
found = template.replace("@HELPERS@", base.HELPERS).replace("@COMMON@", COMMON)
for name, value in values.items():
found = found.replace(f"@{name}@", value)
return found
def review_page() -> str:
sections = []
for path in FILES:
rows = "".join(f'<tr class="add"><td class="num"></td><td class="num">{line}</td><td class="sign">+</td><td class="code">{html.escape(path)} line {line}</td></tr>' for line in range(1, ROWS + 1))
sections.append(f'<details class="file" data-path="{path}"><summary><span class="badge added" title="added">A</span><span class="path">{path}</span>'
f'<span class="stat"><span class="add">+{ROWS}</span><span class="del">&minus;0</span></span></summary><table class="diff"><tbody>{rows}</tbody></table></details>')
return f'<!DOCTYPE html><html><body><section class="group" id="staged" data-files="3">{"".join(sections)}</section></body></html>'
@unittest.skipUnless(shutil.which(os.environ.get("CHROMIUM", "chromium")), "no Chromium")
class TestBulkGrant(base.OrchestratorE2ECase):
def setUp(self):
super().setUp()
OUT.mkdir(parents=True, exist_ok=True)
page = self.page("three-files.html", review_page())
rows = {}
self.sets = {}
for width, _ in WIDTHS:
review = self.review(f"feat: three files {width}", f"feature/bulk-{width}", page)
ask = self.create_ask({**ASK, "command": f"make deploy-{width}", "timeout": 3600})
task = f"operator/bulk-{width}"
rows[task] = {"title": f"echo bulk {width}", "workdir": "/repo", "description": "bulk", "check": "manual", "status": "queued", "roles": {"Operator": "R", "Skills session": "A"}}
self.sets[width] = {"REVIEW": f"review:{review}", "ASK": f"ask:{ask}", "RUN": f"operator:{task}"}
self.spare = f"review:{self.review('feat: spare', 'feature/bulk-spare', page)}"
self.write_council({"rasci.json": rows})
def review(self, title: str, branch: str, page: str) -> str:
arguments = {**self.arguments(title, "", page), "worktree": f"/repo/.worktrees/{branch}", "branch": branch, "agent": "Skills"}
result = self.tool("review_request", arguments)
self.assertFalse(result["isError"], result)
return result["structuredContent"]["id"]
def steps(self, browser: str, signs: bool) -> list[dict]:
local = f"http://localhost:{self.port}/"
flag = "true" if signs else "false"
steps = []
for width, height in WIDTHS:
ids = self.sets[width]
shot = str(OUT / f"{browser}-{width}")
steps += [
{"width": width, "height": height, "url": f"{local}?{width}#stream/inbox", "wait": 1200, "probe": probe(DIFF, **ids), "shot": f"{shot}-continuous-diff.png"},
{"width": width, "height": height, "url": None, "wait": 0, "probe": probe(MODE), "shot": None},
{"width": width, "height": height, "url": f"{local}?{width}-kept#stream/inbox", "wait": 1200, "probe": probe(COLLECT, **ids), "shot": f"{shot}-select-tray.png"},
{"width": width, "height": height, "url": None, "wait": 0, "probe": probe(SHEET), "shot": f"{shot}-grant-sheet.png"},
{"width": width, "height": height, "url": None, "wait": 0, "probe": probe(CONFIRM, SIGNS=flag), "shot": None},
{"width": width, "height": height, "url": None, "wait": 0, "probe": probe(DIRECT, SPARE=self.spare), "shot": f"{shot}-direct.png"},
]
return steps
def check(self, data: dict, browser: str, signs: bool) -> None:
self.assertEqual([error for error in data["errors"] if "(style-src-elem)" not in error and "/favicon.ico" not in error], [])
results = iter(data["results"])
for width, _ in WIDTHS:
ids = self.sets[width]
diff, mode, collect, sheet, confirm, direct = (next(results) for _ in range(6))
with self.subTest(browser=browser, width=width):
self.assertNotIn("error", diff, diff)
self.assertEqual(diff["first"], {"opened": [True, False, False], "marked": [0]}, diff)
self.assertEqual(diff["ended"]["opened"], [True, True, False], diff)
self.assertEqual(diff["second"], {"opened": [True, True, False], "marked": [1]}, diff)
self.assertEqual(diff["jumped"], {"opened": [True, True, True], "marked": [2], "atTop": True}, diff)
self.assertEqual((mode["before"], mode["kept"], mode["after"]), (["true", "false", True, True], True, ["false", "true", False, False]), mode)
self.assertNotIn("error", collect, collect)
self.assertEqual(collect["restored"], ["false", "true", False, False], collect)
self.assertEqual(collect["counts"], ["1 selected", "2 selected", "1 selected", "2 selected", "3 selected"], collect)
self.assertEqual((collect["pressed"], collect["posted"]), (["true"] * 3, []), collect)
self.assertEqual((collect["labels"][0], collect["labels"][-1]), ("Grant selection (3)", "Clear"), collect)
self.assertEqual((sheet["label"], len(sheet["listed"])), ("Grant 3", 3), sheet)
items = sorted(f"{ref}:approve" for ref in ids.values())
self.assertEqual(confirm["posted"], [["/api/sign", items], *([["/api/inbox/approve", items]] if signs else [])], confirm)
self.assertEqual(confirm["count"], "0 selected" if signs else "3 selected", confirm)
self.assertEqual(direct["kept"], True, direct)
self.assertEqual(direct["after"], ["true", "false", True, True], direct)
self.assertEqual((direct["pressed"], direct["posted"]), (None, [[self.spare]]), direct)
self.assertFalse(any(found["wide"] for found in (diff, mode, collect, sheet, confirm, direct)), width)
def granted(self) -> None:
reviews = [ids["REVIEW"].split(":", 1)[1] for ids in self.sets.values()]
asks = [ids["ASK"].split(":", 1)[1] for ids in self.sets.values()]
self.settle(lambda: all(self.status(review) == "approved" for review in reviews))
self.assertEqual([self.ask_status(ask, "0") for ask in asks], ["allowed"] * len(asks))
self.assertEqual(self.status(self.spare.split(":", 1)[1]), "pending")
def test_chromium_continuous_diff_select_tray_one_signature_and_direct_at_three_widths(self):
with mock.patch.object(batches, "UNDO", 0.3):
data = self.drive(self.steps("chromium", True), self.authenticator())
(OUT / "chromium-bulk-grant.json").write_text(json.dumps(data, indent=1), encoding="utf-8")
self.check(data, "chromium", True)
self.granted()
@unittest.skipUnless(shutil.which(os.environ.get("FIREFOX", "firefox")), "no Firefox")
def test_firefox_continuous_diff_select_tray_and_direct_at_three_widths_unsigned(self):
data = self.drive(self.steps("firefox", False), None, "bidi.mjs", os.environ.get("FIREFOX", "firefox"))
(OUT / "firefox-bulk-grant.json").write_text(json.dumps(data, indent=1), encoding="utf-8")
self.check(data, "firefox", False)
if __name__ == "__main__":
unittest.main()
+3 -4
View File
@@ -50,8 +50,7 @@ class TestHubInbox(base.OrchestratorE2ECase):
def layout(self, probe: dict) -> None:
self.assertNotIn("error", probe)
self.assertEqual(sorted(probe["kinds"]), ["Ask", "Operator", "Operator", "Review", "Rule request"])
self.assertIn(["Deny", "Deny via …"], probe["splits"])
self.assertEqual(len(probe["splits"]), 4)
self.assertEqual(probe["splits"], [["Deny", "Deny via …"]] * 5)
self.assertEqual(probe["fields"], ["Kind", "Tool (glob)", "Pattern (glob)", "Directory (glob)", "Expires on"])
self.assertEqual(probe["dry"], "Dry run: the rule would have granted 1 of 1 asks from the last 7 days.")
self.assertEqual(probe["accept"], 1)
@@ -163,9 +162,9 @@ class TestHubInbox(base.OrchestratorE2ECase):
self.assertGreater(found["before"], 0, found)
self.assertEqual((found["moved"], found["focused"], found["wide"]), (0, True, False), found)
self.assertTrue({"Grant selection (1)", "Deny selection (2)"} <= set(found["buttons"]), found["buttons"])
self.assertEqual((sorted(found["listed"]), found["label"]), (sorted([found["title"], "pick a name"]), "Deny 2"))
self.assertEqual((sorted(found["listed"]), found["label"], found["reasoned"]), (sorted([found["title"], "pick a name"]), "Deny 2", True))
task = f"operator/row-{found['title'][-2:]}"
items = sorted([[task, "reject", "post"], ["operator/name", "reject", "post"]])
items = sorted([[task, "reject", "post", "rebase first"], ["operator/name", "reject", "post", "rebase first"]])
self.assertEqual([[path, sorted(entries)] for path, entries in found["posted"]], [["/api/sign", items], *([["/api/inbox/approve", items]] if signs else [])])
self.assertIn("takes effect" if signs else "not signed", found["toast"])
denied += [task, "operator/name"]
+1 -1
View File
@@ -139,7 +139,7 @@ class TestOrchestratorE2E(base.OrchestratorE2ECase):
with self.subTest(url=step["url"], width=step["width"]):
self.assertNotIn("error", probe)
self.assertEqual((probe["title"], probe["h1"]), ("(2) Agent Orchestrator", "Agent Orchestrator"))
self.assertEqual(probe["header"], ["radio-open", "bubbles-toggle", "palette-open", "settings-open"])
self.assertEqual(probe["header"], ["grant-direct", "grant-select", "radio-open", "bubbles-toggle", "palette-open", "settings-open"])
self.assertEqual((probe["tabs"], probe["subs"]), (TABS, SUBS))
self.assertEqual(probe["badges"], {"tab-home": None, "tab-stream": None, "tab-rules": None, "tab-agents": "1", "tab-artifacts": None, "tab-tasks": "2", "tab-resources": None})
self.assertEqual(probe["banner"], "MAYDAY · Docs: disk full")