fix(install): ship no Python bytecode into the installed skill trees and the hub
install.sh copies the rendered skills with cp -a, which carried __pycache__, *.pyc and *.pyo along; Python loads a lone .pyc before the module of the same name, so a stray file in a skill could shadow its script. After each copy, find -H prunes them in .agents/skills and .claude/skills, also when .claude/skills is a symlink to .agents/skills; the delete before the copy uses -H too. orchestrator.sh drops .pyc and .pyo besides __pycache__ in the hub tree.
Tests: test_no_python_bytecode_reaches_the_installed_skills (linked and unlinked) and test_install_ships_no_bytecode_from_the_tree fail on base 3418738 and pass; shellcheck and ruff clean; two independent reviews, round 2 holds.
🎯 Fix: 95 %
💥 Break: 2 %
💸 Cost: 100 %
⏱️ Time: 100 %
🛡️ Security: 100 %
🏆 Score: 93
🚦 Gate: ✅ 90/5, cost and time <= 100, security 100 %
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
3418738993
commit
6897f86d35
4 files changed
+39
-9
No files matched your search
+2
-1
@@ -43,8 +43,9 @@ for root in .agents/skills .claude/skills; do
|
||||
dst="${TARGET}/${root}"
|
||||
log "skills: copying -> ${dst}"
|
||||
mkdir -p "${dst}"
|
||||
find "${dst}" -mindepth 1 -delete
|
||||
find -H "${dst}" -mindepth 1 -delete
|
||||
cp -a "${src}/." "${dst}/"
|
||||
find -H "${dst}" \( -name __pycache__ -o -name '*.py[co]' \) -prune -exec rm -rf {} +
|
||||
if [[ ! "${TARGET}" -ef "${HOME}" ]]; then
|
||||
log "skills: linking in ${dst} what ${HOME}/${root} already holds"
|
||||
for skill in "${dst}"/*; do
|
||||
|
||||
@@ -156,7 +156,7 @@ install_hub() {
|
||||
chmod 700 "${APPROVERS}"
|
||||
cp -a "${REPO_ROOT}/orchestrator/." "${HUB}/"
|
||||
# Python loads a cached .pyc whose header matches the source mtime and size, and cp -a keeps the mtime: one planted in the sandbox-writable tree would run on the host
|
||||
find "${HUB}" -name __pycache__ -type d -prune -exec rm -rf {} +
|
||||
find -H "${HUB}" \( -name __pycache__ -o -name '*.py[co]' \) -prune -exec rm -rf {} +
|
||||
chmod +x "${HUB}/client/permission_hook.py" "${HUB}/client/runner.py" "${HUB}/client/approval.py" "${HUB}/client/cleanup.py" "${HUB}/client/offices.py" "${HUB}/client/sessions.py" "${HUB}/client/resources.py"
|
||||
log "skills: the PermissionRequest hook client is ${HUB}/client/permission_hook.py"
|
||||
log "skills: approvals need a pinned passkey: settings, 'Passkey registrieren', then 'make orchestrator-pin CREDENTIAL=<blob>'; until then every executor refuses"
|
||||
|
||||
Reference in new issue
Block a user