fix(kvb-check-security): scan files MEDUSA's substring path excludes drop
MEDUSA matches its exclude paths as substrings of the whole path (core/parallel.py), so plain source under utils/env/, distro.py, builder.py or .github/ went unscanned and a diff of only such files got no score. security.py now moves each file that only a path exclusion drops to kvb-scan/<sha1 of its path>/<name> in the scan tree, or to kvb-scan/<sha1><suffix> when the name itself holds a pattern, and reports and accepts its findings at the repository path. File patterns such as *.min.js still skip. Reported by Stage 2.0. 🎯 Fix: 95 % 💥 Break: 3 % 💸 Tokens: 94 % ⏱️ Velocity: – 🛡️ Security: 100 % 💰 Value: ? 🏆 Score: 98 🚦 Gate: ✅ 90/5, tokens and velocity <= 100, security 100 % Created-with: https://s.veen.world/skills Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
6b36e80dad
commit
731d0df43b
3 files changed
+81
-35
No files matched your search
+15
-14
@@ -609,21 +609,22 @@ class TestSecurity(unittest.TestCase):
|
||||
unread = f"{never}: medusa's own types, exclusions and limits are unreadable from its source: {HAND}"
|
||||
self.assertEqual((result.stdout, result.returncode), (f"🛡️ security – ({unread})\n", 4))
|
||||
|
||||
def test_a_path_medusa_excludes_is_listed_and_the_rest_scored(self):
|
||||
def test_a_file_a_path_exclusion_drops_is_scanned_and_named_at_its_repository_path(self):
|
||||
self.write("app.py", "print(1)\nx = 1 # MARK-HIGH\n")
|
||||
(self.repo / "cli" / "build").mkdir(parents=True)
|
||||
self.write("cli/build/run.py", "y = 1 # MARK-CRITICAL\n")
|
||||
self.write("environ.py", "z = 1 # MARK-CRITICAL\n")
|
||||
result = self.scan(env=self.env)
|
||||
self.assertEqual((result.stdout, result.returncode), (
|
||||
"🛡️ security 75 % (medusa: 1 finding in 1 file: high app.py:2; not covered: cli/build/run.py, environ.py)\n",
|
||||
3,
|
||||
))
|
||||
self.write("app.py", "print(1)\n")
|
||||
result = self.scan(env=self.env)
|
||||
never = "medusa never covers this diff, nothing cached"
|
||||
none = f"{never}: medusa scans none of its files, not covered: cli/build/run.py, environ.py: {HAND}"
|
||||
self.assertEqual((result.stdout, result.returncode), (f"🛡️ security – ({none})\n", 4))
|
||||
self.write("utils/env/run.py", "y = 1 # MARK-LOW\n")
|
||||
self.write("environ.py", "z = 1 # MARK-LOW\n")
|
||||
self.write("build/lib.min.js", "a // MARK-CRITICAL\n")
|
||||
found = json.loads(self.scan("--json", env=self.env).stdout)
|
||||
self.assertEqual(
|
||||
sorted((f["path"], f["line"], f["severity"]) for f in found["findings"]),
|
||||
[("app.py", 2, "high"), ("environ.py", 1, "low"), ("utils/env/run.py", 1, "low")],
|
||||
)
|
||||
self.assertEqual((found["files"], found["not_covered"]), (3, ["build/lib.min.js"]))
|
||||
sha1 = next(f["sha1"] for f in found["findings"] if f["path"] == "utils/env/run.py")
|
||||
accepted = self.accept("--rule", "FAKE-LOW", "--path", "utils/env/run.py", "--sha1", sha1, "--reason", "fixture")
|
||||
self.assertEqual(accepted.returncode, 0, accepted.stderr)
|
||||
again = json.loads(self.scan("--json", env=self.env).stdout)
|
||||
self.assertEqual(sorted(f["path"] for f in again["findings"]), ["app.py", "environ.py"])
|
||||
|
||||
def test_medusa_limits_come_from_its_source(self):
|
||||
mark = "y = 1 # MARK-CRITICAL\n"
|
||||
|
||||
Reference in new issue
Block a user