feat(operator): report each operator row outcome back to the agent that queued it
operator.py stores the adding session's name and id with the row. Done, cancel and failure go to that stored name and pinned session id, never re-resolved: a radio post by default, a call when that session picked it with radio.py feedback set call. The caller's own parts are dropped. The hub counts unanswered calls per session id. MEDUSA: 34 findings accepted after an independent review, 0 true positives: 3x CGS-SCAN-029 by design (operator-confirmed runner in operator.py execute and its call), 2x CGS-SCAN-030 (exec inside the name execute), CODEGEN-SCAN-003 and CGS-SCAN-028 (open inside Popen), 3x CGS-SCAN-040 (prompt loops end), 4x GENAI-SCAN-1270 (rasci.database() JSON register), 20x FLA-SCAN-055 (dba inside the word feedback). 🎯 Fix: 93 % 💥 Break: 4 % 💸 Cost: 100 % ⏱️ Time: 100 % 🛡️ Security: 100 % 🏆 Score: 89 🚦 Gate: ✅ 90/5, cost and time <= 100, security 100 % Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
3418738993
commit
7d70e07b4c
14 files changed
+833
-95
No files matched your search
@@ -78,6 +78,53 @@ class TestHubConsole(HubCase):
|
||||
self.assertEqual(console, output[-skill_scripts.OUTPUT_LIMIT :])
|
||||
self.assertEqual(console, snapshot["jobs"][-1]["output"])
|
||||
|
||||
def test_only_a_done_or_failed_command_job_reports_the_command_and_directory_it_ran(self):
|
||||
self.register("queued")
|
||||
fields = {"task": "operator/greet", "command": COMMAND, "directory": str(self.outside), "sha256": DIGEST, "status": "running", "proof": None}
|
||||
jobs = [
|
||||
self.httpd.hub.jobs.add({**fields, **extra, "code": None, "output": "", "created_ts": time.time(), "started": time.time(), "finished": None, "dismissed": False})
|
||||
for extra in ({}, {}, {}, {}, {}, {"kind": "gate", "argv": []})
|
||||
]
|
||||
reports = (
|
||||
{"output": "token-42\n", "code": 0, "refused": False}, {"output": "token-42\n", "code": 3, "refused": False},
|
||||
{"output": "", "code": -9, "refused": False}, {"output": "", "code": 130, "refused": False},
|
||||
{"output": "token-42\n", "code": None, "refused": True}, {"output": "", "code": 1, "refused": False},
|
||||
)
|
||||
answers = [self.runner(f"/api/runner/{job['id']}/report", report) for job, report in zip(jobs, reports)]
|
||||
self.assertEqual([(status, body["status"], len(body["runs"])) for status, body in answers], [
|
||||
(200, "done", 1), (200, "failed", 1), (200, "failed", 1), (200, "failed", 1), (200, "refused", 0), (200, "failed", 0),
|
||||
])
|
||||
shown = ["greet", f"--command={COMMAND}", f"--dir={self.outside}"]
|
||||
self.assertEqual(self.scripts.calls, [
|
||||
(skill_scripts.OPERATOR_SCRIPT, ["ran", *shown]),
|
||||
(skill_scripts.OPERATOR_SCRIPT, ["failed", *shown, "--why", "exit 3"]),
|
||||
(skill_scripts.OPERATOR_SCRIPT, ["failed", *shown, "--why", "killed by signal 9"]),
|
||||
(skill_scripts.OPERATOR_SCRIPT, ["failed", *shown, "--why", "exit 130"]),
|
||||
])
|
||||
self.assertNotIn("token-42", json.dumps(self.scripts.calls))
|
||||
|
||||
def test_an_older_installed_operator_without_ran_still_closes_the_row_through_done(self):
|
||||
self.register("queued")
|
||||
fields = {"task": "operator/greet", "command": COMMAND, "directory": str(self.outside), "sha256": DIGEST, "status": "running", "proof": None}
|
||||
jobs = [
|
||||
self.httpd.hub.jobs.add({**fields, "code": None, "output": "", "created_ts": time.time(), "started": time.time(), "finished": None, "dismissed": False})
|
||||
for _ in range(2)
|
||||
]
|
||||
self.scripts.code = 2
|
||||
done = self.runner(f"/api/runner/{jobs[0]['id']}/report", {"output": "", "code": 0, "refused": False})[1]
|
||||
failed = self.runner(f"/api/runner/{jobs[1]['id']}/report", {"output": "", "code": 1, "refused": False})[1]
|
||||
shown = ["greet", f"--command={COMMAND}", f"--dir={self.outside}"]
|
||||
self.assertEqual(self.scripts.calls, [
|
||||
(skill_scripts.OPERATOR_SCRIPT, ["ran", *shown]),
|
||||
(skill_scripts.OPERATOR_SCRIPT, ["done", "greet"]),
|
||||
(skill_scripts.OPERATOR_SCRIPT, ["failed", *shown, "--why", "exit 1"]),
|
||||
])
|
||||
self.assertEqual((len(done["runs"]), len(failed["runs"])), (2, 1))
|
||||
self.scripts.code = 1
|
||||
job = self.httpd.hub.jobs.add({**fields, "code": None, "output": "", "created_ts": time.time(), "started": time.time(), "finished": None, "dismissed": False})
|
||||
self.runner(f"/api/runner/{job['id']}/report", {"output": "", "code": 0, "refused": False})
|
||||
self.assertEqual(self.scripts.calls[-1], (skill_scripts.OPERATOR_SCRIPT, ["ran", *shown]))
|
||||
|
||||
def test_jobs_from_before_the_console_stay_out_of_the_inbox(self):
|
||||
self.register("done")
|
||||
fields = {"task": "operator/greet", "command": COMMAND, "directory": str(self.outside), "sha256": DIGEST, "status": "done", "proof": None}
|
||||
|
||||
Reference in new issue
Block a user