fix(orchestrator): settle queue jobs whose holder is gone instead of showing them running
The hub read queue.json alone, so an active entry whose hold had exited kept showing as running. client/queue_live.py probes each hold lock as queue.py's held() does (shared non-blocking flock, hard links probed too) and reads the whole queue-history.jsonl, cached by inode, size and mtime; an active entry with a history row started after its enqueue ends with that row's exit, one whose holder is gone becomes gone. The outcome lives in the hub-owned field hub_outcome; queue.py status is never rewritten. resources.py uses the same settled(), plan medians skip the queue kind, and a guard test keeps every client module in the Dockerfile COPY line. Also closes fd leaks in read_history and records.read_regular. MEDUSA: 11 findings in resources.py (lines 73, 81, 262, 445 x2, 576, 227, 479, 524, 578) and crons.py:125 accepted as false positives after an independent review, operator pick 2026-11-12. 🎯 Fix: 92 % 💥 Break: 5 % 💸 Cost: 100 % ⏱️ Time: 100 % 🛡️ Security: 100 % 🏆 Score: 87 🚦 Gate: ✅ 90/5, cost and time <= 100, security 100 % Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
3418738993
commit
85b79de0d8
15 files changed
+534
-39
No files matched your search
@@ -23,12 +23,12 @@ const Plan = (() => {
|
||||
}
|
||||
|
||||
/**
|
||||
* @param rows - task rows with status, start, end (epoch seconds or null) and points (median complexity or null).
|
||||
* @returns {duration, perPoint}: the median seconds a done task took from start to end, and the median seconds
|
||||
* per point of the done tasks with points; null where no done task gives one.
|
||||
* @param rows - task rows with kind, status, start, end (epoch seconds or null) and points (median complexity or null).
|
||||
* @returns {duration, perPoint}: the median seconds a done task, never a queue job, took from start to end, and the
|
||||
* median seconds per point of the done tasks with points; null where no done task gives one.
|
||||
*/
|
||||
function medians(rows) {
|
||||
const done = rows.filter((row) => row.status === "done" && row.start !== null && row.end !== null && row.end >= row.start);
|
||||
const done = rows.filter((row) => row.kind !== "queue" && row.status === "done" && row.start !== null && row.end !== null && row.end >= row.start);
|
||||
return {
|
||||
duration: median(done.map((row) => row.end - row.start)),
|
||||
perPoint: median(done.filter((row) => row.points).map((row) => (row.end - row.start) / row.points)),
|
||||
|
||||
Reference in new issue
Block a user