fix(kvb-org-queue): read an empty read-only settings file as no rules

The agent sandbox mounts an absent settings.local.json as an empty
read-only file; permission() crashed on json.loads of it and the block
hook refused every hold. An empty file now counts as no rules, while
deny rules from settings.json still refuse.

🎯 Fix: 95 %
💥 Break: 2 %
💸 Tokens: 100 %
⏱️ Velocity: 100 %
🛡️ Security: 100 %
🏆 Score: 93
🚦 Gate: ✅ 90/5, tokens and velocity <= 100, security 100 %

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kevin Veen-BirkenbachandClaude Opus 5.5 committed 2026-11-17 07:56:24 +00:00
1 parent 62da518721
commit 87fbae9226
2 files changed
+19 -1

No files matched your search

+17
View File
@@ -2325,6 +2325,23 @@ class TestQueueCommands(unittest.TestCase):
allowed = self.hook(json.dumps({"tool_input": {"command": command}}))
self.assertEqual((allowed.returncode, allowed.stdout), (0, ""))
def test_block_reads_an_empty_read_only_settings_file_as_no_rules(self):
project = self.base / "project"
(project / ".claude").mkdir(parents=True)
(project / ".claude" / "settings.json").write_text(
json.dumps({"permissions": {"deny": ["Bash(git push *)"]}}), encoding="utf-8"
)
local = project / ".claude" / "settings.local.json"
local.write_text("", encoding="utf-8")
local.chmod(0o444)
self.env["CLAUDE_PROJECT_DIR"] = str(project)
hold = "python3 /x/queue.py hold --kind deploy --task work/a -- "
allowed = self.hook(json.dumps({"tool_input": {"command": hold + "make test"}}))
self.assertEqual((allowed.returncode, allowed.stdout), (0, ""), allowed.stderr)
denied = self.hook(json.dumps({"tool_input": {"command": hold + "git push origin main"}}))
self.assertEqual(denied.returncode, 2)
self.assertIn("deny rule", denied.stderr)
def test_block_refuses_a_hold_it_cannot_check(self):
hold = "python3 /x/queue.py hold --kind deploy --task work/a -- "
unchecked = {"unbalanced quote": (hold + "echo 'x", self.env)}