feat(orchestrator): review staged work as match cards (requirement 012, phases A and B)

Requirement 012 plus its first two phases: the kvb-match skill (match.py add, list, show) feeds the existing review queue, /api/match serves the cards and local-only stale and snapshot posts, and payload files are read only as regular files under /tmp within the sandbox view and 64 KiB. The card at #tasks/match shows face, name, age in days, repository, branch, worktree and files that open while scrolling; right-click or long press marks a line, stale cards cannot be accepted. Accept, reject and the passkey release follow in phase C after the screenshot feedback. Tests run once on unify/skills-20261114 after the merge (operator order 2026-11-14).

🎯 Fix: 75 %
💥 Break: 8 %
💸 Tokens: 100 %
⏱️ Velocity: 100 %
🛡️ Security: 95 %
🏆 Score: 66
🚦 Gate: ⛔ fix 75 % < 90, break 8 % > 5; security 95 % < 100: ask the operator before the commit

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kevin Veen-BirkenbachandClaude Opus 5.5 committed 2026-11-14 21:36:40 +00:00
1 parent a2a03995cb
commit 8bc7209ed1
23 files changed
+1407 -15

No files matched your search

+4
View File
@@ -434,6 +434,8 @@ pre.notes { margin: 0; padding: 8px 10px; background: var(--sunken); border-radi
{% include "style-home.css" %}
{% include "style-firewall.css" %}
{% include "style-match.css" %}
</style>
</head>
<body>
@@ -585,6 +587,8 @@ pre.notes { margin: 0; padding: 8px 10px; background: var(--sunken); border-radi
{% include "page-kanban.js" %}
{% include "page-match.js" %}
{% include "page-choices.js" %}
{% include "page-time.js" %}
+1 -1
View File
@@ -2,7 +2,7 @@ const Nav = (() => {
"use strict";
const TABS = [["home", "Home"], ["stream", "Stream"], ["agents", "Agents"], ["artifacts", "Artifacts"], ["tasks", "Tasks"], ["resources", "Resources"]];
const SUBS = {stream: [["rules", "Firewall"]]};
const PANES = {inbox: ["tasks", "operator"]};
const PANES = {inbox: ["tasks", "operator"], match: ["tasks", "match"]};
const VIEWS = [["orbit", "Orbit"], ["chord", "Chord"], ["swimlane", "Swimlane"], ["tree", "Tree"], ["3d", "3D"]];
const TASK_VIEWS = [["list", "List"], ["board", "Board"], ["rasci", "RASCI"], ["gantt", "Gantt"], ["burn", "Burndown and burnup"], ["3d", "3D"]];
const OWN = {agents: [["hierarchy", "Hierarchy"]]};
+286
View File
@@ -0,0 +1,286 @@
const MATCH_REFRESH = 2000;
const MATCH_PEEKS = 2;
const LONG_PRESS = 550;
const PRESS_SLOP = 10;
const MATCH_KINDS = {commit: ["Commit", "info", "bi-git"], command: ["Command", "warn", "bi-terminal"]};
const matchView = {cards: null, order: [], marks: new Map(), opened: new Map(), dom: null, sig: "", fetched: 0, loading: false, press: null};
async function fetchMatch() {
if (matchView.loading) {
return;
}
matchView.loading = true;
matchView.fetched = Date.now();
try {
const response = await fetch("/api/match", {cache: "no-store"});
if (response.ok) {
const data = await response.json();
matchView.cards = Array.isArray(data.cards) ? data.cards : [];
}
} catch {
matchView.cards = matchView.cards || [];
} finally {
matchView.loading = false;
}
drawMatch();
}
function matchOrder(cards) {
const ids = new Set(cards.map((card) => card.id));
const kept = matchView.order.filter((id) => ids.has(id));
const fresh = cards.filter((card) => !kept.includes(card.id)).sort((a, b) => Number(a.stale) - Number(b.stale) || (a.created_ts || 0) - (b.created_ts || 0));
matchView.order = [...kept, ...fresh.map((card) => card.id)];
const byId = new Map(cards.map((card) => [card.id, card]));
return matchView.order.map((id) => byId.get(id));
}
function ageWords(born) {
if (typeof born !== "number") {
return "age unknown";
}
const days = Math.max(0, Math.floor((state.now - born) / DAY));
return days === 1 ? "1 day" : `${days} days`;
}
function marksOf(card) {
const key = `${card.id}@${card.hash}`;
if (!matchView.marks.has(key)) {
matchView.marks.set(key, []);
}
return matchView.marks.get(key);
}
function contentRows(text) {
const lines = String(text).split("\n");
if (lines.length && lines[lines.length - 1] === "") {
lines.pop();
}
return lines.map((line, index) => h("tr", {class: "ctx", "data-line": index + 1}, h("td", {class: "num"}, index + 1), h("td", {class: "code"}, revealed(line))));
}
function markRow(mark, columns) {
return h("tr", {class: "match-mark", "data-line": mark.line}, h("td", {colspan: columns}, icon("bi-chat-square-text"), h("span", {class: "match-mark-text"}, revealed(mark.comment))));
}
function fileRows(card, file) {
const commit = card.kind === "commit";
const rows = commit ? (file.patch ? Diffs.rows(file.patch).map(patchRow) : []) : file.state === "read" ? contentRows(file.content) : [];
const columns = commit ? 4 : 2;
const marks = marksOf(card).filter((mark) => mark.path === file.path);
return rows.flatMap((row) => {
const line = row.dataset.line;
const here = marks.filter((mark) => String(mark.line) === line);
if (here.length) {
row.classList.add("marked");
}
return [row, ...here.map((mark) => markRow(mark, columns))];
});
}
function fileHead(card, file) {
const count = marksOf(card).filter((mark) => mark.path === file.path).length;
const marks = count ? h("span", {class: "match-marks", title: `${count} marks`}, String(count)) : null;
if (card.kind === "commit") {
const tone = DIFF_TONES[file.status] || "neutral";
const stat = file.status === "B" ? icon("bi-file-earmark-binary") : h("span", {class: "stat"}, h("span", {class: "add"}, `+${file.additions}`), h("span", {class: "del"}, `-${file.deletions}`));
return h("summary", {class: "diff-head"}, h("span", {class: "letter", "data-tone": tone}, file.status), h("code", {class: "path"}, revealed(file.path)), h("span", {class: "spacer"}),
file.note ? h("span", {class: "note", title: file.note}, icon("bi-eye-slash"), file.note) : null, marks, stat);
}
const tone = file.state === "read" ? "ok" : "bad";
return h("summary", {class: "diff-head"}, h("span", {class: "letter", "data-tone": tone}, icon("bi-file-earmark-text")), h("code", {class: "path"}, revealed(file.path)), h("span", {class: "spacer"}),
file.state === "read" ? null : h("span", {class: "note", title: file.reason}, icon("bi-exclamation-triangle"), `refused: ${file.reason}`), marks, h("span", {class: "muted"}, `${file.size} B`));
}
function fileBlock(card, file, index) {
const opened = matchView.opened.has(card.id) ? matchView.opened.get(card.id).has(file.path) : index === 0;
const rows = fileRows(card, file);
const table = rows.length ? h("div", {class: "diff-scroll"}, h("table", {class: "diff"}, h("tbody", {}, rows))) : h("p", {class: "muted"}, card.kind === "commit" ? "No patch shipped for this file." : "Not read.");
const block = h("details", {class: "match-file", "data-path": file.path, "data-state": card.kind === "command" ? file.state : null, open: opened}, fileHead(card, file), table);
block.addEventListener("toggle", () => remember(card, block));
return h("li", {}, block);
}
function remember(card, block) {
if (!matchView.opened.has(card.id)) {
matchView.opened.set(card.id, new Set());
}
const open = matchView.opened.get(card.id);
if (block.open) {
open.add(block.dataset.path);
} else {
open.delete(block.dataset.path);
}
}
function openOnScroll(body) {
const files = [...body.querySelectorAll(".match-file")];
const view = body.getBoundingClientRect();
for (let index = 0; index < files.length - 1; index += 1) {
const file = files[index];
if (!file.open) {
return;
}
const next = files[index + 1];
if (!next.open && file.getBoundingClientRect().bottom <= view.bottom + 8) {
next.open = true;
return;
}
}
}
function closeComment(card) {
const open = card.querySelector(".match-comment");
if (open) {
open.remove();
}
}
function commentField(card, data, row) {
const article = row.closest(".match-card");
closeComment(article);
const file = row.closest(".match-file");
const words = h("textarea", {class: "field", rows: 2, "aria-label": "Comment", placeholder: "Comment on this line"});
const save = h("button", {type: "button", class: "btn small primary match-save", ...named("Save mark"), on: {click: () => {
if (!words.value.trim()) {
words.focus();
return;
}
marksOf(data).push({path: file.dataset.path, line: Number(row.dataset.line), comment: words.value.trim()});
drawMatch(true);
}}}, icon("bi-bookmark-fill"), "Save");
const cancel = h("button", {type: "button", class: "btn small ghost", ...named("Cancel"), on: {click: () => closeComment(article)}}, "Cancel");
const columns = row.children.length;
const field = h("tr", {class: "match-comment"}, h("td", {colspan: columns}, h("div", {class: "match-comment-box"}, h("code", {}, `${file.dataset.path}:${row.dataset.line}`), words, h("div", {class: "actions"}, cancel, save))));
row.after(field);
words.focus();
}
function codeRow(event) {
const row = event.target instanceof Element ? event.target.closest(".match-file tr[data-line]") : null;
return row && !row.classList.contains("match-mark") ? row : null;
}
function markable(article, data) {
article.addEventListener("contextmenu", (event) => {
const row = codeRow(event);
if (row) {
event.preventDefault();
commentField(article, data, row);
}
});
article.addEventListener("pointerdown", (event) => {
const row = codeRow(event);
if (!row || event.pointerType !== "touch") {
return;
}
const press = {x: event.clientX, y: event.clientY, timer: window.setTimeout(() => {
matchView.press = null;
commentField(article, data, row);
}, LONG_PRESS)};
matchView.press = press;
});
const drop = () => {
if (matchView.press) {
window.clearTimeout(matchView.press.timer);
matchView.press = null;
}
};
article.addEventListener("pointermove", (event) => {
if (matchView.press && Math.hypot(event.clientX - matchView.press.x, event.clientY - matchView.press.y) > PRESS_SLOP) {
drop();
}
});
article.addEventListener("pointerup", drop);
article.addEventListener("pointercancel", drop);
}
function matchHead(card) {
const [kindName, kindTone, kindIcon] = MATCH_KINDS[card.kind] || [card.kind, "neutral", "bi-collection"];
return h("header", {class: "match-head"},
h("div", {class: "match-who"}, face(card.agent || "-", true), h("strong", {class: "match-name"}, revealed(card.agent || "unknown agent")), h("span", {class: "match-age"}, ageWords(card.born))),
h("div", {class: "states"}, h("span", {class: "pill", "data-tone": kindTone}, icon(kindIcon), kindName), card.gate ? pill(`gate ${card.gate}`, card.gate === "pass" ? "ok" : "bad") : null,
card.score ? h("span", {class: "pill", "data-tone": "neutral"}, revealed(card.score)) : null, card.stale ? h("span", {class: "pill match-stale-pill", "data-tone": "bad"}, icon("bi-hourglass-split"), "stale") : null),
h("dl", {class: "meta match-place"}, [["Repository", card.repo], ["Branch", card.branch], ["Worktree", card.worktree]].map(([label, value]) => h("div", {}, h("dt", {}, label), h("dd", {}, h("code", {title: value ? revealed(value) : null}, revealed(dash(value))))))),
h("h2", {class: "match-title"}, revealed(card.title)),
card.stale ? h("p", {class: "match-stale"}, icon("bi-exclamation-triangle"), revealed(card.stale_reason)) : null);
}
function matchCommand(card) {
if (card.kind !== "command") {
return null;
}
return h("section", {class: "match-payload"},
h("pre", {class: "match-command"}, h("code", {}, revealed(card.command))),
h("p", {class: "match-directory"}, revealed(card.directory)),
card.reason && card.reason !== "-" ? h("p", {class: "match-reason"}, revealed(card.reason)) : null);
}
function matchCard(card) {
const files = card.files || [];
const list = files.length ? h("ol", {class: "match-files", "aria-label": `Files: ${files.length}`}, files.map((file, index) => fileBlock(card, file, index))) : h("p", {class: "muted"}, card.kind === "commit" ? "No diff shipped with this stage." : "Its command names no file.");
const body = h("div", {class: "match-body"}, matchCommand(card), list);
body.addEventListener("scroll", () => openOnScroll(body), {passive: true});
const article = h("article", {class: "card match-card front", "data-card": card.id, "data-kind": card.kind, "data-stale": String(Boolean(card.stale)), "aria-label": `${card.kind} card of ${card.agent || "an agent"}`},
matchHead(card), body);
markable(article, card);
window.setTimeout(() => openOnScroll(body), 0);
return article;
}
function peekTab(card) {
const [kindName, kindTone] = MATCH_KINDS[card.kind] || [card.kind, "neutral"];
return h("button", {type: "button", class: "match-peek", "data-card": card.id, "data-stale": String(Boolean(card.stale)), ...named(`Show ${kindName.toLowerCase()} card: ${card.title}`), on: {click: () => {
matchView.order = [card.id, ...matchView.order.filter((id) => id !== card.id)];
drawMatch(true);
}}}, face(card.agent || "-", false), h("span", {class: "pill", "data-tone": kindTone}, kindName), card.stale ? h("span", {class: "pill", "data-tone": "bad"}, "stale") : null, h("span", {class: "match-peek-title"}, revealed(card.title)));
}
function matchScreen() {
const stack = h("div", {class: "match-stack"});
const count = h("span", {class: "muted"});
matchView.dom = {stack, count};
matchView.sig = "";
const bar = h("div", {class: "card controls task-toolbar", role: "toolbar", "aria-label": "Match"}, h("strong", {}, icon("bi-stack"), "Match"), count, h("span", {class: "spacer"}),
iconBtn("bi-list-check", "Tasks", "btn small soft", () => go("tasks", null), "Tasks: back to the task list"));
fetchMatch();
return h("div", {class: "graph tasks match"}, bar, stack);
}
function drawMatch(force) {
const dom = matchView.dom;
if (!dom || !dom.stack.isConnected) {
return;
}
if (!matchView.loading && Date.now() - matchView.fetched > MATCH_REFRESH) {
fetchMatch();
}
if (matchView.cards === null) {
dom.stack.replaceChildren(h("p", {class: "muted"}, "Loading cards …"));
return;
}
const cards = matchOrder(matchView.cards);
const sig = JSON.stringify([cards.map((card) => [card.id, card.hash, card.live_hash, card.stale, card.born, card.files ? card.files.length : null]), Math.floor(state.now / DAY)]);
if (!force && sig === matchView.sig) {
return;
}
matchView.sig = sig;
dom.count.textContent = cards.length === 1 ? "1 card waits" : `${cards.length} cards wait`;
if (!cards.length) {
dom.stack.replaceChildren(emptyState("No card waits", "No staged commit and no operator command waits for a decision."));
return;
}
const [front, ...rest] = cards;
const accept = h("button", {type: "button", class: "btn match-accept", disabled: Boolean(front.stale), ...named("Accept", front.stale ? `Accept: refused while the card is stale (${front.stale_reason})` : "Accept")}, icon("bi-check-lg"));
const reject = h("button", {type: "button", class: "btn match-reject", ...named("Reject")}, icon("bi-x-lg"));
const peeks = rest.length ? h("div", {class: "match-peeks", role: "group", "aria-label": `${rest.length} more cards`}, rest.map(peekTab)) : null;
const behind = rest.slice(0, MATCH_PEEKS).map((card, index) => {
const sheet = h("div", {class: "match-behind", "aria-hidden": "true"});
sheet.style.setProperty("--depth", String(index + 1));
return sheet;
});
const before = dom.stack.querySelector(".match-card.front");
const scrolled = before && before.dataset.card === front.id ? before.querySelector(".match-body").scrollTop : 0;
const shown = matchCard(front);
dom.stack.replaceChildren(peeks, h("div", {class: "match-deck"}, behind, shown), h("div", {class: "match-actions"}, reject, accept));
shown.querySelector(".match-body").scrollTop = scrolled;
}
+4 -2
View File
@@ -55,7 +55,7 @@
}
function screenOf() {
return {home: homeScreen, stream: streamScreen, inbox: tasksScreen, rules: rulesScreen, agents: agentsScreen, artifacts: artifactsScreen, tasks: tasksScreen, resources: resourcesScreen}[ui.screen]();
return {home: homeScreen, stream: streamScreen, inbox: tasksScreen, match: matchScreen, rules: rulesScreen, agents: agentsScreen, artifacts: artifactsScreen, tasks: tasksScreen, resources: resourcesScreen}[ui.screen]();
}
function render(force) {
@@ -70,10 +70,11 @@
inboxDom = null;
inboxSig = "";
taskView.dom = null;
matchView.dom = null;
const main = document.getElementById("main");
main.setAttribute("aria-labelledby", `tab-${ui.screen}`);
main.replaceChildren(screenOf());
const fit = ["tasks", "inbox", "resources"].includes(ui.screen) || (["agents", "artifacts"].includes(ui.screen) && !["tree", "hierarchy"].includes(ui.views[ui.screen]));
const fit = ["tasks", "inbox", "match", "resources"].includes(ui.screen) || (["agents", "artifacts"].includes(ui.screen) && !["tree", "hierarchy"].includes(ui.views[ui.screen]));
document.body.classList.toggle("fit", fit);
document.body.classList.toggle("pane", !fit);
drawn.screen = ui.screen;
@@ -90,6 +91,7 @@
drawInbox();
drawRadio();
drawTasks();
drawMatch(false);
drawChoices();
drawStatus();
tick();
+47
View File
@@ -0,0 +1,47 @@
.graph.tasks.match > .match-stack { flex: 1; }
.match-stack { display: grid; grid-template-rows: auto minmax(0, 1fr) auto; gap: var(--sp-2); min-height: 0; width: min(100%, 960px); margin: 0 auto; }
.match-peeks { display: flex; flex-wrap: wrap; gap: var(--sp-1); min-width: 0; }
.match-peek { display: inline-flex; align-items: center; gap: 6px; max-width: 100%; min-width: 0; padding: 4px 10px 4px 4px; border: 1px solid var(--line); border-radius: 999px; background: var(--panel); color: inherit; font: inherit; font-size: var(--fs-sm); cursor: pointer; }
.match-peek[data-stale="true"] { border-color: var(--bad); }
.match-peek .match-peek-title { overflow: hidden; text-overflow: ellipsis; white-space: nowrap; min-width: 0; }
.match-deck { position: relative; display: grid; grid-template-rows: minmax(0, 1fr); min-height: 0; padding-top: 14px; }
.match-behind { position: absolute; inset: calc(14px - var(--depth) * 7px) calc(var(--depth) * 12px) auto; height: 40px; border: 1px solid var(--line); border-radius: var(--radius-lg); background: var(--panel); opacity: calc(1 - var(--depth) * 0.3); }
.match-card.front { position: relative; display: grid; grid-template-rows: auto minmax(0, 1fr); min-height: 0; padding: 0; overflow: hidden; }
.match-card[data-stale="true"] { box-shadow: inset 0 3px 0 var(--bad); }
.match-head { display: grid; justify-items: center; gap: 6px; padding: var(--sp-3); border-bottom: 1px solid var(--line); text-align: center; }
.match-who { display: grid; justify-items: center; gap: 2px; }
.match-who .avatar.big { width: 72px; height: 72px; }
.match-name { font-size: var(--fs-lg); }
.match-age { color: var(--muted); font-size: var(--fs-sm); }
.match-place { display: grid; grid-template-columns: repeat(3, minmax(0, 1fr)); gap: var(--sp-2); width: 100%; margin: 0; text-align: left; }
.match-place code { display: block; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; }
.match-title { margin: 0; font-size: var(--fs-md); overflow-wrap: anywhere; }
.match-stale { display: flex; align-items: center; gap: 6px; margin: 0; color: var(--bad); font-size: var(--fs-sm); }
.match-body { min-height: 0; overflow: auto; padding: var(--sp-2) var(--sp-3) var(--sp-3); overscroll-behavior: contain; }
.match-payload { display: grid; gap: 4px; margin-bottom: var(--sp-2); }
.match-command { margin: 0; padding: 8px 10px; border-radius: 10px; background: var(--sunken); font-family: var(--mono); white-space: pre-wrap; overflow-wrap: anywhere; }
.match-directory, .match-reason { margin: 0; color: var(--muted); font-size: var(--fs-sm); overflow-wrap: anywhere; }
.match-directory::before { content: "in "; }
.match-files { display: grid; gap: var(--sp-2); margin: 0; padding: 0; list-style: none; }
.match-file { min-width: 0; overflow: hidden; border: 1px solid var(--line); border-radius: 10px; background: var(--panel); }
.match-file > summary.diff-head { padding: 6px 10px; cursor: pointer; list-style: none; }
.match-file > summary.diff-head::-webkit-details-marker { display: none; }
.match-file .diff-scroll { max-height: none; overflow: auto hidden; }
.match-file .diff-head .note { display: inline-flex; align-items: center; gap: 4px; color: var(--warn); font-size: var(--fs-xs); }
.match-marks { min-width: 20px; padding: 0 6px; border-radius: 999px; background: var(--accent); color: var(--on-accent); font-size: var(--fs-xs); text-align: center; }
.match-file tr.marked td.code { box-shadow: inset 3px 0 0 var(--accent); }
.match-file tr.match-mark td, .match-file tr.match-comment td { padding: 4px 10px; background: var(--info-soft); font-family: var(--sans); white-space: normal; }
.match-mark-text { margin-left: 6px; }
.match-comment-box { display: grid; gap: 6px; }
.match-comment-box .actions { display: flex; justify-content: flex-end; gap: 6px; }
.match-actions { display: flex; justify-content: space-between; padding-bottom: var(--sp-1); }
.match-actions .btn { width: 56px; height: 56px; border-radius: 50%; }
.match-reject { color: var(--bad); }
.match-accept { color: var(--ok); }
.match-accept:disabled { opacity: 0.4; cursor: not-allowed; }
@media (max-width: 640px) {
.match-place { grid-template-columns: minmax(0, 1fr); }
.match-head { padding: var(--sp-2); }
.match-who .avatar.big { width: 56px; height: 56px; }
.match-body { padding: var(--sp-1) var(--sp-2) var(--sp-2); }
}