fix(orchestrator): queue every speech row of a poll before one redraw

speakRows queues all speech rows of a poll before the single redraw, so a MAYDAY behind other rows is never lost, and a draw that throws shows a toast instead of stopping the pump. Late and stale rows both bubble. Tests run once on unify/skills-20261114 after the merge (operator order 2026-11-14).

🎯 Fix: 80 %
💥 Break: 5 %
💸 Tokens: 100 %
⏱️ Velocity: 100 %
🛡️ Security: 100 %
🏆 Score: 76
🚦 Gate: ⛔ fix 80 % < 90

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kevin Veen-BirkenbachandClaude Opus 5.5 committed 2026-11-14 21:23:12 +00:00
1 parent a2a03995cb
commit d882e501c1
10 files changed
+732 -31

No files matched your search

+38 -3
View File
@@ -1,7 +1,7 @@
const BUBBLE_FONT = "/vendor/comic-neue.woff2";
const BUBBLE_FADE = 400;
const BUBBLE_EDGE = 8;
const bubbles = {shown: new Map(), frame: 0, font: null};
const bubbles = {shown: new Map(), frame: 0, font: null, quiet: [], waiting: [], warned: 0};
function bubbleLayer() {
return document.getElementById("bubbles");
@@ -99,16 +99,49 @@
view.words.textContent = text;
view.words.scrollTop = view.words.scrollHeight;
}
Object.assign(view.node.dataset, {scale: String(entry.scale), state: item.started ? "speaking" : "waiting", words: String(count)});
Object.assign(view.node.dataset, {scale: String(entry.scale), state: item.quiet ? "quiet" : item.started ? "speaking" : "waiting", words: String(count)});
view.node.style.setProperty("--scale", String(entry.scale));
placeBubble(view, anchorOf(entry.who), entry.scale);
}
function startQuiet(spoken) {
const {start, waiting} = Bubbles.admit(bubbles.quiet, bubbles.waiting, new Set(spoken.map((entry) => entry.who)));
bubbles.waiting = waiting;
for (const item of start) {
Object.assign(item, {started: performance.now(), duration: Bubbles.reading(saidOf(item).length)});
item.timer = window.setTimeout(() => {
bubbles.quiet = bubbles.quiet.filter((other) => other !== item);
drawBubbles();
}, item.duration * 1000);
}
bubbles.quiet = [...bubbles.quiet, ...start];
}
/**
* @param {Array<object>} items the silent bubbles of the rows one poll brought live, oldest first.
*/
function quietBubbles(items) {
bubbles.waiting = items.reduce(Bubbles.queued, bubbles.waiting);
}
function drawBubbles() {
try {
renderBubbles();
} catch (error) {
if (Date.now() - bubbles.warned > SPEECH_QUIET) {
bubbles.warned = Date.now();
toast("Drawing speech bubbles failed", [String(error.message || error)], false);
}
}
}
function renderBubbles() {
if (!settings.bubbles) {
return;
}
const planned = Bubbles.plan(speech.current || speech.loading, speech.pending);
const head = speech.current || speech.loading;
startQuiet(Bubbles.plan(head, speech.pending));
const planned = Bubbles.plan(head, speech.pending, bubbles.quiet);
const kept = new Set(planned.map((entry) => entry.item));
for (const [item, view] of bubbles.shown) {
if (!kept.has(item)) {
@@ -136,6 +169,8 @@
window.cancelAnimationFrame(bubbles.frame);
bubbles.frame = 0;
bubbles.shown.clear();
bubbles.quiet.forEach((item) => window.clearTimeout(item.timer));
Object.assign(bubbles, {quiet: [], waiting: []});
for (const node of bubbleLayer().querySelectorAll(".speech-bubble")) {
node.remove();
}