feat(hub): scoped right-click context menu from the palette commands
Every palette item carries a scope (general, a tab, or an element kind); right-click and the Menu key or Shift+F10 open one menu with the element's items, then the tab's, then the general ones. Shift+right-click and text fields keep the browser menu; the diff feedback becomes one provider; any other key closes the menu instead of reaching the global shortcuts. 🎯 Fix: 85 % 💥 Break: 6 % 💸 Tokens: 100 % ⏱️ Velocity: 100 % 🛡️ Security: 100 % 🏆 Score: 80 🚦 Gate: ⛔ fix 85 % < 90, break 6 % > 5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
d8b1c95402
commit
ded7c9a7b6
12 files changed
+685
-39
No files matched your search
@@ -0,0 +1,201 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import json
|
||||
import os
|
||||
import shutil
|
||||
import sys
|
||||
import unittest
|
||||
from pathlib import Path
|
||||
|
||||
HERE = Path(__file__).resolve().parent
|
||||
sys.path[:0] = [str(HERE.parent), str(HERE)]
|
||||
|
||||
import hub_e2e_kit as base
|
||||
|
||||
OUT = Path(os.environ.get("E2E_OUT", "/tmp/hub-context-menu-shots"))
|
||||
GAP = 8
|
||||
TASK = ["element", "Task work/feature", ["Open task", "Copy task id", "Pin to Home"]]
|
||||
TASKS_TAB = ["tasks", "Tasks", ["Tasks: List", "Tasks: Board", "Tasks: RASCI", "Tasks: Gantt", "Tasks: Burndown and burnup", "Tasks: 3D"]]
|
||||
GENERAL_HEAD = [f"View: {tab}" for tab in base.TABS] + ["Radio …", "Cancel mayday", "Drain", "Suspend", "Resume", "Settings …"]
|
||||
GENERAL_TAIL = ["Look at the sky", "Toggle control room", "Enable notifications", "Keyboard shortcuts"]
|
||||
MOVES = ["Copy task id", "Pin to Home", "Copy task id", "Keyboard shortcuts", "Open task", "Keyboard shortcuts"]
|
||||
MENU = base.UNLABELLED + """
|
||||
const shownMenu = () => document.querySelector(".ctx-menu:not([hidden])");
|
||||
const itemLabel = (node) => (node && node.closest('[role="menuitem"]') ? text(node.closest('[role="menuitem"]').querySelector(".ctx-label")) : null);
|
||||
const key = (word, extra) => (document.activeElement || document.body).dispatchEvent(new KeyboardEvent("keydown", {key: word, bubbles: true, cancelable: true, ...extra}));
|
||||
const menuState = () => {
|
||||
const menu = shownMenu();
|
||||
if (!menu) {
|
||||
return {open: false};
|
||||
}
|
||||
const box = menu.getBoundingClientRect();
|
||||
return {
|
||||
open: true, role: menu.getAttribute("role"), roles: [...new Set(all("button", menu).map((node) => node.getAttribute("role")))],
|
||||
groups: all('[role="group"]', menu).map((group) => [group.dataset.scope, group.getAttribute("aria-label"), all('[role="menuitem"]', group).map(itemLabel)]),
|
||||
box: [box.left, box.top, box.right, box.bottom].map(Math.round), focused: itemLabel(document.activeElement),
|
||||
wide: document.documentElement.scrollWidth > innerWidth + 1, unlabelled: unlabelled(menu),
|
||||
};
|
||||
};
|
||||
const rowOf = () => document.querySelector('#main li.task-row[data-task="work/feature"]');
|
||||
const cardOf = () => document.querySelector('#main .kanban-card[data-task="work/feature"]');
|
||||
"""
|
||||
MOUSE = """(async () => {@HELPERS@@MENU@
|
||||
await screenShown(8000);
|
||||
const row = await until(rowOf, 10000);
|
||||
if (!row) {
|
||||
return {error: text(document.getElementById("main"))};
|
||||
}
|
||||
row.scrollIntoView({block: "center"});
|
||||
await sleep(300);
|
||||
const spot = row.querySelector("code.task-id");
|
||||
const box = spot.getBoundingClientRect();
|
||||
const at = {clientX: Math.round(box.left + box.width / 2), clientY: Math.round(box.top + box.height / 2)};
|
||||
const prevented = !spot.dispatchEvent(new MouseEvent("contextmenu", {bubbles: true, cancelable: true, button: 2, ...at}));
|
||||
await sleep(200);
|
||||
return {prevented, at: [at.clientX, at.clientY], ...menuState()};
|
||||
})()"""
|
||||
STEER = """(async () => {@HELPERS@@MENU@
|
||||
const moves = [];
|
||||
for (const word of ["ArrowDown", "ArrowDown", "ArrowUp", "End", "Home", "ArrowUp"]) {
|
||||
key(word);
|
||||
moves.push(itemLabel(document.activeElement));
|
||||
}
|
||||
key("Escape");
|
||||
await sleep(100);
|
||||
const closed = !shownMenu();
|
||||
const spot = rowOf().querySelector("code.task-id");
|
||||
const box = spot.getBoundingClientRect();
|
||||
const passed = spot.dispatchEvent(new MouseEvent("contextmenu", {bubbles: true, cancelable: true, button: 2, shiftKey: true, clientX: box.left + 2, clientY: box.top + 2}));
|
||||
await sleep(100);
|
||||
const shift = {passed, open: Boolean(shownMenu())};
|
||||
key("k", {ctrlKey: true});
|
||||
await sleep(200);
|
||||
const palette = all("#palette:not([hidden]) .palette-list li").map((li) => text(li.querySelector("span")));
|
||||
key("Escape");
|
||||
await sleep(100);
|
||||
return {moves, closed, shift, palette, paletteClosed: document.getElementById("palette").hidden};
|
||||
})()"""
|
||||
KEYED = """(async () => {@HELPERS@@MENU@
|
||||
await screenShown(8000);
|
||||
const card = await until(cardOf, 10000);
|
||||
if (!card) {
|
||||
return {error: text(document.getElementById("main"))};
|
||||
}
|
||||
card.scrollIntoView({block: "center"});
|
||||
await sleep(300);
|
||||
card.focus();
|
||||
const anchor = card.getBoundingClientRect();
|
||||
const prevented = !key("ContextMenu");
|
||||
await sleep(200);
|
||||
return {prevented, at: [Math.round(anchor.left), Math.round(anchor.bottom)], ...menuState()};
|
||||
})()"""
|
||||
RUN = """(async () => {@HELPERS@@MENU@
|
||||
const first = itemLabel(document.activeElement);
|
||||
key("Enter");
|
||||
const sheet = await until(() => all('#sheet:not([hidden]) [role="dialog"]').find((node) => node.getAttribute("aria-label") === "work/feature"), 4000);
|
||||
await sleep(200);
|
||||
return {first, closed: !shownMenu(), sheet: Boolean(sheet)};
|
||||
})()"""
|
||||
SHIFT_F10 = """(async () => {@HELPERS@@MENU@
|
||||
document.querySelector('#sheet:not([hidden]) .sheet-head button[aria-label="Close"]').click();
|
||||
await sleep(150);
|
||||
const card = cardOf();
|
||||
card.focus();
|
||||
const prevented = !key("F10", {shiftKey: true});
|
||||
await sleep(150);
|
||||
const opened = menuState();
|
||||
key("?");
|
||||
await sleep(100);
|
||||
const help = Boolean(document.querySelector("#sheet:not([hidden])"));
|
||||
return {prevented, element: opened.groups ? opened.groups[0] : null, closed: !shownMenu(), back: document.activeElement === cardOf(), help};
|
||||
})()"""
|
||||
|
||||
|
||||
def probe(template: str) -> str:
|
||||
return template.replace("@HELPERS@", base.HELPERS).replace("@MENU@", MENU)
|
||||
|
||||
|
||||
@unittest.skipUnless(shutil.which(os.environ.get("CHROMIUM", "chromium")), "no Chromium")
|
||||
class TestHubContextMenu(base.OrchestratorE2ECase):
|
||||
def setUp(self):
|
||||
super().setUp()
|
||||
OUT.mkdir(parents=True, exist_ok=True)
|
||||
|
||||
def steps(self, browser: str) -> list[dict]:
|
||||
local = f"http://localhost:{self.port}/"
|
||||
steps = []
|
||||
for width, height in base.WIDTHS:
|
||||
shot = str(OUT / f"{browser}-{width}-context")
|
||||
steps += [
|
||||
{"width": width, "height": height, "url": f"{local}?{width}-mouse#tasks/list", "wait": 1500, "probe": probe(MOUSE), "shot": f"{shot}-mouse.png"},
|
||||
{"width": width, "height": height, "url": None, "wait": 0, "probe": probe(STEER), "shot": None},
|
||||
{"width": width, "height": height, "url": f"{local}?{width}-keyed#tasks/board", "wait": 1500, "probe": probe(KEYED), "shot": f"{shot}-key.png"},
|
||||
{"width": width, "height": height, "url": None, "wait": 0, "probe": probe(RUN), "shot": f"{shot}-task-sheet.png"},
|
||||
{"width": width, "height": height, "url": None, "wait": 0, "probe": probe(SHIFT_F10), "shot": None},
|
||||
]
|
||||
return steps
|
||||
|
||||
def placed(self, menu: dict, at: list[int], size: tuple[int, int]) -> None:
|
||||
"""Args:
|
||||
menu: the menuState of an open menu.
|
||||
at: the viewport point the menu was opened at.
|
||||
size: the viewport width and height.
|
||||
"""
|
||||
left, top, right, bottom = menu["box"]
|
||||
width, height = size
|
||||
self.assertTrue(0 <= left and right <= width and 0 <= top and bottom <= height, menu["box"])
|
||||
if at[0] + right - left <= width - GAP:
|
||||
self.assertLessEqual(abs(left - at[0]), 1, (menu["box"], at))
|
||||
else:
|
||||
self.assertGreaterEqual(right, width - GAP - 1, (menu["box"], at))
|
||||
if at[1] + bottom - top <= height - GAP:
|
||||
self.assertLessEqual(abs(top - at[1]), 1, (menu["box"], at))
|
||||
else:
|
||||
self.assertTrue(bottom <= at[1] + 1 or top <= GAP + 1, (menu["box"], at))
|
||||
|
||||
def grouped(self, menu: dict) -> None:
|
||||
self.assertEqual((menu["open"], menu["role"], menu["roles"], menu["unlabelled"], menu["wide"]), (True, "menu", ["menuitem"], [], False), menu)
|
||||
self.assertEqual(menu["groups"][:2], [TASK, TASKS_TAB])
|
||||
scope, title, general = menu["groups"][2]
|
||||
self.assertEqual((scope, title, len(menu["groups"])), ("general", "General", 3))
|
||||
self.assertEqual(general[: len(GENERAL_HEAD)], GENERAL_HEAD)
|
||||
self.assertEqual(general[-len(GENERAL_TAIL) :], GENERAL_TAIL)
|
||||
self.assertIn(general[len(GENERAL_HEAD)], ("Music on", "Music off"))
|
||||
self.assertEqual(menu["focused"], "Open task")
|
||||
|
||||
def check(self, data: dict) -> None:
|
||||
per = 5
|
||||
for index, (width, height) in enumerate(base.WIDTHS):
|
||||
mouse, steer, keyed, ran, shifted = data["results"][per * index : per * (index + 1)]
|
||||
with self.subTest(width=width):
|
||||
for result in (mouse, steer, keyed, ran, shifted):
|
||||
self.assertNotIn("error", result, result)
|
||||
self.assertTrue(mouse["prevented"], mouse)
|
||||
self.grouped(mouse)
|
||||
self.placed(mouse, mouse["at"], (width, height))
|
||||
self.assertEqual((steer["moves"], steer["closed"]), (MOVES, True), steer)
|
||||
self.assertEqual(steer["shift"], {"passed": True, "open": False})
|
||||
self.assertLessEqual({"View: Home", "Tasks: List", "Stage", "Priority …", "Keyboard shortcuts"}, set(steer["palette"]), steer["palette"])
|
||||
self.assertTrue(steer["paletteClosed"])
|
||||
self.assertTrue(keyed["prevented"], keyed)
|
||||
self.grouped(keyed)
|
||||
self.placed(keyed, keyed["at"], (width, height))
|
||||
self.assertEqual(ran, {"first": "Open task", "closed": True, "sheet": True})
|
||||
self.assertEqual(shifted, {"prevented": True, "element": TASK, "closed": True, "back": True, "help": False})
|
||||
|
||||
def run_browser(self, browser: str, driver: str, binary: str) -> None:
|
||||
data = self.drive(self.steps(browser), None, driver, binary)
|
||||
(OUT / f"{browser}-context-menu.json").write_text(json.dumps(data, indent=1), encoding="utf-8")
|
||||
self.assertEqual([error for error in data["errors"] if "/favicon.ico" not in error], [])
|
||||
self.check(data)
|
||||
|
||||
def test_chromium_right_click_and_menu_key_open_the_grouped_context_menu_and_run_an_item_at_three_widths(self):
|
||||
self.run_browser("chromium", "cdp.mjs", os.environ.get("CHROMIUM", "chromium"))
|
||||
|
||||
@unittest.skipUnless(shutil.which(os.environ.get("FIREFOX", "firefox")), "no Firefox")
|
||||
def test_firefox_right_click_and_menu_key_open_the_grouped_context_menu_and_run_an_item_at_three_widths(self):
|
||||
self.run_browser("firefox", "bidi.mjs", os.environ.get("FIREFOX", "firefox"))
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
@@ -105,9 +105,12 @@ FEEDBACK = """(async () => {@HELPERS@@UNLABELLED@
|
||||
const nearby = Boolean(floating && !floating.hidden);
|
||||
rows[1].querySelector("td.code").dispatchEvent(new MouseEvent("contextmenu", {bubbles: true, cancelable: true, clientX: box.left + 4, clientY: box.top + 4}));
|
||||
await sleep(200);
|
||||
const menu = floating && floating.getAttribute("role");
|
||||
const labels = {float: floating ? unlabelled(floating) : null};
|
||||
floating.querySelector("button").click();
|
||||
const context = document.querySelector(".ctx-menu:not([hidden])");
|
||||
const menu = context && context.getAttribute("role");
|
||||
const labels = {float: floating ? unlabelled(floating) : null, menu: context ? unlabelled(context) : null};
|
||||
const first = context && context.querySelector('[role="menuitem"]');
|
||||
const item = first ? text(first.querySelector(".ctx-label")) : null;
|
||||
first.click();
|
||||
const sheet = await until(() => document.querySelector(".sheet-box textarea"), 4000);
|
||||
const writing = document.querySelector("#sheet .sheet-box");
|
||||
labels.sheet = writing ? unlabelled(writing) : null;
|
||||
@@ -132,7 +135,7 @@ FEEDBACK = """(async () => {@HELPERS@@UNLABELLED@
|
||||
keyed.value = "key f note";
|
||||
all(".sheet-box button").find((button) => name(button) === "Send feedback").click();
|
||||
await sleep(1500);
|
||||
return {nearby, menu, title, range, keyRange, labels, shown: shown || "", posted: window.e2eFeedback, wide: document.documentElement.scrollWidth > window.innerWidth + 1};
|
||||
return {nearby, menu, item, title, range, keyRange, labels, shown: shown || "", posted: window.e2eFeedback, wide: document.documentElement.scrollWidth > window.innerWidth + 1};
|
||||
})()"""
|
||||
|
||||
|
||||
@@ -183,7 +186,7 @@ class TestWorkbenchOperatorTasks(HubCase):
|
||||
self.assertNotIn("error", tasks, tasks)
|
||||
self.assertNotIn("error", feedback, feedback)
|
||||
self.assertEqual(tasks["unlabelled"], {"main": [], "sheet": []})
|
||||
self.assertEqual(feedback["labels"], {"float": [], "sheet": []})
|
||||
self.assertEqual(feedback["labels"], {"float": [], "menu": [], "sheet": []})
|
||||
with self.subTest(browser=browser, width=width):
|
||||
self.assertNotIn("error", tasks, tasks)
|
||||
self.assertEqual((tasks["hash"], tasks["tabs"], tasks["subs"], tasks["streamInbox"], tasks["current"]), ("#tasks/operator", base.TABS, ["Firewall"], False, ["Tasks"]))
|
||||
@@ -202,7 +205,7 @@ class TestWorkbenchOperatorTasks(HubCase):
|
||||
self.assertEqual(tasks["posted"], [["/api/sign", kinds], *([["/api/inbox/approve", kinds]] if signs else [])])
|
||||
self.assertFalse(tasks["wide"])
|
||||
self.assertNotIn("error", feedback, feedback)
|
||||
self.assertEqual((feedback["nearby"], feedback["menu"], feedback["title"]), (True, "menu", "Feedback"))
|
||||
self.assertEqual((feedback["nearby"], feedback["menu"], feedback["item"], feedback["title"]), (True, "menu", "Feedback", "Feedback"))
|
||||
self.assertEqual((feedback["range"], feedback["keyRange"]), ("src/app.py:2-2", "/repo:1-1"))
|
||||
ref = f"review:{self.reviews[(tag, 'second')]}"
|
||||
texts = [text for path, text in feedback["posted"] if path == "/api/messages/sign"]
|
||||
|
||||
@@ -0,0 +1,175 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import json
|
||||
import subprocess
|
||||
import unittest
|
||||
|
||||
from hub_support import HUB
|
||||
|
||||
TEMPLATES = HUB / "templates"
|
||||
SOURCES = ["page-constants.js", "page-diff.js", "page-palette.js", "page-context.js"]
|
||||
GENERAL = [
|
||||
"View: Home", "View: Stream", "View: Agents", "View: Artifacts", "View: Tasks", "View: Resources", "Radio …", "Cancel mayday", "Drain", "Suspend", "Resume",
|
||||
"Settings …", "Music on", "Look at the sky", "Toggle control room", "Enable notifications", "Keyboard shortcuts",
|
||||
]
|
||||
TASKS_TAB = ["Tasks: List", "Tasks: Board", "Tasks: RASCI", "Tasks: Gantt", "Tasks: Burndown and burnup", "Tasks: 3D"]
|
||||
AGENTS_TAB = ["Agents: Orbit", "Agents: Chord", "Agents: Swimlane", "Agents: Tree", "Agents: 3D", "Agents: Hierarchy", "Priority …"]
|
||||
TABS = ["home", "stream", "agents", "artifacts", "tasks", "resources"]
|
||||
PROBE = r"""
|
||||
const fs = require("fs");
|
||||
const vm = require("vm");
|
||||
const [dir, names] = [process.argv[1], JSON.parse(process.argv[2])];
|
||||
const Nav = require(`${dir}/nav.js`);
|
||||
const Panels = require(`${dir}/panels.js`);
|
||||
class Element {
|
||||
constructor(tag, attrs, parent) {
|
||||
Object.assign(this, {tagName: tag.toUpperCase(), attrs: {...attrs}, parentElement: parent || null, rect: null});
|
||||
}
|
||||
getAttribute(name) { return Object.hasOwn(this.attrs, name) ? this.attrs[name] : null; }
|
||||
hasAttribute(name) { return Object.hasOwn(this.attrs, name); }
|
||||
matches(selector) { return selector.split(",").map((part) => part.trim()).some((part) => (part.startsWith("[") ? this.hasAttribute(part.slice(1, -1)) : this.tagName === part.toUpperCase())); }
|
||||
closest(selector) { return this.matches(selector) ? this : this.parentElement && this.parentElement.closest(selector); }
|
||||
contains(node) { return Boolean(node) && (node === this || this.contains(node.parentElement)); }
|
||||
getBoundingClientRect() { return this.rect; }
|
||||
}
|
||||
Panels.item("task", (id) => `Task ${id}`, () => null);
|
||||
const KEYS_OF = {Stage: "s2", Docs: "s3"};
|
||||
const NAMES = {s2: "Stage", s3: "Docs"};
|
||||
const calls = {tasks: [], pins: [], feedback: [], shown: [], closed: 0};
|
||||
const context = {
|
||||
console, Nav, Panels, Element, JSON, Math, Object, Array, String, Number, Boolean, Promise, Map, Set, Intl,
|
||||
document: {activeElement: null, currentScript: null}, window: {innerWidth: 1366, innerHeight: 768, matchMedia: () => ({matches: false})}, navigator: {},
|
||||
state: {views: {"fuer-dich": {label: "For you"}}, tasks: [{task: "work/feature"}], inbox: [{kind: "review", id: "r1", title: "feat: x"}], graph: {nodes: []}},
|
||||
ui: {screen: "tasks"}, tree: {model: null}, settings: {music: {on: false}}, space: {look: false}, userViews: [{name: "Mine"}],
|
||||
palette: {plan: null, input: {value: ""}, index: 0, items: [], list: {replaceChildren: () => {}, children: []}},
|
||||
h: (tag, attrs, ...children) => ({tag, attrs, children}), face: () => null, revealed: (text) => text,
|
||||
agentNames: () => ["Docs", "Stage"], agentKey: (who) => KEYS_OF[who] || who, nameOf: (key) => NAMES[key] || key, labelOf: (key) => NAMES[key] || key, keyOf: (item) => `${item.kind}:${item.id}`,
|
||||
go: () => {}, useView: () => {}, useSaved: () => {}, openAgent: () => {}, openRadio: () => {}, confirmAct: () => {}, openAgentOrder: () => {}, settingsSheet: () => {},
|
||||
toggleMusic: () => {}, skyLook: () => {}, toggleLeitstand: () => {}, askNotify: () => {}, helpSheet: () => {}, micButton: () => null,
|
||||
taskSheet: (id) => calls.tasks.push(id), artSelect: () => {}, select: () => {}, openItem: () => {}, openSheet: () => {}, glossarySections: () => [], toast: () => {},
|
||||
homePins: () => [], homePress: (kind, id) => calls.pins.push(`${kind}:${id}`), HOME_OPENERS: {task: (id) => calls.tasks.push(`home ${id}`)},
|
||||
closeMenus: () => { calls.closed += 1; }, calls,
|
||||
};
|
||||
const probe = `
|
||||
ctxShow = (sections, at) => calls.shown.push({at, sections: labels(sections)});
|
||||
selectionFeedback = () => null;
|
||||
feedbackSheet = (picked) => calls.feedback.push(picked.path);
|
||||
const labels = (sections) => sections.map((section) => [section.scope, section.title, section.items.map((item) => item.label)]);
|
||||
const out = {};
|
||||
const panel = new Element("div", {"data-panel": "tasks/list"});
|
||||
const card = new Element("li", {"data-task": "work/feature", "data-item": "task:work/feature"}, panel);
|
||||
const inside = new Element("span", {}, card);
|
||||
const taskSections = ctxSections(inside);
|
||||
out.task = labels(taskSections);
|
||||
taskSections[0].items.forEach((item) => item.label !== "Copy task id" && item.run());
|
||||
out.ran = {tasks: calls.tasks, pins: calls.pins};
|
||||
ui.screen = "agents";
|
||||
out.agent = labels(ctxSections(new Element("g", {"data-face": "s2", "data-pick": "s2"})));
|
||||
out.operator = labels(ctxSections(new Element("span", {"data-face": "Operator"})))[0][0];
|
||||
ui.screen = "rules";
|
||||
out.rules = labels(ctxSections(new Element("main", {})));
|
||||
ui.screen = "tasks";
|
||||
const fire = (target, extra) => {
|
||||
let prevented = false;
|
||||
const before = calls.shown.length;
|
||||
ctxContextMenu({target, clientX: 12, clientY: 34, shiftKey: false, defaultPrevented: false, ...extra, preventDefault: () => { prevented = true; }});
|
||||
const last = calls.shown.length > before ? calls.shown[calls.shown.length - 1] : null;
|
||||
return {prevented, at: last && last.at, sections: last && last.sections};
|
||||
};
|
||||
out.mouse = {plain: fire(inside, {}), shift: fire(inside, {shiftKey: true}), handled: fire(inside, {defaultPrevented: true}), field: fire(new Element("textarea", {}, card), {})};
|
||||
out.closed = calls.closed;
|
||||
const key = (target, extra) => {
|
||||
document.activeElement = target;
|
||||
let prevented = false;
|
||||
const before = calls.shown.length;
|
||||
ctxKeydown({key: "ContextMenu", shiftKey: false, ctrlKey: false, altKey: false, metaKey: false, ...extra, preventDefault: () => { prevented = true; }});
|
||||
const last = calls.shown.length > before ? calls.shown[calls.shown.length - 1] : null;
|
||||
return {prevented, at: last && last.at, element: last && last.sections[0][1]};
|
||||
};
|
||||
const focused = new Element("article", {"data-task": "work/feature", tabindex: "0"});
|
||||
focused.rect = {left: 30, top: 40, right: 230, bottom: 90, width: 200, height: 50};
|
||||
out.keys = {menu: key(focused, {}), shiftF10: key(focused, {key: "F10", shiftKey: true}), f10: key(focused, {key: "F10"}), ctrl: key(focused, {ctrlKey: true}), field: key(new Element("input", {}), {})};
|
||||
ui.screen = "inbox";
|
||||
const entry = new Element("li", {"data-ref": "review:r1", "data-to": "Skills"});
|
||||
const file = new Element("section", {"data-path": "src/app.py"}, entry);
|
||||
const cell = new Element("td", {}, file);
|
||||
out.unselected = labels(ctxSections(cell))[0];
|
||||
selectionFeedback = () => ({ref: "review:r1", to: "Skills", path: "src/app.py", from: 2, until: 3, quote: "new"});
|
||||
out.selected = fire(cell, {});
|
||||
ctxSections(cell)[0].items[0].run();
|
||||
out.feedback = calls.feedback;
|
||||
out.palette = paletteItems().map((item) => [item.label, item.scope, item.id === undefined ? null : item.id]);
|
||||
drawPalette();
|
||||
out.paletteShown = palette.items.length;
|
||||
out.keysHelp = KEYS.map(([name]) => name);
|
||||
console.log(JSON.stringify(out));
|
||||
`;
|
||||
const source = names.map((name) => fs.readFileSync(`${dir}/${name}`, "utf8")).join("\n");
|
||||
vm.runInNewContext(`${source}\n${probe}`, context);
|
||||
"""
|
||||
|
||||
|
||||
class TestHubContextMenu(unittest.TestCase):
|
||||
@classmethod
|
||||
def setUpClass(cls):
|
||||
done = subprocess.run(["node", "-e", PROBE, str(TEMPLATES), json.dumps(SOURCES)], capture_output=True, text=True, timeout=60, check=False)
|
||||
if done.returncode != 0:
|
||||
raise AssertionError(done.stderr.strip()[:1200])
|
||||
cls.data = json.loads(done.stdout)
|
||||
|
||||
def test_the_element_items_come_first_then_the_tab_then_the_general_ones(self):
|
||||
self.assertEqual(self.data["task"], [
|
||||
["element", "Task work/feature", ["Open task", "Copy task id", "Pin to Home"]],
|
||||
["tasks", "Tasks", TASKS_TAB],
|
||||
["general", "General", GENERAL],
|
||||
])
|
||||
|
||||
def test_the_element_items_act_on_the_clicked_element(self):
|
||||
self.assertEqual(self.data["ran"], {"tasks": ["work/feature"], "pins": ["task:work/feature"]})
|
||||
|
||||
def test_an_agent_scoped_palette_item_shows_only_on_its_own_agent(self):
|
||||
self.assertEqual(self.data["agent"], [["element", "Stage", ["Stage", "Copy name"]], ["agents", "Agents", AGENTS_TAB], ["general", "General", GENERAL]])
|
||||
self.assertEqual(self.data["operator"], "agents")
|
||||
|
||||
def test_a_sub_screen_takes_the_items_of_its_tab(self):
|
||||
self.assertEqual(self.data["rules"], [["stream", "Stream", ["View: Stream › Firewall", "Stream: For you", "Stream: Mine", "Firewall …"]], ["general", "General", GENERAL]])
|
||||
|
||||
def test_every_palette_item_has_a_scope_and_the_palette_still_lists_them_all(self):
|
||||
palette = self.data["palette"]
|
||||
self.assertLessEqual({scope for _, scope, _ in palette}, {"general", "agent", *TABS})
|
||||
self.assertEqual([[label, key] for label, scope, key in palette if scope == "agent"], [["Docs", "s3"], ["Stage", "s2"]])
|
||||
self.assertEqual([key for _, scope, key in palette if scope != "agent"], [None] * (len(palette) - 2))
|
||||
self.assertEqual([label for label, scope, _ in palette if scope == "general"], GENERAL)
|
||||
self.assertEqual(self.data["paletteShown"], len(palette))
|
||||
|
||||
def test_a_right_click_opens_the_menu_at_the_pointer_and_shift_or_a_handled_event_or_a_text_field_keep_the_native_one(self):
|
||||
mouse = self.data["mouse"]
|
||||
self.assertEqual((mouse["plain"]["prevented"], mouse["plain"]["at"]), (True, {"x": 12, "y": 34}))
|
||||
self.assertEqual(mouse["plain"]["sections"], self.data["task"])
|
||||
for case in ("shift", "handled", "field"):
|
||||
with self.subTest(case=case):
|
||||
self.assertEqual(mouse[case], {"prevented": False, "at": None, "sections": None})
|
||||
self.assertEqual(self.data["closed"], 1)
|
||||
|
||||
def test_the_menu_key_and_shift_f10_open_the_menu_of_the_focused_element_at_its_rect(self):
|
||||
keys = self.data["keys"]
|
||||
opened = {"prevented": True, "at": {"x": 30, "y": 90}, "element": "Task work/feature"}
|
||||
self.assertEqual((keys["menu"], keys["shiftF10"]), (opened, opened))
|
||||
for case in ("f10", "ctrl", "field"):
|
||||
with self.subTest(case=case):
|
||||
self.assertEqual(keys[case], {"prevented": False, "at": None, "element": None})
|
||||
|
||||
def test_a_selection_in_a_diff_makes_feedback_the_first_item_of_the_menu(self):
|
||||
self.assertEqual(self.data["unselected"], ["element", "src/app.py", ["Copy path", "Open entry", "Copy id"]])
|
||||
selected = self.data["selected"]
|
||||
self.assertTrue(selected["prevented"])
|
||||
self.assertEqual(selected["sections"][0], ["element", "src/app.py", ["Feedback", "Copy path", "Open entry", "Copy id"]])
|
||||
self.assertEqual(self.data["feedback"], ["src/app.py"])
|
||||
|
||||
def test_the_shortcuts_sheet_names_the_context_menu_keys(self):
|
||||
keys = self.data["keysHelp"]
|
||||
self.assertEqual(keys[:4], ["Ctrl+K", "Right-click", "Shift+right-click", "Menu key · Shift+F10"])
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main()
|
||||
Reference in new issue
Block a user