perf(kvb-check-security): MEDUSA uses 95 % of the physical cores
security.py ran medusa with at most 4 workers since 6540e4e, a cap set without a measurement, so scans left most of the host idle. Operator rule 2026-11-17: always 95 % of the cores, at least one left free. Workers are now max(1, min(floor(0.95 x cores), cores - 1)) over the physical cores /proc/cpuinfo lists (the logical count where it lists none), 13 on this 14-core host, still at most one per scanned file. The argv test computes the expected count instead of pinning the old cap.
🎯 Fix: 92 %
💥 Break: 4 %
💸 Tokens: 100 %
⏱️ Velocity: 100 %
🛡️ Security: 100 %
🏆 Score: 88
🚦 Gate: ✅ 90/5, tokens and velocity <= 100, security 100 %
Created-with: https://s.veen.world/skills
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
b95af2a8e0
commit
ff9bbc19c2
2 files changed
+59
-4
No files matched your search
@@ -23,7 +23,7 @@ Scan:
|
|||||||
The regular files `git diff <ref>` names plus untracked ones, symlinks left
|
The regular files `git diff <ref>` names plus untracked ones, symlinks left
|
||||||
out, copied to a temporary tree and scanned once with
|
out, copied to a temporary tree and scanned once with
|
||||||
`medusa scan <tree> --format json -o <dir> --no-cache --workers <w>`, w the
|
`medusa scan <tree> --format json -o <dir> --no-cache --workers <w>`, w the
|
||||||
files scanned but at most WORKERS, HOME pointing into the temporary
|
files scanned but at most host_workers(), HOME pointing into the temporary
|
||||||
directory because medusa creates ~/.medusa on start and KNOB set to
|
directory because medusa creates ~/.medusa on start and KNOB set to
|
||||||
--timeout (a medusa that ignores KNOB keeps its own cap), read from
|
--timeout (a medusa that ignores KNOB keeps its own cap), read from
|
||||||
`<dir>/medusa-scan-*.json`: a `findings` list whose entries carry
|
`<dir>/medusa-scan-*.json`: a `findings` list whose entries carry
|
||||||
@@ -137,7 +137,8 @@ WEIGHTS = {"critical": 50, "high": 25, "medium": 10, "low": 2, "info": 0}
|
|||||||
SAFE = 100
|
SAFE = 100
|
||||||
SHOWN = 5
|
SHOWN = 5
|
||||||
REACH = 2
|
REACH = 2
|
||||||
WORKERS = 4
|
CORE_SHARE = 0.95
|
||||||
|
CPUINFO = Path("/proc/cpuinfo")
|
||||||
KNOB = "MEDUSA_SCANNER_TIMEOUT"
|
KNOB = "MEDUSA_SCANNER_TIMEOUT"
|
||||||
TIMEOUT = 900
|
TIMEOUT = 900
|
||||||
DEADLINE = 3600
|
DEADLINE = 3600
|
||||||
@@ -213,6 +214,37 @@ class Rules(NamedTuple):
|
|||||||
files: tuple
|
files: tuple
|
||||||
|
|
||||||
|
|
||||||
|
def physical_cores(cpuinfo: str) -> int:
|
||||||
|
"""Returns:
|
||||||
|
The distinct physical id and core id pairs cpuinfo lists, else the
|
||||||
|
logical CPU count.
|
||||||
|
"""
|
||||||
|
pairs, socket = set(), ""
|
||||||
|
for line in cpuinfo.splitlines():
|
||||||
|
key, _, value = line.partition(":")
|
||||||
|
if key.strip() == "physical id":
|
||||||
|
socket = value.strip()
|
||||||
|
elif key.strip() == "core id":
|
||||||
|
pairs.add((socket, value.strip()))
|
||||||
|
return len(pairs) or os.cpu_count() or 1
|
||||||
|
|
||||||
|
|
||||||
|
def scan_workers(cores: int) -> int:
|
||||||
|
"""Returns:
|
||||||
|
CORE_SHARE of the cores rounded down, at least one core left free and
|
||||||
|
at least one worker.
|
||||||
|
"""
|
||||||
|
return max(1, min(int(cores * CORE_SHARE), cores - 1))
|
||||||
|
|
||||||
|
|
||||||
|
def host_workers() -> int:
|
||||||
|
try:
|
||||||
|
cpuinfo = CPUINFO.read_text(encoding="utf-8", errors="replace")
|
||||||
|
except OSError:
|
||||||
|
cpuinfo = ""
|
||||||
|
return scan_workers(physical_cores(cpuinfo))
|
||||||
|
|
||||||
|
|
||||||
def fail(message: str) -> None:
|
def fail(message: str) -> None:
|
||||||
print(f"security: {message}", file=sys.stderr)
|
print(f"security: {message}", file=sys.stderr)
|
||||||
sys.exit(2)
|
sys.exit(2)
|
||||||
@@ -758,7 +790,7 @@ def scan(
|
|||||||
return scanned, hit, missed
|
return scanned, hit, missed
|
||||||
code, out, lasted = medusa_run(
|
code, out, lasted = medusa_run(
|
||||||
[medusa, "scan", str(tree), "--format", "json", "-o", str(reports), "--no-cache",
|
[medusa, "scan", str(tree), "--format", "json", "-o", str(reports), "--no-cache",
|
||||||
"--workers", str(min(scanned, WORKERS))],
|
"--workers", str(min(scanned, host_workers()))],
|
||||||
work, env, deadline,
|
work, env, deadline,
|
||||||
)
|
)
|
||||||
try:
|
try:
|
||||||
|
|||||||
+24
-1
@@ -111,6 +111,28 @@ def ended(pids: list[int]) -> None:
|
|||||||
pass
|
pass
|
||||||
|
|
||||||
|
|
||||||
|
def security_module():
|
||||||
|
spec = importlib.util.spec_from_file_location("kvb_check_security_workers", SECURITY)
|
||||||
|
security = importlib.util.module_from_spec(spec)
|
||||||
|
spec.loader.exec_module(security)
|
||||||
|
return security
|
||||||
|
|
||||||
|
|
||||||
|
class TestScanWorkers(unittest.TestCase):
|
||||||
|
def test_medusa_takes_95_percent_of_the_physical_cores_and_leaves_one_free(self):
|
||||||
|
security = security_module()
|
||||||
|
for cores, workers in ((1, 1), (2, 1), (4, 3), (14, 13), (20, 19), (40, 38), (100, 95)):
|
||||||
|
with self.subTest(cores=cores):
|
||||||
|
self.assertEqual(security.scan_workers(cores), workers)
|
||||||
|
|
||||||
|
def test_physical_cores_count_core_ids_per_socket_and_skip_hyperthreads(self):
|
||||||
|
security = security_module()
|
||||||
|
block = "processor\t: {n}\nphysical id\t: {socket}\ncore id\t\t: {core}\n\n"
|
||||||
|
cpuinfo = "".join(block.format(n=n, socket=n // 4, core=n % 2) for n in range(8))
|
||||||
|
self.assertEqual(security.physical_cores(cpuinfo), 4)
|
||||||
|
self.assertEqual(security.physical_cores(""), os.cpu_count())
|
||||||
|
|
||||||
|
|
||||||
class TestSecurity(unittest.TestCase):
|
class TestSecurity(unittest.TestCase):
|
||||||
def setUp(self):
|
def setUp(self):
|
||||||
tmp = tempfile.TemporaryDirectory()
|
tmp = tempfile.TemporaryDirectory()
|
||||||
@@ -199,7 +221,8 @@ class TestSecurity(unittest.TestCase):
|
|||||||
self.assertEqual(result.returncode, 3, result.stderr)
|
self.assertEqual(result.returncode, 3, result.stderr)
|
||||||
argv = json.loads((self.bin / "argv.json").read_text(encoding="utf-8"))
|
argv = json.loads((self.bin / "argv.json").read_text(encoding="utf-8"))
|
||||||
self.assertEqual(
|
self.assertEqual(
|
||||||
[argv[0], *argv[2:4], argv[4], *argv[6:]], ["scan", "--format", "json", "-o", "--no-cache", "--workers", "2"]
|
[argv[0], *argv[2:4], argv[4], *argv[6:]],
|
||||||
|
["scan", "--format", "json", "-o", "--no-cache", "--workers", str(min(2, security_module().host_workers()))],
|
||||||
)
|
)
|
||||||
result = self.scan("--json", env=self.env)
|
result = self.scan("--json", env=self.env)
|
||||||
self.assertNotIn(PLACEHOLDER, result.stdout + result.stderr)
|
self.assertNotIn(PLACEHOLDER, result.stdout + result.stderr)
|
||||||
|
|||||||
Reference in new issue
Block a user