Files
skills/tests/test_hub_nav.py
T
Kevin Veen-BirkenbachandClaude Opus 5.5 82edf43417 fix(orchestrator): a view transition skipped by the next switch stays quiet
apply() starts a view transition on every hash change; a quick second switch skips the running one, whose ready promise then rejected with an unhandled AbortError, which the presence e2e counted as a page error in Chromium and Firefox. The skip is expected, so its AbortError is caught; every other ready failure is rethrown and still surfaces.

🎯 Fix: 92 %
💥 Break: 2 %
💸 Cost: 100 %
⏱️ Time: 100 %
🛡️ Security: 100 %
🏆 Score: 90
🚦 Gate: ✅ 90/5, cost and time <= 100, security 100 %

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-12 07:53:29 +00:00

132 lines
7.0 KiB
Python

from __future__ import annotations
import json
import subprocess
import unittest
from hub_support import HUB, NAV
SCREENS = HUB / "templates" / "page-screens.js"
TRANSITION_PROBE = """
const fs = require("fs");
const vm = require("vm");
const code = fs.readFileSync(process.argv[1], "utf8");
const unhandled = [];
process.on("unhandledRejection", (error) => unhandled.push(error.name));
const settle = () => new Promise((resolve) => setImmediate(resolve));
function switched(name) {
const error = new Error(`transition ${name}`);
error.name = name;
const started = [];
vm.runInNewContext(`${code}\\napply();`, {
Nav: {TABS: [], route: () => ({screen: "agents", view: "chord"})}, ui: {views: {}}, drawn: {screen: true}, calm: {matches: false}, h: () => null,
window: {location: {hash: "#agents/chord"}, history: {replaceState: () => null}},
document: {getElementById: () => ({append: () => null}), startViewTransition: (update) => {
started.push(typeof update);
return {ready: Promise.reject(error), finished: Promise.resolve(), updateCallbackDone: Promise.resolve()};
}},
});
return started;
}
(async () => {
const started = [...switched("AbortError"), ...switched("InvalidStateError")];
for (let round = 0; round < 5; round += 1) {
await settle();
}
console.log(JSON.stringify({started, unhandled}));
})().catch((error) => console.log(JSON.stringify({crash: String(error)})));
"""
NAV_PROBE = """
const N = require(process.argv[1]);
const hashes = ["", "#stream", "#stream/inbox", "#stream/rules", "#stream/nope", "#agents/chord", "#agents/3d", "#agents", "#agents/nope",
"#artifacts/tree", "#artifacts/orbit", "#graph", "#graph/swimlane", "#graph/orbit", "#tree", "#bogus", "#agents%2Fswimlane",
"#agents/hierarchy", "#artifacts/hierarchy", "#graph/hierarchy", "#tree/hierarchy", "#stream/radio", "#radio",
"#tasks", "#tasks/board", "#tasks/rasci", "#tasks/orbit", "#agents/board", "#tasks/hierarchy", "#tasks/gantt", "#tasks/burn", "#agents/gantt", "#tasks/3d"];
console.log(JSON.stringify({
tabs: N.TABS.map(([id, label]) => [id, label, (N.SUBS[id] || []).map(([sub, name]) => [sub, name])]),
views: N.VIEWS.map(([id, label]) => [id, label]),
taskViews: N.TASK_VIEWS.map(([id, label]) => [id, label]),
agents: N.viewsOf("agents").map(([id, label]) => [id, label]),
artifacts: N.viewsOf("artifacts").map(([id, label]) => [id, label]),
tasks: N.viewsOf("tasks").map(([id, label]) => [id, label]),
icon: N.ICONS.hierarchy,
routes: hashes.map((hash) => N.route(hash)),
hashes: [["stream", null], ["inbox", null], ["rules", null], ["agents", "chord"], ["artifacts", "3d"], ["tasks", "board"]].map(([screen, view]) => N.hashOf(screen, view)),
tabOf: ["stream", "inbox", "rules", "agents", "artifacts", "tasks"].map((screen) => N.tabOf(screen)),
}));
"""
class TestNavModule(unittest.TestCase):
@classmethod
def setUpClass(cls):
done = subprocess.run(["node", "-e", NAV_PROBE, str(NAV)], capture_output=True, text=True, timeout=60, check=True)
cls.data = json.loads(done.stdout)
def test_the_navigation_has_four_entries_and_stream_has_inbox_and_rules(self):
stream = ["stream", "Stream", [["inbox", "Inbox"], ["rules", "Firewall"]]]
self.assertEqual(self.data["tabs"], [stream, ["agents", "Agents", []], ["artifacts", "Artifacts", []], ["tasks", "Tasks", []]])
def test_agents_and_artifacts_offer_five_views_in_order_and_tasks_six(self):
shared = [["orbit", "Orbit"], ["chord", "Chord"], ["swimlane", "Swimlane"], ["tree", "Tree"], ["3d", "3D"]]
self.assertEqual((self.data["views"], self.data["artifacts"]), (shared, shared))
task_views = [["list", "List"], ["board", "Board"], ["rasci", "RASCI"], ["gantt", "Gantt"], ["burn", "Burndown and burnup"], ["3d", "3D"]]
self.assertEqual((self.data["taskViews"], self.data["tasks"]), (task_views,) * 2)
def test_only_agents_add_the_hierarchy_after_3d(self):
self.assertEqual(self.data["agents"][-2:], [["3d", "3D"], ["hierarchy", "Hierarchy"]])
self.assertEqual(self.data["icon"], "bi-diagram-2")
def test_hashes_route_and_the_old_ones_redirect(self):
stream = {"screen": "stream", "view": None, "redirect": None}
self.assertEqual(self.data["routes"], [
stream,
stream,
{"screen": "inbox", "view": None, "redirect": None},
{"screen": "rules", "view": None, "redirect": None},
stream,
{"screen": "agents", "view": "chord", "redirect": None},
{"screen": "agents", "view": "3d", "redirect": None},
{"screen": "agents", "view": None, "redirect": None},
{"screen": "agents", "view": None, "redirect": None},
{"screen": "artifacts", "view": "tree", "redirect": None},
{"screen": "artifacts", "view": "orbit", "redirect": None},
{"screen": "agents", "view": "orbit", "redirect": "#agents/orbit"},
{"screen": "agents", "view": "swimlane", "redirect": "#agents/swimlane"},
{"screen": "agents", "view": "orbit", "redirect": "#agents/orbit"},
{"screen": "artifacts", "view": "tree", "redirect": "#artifacts/tree"},
stream,
{"screen": "agents", "view": "swimlane", "redirect": None},
{"screen": "agents", "view": "hierarchy", "redirect": None},
{"screen": "artifacts", "view": None, "redirect": None},
{"screen": "agents", "view": "hierarchy", "redirect": "#agents/hierarchy"},
{"screen": "artifacts", "view": "tree", "redirect": "#artifacts/tree"},
{"screen": "stream", "view": None, "redirect": "#stream", "spot": True},
stream,
{"screen": "tasks", "view": None, "redirect": None},
{"screen": "tasks", "view": "board", "redirect": None},
{"screen": "tasks", "view": "rasci", "redirect": None},
{"screen": "tasks", "view": None, "redirect": None},
{"screen": "agents", "view": None, "redirect": None},
{"screen": "tasks", "view": None, "redirect": None},
{"screen": "tasks", "view": "gantt", "redirect": None},
{"screen": "tasks", "view": "burn", "redirect": None},
{"screen": "agents", "view": None, "redirect": None},
{"screen": "tasks", "view": "3d", "redirect": None},
])
def test_every_screen_has_its_own_hash_and_tab(self):
self.assertEqual(self.data["hashes"], ["#stream", "#stream/inbox", "#stream/rules", "#agents/chord", "#artifacts/3d", "#tasks/board"])
self.assertEqual(self.data["tabOf"], ["stream", "stream", "stream", "agents", "artifacts", "tasks"])
class TestScreenTransition(unittest.TestCase):
def test_a_view_transition_skipped_by_the_next_switch_stays_quiet_and_other_failures_still_surface(self):
done = subprocess.run(["node", "-e", TRANSITION_PROBE, str(SCREENS)], capture_output=True, text=True, timeout=60, check=True)
self.assertEqual(json.loads(done.stdout), {"started": ["function", "function"], "unhandled": ["InvalidStateError"]})
if __name__ == "__main__":
unittest.main()