The kvb-hub is a local review hub in a container bound to 127.0.0.1: one page, JSON APIs and an MCP endpoint for the operator's inbox, asks, decisions, staged-commit reviews, the radio stream, the agent graph, the worktree tree, push-to-talk and read-aloud radio (Piper, whisper.cpp) and an optional LLM command line. The hub is only a relay. The host executors in hub/client (the runner user service, the PermissionRequest hook and the approval CLI the commit skills call) verify a WebAuthn passkey signature against keys pinned outside every sandbox, refuse replays and fail closed. scripts/hub.sh with make hub-install, hub-check, hub-pin, hub-runner and hub-hook installs and checks the hub; hub-hook writes ~/.claude/settings.json after a backup. make watch-check shows a stuck watch hook. The new kvb-git-diff skill and the commit skills route reviews through the hub; the test_hub_* suites replace test_hub.py. Security review (kvb-think-criticize, three skeptics) fixed four holes: signed rules auto-approved chained shell commands; the client and LLM openers followed redirects, the LLM one with its bearer key; the worktree scan ran git fsmonitor and filter commands from agent-writable repos; compose set no memory, pids or health limits. Documented until core requirement 093, on the operator's word: the hub page is trusted while signing and pinning, local processes can forge the unsigned operator actions, and the container reads the host /tmp. Committed on the operator's word despite the gate: the passkey path is not yet verified live. Accepted MEDUSA false positives (137 findings on 115 lines, rows in security-accepted.jsonl): EXA002 x17, MEDUSA-MM-SCAN-058 x12, B603 x8, MEDUSA-FTSC-SCAN-089 x7, MEDUSA-PRIV-SCAN-762 x6, AIC-EXFIL-005 x5, EXA006 x5, MEDUSA-FTSCAN-231 x5, WEB-SSRF x5, MEDUSA-INF-SCAN-2057 x3, RH005 x3, TC001 x3, LO002 x2, MEDUSA-AEXP-SCAN-096 x2, MEDUSA-CGS-SCAN-028 x2, MEDUSA-INF-SCAN-1350 x2, MEDUSA-INF-SCAN-2369 x2, MEDUSA-INF-SCAN-2440 x2, MEDUSA-INF-SCAN-2638 x2, MLSC-SERIAL-002 x2, PL002 x2, PQC005 x2, SAST-PATH-001 x2, TC004 x2, TC005 x2, TC006 x2, TC007 x2, AA-146, EXA007, FINE-050, GB-ENCODE-001, GB-ENCODE-003, MEDUSA-CGS-SCAN-029, MEDUSA-CGS-SCAN-103, MEDUSA-DP-SCAN-1034, MEDUSA-DP-SCAN-1916, MEDUSA-DP-SCAN-954, MEDUSA-EXF26-TOOL-004, MEDUSA-FT-TRIGGER-005, MEDUSA-INF-SCAN-2206, MEDUSA-INF-SCAN-2457, MEDUSA-INF-WEB-003, MEDUSA-INFRA-SCAN-030, MEDUSA-MP-SCAN-1135, MEDUSA-RLHF-POISON-002, MEDUSA-RT-SCAN-006, MM-ENCODE-001, MP-124, PQC001, PQC002, PQC006, RP001, TC009, TC010, WEB-FLASK-004. 🎯 Fix: 80 % 💥 Break: 4 % 💸 Cost: 129 % ⏱️ Time: – 🛡️ Security: 100 % 💰 Value: ? 🏆 Score: 60 🚦 Gate: ⛔ fix 80 % < 90; cost 129 % > 100: ask the operator before the commit ``` /home/kevinveenbirkenbach/Repositories/github.com/kevinveenbirkenbach/skills/.worktrees/feature/kvb-hub ``` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
121 lines
4.5 KiB
Python
Executable File
121 lines
4.5 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
"""Args:
|
|
--port: port of the kvb-hub on 127.0.0.1; the signature's origin is
|
|
http://localhost:<port>.
|
|
--timeout: seconds to wait for the operator's decision; keep it below the
|
|
hook's timeout in settings.json.
|
|
--approvers: the pinned passkeys, e.g. ~/.config/kvb-hub/approvers.json.
|
|
--replay: this hook's replay store, outside the hub's reach, e.g.
|
|
~/.local/state/kvb-hub-approvals/hook.json.
|
|
stdin: the Claude Code PermissionRequest hook input.
|
|
|
|
Returns:
|
|
stdout: the PermissionRequest decision JSON: allow only when a pinned
|
|
passkey signed exactly this tool, command, cwd, session and ask id;
|
|
deny when the operator denied in the kvb-hub. Nothing on timeout,
|
|
error, a missing or invalid signature or a hub that is down, so
|
|
Claude Code shows its own dialog. The exit code is 0.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
import json
|
|
import sys
|
|
import time
|
|
import urllib.request
|
|
from pathlib import Path
|
|
|
|
import hub_api
|
|
import signing
|
|
import verifier
|
|
|
|
POLL = 25.0
|
|
NAME_LIMIT = 200
|
|
COMMAND_LIMIT = 4000
|
|
PATH_LIMIT = 4096
|
|
DENIED = "The operator denied this in the kvb-hub."
|
|
|
|
|
|
def summary(tool_input: object) -> str:
|
|
if isinstance(tool_input, dict):
|
|
for key in ("command", "file_path", "url", "pattern", "path"):
|
|
if isinstance(tool_input.get(key), str):
|
|
return tool_input[key]
|
|
return json.dumps(tool_input, ensure_ascii=False)
|
|
|
|
|
|
def facts(hook: dict) -> dict:
|
|
return {
|
|
"tool": str(hook.get("tool_name") or "?"),
|
|
"command": summary(hook.get("tool_input")),
|
|
"cwd": str(hook.get("cwd") or ""),
|
|
"session": str(hook.get("session_id") or ""),
|
|
}
|
|
|
|
|
|
def create(base: str, hook: dict, ask: dict, timeout: float) -> str:
|
|
payload = {
|
|
"tool": ask["tool"][:NAME_LIMIT],
|
|
"command": ask["command"][:COMMAND_LIMIT],
|
|
"cwd": ask["cwd"][:PATH_LIMIT],
|
|
"session": ask["session"][:NAME_LIMIT],
|
|
"agent": str(hook.get("agent_type") or "")[:NAME_LIMIT],
|
|
"timeout": timeout,
|
|
}
|
|
headers = {"Content-Type": "application/json", **hub_api.GUARD}
|
|
request = urllib.request.Request(f"{base}/api/asks", data=json.dumps(payload).encode(), headers=headers, method="POST")
|
|
ask_id = hub_api.call(request, hub_api.SLACK)["id"]
|
|
if not isinstance(ask_id, str) or not signing.ID.fullmatch(ask_id):
|
|
raise ValueError("the hub answered no ask id")
|
|
return ask_id
|
|
|
|
|
|
def status(base: str, ask_id: str, wait: float) -> dict:
|
|
answer = hub_api.call(urllib.request.Request(f"{base}/api/asks/{ask_id}?wait={wait:.1f}"), wait + hub_api.SLACK)
|
|
if not isinstance(answer.get("status"), str):
|
|
raise TypeError("the hub answered no status")
|
|
return answer
|
|
|
|
|
|
def decision(answer: dict, item: dict, trust: verifier.Trust) -> dict | None:
|
|
if answer["status"] == "denied":
|
|
return {"behavior": "deny", "message": DENIED}
|
|
if answer["status"] != "allowed":
|
|
return None
|
|
try:
|
|
verifier.check(answer.get("proof"), item, "", trust, time.time())
|
|
except (signing.Refused, OSError) as error:
|
|
print(f"kvb-hub: not signed, Claude Code asks instead: {error}", file=sys.stderr)
|
|
return None
|
|
return {"behavior": "allow"}
|
|
|
|
|
|
def main() -> int:
|
|
parser = argparse.ArgumentParser(prog="permission_hook")
|
|
parser.add_argument("--port", type=int, required=True)
|
|
parser.add_argument("--timeout", type=float, required=True)
|
|
parser.add_argument("--approvers", type=Path, required=True)
|
|
parser.add_argument("--replay", type=Path, required=True)
|
|
args = parser.parse_args()
|
|
base = hub_api.base_url(args.port)
|
|
trust = verifier.Trust(approvers=args.approvers, replay=args.replay, origin=signing.origin_of(args.port))
|
|
deadline = time.monotonic() + args.timeout
|
|
try:
|
|
hook = json.load(sys.stdin)
|
|
ask = facts(hook)
|
|
ask_id = create(base, hook, ask, args.timeout)
|
|
answer = {"status": "pending"}
|
|
while answer["status"] == "pending" and (left := deadline - time.monotonic()) > 0:
|
|
answer = status(base, ask_id, min(left, POLL))
|
|
except (OSError, ValueError, KeyError, TypeError, AttributeError):
|
|
return 0
|
|
chosen = decision(answer, signing.ask_item(ask_id, ask["tool"], ask["command"], ask["cwd"], ask["session"]), trust)
|
|
if chosen is not None:
|
|
print(json.dumps({"hookSpecificOutput": {"hookEventName": "PermissionRequest", "decision": chosen}}))
|
|
return 0
|
|
|
|
|
|
if __name__ == "__main__":
|
|
raise SystemExit(main())
|