The kvb-hub is a local review hub in a container bound to 127.0.0.1: one page, JSON APIs and an MCP endpoint for the operator's inbox, asks, decisions, staged-commit reviews, the radio stream, the agent graph, the worktree tree, push-to-talk and read-aloud radio (Piper, whisper.cpp) and an optional LLM command line. The hub is only a relay. The host executors in hub/client (the runner user service, the PermissionRequest hook and the approval CLI the commit skills call) verify a WebAuthn passkey signature against keys pinned outside every sandbox, refuse replays and fail closed. scripts/hub.sh with make hub-install, hub-check, hub-pin, hub-runner and hub-hook installs and checks the hub; hub-hook writes ~/.claude/settings.json after a backup. make watch-check shows a stuck watch hook. The new kvb-git-diff skill and the commit skills route reviews through the hub; the test_hub_* suites replace test_hub.py. Security review (kvb-think-criticize, three skeptics) fixed four holes: signed rules auto-approved chained shell commands; the client and LLM openers followed redirects, the LLM one with its bearer key; the worktree scan ran git fsmonitor and filter commands from agent-writable repos; compose set no memory, pids or health limits. Documented until core requirement 093, on the operator's word: the hub page is trusted while signing and pinning, local processes can forge the unsigned operator actions, and the container reads the host /tmp. Committed on the operator's word despite the gate: the passkey path is not yet verified live. Accepted MEDUSA false positives (137 findings on 115 lines, rows in security-accepted.jsonl): EXA002 x17, MEDUSA-MM-SCAN-058 x12, B603 x8, MEDUSA-FTSC-SCAN-089 x7, MEDUSA-PRIV-SCAN-762 x6, AIC-EXFIL-005 x5, EXA006 x5, MEDUSA-FTSCAN-231 x5, WEB-SSRF x5, MEDUSA-INF-SCAN-2057 x3, RH005 x3, TC001 x3, LO002 x2, MEDUSA-AEXP-SCAN-096 x2, MEDUSA-CGS-SCAN-028 x2, MEDUSA-INF-SCAN-1350 x2, MEDUSA-INF-SCAN-2369 x2, MEDUSA-INF-SCAN-2440 x2, MEDUSA-INF-SCAN-2638 x2, MLSC-SERIAL-002 x2, PL002 x2, PQC005 x2, SAST-PATH-001 x2, TC004 x2, TC005 x2, TC006 x2, TC007 x2, AA-146, EXA007, FINE-050, GB-ENCODE-001, GB-ENCODE-003, MEDUSA-CGS-SCAN-029, MEDUSA-CGS-SCAN-103, MEDUSA-DP-SCAN-1034, MEDUSA-DP-SCAN-1916, MEDUSA-DP-SCAN-954, MEDUSA-EXF26-TOOL-004, MEDUSA-FT-TRIGGER-005, MEDUSA-INF-SCAN-2206, MEDUSA-INF-SCAN-2457, MEDUSA-INF-WEB-003, MEDUSA-INFRA-SCAN-030, MEDUSA-MP-SCAN-1135, MEDUSA-RLHF-POISON-002, MEDUSA-RT-SCAN-006, MM-ENCODE-001, MP-124, PQC001, PQC002, PQC006, RP001, TC009, TC010, WEB-FLASK-004. 🎯 Fix: 80 % 💥 Break: 4 % 💸 Cost: 129 % ⏱️ Time: – 🛡️ Security: 100 % 💰 Value: ? 🏆 Score: 60 🚦 Gate: ⛔ fix 80 % < 90; cost 129 % > 100: ask the operator before the commit ``` /home/kevinveenbirkenbach/Repositories/github.com/kevinveenbirkenbach/skills/.worktrees/feature/kvb-hub ``` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
129 lines
5.8 KiB
Python
129 lines
5.8 KiB
Python
from __future__ import annotations
|
|
|
|
import time
|
|
|
|
from .errors import Conflict, Missing, ToolError
|
|
from .fields import (
|
|
COMMAND_LIMIT,
|
|
PATH_LIMIT,
|
|
WAIT_CAP,
|
|
bounded,
|
|
decode,
|
|
expect,
|
|
field,
|
|
instant,
|
|
message_text,
|
|
seconds,
|
|
)
|
|
from .signed import ask_signed
|
|
|
|
ASK_LIFETIME = 3600
|
|
DESCRIPTION_LIMIT = 1000
|
|
OPTION_LIMIT = 12
|
|
ASK_TEXTS = {"command": COMMAND_LIMIT, "cwd": PATH_LIMIT, "session": 200, "agent": 200}
|
|
ANSWERS = {"allow": "allowed", "deny": "denied"}
|
|
|
|
|
|
def ask_state(ask: dict, now: float) -> dict:
|
|
status = "expired" if ask["status"] == "pending" and ask["expires"] <= now else ask["status"]
|
|
return {"id": ask["id"], "status": status, "decided": ask["decided"], "proof": ask.get("proof")}
|
|
|
|
|
|
def ask_row(ask: dict, names: dict[str, str]) -> dict:
|
|
keys = ("id", "tool", "command", "cwd", "session", "created_ts", "expires")
|
|
return {**{key: ask[key] for key in keys}, "agent": names.get(ask["session"], ""), "subagent": ask["agent"]}
|
|
|
|
|
|
def decision_state(decision: dict) -> dict:
|
|
return {key: decision[key] for key in ("id", "status", "choice", "decided")}
|
|
|
|
|
|
def decision_row(decision: dict) -> dict:
|
|
return {key: decision[key] for key in ("id", "question", "options", "agent", "created_ts")}
|
|
|
|
|
|
def option_of(option: object) -> dict:
|
|
if not isinstance(option, dict):
|
|
raise ToolError("every option must be an object with label and description")
|
|
expect(option, ("label", "description"))
|
|
label = field(option, "label").strip()
|
|
return {"label": label, "description": bounded(option, "description", DESCRIPTION_LIMIT).strip()}
|
|
|
|
|
|
class Asking:
|
|
def ask(self, body: bytes) -> dict:
|
|
payload = decode(body)
|
|
expect(payload, ("tool", *ASK_TEXTS, "timeout"))
|
|
values = {name: bounded(payload, name, limit) for name, limit in ASK_TEXTS.items()}
|
|
lifetime = seconds(payload["timeout"], ASK_LIFETIME)
|
|
created = time.time()
|
|
fields = {**values, "tool": field(payload, "tool").strip(), "status": "pending", "decided": None, "proof": None}
|
|
record = self.asks.add({**fields, "created_ts": created, "expires": created + lifetime})
|
|
self.automate("ask", record, {"item": ask_signed(record), "gate": ""})
|
|
return {"id": record["id"], "status": record["status"]}
|
|
|
|
def ask_wait(self, ask_id: str, query: dict[str, list[str]]) -> dict:
|
|
wait = instant(query, "wait")
|
|
record = self.asks.get(ask_id)
|
|
if record is None:
|
|
raise Missing(ask_id)
|
|
left = max(record["expires"] - time.time(), 0.0)
|
|
record = self.asks.wait(ask_id, min(wait or 0.0, WAIT_CAP, left))
|
|
return ask_state(record, time.time())
|
|
|
|
def settle(self, kind_name: str, item_id: str, verb: str, body: bytes) -> dict:
|
|
if kind_name == "asks" and verb in ANSWERS:
|
|
record = self.asks.get(item_id)
|
|
if record is None:
|
|
raise Missing(item_id)
|
|
if ask_state(record, time.time())["status"] == "expired":
|
|
raise Conflict(ask_state(record, time.time()))
|
|
proof = None
|
|
if verb == "allow":
|
|
payload = decode(body)
|
|
expect(payload, ("proof",))
|
|
proof = self.covered(payload["proof"], [ask_signed(record)], time.time())
|
|
decided, changed = self.asks.decide(item_id, {"status": ANSWERS[verb], "proof": proof})
|
|
if not changed:
|
|
raise Conflict(ask_state(decided, time.time()))
|
|
return ask_state(decided, time.time())
|
|
if kind_name != "decisions" or verb != "choose":
|
|
raise Missing(verb)
|
|
payload = decode(body)
|
|
expect(payload, ("label",))
|
|
label = field(payload, "label")
|
|
record = self.decisions.get(item_id)
|
|
if record is None:
|
|
raise Missing(item_id)
|
|
if label not in [option["label"] for option in record["options"]]:
|
|
raise ToolError(f"label must be one of the options of decision {item_id}")
|
|
decided, changed = self.decisions.decide(item_id, {"status": "decided", "choice": label})
|
|
if not changed:
|
|
raise Conflict(decision_state(decided))
|
|
return decision_state(decided)
|
|
|
|
def decision_request(self, arguments: dict) -> dict:
|
|
expect(arguments, ("question", "options", "agent", "recommended"))
|
|
question = message_text(arguments, "question")
|
|
options = arguments["options"]
|
|
if not isinstance(options, list) or not 1 <= len(options) <= OPTION_LIMIT:
|
|
raise ToolError(f"options must be a list of 1 to {OPTION_LIMIT} objects")
|
|
parsed = [option_of(option) for option in options]
|
|
if len({option["label"] for option in parsed}) != len(parsed):
|
|
raise ToolError("option labels must be distinct")
|
|
recommended = arguments["recommended"]
|
|
if not isinstance(recommended, str) or recommended.strip() not in ["", *(option["label"] for option in parsed)]:
|
|
raise ToolError("recommended must be one of the option labels or an empty string")
|
|
fields = {"question": question, "options": parsed, "agent": field(arguments, "agent").strip(), "recommended": recommended.strip()}
|
|
record = self.decisions.add({**fields, "status": "pending", "choice": None, "decided": None, "created_ts": time.time()})
|
|
self.automate("decision", record, {"recommended": record["recommended"], "agent": record["agent"]})
|
|
return {"id": record["id"], "status": record["status"], "url": self.url()}
|
|
|
|
def decision_wait(self, arguments: dict) -> dict:
|
|
expect(arguments, ("id", "timeout_seconds"))
|
|
decision_id = field(arguments, "id")
|
|
record = self.decisions.wait(decision_id, seconds(arguments["timeout_seconds"], WAIT_CAP))
|
|
if record is None:
|
|
raise ToolError(f"no decision {decision_id}")
|
|
return decision_state(record)
|