The kvb-hub is a local review hub in a container bound to 127.0.0.1: one page, JSON APIs and an MCP endpoint for the operator's inbox, asks, decisions, staged-commit reviews, the radio stream, the agent graph, the worktree tree, push-to-talk and read-aloud radio (Piper, whisper.cpp) and an optional LLM command line. The hub is only a relay. The host executors in hub/client (the runner user service, the PermissionRequest hook and the approval CLI the commit skills call) verify a WebAuthn passkey signature against keys pinned outside every sandbox, refuse replays and fail closed. scripts/hub.sh with make hub-install, hub-check, hub-pin, hub-runner and hub-hook installs and checks the hub; hub-hook writes ~/.claude/settings.json after a backup. make watch-check shows a stuck watch hook. The new kvb-git-diff skill and the commit skills route reviews through the hub; the test_hub_* suites replace test_hub.py. Security review (kvb-think-criticize, three skeptics) fixed four holes: signed rules auto-approved chained shell commands; the client and LLM openers followed redirects, the LLM one with its bearer key; the worktree scan ran git fsmonitor and filter commands from agent-writable repos; compose set no memory, pids or health limits. Documented until core requirement 093, on the operator's word: the hub page is trusted while signing and pinning, local processes can forge the unsigned operator actions, and the container reads the host /tmp. Committed on the operator's word despite the gate: the passkey path is not yet verified live. Accepted MEDUSA false positives (137 findings on 115 lines, rows in security-accepted.jsonl): EXA002 x17, MEDUSA-MM-SCAN-058 x12, B603 x8, MEDUSA-FTSC-SCAN-089 x7, MEDUSA-PRIV-SCAN-762 x6, AIC-EXFIL-005 x5, EXA006 x5, MEDUSA-FTSCAN-231 x5, WEB-SSRF x5, MEDUSA-INF-SCAN-2057 x3, RH005 x3, TC001 x3, LO002 x2, MEDUSA-AEXP-SCAN-096 x2, MEDUSA-CGS-SCAN-028 x2, MEDUSA-INF-SCAN-1350 x2, MEDUSA-INF-SCAN-2369 x2, MEDUSA-INF-SCAN-2440 x2, MEDUSA-INF-SCAN-2638 x2, MLSC-SERIAL-002 x2, PL002 x2, PQC005 x2, SAST-PATH-001 x2, TC004 x2, TC005 x2, TC006 x2, TC007 x2, AA-146, EXA007, FINE-050, GB-ENCODE-001, GB-ENCODE-003, MEDUSA-CGS-SCAN-029, MEDUSA-CGS-SCAN-103, MEDUSA-DP-SCAN-1034, MEDUSA-DP-SCAN-1916, MEDUSA-DP-SCAN-954, MEDUSA-EXF26-TOOL-004, MEDUSA-FT-TRIGGER-005, MEDUSA-INF-SCAN-2206, MEDUSA-INF-SCAN-2457, MEDUSA-INF-WEB-003, MEDUSA-INFRA-SCAN-030, MEDUSA-MP-SCAN-1135, MEDUSA-RLHF-POISON-002, MEDUSA-RT-SCAN-006, MM-ENCODE-001, MP-124, PQC001, PQC002, PQC006, RP001, TC009, TC010, WEB-FLASK-004. 🎯 Fix: 80 % 💥 Break: 4 % 💸 Cost: 129 % ⏱️ Time: – 🛡️ Security: 100 % 💰 Value: ? 🏆 Score: 60 🚦 Gate: ⛔ fix 80 % < 90; cost 129 % > 100: ask the operator before the commit ``` /home/kevinveenbirkenbach/Repositories/github.com/kevinveenbirkenbach/skills/.worktrees/feature/kvb-hub ``` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
107 lines
3.6 KiB
Python
107 lines
3.6 KiB
Python
from __future__ import annotations
|
|
|
|
import json
|
|
import math
|
|
import re
|
|
|
|
from .errors import ToolError
|
|
|
|
WAIT_CAP = 300
|
|
TEXT_LIMIT = 20_000
|
|
COMMAND_LIMIT = 4000
|
|
PATH_LIMIT = 4096
|
|
NAME_LIMIT = 120
|
|
COUNT = re.compile(r"[0-9]{1,12}")
|
|
PATH = re.compile(r"/[^\x00-\x1f\x7f]{0,4095}")
|
|
LINE = r"(?=[^\x00-\x1f\x7f]*\S)[^\x00-\x1f\x7f]{{1,{0}}}"
|
|
ORDER_NAME = re.compile(r"(?![\s-])[^,\x00-\x1f\x7f]{1,200}")
|
|
FIELDS = {
|
|
"repo": (PATH, "an absolute path"),
|
|
"worktree": (PATH, "an absolute path"),
|
|
"page": (PATH, "an absolute path"),
|
|
"branch": (re.compile(r"[\w./@+-]{1,255}"), "a branch name"),
|
|
"tree": (re.compile(r"[0-9a-f]{40}|[0-9a-f]{64}"), "the hash git write-tree prints"),
|
|
"title": (re.compile(LINE.format(200)), "one line of 1 to 200 characters"),
|
|
"agent": (re.compile(LINE.format(200)), "one line of 1 to 200 characters"),
|
|
"to": (re.compile(LINE.format(200)), "an agent name, one line of 1 to 200 characters"),
|
|
"label": (re.compile(LINE.format(NAME_LIMIT)), f"one line of 1 to {NAME_LIMIT} characters"),
|
|
"tool": (re.compile(LINE.format(200)), "one line of 1 to 200 characters"),
|
|
"id": (re.compile(r"[0-9a-f]{16}"), "an id the kvb-hub returned"),
|
|
}
|
|
|
|
|
|
def expect(arguments: dict, names: tuple[str, ...]) -> None:
|
|
problems = [f"missing argument {name}" for name in names if name not in arguments]
|
|
problems += [f"unknown argument {key}" for key in sorted(map(str, arguments)) if key not in names]
|
|
if problems:
|
|
raise ToolError("; ".join(problems))
|
|
|
|
|
|
def field(arguments: dict, name: str) -> str:
|
|
pattern, hint = FIELDS[name]
|
|
value = arguments[name]
|
|
if not isinstance(value, str) or not pattern.fullmatch(value):
|
|
raise ToolError(f"{name} must be {hint}")
|
|
return value
|
|
|
|
|
|
def bounded(arguments: dict, name: str, limit: int) -> str:
|
|
value = arguments[name]
|
|
if not isinstance(value, str) or len(value) > limit:
|
|
raise ToolError(f"{name} must be text of at most {limit} characters")
|
|
return value
|
|
|
|
|
|
def message_text(arguments: dict, name: str) -> str:
|
|
value = bounded(arguments, name, TEXT_LIMIT)
|
|
if not value.strip():
|
|
raise ToolError(f"{name} must not be empty")
|
|
return value.strip()
|
|
|
|
|
|
def seconds(value: object, cap: float) -> float:
|
|
if isinstance(value, bool) or not isinstance(value, int | float) or not 0 <= value < math.inf:
|
|
raise ToolError("timeout_seconds must be a finite number of seconds, 0 or more")
|
|
return float(min(value, cap))
|
|
|
|
|
|
def decode(body: bytes) -> dict:
|
|
try:
|
|
data = json.loads(body)
|
|
except (ValueError, RecursionError):
|
|
raise ToolError("body must be a JSON object") from None
|
|
if not isinstance(data, dict):
|
|
raise ToolError("body must be a JSON object")
|
|
return data
|
|
|
|
|
|
def single(query: dict[str, list[str]], name: str) -> str | None:
|
|
values = query.get(name)
|
|
if values is None:
|
|
return None
|
|
if len(values) != 1:
|
|
raise ToolError(f"{name} must be given once")
|
|
return values[0]
|
|
|
|
|
|
def instant(query: dict[str, list[str]], name: str) -> float | None:
|
|
text = single(query, name)
|
|
if text is None or text == "":
|
|
return None
|
|
try:
|
|
value = float(text)
|
|
except ValueError:
|
|
raise ToolError(f"{name} must be seconds since the epoch") from None
|
|
if not 0 <= value < 1e11:
|
|
raise ToolError(f"{name} must be seconds since the epoch")
|
|
return value
|
|
|
|
|
|
def whole(query: dict[str, list[str]], name: str) -> int | None:
|
|
text = single(query, name)
|
|
if text is None or text == "":
|
|
return None
|
|
if not COUNT.fullmatch(text):
|
|
raise ToolError(f"{name} must be a whole number")
|
|
return int(text)
|