staged_diff masks only the secret rule hits and seals each masked file's clear patch apart; reviews and asks store the sealed patches next to their diff, delete them once the item leaves pending, and the hub sweeps orphans. POST /api/diffs/<kind>/<id>/reveal/sign and /reveal hand the clear patches to a signed request; page-diff.js offers Reveal per hidden file and Reveal all, keeps the clear text in the page only and forgets it once the item leaves the inbox. Requirement 019, unit, hub and e2e tests. Accepted MEDUSA false positives (security.py accept after kvb-think-criticize, 2026-11-17): approval.py FTSCAN-231 WEB-SSRF RH005; permission_hook.py MM-SCAN-058 WEB-SSRF RH005; staged_diff.py SAST-ENV-001 AI-BACKDOOR-006 B603; hub.py MEX-SCAN-1167 INF-SCAN-589; page-load.js EXA002; hub_case.py TC001-TC009 INF-SCAN-2057/2206/2440/2457 EXA002 EXA006 PL002 B603 FTSC-SCAN-089. 🎯 Fix: 92 % 💥 Break: 4 % 💸 Tokens: – ⏱️ Velocity: – 🛡️ Security: 100 % 🏆 Score: 88 🚦 Gate: ✅ 90/5, tokens and velocity <= 100, security 100 % Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
207 lines
9.5 KiB
JavaScript
207 lines
9.5 KiB
JavaScript
const DIFF_TONES = {A: "ok", M: "info", D: "bad", R: "violet", B: "neutral"};
|
|
const HIDDEN_NOTES = new Set(["masked", "content withheld"]);
|
|
const diffView = {cache: new Map(), revealed: new Map(), version: 0, float: null, picked: null, timer: 0};
|
|
const revealedOf = (item) => diffView.revealed.get(keyOf(item)) || new Map();
|
|
const hiddenFile = (item, file) => HIDDEN_NOTES.has(file.note) && !revealedOf(item).has(file.path);
|
|
|
|
function forgetRevealed() {
|
|
const waiting = new Set(state.inbox.map(keyOf));
|
|
for (const key of [...diffView.revealed.keys()]) {
|
|
if (!waiting.has(key)) {
|
|
diffView.revealed.delete(key);
|
|
}
|
|
}
|
|
}
|
|
|
|
async function revealFiles(item, paths) {
|
|
const route = `/api/diffs/${item.kind}/${encodeURIComponent(item.id)}/reveal`;
|
|
const label = paths.length === 1 ? `Reveal: ${short(paths[0])}` : `Reveal ${paths.length} files`;
|
|
const signed = await signedProof(`${route}/sign`, {paths}, label, null);
|
|
if (!signed || !signed.proof) {
|
|
return;
|
|
}
|
|
const result = await sendJson(route, {paths, proof: signed.proof});
|
|
if (!result.ok || !result.data) {
|
|
toast(`${label}: not possible`, fail(result), false);
|
|
return;
|
|
}
|
|
diffView.revealed.set(keyOf(item), new Map([...revealedOf(item), ...Object.entries(result.data.patches)]));
|
|
diffView.version += 1;
|
|
drawInbox();
|
|
drawStream();
|
|
}
|
|
|
|
function revealButton(item, paths, words) {
|
|
const hint = `${words}: your passkey signs the reveal; the clear text stays in this page only and the reveal is logged`;
|
|
return h("button", {type: "button", class: "btn small ghost reveal", ...named(words, hint), on: {click: (event) => {
|
|
event.preventDefault();
|
|
event.stopPropagation();
|
|
revealFiles(item, paths);
|
|
}}}, icon("bi-eye"), words);
|
|
}
|
|
|
|
function diffOf(item) {
|
|
if (!item || typeof item.diff !== "number" || !["review", "ask"].includes(item.kind)) {
|
|
return null;
|
|
}
|
|
const key = keyOf(item);
|
|
if (!diffView.cache.has(key)) {
|
|
diffView.cache.set(key, "loading");
|
|
fetch(`/api/diffs/${item.kind}/${encodeURIComponent(item.id)}`, {cache: "no-store"})
|
|
.then((response) => (response.ok ? response.json() : {diff: null}))
|
|
.then((data) => diffView.cache.set(key, Array.isArray(data.diff) ? data.diff : null))
|
|
.catch(() => diffView.cache.set(key, null))
|
|
.then(() => {
|
|
diffView.version += 1;
|
|
drawInbox();
|
|
drawStream();
|
|
});
|
|
}
|
|
return diffView.cache.get(key);
|
|
}
|
|
|
|
function patchRow(row) {
|
|
const number = row.new || row.old || null;
|
|
if (row.kind === "hunk") {
|
|
return h("tr", {class: "hunk"}, h("td", {colspan: 3}), h("td", {class: "code"}, revealed(row.text)));
|
|
}
|
|
return h("tr", {class: row.kind, "data-line": number},
|
|
h("td", {class: "num"}, row.old), h("td", {class: "num"}, row.new), h("td", {class: "sign"}, SIGNS[row.kind] || " "), h("td", {class: "code"}, revealed(row.text)));
|
|
}
|
|
|
|
function diffBlock(item, raw) {
|
|
const clear = revealedOf(item).get(raw.path);
|
|
const hidden = hiddenFile(item, raw);
|
|
const file = clear === undefined ? raw : {...raw, patch: clear, note: ""};
|
|
const tone = DIFF_TONES[file.status] || "neutral";
|
|
const head = [h("span", {class: "letter", "data-tone": tone}, file.status), h("code", {class: "path"}, revealed(file.path)),
|
|
file.mode && file.mode !== "100644" ? h("code", {class: "mode", title: `mode: ${file.mode}`}, file.mode) : null, h("span", {class: "spacer"}),
|
|
file.note ? h("span", {class: "note", title: file.note}, icon("bi-eye-slash"), file.note) : null,
|
|
hidden ? revealButton(item, [file.path], "Reveal") : null,
|
|
clear === undefined ? null : h("span", {class: "note revealed", title: "revealed by your passkey, kept in this page only"}, icon("bi-eye"), "revealed"),
|
|
file.status === "B" ? icon("bi-file-earmark-binary") : h("span", {class: "stat"}, h("span", {class: "add"}, `+${file.additions}`), h("span", {class: "del"}, `-${file.deletions}`))];
|
|
const shown = clear === undefined ? (hidden ? raw.note : null) : "revealed";
|
|
if (file.status === "B" || !file.patch) {
|
|
return h("section", {class: "diff-file", "data-path": file.path, "data-status": file.status, "data-patch": "none", "data-hidden": shown}, h("div", {class: "diff-head"}, head));
|
|
}
|
|
const table = h("table", {class: "diff"}, h("tbody", {}, Diffs.rows(file.patch).map(patchRow)));
|
|
return h("section", {class: "diff-file", "data-path": file.path, "data-status": file.status, "data-hidden": shown},
|
|
h("details", {open: !Diffs.collapsed(file)}, h("summary", {class: "diff-head"}, head), h("div", {class: "diff-scroll"}, table)));
|
|
}
|
|
|
|
function diffBlocks(item) {
|
|
const found = diffOf(item);
|
|
if (found === null || found === undefined) {
|
|
return null;
|
|
}
|
|
if (found === "loading") {
|
|
return h("p", {class: "muted"}, "…");
|
|
}
|
|
const hidden = found.filter((file) => hiddenFile(item, file)).map((file) => file.path);
|
|
return h("div", {class: "diff-files", "aria-label": `Diff: ${found.length}`},
|
|
hidden.length > 1 ? h("div", {class: "reveal-all"}, revealButton(item, hidden, `Reveal all ${hidden.length}`)) : null,
|
|
found.map((file) => diffBlock(item, file)));
|
|
}
|
|
|
|
function feedbackList(ref) {
|
|
const sent = Diffs.feedbackOf(state.messages, ref);
|
|
return sent.length ? h("ul", {class: "feedback-list", "aria-label": `Feedback: ${sent.length}`}, sent.map((message) => h("li", {}, icon("bi-chat-left-text"), h("span", {class: "text"}, message.text), when(message.created_ts)))) : null;
|
|
}
|
|
|
|
function selectionFeedback() {
|
|
const selection = window.getSelection();
|
|
if (!selection || selection.isCollapsed || !selection.rangeCount || !selection.toString().trim()) {
|
|
return null;
|
|
}
|
|
const range = selection.getRangeAt(0);
|
|
const elementOf = (node) => (node instanceof Element ? node : node.parentElement);
|
|
const region = elementOf(range.startContainer) && elementOf(range.startContainer).closest("[data-path]");
|
|
const card = region && region.closest("[data-ref]");
|
|
if (!card || !card.dataset.to || !elementOf(range.endContainer) || elementOf(range.endContainer).closest("[data-path]") !== region) {
|
|
return null;
|
|
}
|
|
const quote = selection.toString();
|
|
const code = region.querySelector("code");
|
|
const lines = region.classList.contains("command") && code
|
|
? Diffs.lineSpan(code.textContent, quote)
|
|
: Diffs.span([...region.querySelectorAll("tr[data-line]")].filter((row) => range.intersectsNode(row)).map((row) => Number(row.dataset.line)));
|
|
if (!lines) {
|
|
return null;
|
|
}
|
|
return {ref: card.dataset.ref, to: card.dataset.to, path: region.dataset.path, from: lines[0], until: lines[1], quote, rect: range.getBoundingClientRect()};
|
|
}
|
|
|
|
function feedbackSheet(picked) {
|
|
hideFeedback();
|
|
const words = h("textarea", {class: "field", rows: 4, "aria-label": "Feedback", title: "Feedback"});
|
|
const send = iconBtn("bi-send", "Send feedback", "btn primary", async () => {
|
|
if (!words.value.trim()) {
|
|
words.focus();
|
|
return;
|
|
}
|
|
send.disabled = true;
|
|
const sent = await radioSend({to: picked.to, text: Diffs.feedback(picked.ref, picked.path, picked.from, picked.until, picked.quote, words.value), upload: "", cls: "post", voice: ""});
|
|
send.disabled = false;
|
|
if (sent) {
|
|
closeSheet();
|
|
}
|
|
}, `Send feedback: a post to ${picked.to}`);
|
|
openSheet("Feedback", [
|
|
h("div", {class: "who"}, icon("bi-chat-left-text"), person(picked.to), h("code", {}, `${picked.path}:${picked.from}-${picked.until}`)),
|
|
h("pre", {class: "notes"}, Diffs.quoted(picked.quote)),
|
|
words,
|
|
h("div", {class: "actions"}, h("span", {class: "spacer"}), send)], false);
|
|
words.focus();
|
|
}
|
|
|
|
function hideFeedback() {
|
|
if (diffView.float) {
|
|
diffView.float.hidden = true;
|
|
}
|
|
diffView.picked = null;
|
|
}
|
|
|
|
function showFeedback(picked, x, y) {
|
|
if (!diffView.float) {
|
|
diffView.float = h("div", {class: "feedback-float", role: "toolbar", hidden: true},
|
|
h("button", {type: "button", class: "btn small primary icon-only", ...named("Feedback", "Feedback (f): a post with the selected lines to the requesting agent"), on: {
|
|
mousedown: (event) => event.preventDefault(),
|
|
click: () => diffView.picked && feedbackSheet(diffView.picked),
|
|
}}, icon("bi-chat-left-text")));
|
|
document.body.append(diffView.float);
|
|
}
|
|
diffView.picked = picked;
|
|
diffView.float.style.left = `${Math.max(Math.min(x, window.innerWidth - 44), 4)}px`;
|
|
diffView.float.style.top = `${Math.max(Math.min(y, window.innerHeight - 44), 4)}px`;
|
|
diffView.float.hidden = false;
|
|
}
|
|
|
|
function feedbackButton() {
|
|
window.clearTimeout(diffView.timer);
|
|
diffView.timer = window.setTimeout(() => {
|
|
const picked = selectionFeedback();
|
|
if (picked) {
|
|
showFeedback(picked, picked.rect.right + 4, picked.rect.bottom + 4);
|
|
} else if (!diffView.float || !diffView.float.contains(document.activeElement)) {
|
|
hideFeedback();
|
|
}
|
|
}, 120);
|
|
}
|
|
|
|
/**
|
|
* @returns the context menu items of a [data-path] region, a diff file or a command: Feedback while lines of one are
|
|
* selected.
|
|
*/
|
|
function feedbackItems() {
|
|
const picked = selectionFeedback();
|
|
return picked ? [{label: "Feedback", hint: "f: a post with the selected lines to the requesting agent", run: () => feedbackSheet(picked)}] : [];
|
|
}
|
|
|
|
function feedbackKey() {
|
|
const picked = selectionFeedback();
|
|
if (picked) {
|
|
feedbackSheet(picked);
|
|
}
|
|
return Boolean(picked);
|
|
}
|