Kevin Veen-BirkenbachandClaude Opus 5.5
8ba45efd04
The kvb-hub is a local review hub in a container bound to 127.0.0.1: one page, JSON APIs and an MCP endpoint for the operator's inbox, asks, decisions, staged-commit reviews, the radio stream, the agent graph, the worktree tree, push-to-talk and read-aloud radio (Piper, whisper.cpp) and an optional LLM command line. The hub is only a relay. The host executors in hub/client (the runner user service, the PermissionRequest hook and the approval CLI the commit skills call) verify a WebAuthn passkey signature against keys pinned outside every sandbox, refuse replays and fail closed. scripts/hub.sh with make hub-install, hub-check, hub-pin, hub-runner and hub-hook installs and checks the hub; hub-hook writes ~/.claude/settings.json after a backup. make watch-check shows a stuck watch hook. The new kvb-git-diff skill and the commit skills route reviews through the hub; the test_hub_* suites replace test_hub.py. Security review (kvb-think-criticize, three skeptics) fixed four holes: signed rules auto-approved chained shell commands; the client and LLM openers followed redirects, the LLM one with its bearer key; the worktree scan ran git fsmonitor and filter commands from agent-writable repos; compose set no memory, pids or health limits. Documented until core requirement 093, on the operator's word: the hub page is trusted while signing and pinning, local processes can forge the unsigned operator actions, and the container reads the host /tmp. Committed on the operator's word despite the gate: the passkey path is not yet verified live. Accepted MEDUSA false positives (137 findings on 115 lines, rows in security-accepted.jsonl): EXA002 x17, MEDUSA-MM-SCAN-058 x12, B603 x8, MEDUSA-FTSC-SCAN-089 x7, MEDUSA-PRIV-SCAN-762 x6, AIC-EXFIL-005 x5, EXA006 x5, MEDUSA-FTSCAN-231 x5, WEB-SSRF x5, MEDUSA-INF-SCAN-2057 x3, RH005 x3, TC001 x3, LO002 x2, MEDUSA-AEXP-SCAN-096 x2, MEDUSA-CGS-SCAN-028 x2, MEDUSA-INF-SCAN-1350 x2, MEDUSA-INF-SCAN-2369 x2, MEDUSA-INF-SCAN-2440 x2, MEDUSA-INF-SCAN-2638 x2, MLSC-SERIAL-002 x2, PL002 x2, PQC005 x2, SAST-PATH-001 x2, TC004 x2, TC005 x2, TC006 x2, TC007 x2, AA-146, EXA007, FINE-050, GB-ENCODE-001, GB-ENCODE-003, MEDUSA-CGS-SCAN-029, MEDUSA-CGS-SCAN-103, MEDUSA-DP-SCAN-1034, MEDUSA-DP-SCAN-1916, MEDUSA-DP-SCAN-954, MEDUSA-EXF26-TOOL-004, MEDUSA-FT-TRIGGER-005, MEDUSA-INF-SCAN-2206, MEDUSA-INF-SCAN-2457, MEDUSA-INF-WEB-003, MEDUSA-INFRA-SCAN-030, MEDUSA-MP-SCAN-1135, MEDUSA-RLHF-POISON-002, MEDUSA-RT-SCAN-006, MM-ENCODE-001, MP-124, PQC001, PQC002, PQC006, RP001, TC009, TC010, WEB-FLASK-004. 🎯 Fix: 80 % 💥 Break: 4 % 💸 Cost: 129 % ⏱️ Time: – 🛡️ Security: 100 % 💰 Value: ? 🏆 Score: 60 🚦 Gate: ⛔ fix 80 % < 90; cost 129 % > 100: ask the operator before the commit ``` /home/kevinveenbirkenbach/Repositories/github.com/kevinveenbirkenbach/skills/.worktrees/feature/kvb-hub ``` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
64 lines
2.2 KiB
Python
64 lines
2.2 KiB
Python
from __future__ import annotations
|
|
|
|
import secrets
|
|
import threading
|
|
import time
|
|
from collections.abc import Callable
|
|
|
|
from .errors import Conflict, Missing
|
|
|
|
UNDO = 3.0
|
|
|
|
|
|
class Pending:
|
|
def __init__(self) -> None:
|
|
self.lock = threading.Lock()
|
|
self.batches: dict[str, dict] = {}
|
|
self.applied: set[str] = set()
|
|
|
|
def add(self, items: list[dict], source: str, proof: dict | None, apply: Callable[[dict], None]) -> dict:
|
|
"""Args:
|
|
items: the checked inbox items.
|
|
source: operator, or rule:<id> for an automatic approval.
|
|
proof: the signature relayed to the executors once the undo
|
|
window passed; None when no item needs one.
|
|
apply: settles the batch after the undo window.
|
|
|
|
Returns:
|
|
The batch without its proof and timer.
|
|
"""
|
|
batch_id = secrets.token_hex(8)
|
|
timer = threading.Timer(UNDO, self.fire, args=(batch_id, apply))
|
|
timer.daemon = True
|
|
batch = {"id": batch_id, "items": items, "source": source, "due": time.time() + UNDO}
|
|
with self.lock:
|
|
self.batches[batch_id] = {**batch, "proof": proof, "timer": timer}
|
|
timer.start()
|
|
return dict(batch)
|
|
|
|
def fire(self, batch_id: str, apply: Callable[[dict], None]) -> None:
|
|
with self.lock:
|
|
batch = self.batches.pop(batch_id, None)
|
|
if batch is not None:
|
|
self.applied.add(batch_id)
|
|
if batch is not None:
|
|
apply(batch)
|
|
|
|
def undo(self, batch_id: str) -> dict:
|
|
with self.lock:
|
|
batch = self.batches.pop(batch_id, None)
|
|
if batch is None and batch_id in self.applied:
|
|
raise Conflict({"id": batch_id, "status": "applied"})
|
|
if batch is None:
|
|
raise Missing(batch_id)
|
|
batch["timer"].cancel()
|
|
return batch
|
|
|
|
def holds(self, kind_name: str, item_id: str) -> bool:
|
|
with self.lock:
|
|
return any(item["kind"] == kind_name and item["id"] == item_id for batch in self.batches.values() for item in batch["items"])
|
|
|
|
def listed(self) -> list[dict]:
|
|
with self.lock:
|
|
return [{key: batch[key] for key in ("id", "items", "source", "due")} for batch in self.batches.values()]
|