The kvb-hub is a local review hub in a container bound to 127.0.0.1: one page, JSON APIs and an MCP endpoint for the operator's inbox, asks, decisions, staged-commit reviews, the radio stream, the agent graph, the worktree tree, push-to-talk and read-aloud radio (Piper, whisper.cpp) and an optional LLM command line. The hub is only a relay. The host executors in hub/client (the runner user service, the PermissionRequest hook and the approval CLI the commit skills call) verify a WebAuthn passkey signature against keys pinned outside every sandbox, refuse replays and fail closed. scripts/hub.sh with make hub-install, hub-check, hub-pin, hub-runner and hub-hook installs and checks the hub; hub-hook writes ~/.claude/settings.json after a backup. make watch-check shows a stuck watch hook. The new kvb-git-diff skill and the commit skills route reviews through the hub; the test_hub_* suites replace test_hub.py. Security review (kvb-think-criticize, three skeptics) fixed four holes: signed rules auto-approved chained shell commands; the client and LLM openers followed redirects, the LLM one with its bearer key; the worktree scan ran git fsmonitor and filter commands from agent-writable repos; compose set no memory, pids or health limits. Documented until core requirement 093, on the operator's word: the hub page is trusted while signing and pinning, local processes can forge the unsigned operator actions, and the container reads the host /tmp. Committed on the operator's word despite the gate: the passkey path is not yet verified live. Accepted MEDUSA false positives (137 findings on 115 lines, rows in security-accepted.jsonl): EXA002 x17, MEDUSA-MM-SCAN-058 x12, B603 x8, MEDUSA-FTSC-SCAN-089 x7, MEDUSA-PRIV-SCAN-762 x6, AIC-EXFIL-005 x5, EXA006 x5, MEDUSA-FTSCAN-231 x5, WEB-SSRF x5, MEDUSA-INF-SCAN-2057 x3, RH005 x3, TC001 x3, LO002 x2, MEDUSA-AEXP-SCAN-096 x2, MEDUSA-CGS-SCAN-028 x2, MEDUSA-INF-SCAN-1350 x2, MEDUSA-INF-SCAN-2369 x2, MEDUSA-INF-SCAN-2440 x2, MEDUSA-INF-SCAN-2638 x2, MLSC-SERIAL-002 x2, PL002 x2, PQC005 x2, SAST-PATH-001 x2, TC004 x2, TC005 x2, TC006 x2, TC007 x2, AA-146, EXA007, FINE-050, GB-ENCODE-001, GB-ENCODE-003, MEDUSA-CGS-SCAN-029, MEDUSA-CGS-SCAN-103, MEDUSA-DP-SCAN-1034, MEDUSA-DP-SCAN-1916, MEDUSA-DP-SCAN-954, MEDUSA-EXF26-TOOL-004, MEDUSA-FT-TRIGGER-005, MEDUSA-INF-SCAN-2206, MEDUSA-INF-SCAN-2457, MEDUSA-INF-WEB-003, MEDUSA-INFRA-SCAN-030, MEDUSA-MP-SCAN-1135, MEDUSA-RLHF-POISON-002, MEDUSA-RT-SCAN-006, MM-ENCODE-001, MP-124, PQC001, PQC002, PQC006, RP001, TC009, TC010, WEB-FLASK-004. 🎯 Fix: 80 % 💥 Break: 4 % 💸 Cost: 129 % ⏱️ Time: – 🛡️ Security: 100 % 💰 Value: ? 🏆 Score: 60 🚦 Gate: ⛔ fix 80 % < 90; cost 129 % > 100: ask the operator before the commit ``` /home/kevinveenbirkenbach/Repositories/github.com/kevinveenbirkenbach/skills/.worktrees/feature/kvb-hub ``` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
135 lines
5.4 KiB
Python
135 lines
5.4 KiB
Python
from __future__ import annotations
|
|
|
|
import json
|
|
import secrets
|
|
import threading
|
|
import time
|
|
from collections import deque
|
|
from pathlib import Path
|
|
|
|
from .council import agent
|
|
from .errors import ToolError
|
|
from .fields import single
|
|
from .records import read_jsonl, shown
|
|
from .register import status_of
|
|
from .transcripts import LOG_KEEP, STREAM_CUT, STREAM_KINDS
|
|
|
|
EVENT_KINDS = ("radio", "review", "ask", "decision", "operator", "register", "rename", "cron", "rule", "approval", "run", "transcript")
|
|
VIEWS = {
|
|
"fuer-dich": {"label": "Für dich", "kinds": list(EVENT_KINDS[:-1]), "waiting": True},
|
|
"reviews": {"label": "Reviews", "kinds": ["review"], "waiting": False},
|
|
"asks": {"label": "Asks", "kinds": ["ask"], "waiting": False},
|
|
"entscheidungen": {"label": "Entscheidungen", "kinds": ["decision"], "waiting": False},
|
|
"operator": {"label": "Operator", "kinds": ["operator", "run"], "waiting": False},
|
|
"register": {"label": "Register", "kinds": ["register", "rename"], "waiting": False},
|
|
"radio": {"label": "Radio", "kinds": ["radio"], "waiting": False},
|
|
"crons": {"label": "Crons", "kinds": ["cron"], "waiting": False},
|
|
}
|
|
|
|
|
|
def event(fields: dict) -> dict:
|
|
return {"part": "", "agent": "", "now": "", "session": "", "sub": "", "text": "", "waiting": False, "ref": {}, **fields}
|
|
|
|
|
|
def event_filters(query: dict[str, list[str]]) -> dict:
|
|
view = single(query, "view") or ""
|
|
if view:
|
|
if view not in VIEWS:
|
|
raise ToolError(f"view must be one of {', '.join(VIEWS)}")
|
|
kinds, waiting = set(VIEWS[view]["kinds"]), VIEWS[view]["waiting"]
|
|
else:
|
|
listed = single(query, "kinds")
|
|
kinds = set(EVENT_KINDS) if not listed else set(listed.split(","))
|
|
if not kinds <= set(EVENT_KINDS):
|
|
raise ToolError(f"kinds must be a comma list of {', '.join(EVENT_KINDS)}")
|
|
waiting = single(query, "waiting") == "1"
|
|
parts = single(query, "parts")
|
|
chosen = set(STREAM_KINDS) if not parts else set(parts.split(","))
|
|
if not chosen <= set(STREAM_KINDS):
|
|
raise ToolError(f"parts must be a comma list of {', '.join(STREAM_KINDS)}")
|
|
texts = {name: single(query, name) or "" for name in ("agent", "session", "sub")}
|
|
return {"kinds": kinds, "waiting": waiting, "parts": chosen, "q": (single(query, "q") or "").lower(), "aliases": set(), **texts}
|
|
|
|
|
|
def wanted(entry: dict, filters: dict) -> bool:
|
|
return all(
|
|
(
|
|
entry["kind"] in filters["kinds"],
|
|
not filters["waiting"] or entry["waiting"],
|
|
not filters["agent"] or entry["agent"] == filters["agent"] or entry["session"] in filters["aliases"],
|
|
not filters["session"] or entry["session"] == filters["session"],
|
|
not filters["sub"] or entry["sub"] == filters["sub"],
|
|
entry["kind"] != "transcript" or entry["part"] in filters["parts"],
|
|
not filters["q"] or filters["q"] in f"{entry['title']}\n{entry['text']}".lower(),
|
|
)
|
|
)
|
|
|
|
|
|
def described(value: object) -> str:
|
|
if value is None or isinstance(value, str | int | float | bool):
|
|
return shown(value)
|
|
return "…"
|
|
|
|
|
|
def register_changes(before: dict[str, dict], after: dict[str, dict], now: float) -> list[dict]:
|
|
found = []
|
|
for task in sorted(set(before) | set(after)):
|
|
old, new = before.get(task), after.get(task)
|
|
if old == new:
|
|
continue
|
|
if old is None or new is None:
|
|
row = new if old is None else old
|
|
change = f"neu: {shown(row.get('title'))}" if old is None else "entfernt"
|
|
else:
|
|
keys = sorted(key for key in set(old) | set(new) if old.get(key) != new.get(key))
|
|
change = "; ".join(f"{key}: {described(old.get(key))} → {described(new.get(key))}" for key in keys)
|
|
row = new if new is not None else old
|
|
found.append(event({
|
|
"id": f"register:{task}:{now}", "ts": now, "kind": "register", "agent": agent(row.get("worker")),
|
|
"title": task, "text": change[:STREAM_CUT], "ref": {"task": task, "status": status_of(row)},
|
|
}))
|
|
return found
|
|
|
|
|
|
class Watch:
|
|
def __init__(self) -> None:
|
|
self.lock = threading.Lock()
|
|
self.last: dict[str, dict] | None = None
|
|
self.seen: dict[str, float] = {}
|
|
self.changes: deque[dict] = deque(maxlen=LOG_KEEP)
|
|
|
|
def see(self, tasks: dict[str, dict], now: float) -> None:
|
|
with self.lock:
|
|
for task in tasks:
|
|
self.seen.setdefault(task, now)
|
|
if self.last is not None and self.last != tasks:
|
|
self.changes.extend(register_changes(self.last, tasks, now))
|
|
self.last = json.loads(json.dumps(tasks))
|
|
|
|
def first(self, task: str, now: float) -> float:
|
|
with self.lock:
|
|
return self.seen.get(task, now)
|
|
|
|
def listed(self) -> list[dict]:
|
|
with self.lock:
|
|
return list(self.changes)
|
|
|
|
|
|
class Log:
|
|
def __init__(self, file: Path) -> None:
|
|
self.file = file
|
|
self.lock = threading.Lock()
|
|
self.rows: deque[dict] = deque(read_jsonl(file)[-LOG_KEEP:], maxlen=LOG_KEEP)
|
|
|
|
def add(self, row: dict) -> dict:
|
|
entry = event({**row, "id": f"{row['kind']}:{secrets.token_hex(8)}", "ts": time.time()})
|
|
with self.lock:
|
|
self.rows.append(entry)
|
|
with self.file.open("a", encoding="utf-8") as handle:
|
|
handle.write(json.dumps(entry) + "\n")
|
|
return entry
|
|
|
|
def listed(self) -> list[dict]:
|
|
with self.lock:
|
|
return list(self.rows)
|