Kevin Veen-BirkenbachandClaude Opus 5.5
8ba45efd04
The kvb-hub is a local review hub in a container bound to 127.0.0.1: one page, JSON APIs and an MCP endpoint for the operator's inbox, asks, decisions, staged-commit reviews, the radio stream, the agent graph, the worktree tree, push-to-talk and read-aloud radio (Piper, whisper.cpp) and an optional LLM command line. The hub is only a relay. The host executors in hub/client (the runner user service, the PermissionRequest hook and the approval CLI the commit skills call) verify a WebAuthn passkey signature against keys pinned outside every sandbox, refuse replays and fail closed. scripts/hub.sh with make hub-install, hub-check, hub-pin, hub-runner and hub-hook installs and checks the hub; hub-hook writes ~/.claude/settings.json after a backup. make watch-check shows a stuck watch hook. The new kvb-git-diff skill and the commit skills route reviews through the hub; the test_hub_* suites replace test_hub.py. Security review (kvb-think-criticize, three skeptics) fixed four holes: signed rules auto-approved chained shell commands; the client and LLM openers followed redirects, the LLM one with its bearer key; the worktree scan ran git fsmonitor and filter commands from agent-writable repos; compose set no memory, pids or health limits. Documented until core requirement 093, on the operator's word: the hub page is trusted while signing and pinning, local processes can forge the unsigned operator actions, and the container reads the host /tmp. Committed on the operator's word despite the gate: the passkey path is not yet verified live. Accepted MEDUSA false positives (137 findings on 115 lines, rows in security-accepted.jsonl): EXA002 x17, MEDUSA-MM-SCAN-058 x12, B603 x8, MEDUSA-FTSC-SCAN-089 x7, MEDUSA-PRIV-SCAN-762 x6, AIC-EXFIL-005 x5, EXA006 x5, MEDUSA-FTSCAN-231 x5, WEB-SSRF x5, MEDUSA-INF-SCAN-2057 x3, RH005 x3, TC001 x3, LO002 x2, MEDUSA-AEXP-SCAN-096 x2, MEDUSA-CGS-SCAN-028 x2, MEDUSA-INF-SCAN-1350 x2, MEDUSA-INF-SCAN-2369 x2, MEDUSA-INF-SCAN-2440 x2, MEDUSA-INF-SCAN-2638 x2, MLSC-SERIAL-002 x2, PL002 x2, PQC005 x2, SAST-PATH-001 x2, TC004 x2, TC005 x2, TC006 x2, TC007 x2, AA-146, EXA007, FINE-050, GB-ENCODE-001, GB-ENCODE-003, MEDUSA-CGS-SCAN-029, MEDUSA-CGS-SCAN-103, MEDUSA-DP-SCAN-1034, MEDUSA-DP-SCAN-1916, MEDUSA-DP-SCAN-954, MEDUSA-EXF26-TOOL-004, MEDUSA-FT-TRIGGER-005, MEDUSA-INF-SCAN-2206, MEDUSA-INF-SCAN-2457, MEDUSA-INF-WEB-003, MEDUSA-INFRA-SCAN-030, MEDUSA-MP-SCAN-1135, MEDUSA-RLHF-POISON-002, MEDUSA-RT-SCAN-006, MM-ENCODE-001, MP-124, PQC001, PQC002, PQC006, RP001, TC009, TC010, WEB-FLASK-004. 🎯 Fix: 80 % 💥 Break: 4 % 💸 Cost: 129 % ⏱️ Time: – 🛡️ Security: 100 % 💰 Value: ? 🏆 Score: 60 🚦 Gate: ⛔ fix 80 % < 90; cost 129 % > 100: ask the operator before the commit ``` /home/kevinveenbirkenbach/Repositories/github.com/kevinveenbirkenbach/skills/.worktrees/feature/kvb-hub ``` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
66 lines
3.4 KiB
Python
66 lines
3.4 KiB
Python
from __future__ import annotations
|
|
|
|
import time
|
|
|
|
from .errors import Conflict, Missing, ToolError
|
|
from .fields import bounded, decode, expect
|
|
from .register import OPERATOR, REGISTER, operator_rows, read_register, runnable
|
|
from .signed import operator_signed
|
|
from .skill_scripts import OPERATOR_SCRIPT
|
|
|
|
JOB_OPEN = ("queued", "running")
|
|
RUN_OUTPUT = 64 << 10
|
|
|
|
|
|
def runner_job(job: dict) -> dict:
|
|
return {**{key: job[key] for key in ("id", "task", "command", "directory", "sha256")}, "proof": job.get("proof")}
|
|
|
|
|
|
class Jobs:
|
|
def open_jobs(self) -> set[str]:
|
|
return {job["task"] for job in self.jobs.listed() if job["status"] in JOB_OPEN}
|
|
|
|
def queue_job(self, item: dict, proof: dict | None) -> str:
|
|
row = next((row for row in operator_rows(read_register(self.council / REGISTER)) if row["task"] == item["id"]), None)
|
|
if row is None or not runnable(row) or operator_signed(row) != item["signed"]:
|
|
return "verweigert: die Zeile hat sich seit der Freigabe geändert"
|
|
if item["id"] in self.open_jobs():
|
|
return "läuft schon"
|
|
job = {"task": row["task"], "command": row["command"], "directory": row["directory"], "sha256": item["sha256"], "status": "queued", "proof": proof}
|
|
self.jobs.add({**job, "code": None, "output": "", "created_ts": time.time(), "started": None, "finished": None})
|
|
return "an den Runner übergeben"
|
|
|
|
def runner_jobs(self) -> dict:
|
|
return {"jobs": [runner_job(job) for job in self.jobs.listed() if job["status"] == "queued"]}
|
|
|
|
def claim(self, job_id: str) -> dict:
|
|
job, changed = self.jobs.transition(job_id, "queued", {"status": "running", "started": time.time()})
|
|
if job is None:
|
|
raise Missing(job_id)
|
|
if not changed:
|
|
raise Conflict({"id": job_id, "status": job["status"]})
|
|
return runner_job(job)
|
|
|
|
def report(self, job_id: str, body: bytes) -> dict:
|
|
payload = decode(body)
|
|
expect(payload, ("output", "code", "refused"))
|
|
output, code, refused = bounded(payload, "output", RUN_OUTPUT), payload["code"], payload["refused"]
|
|
if not isinstance(refused, bool) or (code is not None and (isinstance(code, bool) or not isinstance(code, int))):
|
|
raise ToolError("code must be a whole number or null and refused true or false")
|
|
record = self.jobs.get(job_id)
|
|
if record is None:
|
|
raise Missing(job_id)
|
|
if record["status"] != "running":
|
|
raise Conflict({"id": job_id, "status": record["status"]})
|
|
if code is None and not refused:
|
|
self.jobs.change(job_id, {"output": output})
|
|
return {"id": job_id, "status": "running", "code": None}
|
|
status = "refused" if refused else "done" if code == 0 else "failed"
|
|
job, changed = self.jobs.transition(job_id, "running", {"status": status, "code": code, "output": output, "finished": time.time()})
|
|
if not changed:
|
|
raise Conflict({"id": job_id, "status": job["status"]})
|
|
runs = [self.scripts.run(OPERATOR_SCRIPT, ["done", job["task"].removeprefix(OPERATOR)])] if status == "done" else []
|
|
tail = "\n".join(output.splitlines()[-20:])
|
|
self.log.add({"kind": "run", "title": f"{status}: {job['command'][:200]}", "text": tail, "ref": {"job": job_id, "task": job["task"], "code": code, "status": status}})
|
|
return {"id": job_id, "status": status, "code": code, "runs": runs}
|