Files
skills/hub/kvb_hub/review_page.py
T
Kevin Veen-BirkenbachandClaude Opus 5.5 8ba45efd04 feat(hub): kvb-hub review hub with passkey-signed approvals
The kvb-hub is a local review hub in a container bound to 127.0.0.1: one page, JSON APIs and an MCP endpoint for the operator's inbox, asks, decisions, staged-commit reviews, the radio stream, the agent graph, the worktree tree, push-to-talk and read-aloud radio (Piper, whisper.cpp) and an optional LLM command line. The hub is only a relay. The host executors in hub/client (the runner user service, the PermissionRequest hook and the approval CLI the commit skills call) verify a WebAuthn passkey signature against keys pinned outside every sandbox, refuse replays and fail closed. scripts/hub.sh with make hub-install, hub-check, hub-pin, hub-runner and hub-hook installs and checks the hub; hub-hook writes ~/.claude/settings.json after a backup. make watch-check shows a stuck watch hook. The new kvb-git-diff skill and the commit skills route reviews through the hub; the test_hub_* suites replace test_hub.py.

Security review (kvb-think-criticize, three skeptics) fixed four holes: signed rules auto-approved chained shell commands; the client and LLM openers followed redirects, the LLM one with its bearer key; the worktree scan ran git fsmonitor and filter commands from agent-writable repos; compose set no memory, pids or health limits. Documented until core requirement 093, on the operator's word: the hub page is trusted while signing and pinning, local processes can forge the unsigned operator actions, and the container reads the host /tmp. Committed on the operator's word despite the gate: the passkey path is not yet verified live.

Accepted MEDUSA false positives (137 findings on 115 lines, rows in security-accepted.jsonl): EXA002 x17, MEDUSA-MM-SCAN-058 x12, B603 x8, MEDUSA-FTSC-SCAN-089 x7, MEDUSA-PRIV-SCAN-762 x6, AIC-EXFIL-005 x5, EXA006 x5, MEDUSA-FTSCAN-231 x5, WEB-SSRF x5, MEDUSA-INF-SCAN-2057 x3, RH005 x3, TC001 x3, LO002 x2, MEDUSA-AEXP-SCAN-096 x2, MEDUSA-CGS-SCAN-028 x2, MEDUSA-INF-SCAN-1350 x2, MEDUSA-INF-SCAN-2369 x2, MEDUSA-INF-SCAN-2440 x2, MEDUSA-INF-SCAN-2638 x2, MLSC-SERIAL-002 x2, PL002 x2, PQC005 x2, SAST-PATH-001 x2, TC004 x2, TC005 x2, TC006 x2, TC007 x2, AA-146, EXA007, FINE-050, GB-ENCODE-001, GB-ENCODE-003, MEDUSA-CGS-SCAN-029, MEDUSA-CGS-SCAN-103, MEDUSA-DP-SCAN-1034, MEDUSA-DP-SCAN-1916, MEDUSA-DP-SCAN-954, MEDUSA-EXF26-TOOL-004, MEDUSA-FT-TRIGGER-005, MEDUSA-INF-SCAN-2206, MEDUSA-INF-SCAN-2457, MEDUSA-INF-WEB-003, MEDUSA-INFRA-SCAN-030, MEDUSA-MP-SCAN-1135, MEDUSA-RLHF-POISON-002, MEDUSA-RT-SCAN-006, MM-ENCODE-001, MP-124, PQC001, PQC002, PQC006, RP001, TC009, TC010, WEB-FLASK-004.

🎯 Fix: 80 %
💥 Break: 4 %
💸 Cost: 129 %
⏱️ Time: –
🛡️ Security: 100 %
💰 Value: ?
🏆 Score: 60
🚦 Gate: ⛔ fix 80 % < 90; cost 129 % > 100: ask the operator before the commit

```
/home/kevinveenbirkenbach/Repositories/github.com/kevinveenbirkenbach/skills/.worktrees/feature/kvb-hub
```

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 18:46:40 +00:00

99 lines
3.8 KiB
Python

from __future__ import annotations
import re
from html.parser import HTMLParser
DIGITS = re.compile(r"[0-9]+")
TEXTS = ("path", "old", "add", "del", "tag", "placeholder")
class ReviewPage(HTMLParser):
def __init__(self) -> None:
super().__init__(convert_charrefs=True)
self.files: list[dict] = []
self.section = ""
self.details: list[str] = []
self.spans: list[str] = []
self.file: dict | None = None
self.texts: dict[str, list[str]] = {}
self.row = ""
self.cells: list[str] | None = None
self.cell: list[str] | None = None
self.detail = False
def handle_starttag(self, tag: str, attrs: list[tuple[str, str | None]]) -> None:
values = dict(attrs)
classes = (values.get("class") or "").split()
first = classes[0] if classes else ""
if tag == "section":
self.section = values.get("id") or ""
elif tag == "details":
if first == "file" and "commit" not in self.details:
self.file = {"section": self.section, "status": "", "tags": [], "lines": []}
self.texts = {name: [] for name in TEXTS}
self.spans = []
self.details.append(first)
elif self.file is None:
return
elif tag == "span":
self.spans.append(first)
if first == "badge":
self.file["status"] = values.get("title") or ""
elif tag == "p" and first == "placeholder":
self.detail = True
elif tag == "tr":
self.row, self.cells = first, []
elif tag == "td" and self.cells is not None:
self.cell = []
def handle_data(self, data: str) -> None:
if self.file is None:
return
if self.cell is not None:
self.cell.append(data)
elif self.detail:
self.texts["placeholder"].append(data)
elif self.spans and self.spans[-1] in self.texts:
self.texts[self.spans[-1]].append(data)
def handle_endtag(self, tag: str) -> None:
if tag == "section":
self.section = ""
elif tag == "details" and self.details:
if self.details.pop() == "file" and self.file is not None:
self.files.append(self.finish(self.file))
self.file = None
elif self.file is None:
return
elif tag == "span" and self.spans:
if self.spans.pop() == "tag":
self.file["tags"].append("".join(self.texts["tag"]).strip())
self.texts["tag"] = []
elif tag == "p":
self.detail = False
elif tag == "td" and self.cell is not None and self.cells is not None:
self.cells.append("".join(self.cell))
self.cell = None
elif tag == "tr" and self.cells is not None:
self.file["lines"].append(diff_line(self.row, self.cells))
self.cells = None
def finish(self, file: dict) -> dict:
text = {name: "".join(parts).strip() for name, parts in self.texts.items()}
counts = {name: DIGITS.search(text[name]) for name in ("add", "del")}
numbers = {name: int(match.group()) if match else 0 for name, match in counts.items()}
return {**file, "path": text["path"], "old": text["old"], "added": numbers["add"], "removed": numbers["del"], "detail": text["placeholder"]}
def diff_line(kind_name: str, cells: list[str]) -> dict:
if len(cells) >= 4:
return {"kind": kind_name, "old": cells[0].strip(), "new": cells[1].strip(), "text": cells[3]}
return {"kind": kind_name, "old": "", "new": "", "text": cells[-1].strip() if cells else ""}
def review_files(page: bytes) -> list[dict]:
parser = ReviewPage()
parser.feed(page.decode("utf-8", errors="replace"))
parser.close()
return parser.files