Requirement 001 phase 6, S5: - Tasks tab: every pending ask, rule request, operator row and choice card shows under "waits on Operator"; a choice request goes out on a fixed channel button, post and call with an agent multi-select, and a click on an option sends a passkey-signed answer the agent checks with operator_message. The unsigned /api/decisions/<id>/choose route is gone, and a decision, choice answer or choice recipient whose name holds "*" is refused, so a signed answer never reaches every agent. - Gantt view: one bar per task from start to end (running to now), one arrow per explicit, branch-base and queue-order edge, hatched forecast bars (always, points only, real only) from the median duration or points times median hours per point. - rasci.py set --after/--drop-after stores task dependencies and refuses unknown tasks and cycles. - Estimation toggle (No estimate default, Story points) is stored in the hub settings; burndown and burnup per whole register, list filter or one agent or line, counting tasks or summing complexity with the unestimated tasks as their own line. - New skill kvb-org-queue-estimate: "Request estimates" (story points mode, passkey-signed board action) or the skill sends exactly one newsletter listing every unestimated task with its RASCI parties; a party name that is no plain name shows as "unnamed party". - Business value per task or in bulk is stored only with a verified passkey assertion over the exact ids and values; WSJF uses it instead of the median. The task list sorts by every decision-50 mode both ways. - e2e: the walk's pending ask lives an hour instead of 60 s, and the CDP and BiDi drivers retry removing the browser profile while the browser exits (ENOTEMPTY). Evidence: make test 709 OK, ruff and markdownlint clean (/tmp/s5-make-test-fix-2.log); e2e 26 OK in Chromium and Firefox (/tmp/s5-e2e-fix-2.log); MEDUSA 50 files, an independent skeptic rejected four holes (unsigned choose route, unsigned estimates request, free-text party names, "*" recipients incl. normalizer bypasses), all fixed and re-verified, the 8 remaining pattern hits accepted, rescan 0 open. 🎯 Fix: 92 % 💥 Break: 4 % 💸 Cost: 100 % ⏱️ Time: – 🛡️ Security: 100 % 🏆 Score: 88 🚦 Gate: ✅ 90/5, cost and time <= 100, security 100 % Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
126 lines
5.6 KiB
Python
126 lines
5.6 KiB
Python
from __future__ import annotations
|
|
|
|
import time
|
|
|
|
from .choosing import EVERYONE, answer_text
|
|
from .errors import Conflict, Missing, ToolError
|
|
from .fields import (
|
|
COMMAND_LIMIT,
|
|
PATH_LIMIT,
|
|
WAIT_CAP,
|
|
bounded,
|
|
decode,
|
|
expect,
|
|
field,
|
|
instant,
|
|
message_text,
|
|
seconds,
|
|
)
|
|
from .signed import ask_signed
|
|
|
|
ASK_LIFETIME = 3600
|
|
DESCRIPTION_LIMIT = 1000
|
|
OPTION_LIMIT = 12
|
|
ASK_TEXTS = {"command": COMMAND_LIMIT, "cwd": PATH_LIMIT, "session": 200, "agent": 200}
|
|
ANSWERS = {"allow": "allowed", "deny": "denied"}
|
|
|
|
|
|
def ask_state(ask: dict, now: float) -> dict:
|
|
status = "expired" if ask["status"] == "pending" and ask["expires"] <= now else ask["status"]
|
|
return {"id": ask["id"], "status": status, "decided": ask["decided"], "proof": ask.get("proof"), "channel": ask.get("channel", ""), "reason": ask.get("reason", ""), "to": ask.get("to", "")}
|
|
|
|
|
|
def ask_row(ask: dict, names: dict[str, str]) -> dict:
|
|
keys = ("id", "tool", "command", "cwd", "session", "created_ts", "expires")
|
|
return {**{key: ask[key] for key in keys}, "agent": names.get(ask["session"], ""), "subagent": ask["agent"]}
|
|
|
|
|
|
def decision_state(decision: dict) -> dict:
|
|
"""Returns:
|
|
The status and choice, with the id and text of the operator's
|
|
passkey-signed answer when a click chose it, else None for both.
|
|
"""
|
|
message = decision.get("message")
|
|
answer = None if message is None else answer_text(decision, decision["choice"])
|
|
return {**{key: decision[key] for key in ("id", "status", "choice", "decided")}, "message": message, "answer": answer}
|
|
|
|
|
|
def decision_row(decision: dict) -> dict:
|
|
return {key: decision[key] for key in ("id", "question", "options", "agent", "created_ts")}
|
|
|
|
|
|
def option_of(option: object) -> dict:
|
|
if not isinstance(option, dict):
|
|
raise ToolError("every option must be an object with label and description")
|
|
expect(option, ("label", "description"))
|
|
label = field(option, "label").strip()
|
|
return {"label": label, "description": bounded(option, "description", DESCRIPTION_LIMIT).strip()}
|
|
|
|
|
|
class Asking:
|
|
def ask(self, body: bytes) -> dict:
|
|
payload = decode(body)
|
|
expect(payload, ("tool", *ASK_TEXTS, "timeout"))
|
|
values = {name: bounded(payload, name, limit) for name, limit in ASK_TEXTS.items()}
|
|
lifetime = seconds(payload, "timeout", ASK_LIFETIME)
|
|
created = time.time()
|
|
fields = {**values, "tool": field(payload, "tool").strip(), "status": "pending", "decided": None, "proof": None}
|
|
record = self.asks.add({**fields, "created_ts": created, "expires": created + lifetime})
|
|
self.automate("ask", record)
|
|
return {"id": record["id"], "status": record["status"]}
|
|
|
|
def ask_wait(self, ask_id: str, query: dict[str, list[str]]) -> dict:
|
|
wait = instant(query, "wait")
|
|
record = self.asks.get(ask_id)
|
|
if record is None:
|
|
raise Missing(ask_id)
|
|
left = max(record["expires"] - time.time(), 0.0)
|
|
record = self.asks.wait(ask_id, min(wait or 0.0, WAIT_CAP, left))
|
|
return ask_state(record, time.time())
|
|
|
|
def settle(self, kind_name: str, item_id: str, verb: str, body: bytes) -> dict:
|
|
if kind_name == "asks" and verb in ANSWERS:
|
|
record = self.asks.get(item_id)
|
|
if record is None:
|
|
raise Missing(item_id)
|
|
if ask_state(record, time.time())["status"] == "expired":
|
|
raise Conflict(ask_state(record, time.time()))
|
|
proof = None
|
|
if verb == "allow":
|
|
payload = decode(body)
|
|
expect(payload, ("proof",))
|
|
proof = self.covered(payload["proof"], [ask_signed(record)], time.time())
|
|
decided, changed = self.asks.decide(item_id, {"status": ANSWERS[verb], "proof": proof})
|
|
if not changed:
|
|
raise Conflict(ask_state(decided, time.time()))
|
|
return ask_state(decided, time.time())
|
|
raise Missing(verb)
|
|
|
|
def decision_request(self, arguments: dict) -> dict:
|
|
expect(arguments, ("question", "options", "agent", "recommended"))
|
|
question = message_text(arguments, "question")
|
|
options = arguments["options"]
|
|
if not isinstance(options, list) or not 1 <= len(options) <= OPTION_LIMIT:
|
|
raise ToolError(f"options must be a list of 1 to {OPTION_LIMIT} objects")
|
|
parsed = [option_of(option) for option in options]
|
|
if len({option["label"] for option in parsed}) != len(parsed):
|
|
raise ToolError("option labels must be distinct")
|
|
recommended = arguments["recommended"]
|
|
if not isinstance(recommended, str) or recommended.strip() not in ["", *(option["label"] for option in parsed)]:
|
|
raise ToolError("recommended must be one of the option labels or an empty string")
|
|
asker = field(arguments, "agent").strip()
|
|
if EVERYONE in asker:
|
|
raise ToolError(f"agent names the asking agent, never a name with {EVERYONE}")
|
|
fields = {"question": question, "options": parsed, "agent": asker, "recommended": recommended.strip()}
|
|
record = self.decisions.add({**fields, "status": "pending", "choice": None, "decided": None, "created_ts": time.time()})
|
|
self.automate("decision", record)
|
|
return {"id": record["id"], "status": record["status"], "url": self.url()}
|
|
|
|
def decision_wait(self, arguments: dict) -> dict:
|
|
expect(arguments, ("id", "timeout_seconds"))
|
|
decision_id = field(arguments, "id")
|
|
record = self.decisions.wait(decision_id, seconds(arguments, "timeout_seconds", WAIT_CAP))
|
|
if record is None:
|
|
raise ToolError(f"no decision {decision_id}")
|
|
return decision_state(record)
|