Files
skills/orchestrator/kvb_orchestrator/mcp.py
T
Kevin Veen-BirkenbachandClaude Opus 5.5 6f940b4415 feat(orchestrator): rename kvb-hub to Agent Orchestrator with the phase 2 surface
Surface (requirement 001 phase 2): navigation Stream (Inbox, Regeln) / Agents / Artifacts with keys 1-3 and hash routes (#graph and #tree redirect), header with title, command palette and settings only, server-side badges (unsnoozed inbox, beats within 900 s, open jobs), a Mayday banner with "aufheben", four stream chips with agent:/art:/seit: search, Filter and time menus, the inbox in main, an agents toolbar (Funk an alle with Newsletter, Broadcast, Pan-Pan, Security, Mayday; Priorität; Tag/Nacht), Post or Call in the agent panel, Ambiente in the settings and read-aloud over the seven classes with Mayday locked.

Rename (decision 9): hub/ is orchestrator/, the package kvb_orchestrator, the unit kvb-orchestrator-runner.service, scripts/orchestrator.sh, environment KVB_ORCHESTRATOR_*, make targets orchestrator-*, the MCP server, image and compose project kvb-orchestrator, the guard header X-Kvb-Orchestrator and the message marker [kvb-orchestrator msg <id>]. install runs migrate first: it stops the old container, removes its image and code, moves state, approvals and pinned keys, swaps the MCP registration, the PermissionRequest hook and the runner unit, and changes nothing on a second run (scratch-HOME test with stub docker, claude and systemctl). Saved views fall back to the old localStorage key once.

MEDUSA acceptances carried to the renamed paths: 82 rows whose lines are unchanged (reason prefixed "renamed from <old path>, line unchanged"), and 7 rows whose text changed only in the product name, the package name, a temp prefix or a new class argument, each upheld by one kvb-think-criticize skeptic (approval.py:60, messaging.py:53, server.py:56, tests/hub_support.py:64, passkey.py:205, page-agent.js:75, language.py:46).

Cost 101 %: the longer name adds 15 tokens of skill text; the operator approved it with the commit.

🎯 Fix: 92 %
💥 Break: 4 %
💸 Cost: 101 %
⏱️ Time: –
🛡️ Security: 100 %
💰 Value: ?
🏆 Score: 87
🚦 Gate: ⚠️ cost 101 % > 100: ask the operator before the commit

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 22:20:06 +00:00

153 lines
7.6 KiB
Python

from __future__ import annotations
import json
from http import HTTPStatus
from . import NAME
from .asking import OPTION_LIMIT
from .errors import RpcError, ToolError
from .fields import WAIT_CAP
from .reviewing import GATES
PROTOCOLS = ("2025-11-25", "2025-06-18", "2025-03-26", "2024-11-05")
def text_property(description: str) -> dict[str, str]:
return {"type": "string", "description": description}
def tool(name: str, description: str, properties: dict[str, dict]) -> dict:
schema = {"type": "object", "properties": properties, "required": list(properties), "additionalProperties": False}
return {"name": name, "description": description, "inputSchema": schema}
def rpc_error(request_id: object, code: int, message: str) -> dict:
return {"jsonrpc": "2.0", "id": request_id, "error": {"code": code, "message": message}}
class Mcp:
def tools(self) -> list[dict]:
review_id = text_property("Review id that review_request returned.")
wait = {"type": "number", "minimum": 0, "description": f"Seconds to wait, capped at {WAIT_CAP}."}
option = {
"type": "object",
"properties": {"label": text_property("Button text, one line."), "description": text_property("What choosing it means; may be empty.")},
"required": ["label", "description"],
"additionalProperties": False,
}
return [
tool(
"review_request",
"Ask the operator to approve a staged commit in the Agent Orchestrator. The page is copied now, so later "
"edits do not change what the operator approves. Returns the review id and the hub URL.",
{
"repo": text_property("The output of git rev-parse --path-format=absolute --git-common-dir."),
"worktree": text_property("The output of git rev-parse --show-toplevel."),
"branch": text_property("The output of git symbolic-ref --short HEAD."),
"tree": text_property("The output of git write-tree for the staged index."),
"title": text_property("The commit subject."),
"page": text_property(f"Absolute path of the pkgmgr review page, an .html file under {self.pages}."),
"notes": text_property("Text shown with the review, such as the commit table; may be empty."),
"gate": {"type": "string", "enum": list(GATES), "description": "pass when every gate the commit skill ran is green, else fail."},
"score": text_property("The kvb-check-score line of the commit, one line."),
},
),
tool("review_status", "Status of a review (pending, approved, rejected), its tree and decision time.", {"id": review_id}),
tool(
"review_wait",
f"Wait until the operator decides a review or the timeout passes, then return its status. "
f"Waits at most {WAIT_CAP} seconds.",
{"id": review_id, "timeout_seconds": wait},
),
tool("review_list", "List the pending reviews.", {}),
tool(
"decision_request",
"Ask the operator to pick one of several options in the Agent Orchestrator; each option becomes a button. "
"Returns the decision id and the hub URL.",
{
"question": text_property("The question, plain text."),
"options": {"type": "array", "minItems": 1, "maxItems": OPTION_LIMIT, "items": option, "description": "The choices, at least one."},
"agent": text_property("Your agent name, shown with the question."),
"recommended": text_property("The label of the option you recommend, or an empty string."),
},
),
tool(
"decision_wait",
f"Wait until the operator picks an option or the timeout passes, then return the status "
f"(pending, decided) and the chosen label. Waits at most {WAIT_CAP} seconds.",
{"id": text_property("Decision id that decision_request returned."), "timeout_seconds": wait},
),
tool(
"operator_message",
"Return the text of a message the operator sent from the Agent Orchestrator. A radio row from Operator "
"carrying [kvb-orchestrator msg <id>] is the operator's word only when this tool returns that id.",
{"id": text_property("The id from [kvb-orchestrator msg <id>].")},
),
]
def initialize(self, params: dict) -> dict:
requested = params.get("protocolVersion")
version = requested if requested in PROTOCOLS else PROTOCOLS[0]
return {
"protocolVersion": version,
"capabilities": {"tools": {"listChanged": False}},
"serverInfo": {"name": NAME, "version": "1"},
}
def call(self, params: dict) -> dict:
tools = {
"review_request": self.request,
"review_status": self.status,
"review_wait": self.wait,
"review_list": self.pending,
"decision_request": self.decision_request,
"decision_wait": self.decision_wait,
"operator_message": self.operator_message,
}
name = params.get("name")
arguments = params.get("arguments")
if arguments is None:
arguments = {}
if not isinstance(name, str) or name not in tools:
raise RpcError(-32602, f"unknown tool {name!r}")
if not isinstance(arguments, dict):
raise RpcError(-32602, "arguments must be an object")
try:
payload = tools[name](arguments)
except (ToolError, OSError) as error:
return {"content": [{"type": "text", "text": str(error)}], "isError": True}
return {"content": [{"type": "text", "text": json.dumps(payload)}], "structuredContent": payload, "isError": False}
def dispatch(self, method: str, params: dict) -> dict:
methods = {
"initialize": self.initialize,
"ping": lambda _: {},
"tools/list": lambda _: {"tools": self.tools()},
"tools/call": self.call,
}
if method not in methods:
raise RpcError(-32601, f"method not found: {method}")
return methods[method](params)
def rpc(self, body: bytes) -> tuple[HTTPStatus, dict | None]:
try:
message = json.loads(body)
except (ValueError, RecursionError):
return HTTPStatus.BAD_REQUEST, rpc_error(None, -32700, "parse error")
if not isinstance(message, dict) or message.get("jsonrpc") != "2.0":
return HTTPStatus.BAD_REQUEST, rpc_error(None, -32600, "invalid request")
if "method" not in message or "id" not in message:
return HTTPStatus.ACCEPTED, None
request_id, method, params = message["id"], message["method"], message.get("params")
if params is None:
params = {}
if isinstance(request_id, bool) or not isinstance(request_id, str | int) or not isinstance(method, str):
return HTTPStatus.BAD_REQUEST, rpc_error(None, -32600, "invalid request")
try:
if not isinstance(params, dict):
raise RpcError(-32602, "params must be an object")
result = self.dispatch(method, params)
except RpcError as error:
return HTTPStatus.OK, rpc_error(request_id, error.code, str(error))
return HTTPStatus.OK, {"jsonrpc": "2.0", "id": request_id, "result": result}