Release version 1.8.6

https://chatgpt.com/share/69432655-a948-800f-8c0d-353921cdf644

.github/workflows/test-e2e.yml

@@ -11,7 +11,9 @@ jobs:
       fail-fast: false
       matrix:
         distro: [arch, debian, ubuntu, fedora, centos]
-
+    env:
+      NIX_CONFIG: |
+        access-tokens = github.com=${{ secrets.GITHUB_TOKEN }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4

.github/workflows/test-env-nix.yml

@@ -12,7 +12,9 @@ jobs:
       fail-fast: false
       matrix:
         distro: [arch, debian, ubuntu, fedora, centos]
-
+    env:
+      NIX_CONFIG: |
+        access-tokens = github.com=${{ secrets.GITHUB_TOKEN }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4

.github/workflows/test-env-virtual.yml

@@ -11,7 +11,9 @@ jobs:
       fail-fast: false
       matrix:
         distro: [arch, debian, ubuntu, fedora, centos]
-
+    env:
+      NIX_CONFIG: |
+        access-tokens = github.com=${{ secrets.GITHUB_TOKEN }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4

.github/workflows/test-integration.yml

@@ -7,7 +7,9 @@ jobs:
   test-integration:
     runs-on: ubuntu-latest
     timeout-minutes: 30
-
+    env:
+      NIX_CONFIG: |
+        access-tokens = github.com=${{ secrets.GITHUB_TOKEN }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4

.github/workflows/test-unit.yml

@@ -7,7 +7,9 @@ jobs:
   test-unit:
     runs-on: ubuntu-latest
     timeout-minutes: 30
-
+    env:
+      NIX_CONFIG: |
+        access-tokens = github.com=${{ secrets.GITHUB_TOKEN }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4

.github/workflows/test-virgin-root.yml

@@ -11,7 +11,9 @@ jobs:
       fail-fast: false
       matrix:
         distro: [arch, debian, ubuntu, fedora, centos]
-
+    env:
+      NIX_CONFIG: |
+        access-tokens = github.com=${{ secrets.GITHUB_TOKEN }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -19,27 +21,26 @@ jobs:
       - name: Show Docker version
         run: docker version
 
-      # 🔹 BUILD virgin image if missing
       - name: Build virgin container (${{ matrix.distro }})
         run: |
           set -euo pipefail
           PKGMGR_DISTRO="${{ matrix.distro }}" make build-missing-virgin
 
-      # 🔹 RUN test inside virgin image
       - name: Virgin ${{ matrix.distro }} pkgmgr test (root)
         run: |
           set -euo pipefail
 
           docker run --rm \
-            -v "$PWD":/src \
+            -v "$PWD":/opt/src/pkgmgr \
             -v pkgmgr_repos:/root/Repositories \
             -v pkgmgr_pip_cache:/root/.cache/pip \
-            -w /src \
+            -e NIX_CONFIG="${NIX_CONFIG}" \
+            -w /opt/src/pkgmgr \
             "pkgmgr-${{ matrix.distro }}-virgin" \
             bash -lc '
               set -euo pipefail
 
-              git config --global --add safe.directory /src
+              git config --global --add safe.directory /opt/src/pkgmgr
 
               make install
               make setup
@@ -50,5 +51,5 @@ jobs:
               pkgmgr version pkgmgr
 
               echo ">>> Running Nix-based: nix run .#pkgmgr -- version pkgmgr"
-              nix run /src#pkgmgr -- version pkgmgr
+              nix run /opt/src/pkgmgr#pkgmgr -- version pkgmgr
             '

.github/workflows/test-virgin-user.yml

@@ -11,7 +11,9 @@ jobs:
       fail-fast: false
       matrix:
         distro: [arch, debian, ubuntu, fedora, centos]
-
+    env:
+      NIX_CONFIG: |
+        access-tokens = github.com=${{ secrets.GITHUB_TOKEN }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -19,20 +21,19 @@ jobs:
       - name: Show Docker version
         run: docker version
 
-      # 🔹 BUILD virgin image if missing
       - name: Build virgin container (${{ matrix.distro }})
         run: |
           set -euo pipefail
           PKGMGR_DISTRO="${{ matrix.distro }}" make build-missing-virgin
 
-      # 🔹 RUN test inside virgin image as non-root
       - name: Virgin ${{ matrix.distro }} pkgmgr test (user)
         run: |
           set -euo pipefail
 
           docker run --rm \
-            -v "$PWD":/src \
+            -v "$PWD":/opt/src/pkgmgr \
-            -w /src \
+            -e NIX_CONFIG="${NIX_CONFIG}" \
+            -w /opt/src/pkgmgr \
             "pkgmgr-${{ matrix.distro }}-virgin" \
             bash -lc '
               set -euo pipefail
@@ -42,7 +43,7 @@ jobs:
               useradd -m dev
               echo "dev ALL=(ALL) NOPASSWD: ALL" > /etc/sudoers.d/dev
               chmod 0440 /etc/sudoers.d/dev
-              chown -R dev:dev /src
+              chown -R dev:dev /opt/src/pkgmgr
 
               mkdir -p /nix/store /nix/var/nix /nix/var/log/nix /nix/var/nix/profiles
               chown -R dev:dev /nix
@@ -51,7 +52,7 @@ jobs:
 
               sudo -H -u dev env HOME=/home/dev PKGMGR_DISABLE_NIX_FLAKE_INSTALLER=1 bash -lc "
                 set -euo pipefail
-                cd /src
+                cd /opt/src/pkgmgr
 
                 make setup-venv
                 . \"\$HOME/.venvs/pkgmgr/bin/activate\"
@@ -59,6 +60,6 @@ jobs:
                 pkgmgr version pkgmgr
 
                 export NIX_REMOTE=local
-                nix run /src#pkgmgr -- version pkgmgr
+                nix run /opt/src/pkgmgr#pkgmgr -- version pkgmgr
               "
             '

CHANGELOG.md

@@ -1,3 +1,35 @@
+## [1.8.6] - 2025-12-17
+
+* Prevent Rate Limits during GitHub Nix Setups
+
+
+## [1.8.5] - 2025-12-17
+
+* * Clearer Git error handling, especially when a directory is not a Git repository.
+* More reliable repository verification with improved commit and GPG signature checks.
+* Better error messages and overall robustness when working with Git-based workflows.
+
+
+## [1.9.0] - 2025-12-17
+
+* Automated release.
+
+
+## [1.8.4] - 2025-12-17
+
+* * Made pkgmgr’s base-layer role explicit by standardizing the Docker/CI mount path to *`/opt/src/pkgmgr`*.
+
+
+## [1.8.3] - 2025-12-16
+
+* MIRRORS now supports plain URL entries, ensuring metadata-only sources like PyPI are recorded without ever being added to the Git configuration.
+
+
+## [1.8.2] - 2025-12-16
+
+* * ***pkgmgr tools code*** is more robust and predictable: it now fails early with clear errors if VS Code is not installed or a repository is not yet identified.
+
+
 ## [1.8.1] - 2025-12-16
 
 * * Improved stability and consistency of all Git operations (clone, pull, push, release, branch handling) with clearer error messages and predictable preview behavior.

Dockerfile

@@ -50,6 +50,6 @@ RUN set -euo pipefail; \
 # Entry point
 COPY scripts/docker/entry.sh /usr/local/bin/docker-entry.sh
 
-WORKDIR /src
+WORKDIR /opt/src/pkgmgr
 ENTRYPOINT ["/usr/local/bin/docker-entry.sh"]
 CMD ["pkgmgr", "--help"]

Makefile

@@ -10,6 +10,10 @@ DISTROS ?= arch debian ubuntu fedora centos
 PKGMGR_DISTRO ?= arch
 export PKGMGR_DISTRO
 
+# Nix Config Variable (To avoid rate limit)
+NIX_CONFIG ?=
+export NIX_CONFIG
+
 # ------------------------------------------------------------
 # Base images
 # (kept for documentation/reference; actual build logic is in scripts/build)

flake.nix

@@ -32,7 +32,7 @@
         rec {
           pkgmgr = pyPkgs.buildPythonApplication {
             pname   = "package-manager";
-            version = "1.8.1";
+            version = "1.8.6";
 
             # Use the git repo as source
             src = ./.;

packaging/arch/PKGBUILD

@@ -1,7 +1,7 @@
 # Maintainer: Kevin Veen-Birkenbach <info@veen.world>
 
 pkgname=package-manager
-pkgver=1.8.1
+pkgver=1.8.6
 pkgrel=1
 pkgdesc="Local-flake wrapper for Kevin's package-manager (Nix-based)."
 arch=('any')

packaging/debian/changelog

@@ -1,3 +1,41 @@
+package-manager (1.8.6-1) unstable; urgency=medium
+
+  * Prevent Rate Limits during GitHub Nix Setups
+
+ -- Kevin Veen-Birkenbach <kevin@veen.world>  Wed, 17 Dec 2025 23:50:31 +0100
+
+package-manager (1.8.5-1) unstable; urgency=medium
+
+  * * Clearer Git error handling, especially when a directory is not a Git repository.
+* More reliable repository verification with improved commit and GPG signature checks.
+* Better error messages and overall robustness when working with Git-based workflows.
+
+ -- Kevin Veen-Birkenbach <kevin@veen.world>  Wed, 17 Dec 2025 22:15:48 +0100
+
+package-manager (1.9.0-1) unstable; urgency=medium
+
+  * Automated release.
+
+ -- Kevin Veen-Birkenbach <kevin@veen.world>  Wed, 17 Dec 2025 22:10:31 +0100
+
+package-manager (1.8.4-1) unstable; urgency=medium
+
+  * * Made pkgmgr’s base-layer role explicit by standardizing the Docker/CI mount path to *`/opt/src/pkgmgr`*.
+
+ -- Kevin Veen-Birkenbach <kevin@veen.world>  Wed, 17 Dec 2025 11:20:16 +0100
+
+package-manager (1.8.3-1) unstable; urgency=medium
+
+  * MIRRORS now supports plain URL entries, ensuring metadata-only sources like PyPI are recorded without ever being added to the Git configuration.
+
+ -- Kevin Veen-Birkenbach <kevin@veen.world>  Tue, 16 Dec 2025 19:49:51 +0100
+
+package-manager (1.8.2-1) unstable; urgency=medium
+
+  * * ***pkgmgr tools code*** is more robust and predictable: it now fails early with clear errors if VS Code is not installed or a repository is not yet identified.
+
+ -- Kevin Veen-Birkenbach <kevin@veen.world>  Tue, 16 Dec 2025 19:22:41 +0100
+
 package-manager (1.8.1-1) unstable; urgency=medium
 
   * * Improved stability and consistency of all Git operations (clone, pull, push, release, branch handling) with clearer error messages and predictable preview behavior.

packaging/fedora/package-manager.spec

@@ -1,5 +1,5 @@
 Name:           package-manager
-Version:        1.8.1
+Version:        1.8.6
 Release:        1%{?dist}
 Summary:        Wrapper that runs Kevin's package-manager via Nix flake
 
@@ -74,6 +74,26 @@ echo ">>> package-manager removed. Nix itself was not removed."
 /usr/lib/package-manager/
 
 %changelog
+* Wed Dec 17 2025 Kevin Veen-Birkenbach <kevin@veen.world> - 1.8.6-1
+- Prevent Rate Limits during GitHub Nix Setups
+
+* Wed Dec 17 2025 Kevin Veen-Birkenbach <kevin@veen.world> - 1.8.5-1
+- * Clearer Git error handling, especially when a directory is not a Git repository.
+* More reliable repository verification with improved commit and GPG signature checks.
+* Better error messages and overall robustness when working with Git-based workflows.
+
+* Wed Dec 17 2025 Kevin Veen-Birkenbach <kevin@veen.world> - 1.9.0-1
+- Automated release.
+
+* Wed Dec 17 2025 Kevin Veen-Birkenbach <kevin@veen.world> - 1.8.4-1
+- * Made pkgmgr’s base-layer role explicit by standardizing the Docker/CI mount path to *`/opt/src/pkgmgr`*.
+
+* Tue Dec 16 2025 Kevin Veen-Birkenbach <kevin@veen.world> - 1.8.3-1
+- MIRRORS now supports plain URL entries, ensuring metadata-only sources like PyPI are recorded without ever being added to the Git configuration.
+
+* Tue Dec 16 2025 Kevin Veen-Birkenbach <kevin@veen.world> - 1.8.2-1
+- * ***pkgmgr tools code*** is more robust and predictable: it now fails early with clear errors if VS Code is not installed or a repository is not yet identified.
+
 * Tue Dec 16 2025 Kevin Veen-Birkenbach <kevin@veen.world> - 1.8.1-1
 - * Improved stability and consistency of all Git operations (clone, pull, push, release, branch handling) with clearer error messages and predictable preview behavior.
 * Mirrors are now handled cleanly: only valid Git remotes are used for Git operations, while non-Git URLs (e.g. PyPI) are excluded, preventing broken or confusing repository configs.

pyproject.toml

@@ -7,7 +7,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "kpmx"
-version = "1.8.1"
+version = "1.8.6"
 description = "Kevin's package-manager tool (pkgmgr)"
 readme = "README.md"
 requires-python = ">=3.9"

scripts/docker/entry.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
-echo "[docker] Starting package-manager container"
+echo "[docker-pkgmgr] Starting package-manager container"
 
 # ---------------------------------------------------------------------------
 # Log distribution info
@@ -9,19 +9,19 @@ echo "[docker] Starting package-manager container"
 if [[ -f /etc/os-release ]]; then
   # shellcheck disable=SC1091
   . /etc/os-release
-  echo "[docker] Detected distro: ${ID:-unknown} (like: ${ID_LIKE:-})"
+  echo "[docker-pkgmgr] Detected distro: ${ID:-unknown} (like: ${ID_LIKE:-})"
 fi
 
-# Always use /src (mounted from host) as working directory
+# Always use /opt/src/pkgmgr (mounted from host) as working directory
-echo "[docker] Using /src as working directory"
+echo "[docker-pkgmgr] Using /opt/src/pkgmgr as working directory"
-cd /src
+cd /opt/src/pkgmgr
 
 # ---------------------------------------------------------------------------
-# DEV mode: rebuild package-manager from the mounted /src tree
+# DEV mode: rebuild package-manager from the mounted /opt/src/pkgmgr tree
 # ---------------------------------------------------------------------------
 if [[ "${REINSTALL_PKGMGR:-0}" == "1" ]]; then
-  echo "[docker] DEV mode enabled (REINSTALL_PKGMGR=1)"
+  echo "[docker-pkgmgr] DEV mode enabled (REINSTALL_PKGMGR=1)"
-  echo "[docker] Rebuilding package-manager from /src via scripts/installation/package.sh..."
+  echo "[docker-pkgmgr] Rebuilding package-manager from /opt/src/pkgmgr via scripts/installation/package.sh..."
   bash scripts/installation/package.sh || exit 1
 fi
 
@@ -29,9 +29,9 @@ fi
 # Hand off to pkgmgr or arbitrary command
 # ---------------------------------------------------------------------------
 if [[ $# -eq 0 ]]; then
-  echo "[docker] No arguments provided. Showing pkgmgr help..."
+  echo "[docker-pkgmgr] No arguments provided. Showing pkgmgr help..."
   exec pkgmgr --help
 else
-  echo "[docker] Executing command: $*"
+  echo "[docker-pkgmgr] Executing command: $*"
   exec "$@"
 fi

scripts/installation/arch/package.sh

@@ -6,7 +6,7 @@ echo "[arch/package] Building Arch package (makepkg --nodeps) in an isolated bui
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 PROJECT_ROOT="$(cd "${SCRIPT_DIR}/../../.." && pwd)"
 
-# We must not build inside /src (mounted repo). Build in /tmp to avoid permission issues.
+# We must not build inside /opt/src/pkgmgr (mounted repo). Build in /tmp to avoid permission issues.
 BUILD_ROOT="/tmp/package-manager-arch-build"
 PKG_SRC_DIR="${PROJECT_ROOT}/packaging/arch"
 PKG_BUILD_DIR="${BUILD_ROOT}/packaging/arch"

scripts/test/test-e2e.sh

@@ -6,12 +6,13 @@ echo ">>> Running E2E tests: $PKGMGR_DISTRO"
 echo "============================================================"
 
 docker run --rm \
-  -v "$(pwd):/src" \
+  -v "$(pwd):/opt/src/pkgmgr" \
   -v "pkgmgr_nix_store_${PKGMGR_DISTRO}:/nix" \
   -v "pkgmgr_nix_cache_${PKGMGR_DISTRO}:/root/.cache/nix" \
   -e REINSTALL_PKGMGR=1 \
   -e TEST_PATTERN="${TEST_PATTERN}" \
-  --workdir /src \
+  -e NIX_CONFIG="${NIX_CONFIG}" \
+  --workdir /opt/src/pkgmgr \
   "pkgmgr-${PKGMGR_DISTRO}" \
   bash -lc '
     set -euo pipefail
@@ -40,14 +41,14 @@ docker run --rm \
     }
 
     # Mark the mounted repository as safe to avoid Git ownership errors.
-    # Newer Git (e.g. on Ubuntu) complains about the gitdir (/src/.git),
+    # Newer Git (e.g. on Ubuntu) complains about the gitdir (/opt/src/pkgmgr/.git),
-    # older versions about the worktree (/src). Nix turns "." into the
+    # older versions about the worktree (/opt/src/pkgmgr). Nix turns "." into the
-    # flake input "git+file:///src", which then uses Git under the hood.
+    # flake input "git+file:///opt/src/pkgmgr", which then uses Git under the hood.
     if command -v git >/dev/null 2>&1; then
       # Worktree path
-      git config --global --add safe.directory /src || true
+      git config --global --add safe.directory /opt/src/pkgmgr || true
       # Gitdir path shown in the "dubious ownership" error
-      git config --global --add safe.directory /src/.git || true
+      git config --global --add safe.directory /opt/src/pkgmgr/.git || true
       # Ephemeral CI containers: allow all paths as a last resort
       git config --global --add safe.directory "*" || true
     fi
@@ -55,6 +56,6 @@ docker run --rm \
     # Run the E2E tests inside the Nix development shell
     nix develop .#default --no-write-lock-file -c \
       python3 -m unittest discover \
-        -s /src/tests/e2e \
+        -s /opt/src/pkgmgr/tests/e2e \
         -p "$TEST_PATTERN"
   '

scripts/test/test-env-nix.sh

@@ -9,18 +9,19 @@ echo ">>> Image: ${IMAGE}"
 echo "============================================================"
 
 docker run --rm \
-  -v "$(pwd):/src" \
+  -v "$(pwd):/opt/src/pkgmgr" \
   -v "pkgmgr_nix_store_${PKGMGR_DISTRO}:/nix" \
   -v "pkgmgr_nix_cache_${PKGMGR_DISTRO}:/root/.cache/nix" \
-  --workdir /src \
+  --workdir /opt/src/pkgmgr \
   -e REINSTALL_PKGMGR=1 \
+  -e NIX_CONFIG="${NIX_CONFIG}" \
   "${IMAGE}" \
   bash -lc '
     set -euo pipefail
 
     if command -v git >/dev/null 2>&1; then
-      git config --global --add safe.directory /src || true
+      git config --global --add safe.directory /opt/src/pkgmgr || true
-      git config --global --add safe.directory /src/.git || true
+      git config --global --add safe.directory /opt/src/pkgmgr/.git || true
       git config --global --add safe.directory "*" || true
     fi
 
@@ -38,9 +39,9 @@ docker run --rm \
     # ------------------------------------------------------------
     # Retry helper for GitHub API rate-limit (HTTP 403)
     # ------------------------------------------------------------
-    if [[ -f /src/scripts/nix/lib/retry_403.sh ]]; then
+    if [[ -f /opt/src/pkgmgr/scripts/nix/lib/retry_403.sh ]]; then
       # shellcheck source=./scripts/nix/lib/retry_403.sh
-      source /src/scripts/nix/lib/retry_403.sh
+      source /opt/src/pkgmgr/scripts/nix/lib/retry_403.sh
     elif [[ -f ./scripts/nix/lib/retry_403.sh ]]; then
       # shellcheck source=./scripts/nix/lib/retry_403.sh
       source ./scripts/nix/lib/retry_403.sh

scripts/test/test-env-virtual.sh

@@ -17,8 +17,9 @@ echo
 # ------------------------------------------------------------
 if OUTPUT=$(docker run --rm \
     -e REINSTALL_PKGMGR=1 \
-    -v "$(pwd):/src" \
+    -v "$(pwd):/opt/src/pkgmgr" \
-    -w /src \
+    -w /opt/src/pkgmgr \
+    -e NIX_CONFIG="${NIX_CONFIG}" \
     "${IMAGE}" \
     bash -lc '
         set -euo pipefail

scripts/test/test-integration.sh

@@ -6,19 +6,20 @@ echo ">>> Running INTEGRATION tests in ${PKGMGR_DISTRO} container"
 echo "============================================================"
 
 docker run --rm \
-  -v "$(pwd):/src" \
+  -v "$(pwd):/opt/src/pkgmgr" \
   -v "pkgmgr_nix_store_${PKGMGR_DISTRO}:/nix" \
   -v "pkgmgr_nix_cache_${PKGMGR_DISTRO}:/root/.cache/nix" \
-  --workdir /src \
+  --workdir /opt/src/pkgmgr \
   -e REINSTALL_PKGMGR=1 \
   -e TEST_PATTERN="${TEST_PATTERN}" \
+  -e NIX_CONFIG="${NIX_CONFIG}" \
   "pkgmgr-${PKGMGR_DISTRO}" \
   bash -lc '
     set -e;
-    git config --global --add safe.directory /src || true;
+    git config --global --add safe.directory /opt/src/pkgmgr || true;
     nix develop .#default --no-write-lock-file -c \
       python3 -m unittest discover \
         -s tests/integration \
-        -t /src \
+        -t /opt/src/pkgmgr \
         -p "$TEST_PATTERN";
   '

scripts/test/test-unit.sh

@@ -6,19 +6,20 @@ echo ">>> Running UNIT tests in ${PKGMGR_DISTRO} container"
 echo "============================================================"
 
 docker run --rm \
-  -v "$(pwd):/src" \
+  -v "$(pwd):/opt/src/pkgmgr" \
   -v "pkgmgr_nix_cache_${PKGMGR_DISTRO}:/root/.cache/nix" \
   -v "pkgmgr_nix_store_${PKGMGR_DISTRO}:/nix" \
-  --workdir /src \
+  --workdir /opt/src/pkgmgr \
   -e REINSTALL_PKGMGR=1 \
   -e TEST_PATTERN="${TEST_PATTERN}" \
+  -e NIX_CONFIG="${NIX_CONFIG}" \
   "pkgmgr-${PKGMGR_DISTRO}" \
   bash -lc '
     set -e;
-    git config --global --add safe.directory /src || true;
+    git config --global --add safe.directory /opt/src/pkgmgr || true;
     nix develop .#default --no-write-lock-file -c \
       python3 -m unittest discover \
         -s tests/unit \
-        -t /src \
+        -t /opt/src/pkgmgr \
         -p "$TEST_PATTERN";
   '

src/pkgmgr/actions/branch/close_branch.py

@@ -2,7 +2,7 @@ from __future__ import annotations
 
 from typing import Optional
 
-from pkgmgr.core.git.errors import GitError
+from pkgmgr.core.git.errors import GitRunError
 from pkgmgr.core.git.queries import get_current_branch
 from pkgmgr.core.git.commands import (
     GitDeleteRemoteBranchError,
@@ -32,7 +32,7 @@ def close_branch(
     if not name:
         try:
             name = get_current_branch(cwd=cwd)
-        except GitError as exc:
+        except GitRunError as exc:
             raise RuntimeError(f"Failed to detect current branch: {exc}") from exc
 
     if not name:
@@ -55,7 +55,7 @@ def close_branch(
             print("Aborted closing branch.")
             return
 
-    # Execute workflow (commands raise specific GitError subclasses)
+    # Execute workflow (commands raise specific GitRunError subclasses)
     fetch("origin", cwd=cwd)
     checkout(target_base, cwd=cwd)
     pull("origin", target_base, cwd=cwd)

src/pkgmgr/actions/branch/drop_branch.py

@@ -2,7 +2,7 @@ from __future__ import annotations
 
 from typing import Optional
 
-from pkgmgr.core.git.errors import GitError
+from pkgmgr.core.git.errors import GitRunError
 from pkgmgr.core.git.queries import get_current_branch
 from pkgmgr.core.git.commands import (
     GitDeleteRemoteBranchError,
@@ -26,7 +26,7 @@ def drop_branch(
     if not name:
         try:
             name = get_current_branch(cwd=cwd)
-        except GitError as exc:
+        except GitRunError as exc:
             raise RuntimeError(f"Failed to detect current branch: {exc}") from exc
 
     if not name:

src/pkgmgr/actions/branch/open_branch.py

@@ -30,7 +30,7 @@ def open_branch(
 
     resolved_base = resolve_base_branch(base_branch, fallback_base, cwd=cwd)
 
-    # Workflow (commands raise specific GitError subclasses)
+    # Workflow (commands raise specific GitBaseError subclasses)
     fetch("origin", cwd=cwd)
     checkout(resolved_base, cwd=cwd)
     pull("origin", resolved_base, cwd=cwd)

src/pkgmgr/actions/mirror/git_remote.py

@@ -3,7 +3,7 @@ from __future__ import annotations
 import os
 from typing import Optional, Set
 
-from pkgmgr.core.git.errors import GitError
+from pkgmgr.core.git.errors import GitRunError
 from pkgmgr.core.git.commands import (
     GitAddRemoteError,
     GitAddRemotePushUrlError,
@@ -90,7 +90,7 @@ def determine_primary_remote_url(
 def has_origin_remote(repo_dir: str) -> bool:
     try:
         return "origin" in list_remotes(cwd=repo_dir)
-    except GitError:
+    except GitRunError:
         return False
 
 
@@ -122,7 +122,7 @@ def _ensure_additional_push_urls(
 
     try:
         existing = get_remote_push_urls("origin", cwd=repo_dir)
-    except GitError:
+    except GitRunError:
         existing = set()
 
     for url in sorted(desired - existing):

src/pkgmgr/actions/mirror/io.py

@@ -1,8 +1,9 @@
 from __future__ import annotations
 
 import os
+from collections.abc import Iterable, Mapping
+from typing import Union
 from urllib.parse import urlparse
-from typing import Mapping
 
 from .types import MirrorMap, Repository
 
@@ -32,7 +33,7 @@ def read_mirrors_file(repo_dir: str, filename: str = "MIRRORS") -> MirrorMap:
     """
     Supports:
         NAME URL
-        URL  → auto name = hostname
+        URL  -> auto-generate name from hostname
     """
     path = os.path.join(repo_dir, filename)
     mirrors: MirrorMap = {}
@@ -52,7 +53,8 @@ def read_mirrors_file(repo_dir: str, filename: str = "MIRRORS") -> MirrorMap:
                 # Case 1: "name url"
                 if len(parts) == 2:
                     name, url = parts
-                # Case 2: "url" → auto-generate name
+
+                # Case 2: "url" -> auto name
                 elif len(parts) == 1:
                     url = parts[0]
                     parsed = urlparse(url)
@@ -67,21 +69,56 @@ def read_mirrors_file(repo_dir: str, filename: str = "MIRRORS") -> MirrorMap:
                     continue
 
                 mirrors[name] = url
+
     except OSError as exc:
         print(f"[WARN] Could not read MIRRORS file at {path}: {exc}")
 
     return mirrors
 
 
+MirrorsInput = Union[Mapping[str, str], Iterable[str]]
+
+
 def write_mirrors_file(
     repo_dir: str,
-    mirrors: Mapping[str, str],
+    mirrors: MirrorsInput,
     filename: str = "MIRRORS",
     preview: bool = False,
 ) -> None:
+    """
+    Write MIRRORS in one of two formats:
 
+    1) Mapping[str, str] -> "NAME URL" per line (legacy / compatible)
+    2) Iterable[str]     -> "URL" per line (new preferred)
+
+    Strings are treated as a single URL (not iterated character-by-character).
+    """
     path = os.path.join(repo_dir, filename)
-    lines = [f"{name} {url}" for name, url in sorted(mirrors.items())]
+
+    lines: list[str]
+
+    if isinstance(mirrors, Mapping):
+        items = [
+            (str(name), str(url))
+            for name, url in mirrors.items()
+            if url is not None and str(url).strip()
+        ]
+        items.sort(key=lambda x: (x[0], x[1]))
+        lines = [f"{name} {url}" for name, url in items]
+
+    else:
+        if isinstance(mirrors, (str, bytes)):
+            urls = [str(mirrors).strip()]
+        else:
+            urls = [
+                str(url).strip()
+                for url in mirrors
+                if url is not None and str(url).strip()
+            ]
+
+        urls = sorted(set(urls))
+        lines = urls
+
     content = "\n".join(lines) + ("\n" if lines else "")
 
     if preview:
@@ -94,5 +131,6 @@ def write_mirrors_file(
         with open(path, "w", encoding="utf-8") as fh:
             fh.write(content)
         print(f"[INFO] Wrote MIRRORS file at {path}")
+
     except OSError as exc:
         print(f"[ERROR] Failed to write MIRRORS file at {path}: {exc}")

src/pkgmgr/actions/release/workflow.py

@@ -5,7 +5,7 @@ import sys
 from typing import Optional
 
 from pkgmgr.actions.branch import close_branch
-from pkgmgr.core.git import GitError
+from pkgmgr.core.git import GitRunError
 from pkgmgr.core.git.commands import add, commit, push, tag_annotated
 from pkgmgr.core.git.queries import get_current_branch
 from pkgmgr.core.repository.paths import resolve_repo_paths
@@ -40,7 +40,7 @@ def _release_impl(
     # Determine current branch early
     try:
         branch = get_current_branch() or "main"
-    except GitError:
+    except GitRunError:
         branch = "main"
     print(f"Releasing on branch: {branch}")
 
@@ -158,7 +158,7 @@ def _release_impl(
             update_latest_tag(new_tag, preview=False)
         else:
             print(f"[INFO] Skipping 'latest' update (tag {new_tag} is not the highest).")
-    except GitError as exc:
+    except GitRunError as exc:
         print(f"[WARN] Failed to update floating 'latest' tag for {new_tag}: {exc}")
         print("'latest' tag was not updated.")
 

src/pkgmgr/actions/repository/create/mirrors.py

@@ -12,8 +12,8 @@ class MirrorBootstrapper:
     """
     MIRRORS is the single source of truth.
 
-    We write defaults to MIRRORS and then call mirror setup which will
+    Defaults are written to MIRRORS and mirror setup derives
-    configure git remotes based on MIRRORS content (but only for git URLs).
+    git remotes exclusively from that file (git URLs only).
     """
 
     def write_defaults(
@@ -25,10 +25,8 @@ class MirrorBootstrapper:
         preview: bool,
     ) -> None:
         mirrors = {
-            # preferred SSH url is supplied by CreateRepoPlanner.primary_remote
+            primary,
-            "origin": primary,
+            f"https://pypi.org/project/{name}/",
-            # metadata only: must NEVER be configured as a git remote
-            "pypi": f"https://pypi.org/project/{name}/",
         }
         write_mirrors_file(repo_dir, mirrors, preview=preview)
 
@@ -41,7 +39,8 @@ class MirrorBootstrapper:
         preview: bool,
         remote: bool,
     ) -> None:
-        # IMPORTANT: do NOT set repo["mirrors"] here.
+        # IMPORTANT:
+        # Do NOT set repo["mirrors"] here.
         # MIRRORS file is the single source of truth.
         setup_mirrors(
             selected_repos=[repo],

src/pkgmgr/cli/commands/tools.py

@@ -1,64 +1,27 @@
 from __future__ import annotations
 
-import json 
-import os 
-
 from typing import Any, Dict, List
 
-from pkgmgr .cli .context import CLIContext 
+from pkgmgr.cli.context import CLIContext
-from pkgmgr .core .command .run import run_command 
+from pkgmgr.cli.tools import open_vscode_workspace
-from pkgmgr .core .repository .identifier import get_repo_identifier 
+from pkgmgr.cli.tools.paths import resolve_repository_path
-from pkgmgr .core .repository .dir import get_repo_dir 
+from pkgmgr.core.command.run import run_command
-
 
 Repository = Dict[str, Any]
 
 
-def _resolve_repository_path(repository: Repository, ctx: CLIContext) -> str:
-    """
-    Resolve the filesystem path for a repository.
-
-    Priority:
-      1. Use explicit keys if present (directory / path / workspace / workspace_dir).
-      2. Fallback to get_repo_dir(...) using the repositories base directory
-         from the CLI context.
-    """
-
-    # 1) Explicit path-like keys on the repository object
-    for key in ("directory", "path", "workspace", "workspace_dir"):
-        value = repository.get(key)
-        if value:
-            return value
-
-    # 2) Fallback: compute from base dir + repository metadata
-    base_dir = (
-        getattr(ctx, "repositories_base_dir", None)
-        or getattr(ctx, "repositories_dir", None)
-    )
-    if not base_dir:
-        raise RuntimeError(
-            "Cannot resolve repositories base directory from context; "
-            "expected ctx.repositories_base_dir or ctx.repositories_dir."
-        )
-
-    return get_repo_dir(base_dir, repository)
-
-
 def handle_tools_command(
     args,
     ctx: CLIContext,
     selected: List[Repository],
 ) -> None:
-
     # ------------------------------------------------------------------
     # nautilus "explore" command
     # ------------------------------------------------------------------
     if args.command == "explore":
         for repository in selected:
-            repo_path = _resolve_repository_path(repository, ctx)
+            repo_path = resolve_repository_path(repository, ctx)
-            run_command(
+            run_command(f'nautilus "{repo_path}" & disown')
-                f'nautilus "{repo_path}" & disown'
-            )
         return
 
     # ------------------------------------------------------------------
@@ -66,50 +29,13 @@ def handle_tools_command(
     # ------------------------------------------------------------------
     if args.command == "terminal":
         for repository in selected:
-            repo_path = _resolve_repository_path(repository, ctx)
+            repo_path = resolve_repository_path(repository, ctx)
-            run_command(
+            run_command(f'gnome-terminal --tab --working-directory="{repo_path}"')
-                f'gnome-terminal --tab --working-directory="{repo_path}"'
-            )
         return
 
     # ------------------------------------------------------------------
     # VS Code workspace command
     # ------------------------------------------------------------------
     if args.command == "code":
-        if not selected:
+        open_vscode_workspace(ctx, selected)
-            print("No repositories selected.")
-            return 
-
-        identifiers = [
-            get_repo_identifier(repo, ctx.all_repositories)
-            for repo in selected
-        ]
-        sorted_identifiers = sorted(identifiers)
-        workspace_name = "_".join(sorted_identifiers) + ".code-workspace"
-
-        directories_cfg = ctx.config_merged.get("directories") or {}
-        workspaces_dir = os.path.expanduser(
-            directories_cfg.get("workspaces", "~/Workspaces")
-        )
-        os.makedirs(workspaces_dir, exist_ok=True)
-        workspace_file = os.path.join(workspaces_dir, workspace_name)
-
-        folders = [
-            {"path": _resolve_repository_path(repository, ctx)}
-            for repository in selected
-        ]
-
-        workspace_data = {
-            "folders": folders,
-            "settings": {},
-        }
-
-        if not os.path.exists(workspace_file):
-            with open(workspace_file, "w", encoding="utf-8") as f:
-                json.dump(workspace_data, f, indent=4)
-            print(f"Created workspace file: {workspace_file}")
-        else:
-            print(f"Using existing workspace file: {workspace_file}")
-
-        run_command(f'code "{workspace_file}"')
         return

src/pkgmgr/cli/tools/__init__.py

@@ -0,0 +1,5 @@
+from __future__ import annotations
+
+from .vscode import open_vscode_workspace
+
+__all__ = ["open_vscode_workspace"]

src/pkgmgr/cli/tools/paths.py

@@ -0,0 +1,35 @@
+from __future__ import annotations
+
+from typing import Any, Dict
+
+from pkgmgr.cli.context import CLIContext
+from pkgmgr.core.repository.dir import get_repo_dir
+
+Repository = Dict[str, Any]
+
+
+def resolve_repository_path(repository: Repository, ctx: CLIContext) -> str:
+    """
+    Resolve the filesystem path for a repository.
+
+    Priority:
+      1. Use explicit keys if present (directory / path / workspace / workspace_dir).
+      2. Fallback to get_repo_dir(...) using the repositories base directory
+         from the CLI context.
+    """
+    for key in ("directory", "path", "workspace", "workspace_dir"):
+        value = repository.get(key)
+        if value:
+            return value
+
+    base_dir = (
+        getattr(ctx, "repositories_base_dir", None)
+        or getattr(ctx, "repositories_dir", None)
+    )
+    if not base_dir:
+        raise RuntimeError(
+            "Cannot resolve repositories base directory from context; "
+            "expected ctx.repositories_base_dir or ctx.repositories_dir."
+        )
+
+    return get_repo_dir(base_dir, repository)

src/pkgmgr/cli/tools/vscode.py

@@ -0,0 +1,102 @@
+from __future__ import annotations
+
+import json
+import os
+import shutil
+from typing import Any, Dict, List
+
+from pkgmgr.cli.context import CLIContext
+from pkgmgr.cli.tools.paths import resolve_repository_path
+from pkgmgr.core.command.run import run_command
+from pkgmgr.core.repository.identifier import get_repo_identifier
+
+Repository = Dict[str, Any]
+
+
+def _ensure_vscode_cli_available() -> None:
+    """
+    Ensure that the VS Code CLI ('code') is available in PATH.
+    """
+    if shutil.which("code") is None:
+        raise RuntimeError(
+            "VS Code CLI ('code') not found in PATH.\n\n"
+            "Hint:\n"
+            "  Install Visual Studio Code and ensure the 'code' command is available.\n"
+            "  VS Code → Command Palette → 'Shell Command: Install code command in PATH'\n"
+        )
+
+
+def _ensure_identifiers_are_filename_safe(identifiers: List[str]) -> None:
+    """
+    Ensure identifiers can be used in a filename.
+
+    If an identifier contains '/', it likely means the repository has not yet
+    been explicitly identified (no short identifier configured).
+    """
+    invalid = [i for i in identifiers if "/" in i or os.sep in i]
+    if invalid:
+        raise RuntimeError(
+            "Cannot create VS Code workspace.\n\n"
+            "The following repositories are not yet identified "
+            "(identifier contains '/'): \n"
+            + "\n".join(f"  - {i}" for i in invalid)
+            + "\n\n"
+            "Hint:\n"
+            "  The repository has no short identifier yet.\n"
+            "  Add an explicit identifier in your configuration before using `pkgmgr tools code`.\n"
+        )
+
+
+def _resolve_workspaces_dir(ctx: CLIContext) -> str:
+    directories_cfg = ctx.config_merged.get("directories") or {}
+    return os.path.expanduser(directories_cfg.get("workspaces", "~/Workspaces"))
+
+
+def _build_workspace_filename(identifiers: List[str]) -> str:
+    sorted_identifiers = sorted(identifiers)
+    return "_".join(sorted_identifiers) + ".code-workspace"
+
+
+def _build_workspace_data(selected: List[Repository], ctx: CLIContext) -> Dict[str, Any]:
+    folders = [{"path": resolve_repository_path(repo, ctx)} for repo in selected]
+    return {
+        "folders": folders,
+        "settings": {},
+    }
+
+
+def open_vscode_workspace(ctx: CLIContext, selected: List[Repository]) -> None:
+    """
+    Create (if missing) and open a VS Code workspace for the selected repositories.
+
+    Policy:
+      - Fail with a clear error if VS Code CLI is missing.
+      - Fail with a clear error if any repository identifier contains '/', because that
+        indicates the repo has not been explicitly identified (no short identifier).
+      - Do NOT auto-sanitize identifiers and do NOT create subfolders under workspaces.
+    """
+    if not selected:
+        print("No repositories selected.")
+        return
+
+    _ensure_vscode_cli_available()
+
+    identifiers = [get_repo_identifier(repo, ctx.all_repositories) for repo in selected]
+    _ensure_identifiers_are_filename_safe(identifiers)
+
+    workspaces_dir = _resolve_workspaces_dir(ctx)
+    os.makedirs(workspaces_dir, exist_ok=True)
+
+    workspace_name = _build_workspace_filename(identifiers)
+    workspace_file = os.path.join(workspaces_dir, workspace_name)
+
+    workspace_data = _build_workspace_data(selected, ctx)
+
+    if not os.path.exists(workspace_file):
+        with open(workspace_file, "w", encoding="utf-8") as f:
+            json.dump(workspace_data, f, indent=4)
+        print(f"Created workspace file: {workspace_file}")
+    else:
+        print(f"Using existing workspace file: {workspace_file}")
+
+    run_command(f'code "{workspace_file}"')

src/pkgmgr/core/git/__init__.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from .errors import GitError
+from .errors import GitRunError
 from .run import run
 
 """
@@ -12,6 +12,6 @@ details of subprocess handling.
 """
 
 __all__ = [
-    "GitError",
+    "GitRunError",
     "run",
 ]

src/pkgmgr/core/git/commands/__init__.py

@@ -16,7 +16,7 @@ from .fetch import GitFetchError, fetch
 from .init import GitInitError, init
 from .merge_no_ff import GitMergeError, merge_no_ff
 from .pull import GitPullError, pull
-from .pull_args import GitPullArgsError, pull_args  # <-- add
+from .pull_args import GitPullArgsError, pull_args
 from .pull_ff_only import GitPullFfOnlyError, pull_ff_only
 from .push import GitPushError, push
 from .push_upstream import GitPushUpstreamError, push_upstream
@@ -30,7 +30,7 @@ __all__ = [
     "fetch",
     "checkout",
     "pull",
-    "pull_args",  # <-- add
+    "pull_args",
     "pull_ff_only",
     "merge_no_ff",
     "push",
@@ -52,7 +52,7 @@ __all__ = [
     "GitFetchError",
     "GitCheckoutError",
     "GitPullError",
-    "GitPullArgsError",  # <-- add
+    "GitPullArgsError",
     "GitPullFfOnlyError",
     "GitMergeError",
     "GitPushError",

src/pkgmgr/core/git/commands/add.py

@@ -2,7 +2,7 @@ from __future__ import annotations
 
 from typing import Iterable, List, Sequence, Union
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -37,7 +37,7 @@ def add(
 
     try:
         run(["add", *normalized], cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitAddError(
             f"Failed to add paths to staging area: {normalized!r}.",
             cwd=cwd,

src/pkgmgr/core/git/commands/add_all.py

@@ -1,7 +1,6 @@
-# src/pkgmgr/core/git/commands/add_all.py
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitCommandError, GitRunError
 from ..run import run
 
 
@@ -18,5 +17,5 @@ def add_all(*, cwd: str = ".", preview: bool = False) -> None:
     """
     try:
         run(["add", "-A"], cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitAddAllError("Failed to stage all changes with `git add -A`.", cwd=cwd) from exc

src/pkgmgr/core/git/commands/add_remote.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -27,7 +27,7 @@ def add_remote(
             cwd=cwd,
             preview=preview,
         )
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitAddRemoteError(
             f"Failed to add remote {name!r} with URL {url!r}.",
             cwd=cwd,

src/pkgmgr/core/git/commands/add_remote_push_url.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -27,7 +27,7 @@ def add_remote_push_url(
             cwd=cwd,
             preview=preview,
         )
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitAddRemotePushUrlError(
             f"Failed to add push url {url!r} to remote {remote!r}.",
             cwd=cwd,

src/pkgmgr/core/git/commands/branch_move.py

@@ -1,7 +1,6 @@
-# src/pkgmgr/core/git/commands/branch_move.py
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -18,5 +17,5 @@ def branch_move(branch: str, *, cwd: str = ".", preview: bool = False) -> None:
     """
     try:
         run(["branch", "-M", branch], cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitBranchMoveError(f"Failed to move/rename current branch to {branch!r}.", cwd=cwd) from exc

src/pkgmgr/core/git/commands/checkout.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -11,7 +11,7 @@ class GitCheckoutError(GitCommandError):
 def checkout(branch: str, cwd: str = ".") -> None:
     try:
         run(["checkout", branch], cwd=cwd)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitCheckoutError(
             f"Failed to checkout branch {branch!r}.",
             cwd=cwd,

src/pkgmgr/core/git/commands/clone.py

@@ -2,7 +2,7 @@ from __future__ import annotations
 
 from typing import List
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -25,7 +25,7 @@ def clone(
     """
     try:
         run(["clone", *args], cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitCloneError(
             f"Git clone failed with args={args!r}.",
             cwd=cwd,

src/pkgmgr/core/git/commands/commit.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -30,7 +30,7 @@ def commit(
 
     try:
         run(args, cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitCommitError(
             "Failed to create commit.",
             cwd=cwd,

src/pkgmgr/core/git/commands/create_branch.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -16,7 +16,7 @@ def create_branch(branch: str, base: str, cwd: str = ".") -> None:
     """
     try:
         run(["checkout", "-b", branch, base], cwd=cwd)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitCreateBranchError(
             f"Failed to create branch {branch!r} from base {base!r}.",
             cwd=cwd,

src/pkgmgr/core/git/commands/delete_local_branch.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -12,7 +12,7 @@ def delete_local_branch(branch: str, cwd: str = ".", force: bool = False) -> Non
     flag = "-D" if force else "-d"
     try:
         run(["branch", flag, branch], cwd=cwd)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitDeleteLocalBranchError(
             f"Failed to delete local branch {branch!r} (flag {flag}).",
             cwd=cwd,

src/pkgmgr/core/git/commands/delete_remote_branch.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -11,7 +11,7 @@ class GitDeleteRemoteBranchError(GitCommandError):
 def delete_remote_branch(remote: str, branch: str, cwd: str = ".") -> None:
     try:
         run(["push", remote, "--delete", branch], cwd=cwd)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitDeleteRemoteBranchError(
             f"Failed to delete remote branch {branch!r} on {remote!r}.",
             cwd=cwd,

src/pkgmgr/core/git/commands/fetch.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -33,7 +33,7 @@ def fetch(
 
     try:
         run(args, cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitFetchError(
             f"Failed to fetch from remote {remote!r}.",
             cwd=cwd,

src/pkgmgr/core/git/commands/init.py

@@ -1,7 +1,6 @@
-# src/pkgmgr/core/git/commands/init.py
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -18,5 +17,5 @@ def init(*, cwd: str = ".", preview: bool = False) -> None:
     """
     try:
         run(["init"], cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitInitError("Failed to initialize git repository.", cwd=cwd) from exc

src/pkgmgr/core/git/commands/merge_no_ff.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -11,7 +11,7 @@ class GitMergeError(GitCommandError):
 def merge_no_ff(branch: str, cwd: str = ".") -> None:
     try:
         run(["merge", "--no-ff", branch], cwd=cwd)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitMergeError(
             f"Failed to merge branch {branch!r} with --no-ff.",
             cwd=cwd,

src/pkgmgr/core/git/commands/pull.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -11,7 +11,7 @@ class GitPullError(GitCommandError):
 def pull(remote: str, branch: str, cwd: str = ".") -> None:
     try:
         run(["pull", remote, branch], cwd=cwd)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitPullError(
             f"Failed to pull {remote!r}/{branch!r}.",
             cwd=cwd,

src/pkgmgr/core/git/commands/pull_args.py

@@ -2,7 +2,7 @@ from __future__ import annotations
 
 from typing import List
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -28,7 +28,7 @@ def pull_args(
     extra = args or []
     try:
         run(["pull", *extra], cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitPullArgsError(
             f"Failed to run `git pull` with args={extra!r}.",
             cwd=cwd,

src/pkgmgr/core/git/commands/pull_ff_only.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -17,7 +17,7 @@ def pull_ff_only(*, cwd: str = ".", preview: bool = False) -> None:
     """
     try:
         run(["pull", "--ff-only"], cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitPullFfOnlyError(
             "Failed to pull with --ff-only.",
             cwd=cwd,

src/pkgmgr/core/git/commands/push.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -28,7 +28,7 @@ def push(
 
     try:
         run(args, cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitPushError(
             f"Failed to push ref {ref!r} to remote {remote!r}.",
             cwd=cwd,

src/pkgmgr/core/git/commands/push_upstream.py

@@ -1,7 +1,6 @@
-# src/pkgmgr/core/git/commands/push_upstream.py
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -24,7 +23,7 @@ def push_upstream(
     """
     try:
         run(["push", "-u", remote, branch], cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitPushUpstreamError(
             f"Failed to push branch {branch!r} to {remote!r} with upstream tracking.",
             cwd=cwd,

src/pkgmgr/core/git/commands/set_remote_url.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -35,7 +35,7 @@ def set_remote_url(
             cwd=cwd,
             preview=preview,
         )
-    except GitError as exc:
+    except GitRunError as exc:
         mode = "push" if push else "fetch"
         raise GitSetRemoteUrlError(
             f"Failed to set {mode} url for remote {remote!r} to {url!r}.",

src/pkgmgr/core/git/commands/tag_annotated.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -23,7 +23,7 @@ def tag_annotated(
     """
     try:
         run(["tag", "-a", tag, "-m", message], cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitTagAnnotatedError(
             f"Failed to create annotated tag {tag!r}.",
             cwd=cwd,

src/pkgmgr/core/git/commands/tag_force_annotated.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError, GitCommandError
+from ..errors import GitRunError, GitCommandError
 from ..run import run
 
 
@@ -24,7 +24,7 @@ def tag_force_annotated(
     """
     try:
         run(["tag", "-f", "-a", name, target, "-m", message], cwd=cwd, preview=preview)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitTagForceAnnotatedError(
             f"Failed to force annotated tag {name!r} at {target!r}.",
             cwd=cwd,

src/pkgmgr/core/git/errors.py

@@ -1,11 +1,19 @@
 from __future__ import annotations
 
 
-class GitError(RuntimeError):
+class GitBaseError(RuntimeError):
     """Base error raised for Git related failures."""
 
+class GitRunError(GitBaseError):
+    """Base error raised for Git related failures."""
 
-class GitCommandError(GitError):
+class GitNotRepositoryError(GitBaseError):
+    """Raised when the current working directory is not a git repository."""
+
+class GitQueryError(GitRunError):
+    """Base class for read-only git query failures."""
+
+class GitCommandError(GitRunError):
     """
     Base class for state-changing git command failures.
 
@@ -13,4 +21,5 @@ class GitCommandError(GitError):
     """
     def __init__(self, message: str, *, cwd: str = ".") -> None:
         super().__init__(message)
-        self.cwd = cwd
+        if cwd in locals():
+            self.cwd = cwd

src/pkgmgr/core/git/queries/__init__.py

@@ -1,24 +1,36 @@
 from __future__ import annotations
 
+from .get_changelog import GitChangelogQueryError, get_changelog
+from .get_config_value import get_config_value
 from .get_current_branch import get_current_branch
 from .get_head_commit import get_head_commit
 from .get_latest_commit import get_latest_commit
-from .get_tags import get_tags
+from .get_latest_signing_key import (
-from .resolve_base_branch import GitBaseBranchNotFoundError, resolve_base_branch
+    GitLatestSigningKeyQueryError,
-from .list_remotes import list_remotes
+    get_latest_signing_key,
+)
+from .get_remote_head_commit import (
+    GitRemoteHeadCommitQueryError,
+    get_remote_head_commit,
+)
 from .get_remote_push_urls import get_remote_push_urls
-from .probe_remote_reachable import probe_remote_reachable
-from .get_changelog import get_changelog, GitChangelogQueryError
-from .get_tags_at_ref import get_tags_at_ref, GitTagsAtRefQueryError
-from .get_config_value import get_config_value
-from .get_upstream_ref import get_upstream_ref
-from .list_tags import list_tags
 from .get_repo_root import get_repo_root
+from .get_tags import get_tags
+from .get_tags_at_ref import GitTagsAtRefQueryError, get_tags_at_ref
+from .get_upstream_ref import get_upstream_ref
+from .list_remotes import list_remotes
+from .list_tags import list_tags
+from .probe_remote_reachable import probe_remote_reachable
+from .resolve_base_branch import GitBaseBranchNotFoundError, resolve_base_branch
 
 __all__ = [
     "get_current_branch",
     "get_head_commit",
     "get_latest_commit",
+    "get_latest_signing_key",
+    "GitLatestSigningKeyQueryError",
+    "get_remote_head_commit",
+    "GitRemoteHeadCommitQueryError",
     "get_tags",
     "resolve_base_branch",
     "GitBaseBranchNotFoundError",

src/pkgmgr/core/git/queries/get_changelog.py

@@ -2,11 +2,11 @@ from __future__ import annotations
 
 from typing import Optional
 
-from ..errors import GitError
+from ..errors import GitQueryError, GitRunError
 from ..run import run
 
 
-class GitChangelogQueryError(GitError):
+class GitChangelogQueryError(GitQueryError):
     """Raised when querying the git changelog fails."""
 
 
@@ -38,7 +38,7 @@ def get_changelog(
 
     try:
         return run(cmd, cwd=cwd)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitChangelogQueryError(
             f"Failed to query changelog for range {rev_range!r}.",
         ) from exc

src/pkgmgr/core/git/queries/get_config_value.py

@@ -2,11 +2,11 @@ from __future__ import annotations
 
 from typing import Optional
 
-from ..errors import GitError
+from ..errors import GitRunError
 from ..run import run
 
 
-def _is_missing_key_error(exc: GitError) -> bool:
+def _is_missing_key_error(exc: GitRunError) -> bool:
     msg = str(exc).lower()
 
     # Ensure we only swallow the expected case for THIS command.
@@ -25,7 +25,7 @@ def get_config_value(key: str, *, cwd: str = ".") -> Optional[str]:
     """
     try:
         output = run(["config", "--get", key], cwd=cwd)
-    except GitError as exc:
+    except GitRunError as exc:
         if _is_missing_key_error(exc):
             return None
         raise

src/pkgmgr/core/git/queries/get_current_branch.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 from typing import Optional
-from ..errors import GitError
+from ..errors import GitRunError
 from ..run import run
 
 
@@ -13,6 +13,6 @@ def get_current_branch(cwd: str = ".") -> Optional[str]:
     """
     try:
         output = run(["rev-parse", "--abbrev-ref", "HEAD"], cwd=cwd)
-    except GitError:
+    except GitRunError:
         return None
     return output or None

src/pkgmgr/core/git/queries/get_head_commit.py

@@ -2,7 +2,7 @@ from __future__ import annotations
 
 from typing import Optional
 
-from ..errors import GitError
+from ..errors import GitRunError
 from ..run import run
 
 
@@ -12,6 +12,6 @@ def get_head_commit(cwd: str = ".") -> Optional[str]:
     """
     try:
         output = run(["rev-parse", "HEAD"], cwd=cwd)
-    except GitError:
+    except GitRunError:
         return None
     return output or None

src/pkgmgr/core/git/queries/get_latest_commit.py

@@ -2,7 +2,7 @@ from __future__ import annotations
 
 from typing import Optional
 
-from ..errors import GitError
+from ..errors import GitRunError
 from ..run import run
 
 
@@ -19,7 +19,7 @@ def get_latest_commit(cwd: str = ".") -> Optional[str]:
     """
     try:
         output = run(["log", "-1", "--format=%H"], cwd=cwd)
-    except GitError:
+    except GitRunError:
         return None
 
     output = output.strip()

src/pkgmgr/core/git/queries/get_latest_signing_key.py

@@ -0,0 +1,25 @@
+from __future__ import annotations
+
+from ..errors import GitQueryError, GitRunError
+from ..run import run
+
+
+class GitLatestSigningKeyQueryError(GitQueryError):
+    """Raised when querying the latest commit signing key fails."""
+
+
+def get_latest_signing_key(*, cwd: str = ".") -> str:
+    """
+    Return the GPG signing key ID of the latest commit, via:
+
+      git log -1 --format=%GK
+
+    Returns:
+      The key id string (may be empty if commit is not signed).
+    """
+    try:
+        return run(["log", "-1", "--format=%GK"], cwd=cwd).strip()
+    except GitRunError as exc:
+        raise GitLatestSigningKeyQueryError(
+            "Failed to query latest signing key.",
+        ) from exc

src/pkgmgr/core/git/queries/get_remote_head_commit.py

@@ -0,0 +1,33 @@
+from __future__ import annotations
+
+from ..errors import GitQueryError, GitRunError
+from ..run import run
+
+
+class GitRemoteHeadCommitQueryError(GitQueryError):
+    """Raised when querying the remote HEAD commit fails."""
+
+
+def get_remote_head_commit(
+    *,
+    remote: str = "origin",
+    ref: str = "HEAD",
+    cwd: str = ".",
+) -> str:
+    """
+    Return the commit hash for <remote> <ref> via:
+
+      git ls-remote <remote> <ref>
+
+    Returns:
+      The commit hash string (may be empty if remote/ref yields no output).
+    """
+    try:
+        out = run(["ls-remote", remote, ref], cwd=cwd).strip()
+    except GitRunError as exc:
+        raise GitRemoteHeadCommitQueryError(
+            f"Failed to query remote head commit for {remote!r} {ref!r}.",
+        ) from exc
+
+    # minimal parsing: first token is the hash
+    return (out.split()[0].strip() if out else "")

src/pkgmgr/core/git/queries/get_remote_push_urls.py

@@ -4,7 +4,6 @@ from typing import Set
 
 from ..run import run
 
-
 def get_remote_push_urls(remote: str, cwd: str = ".") -> Set[str]:
     """
     Return all push URLs configured for a remote.
@@ -12,7 +11,7 @@ def get_remote_push_urls(remote: str, cwd: str = ".") -> Set[str]:
     Equivalent to:
       git remote get-url --push --all <remote>
 
-    Raises GitError if the command fails.
+    Raises GitBaseError if the command fails.
     """
     output = run(["remote", "get-url", "--push", "--all", remote], cwd=cwd)
     if not output:

src/pkgmgr/core/git/queries/get_repo_root.py

@@ -1,9 +1,8 @@
-# src/pkgmgr/core/git/queries/get_repo_root.py
 from __future__ import annotations
 
 from typing import Optional
 
-from ..errors import GitError
+from ..errors import GitRunError
 from ..run import run
 
 
@@ -16,7 +15,7 @@ def get_repo_root(*, cwd: str = ".") -> Optional[str]:
     """
     try:
         out = run(["rev-parse", "--show-toplevel"], cwd=cwd)
-    except GitError:
+    except GitRunError:
         return None
 
     out = out.strip()

src/pkgmgr/core/git/queries/get_tags.py

@@ -2,7 +2,7 @@ from __future__ import annotations
 
 from typing import List
 
-from ..errors import GitError
+from ..errors import GitRunError
 from ..run import run
 
 
@@ -14,11 +14,10 @@ def get_tags(cwd: str = ".") -> List[str]:
     """
     try:
         output = run(["tag"], cwd=cwd)
-    except GitError as exc:
+    except GitRunError as exc:
         # If the repo is not a git repo, surface a clear error.
         if "not a git repository" in str(exc):
             raise
-        # Otherwise, treat as "no tags" (e.g., empty stdout).
         return []
 
     if not output:

src/pkgmgr/core/git/queries/get_tags_at_ref.py

@@ -2,11 +2,11 @@ from __future__ import annotations
 
 from typing import List
 
-from ..errors import GitError
+from ..errors import GitQueryError, GitRunError
 from ..run import run
 
 
-class GitTagsAtRefQueryError(GitError):
+class GitTagsAtRefQueryError(GitQueryError):
     """Raised when querying tags for a ref fails."""
 
 
@@ -19,7 +19,7 @@ def get_tags_at_ref(ref: str, *, cwd: str = ".") -> List[str]:
     """
     try:
         output = run(["tag", "--points-at", ref], cwd=cwd)
-    except GitError as exc:
+    except GitRunError as exc:
         raise GitTagsAtRefQueryError(
             f"Failed to query tags at ref {ref!r}.",
         ) from exc

src/pkgmgr/core/git/queries/get_upstream_ref.py

@@ -2,7 +2,7 @@ from __future__ import annotations
 
 from typing import Optional
 
-from ..errors import GitError
+from ..errors import GitRunError
 from ..run import run
 
 
@@ -18,7 +18,7 @@ def get_upstream_ref(*, cwd: str = ".") -> Optional[str]:
             ["rev-parse", "--abbrev-ref", "--symbolic-full-name", "@{u}"],
             cwd=cwd,
         )
-    except GitError:
+    except GitRunError:
         return None
 
     out = out.strip()

src/pkgmgr/core/git/queries/list_remotes.py

@@ -9,7 +9,7 @@ def list_remotes(cwd: str = ".") -> List[str]:
     """
     Return a list of configured git remotes (e.g. ['origin', 'upstream']).
 
-    Raises GitError if the command fails.
+    Raises GitBaseError if the command fails.
     """
     output = run(["remote"], cwd=cwd)
     if not output:

src/pkgmgr/core/git/queries/probe_remote_reachable.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from ..errors import GitError
+from ..errors import GitRunError
 from ..run import run
 
 
@@ -17,5 +17,5 @@ def probe_remote_reachable(url: str, cwd: str = ".") -> bool:
     try:
         run(["ls-remote", "--exit-code", url], cwd=cwd)
         return True
-    except GitError:
+    except GitRunError:
         return False

src/pkgmgr/core/git/queries/resolve_base_branch.py

@@ -1,15 +1,14 @@
-# src/pkgmgr/core/git/queries/resolve_base_branch.py
 from __future__ import annotations
 
-from ..errors import GitError
+from ..errors import GitQueryError, GitRunError
 from ..run import run
 
 
-class GitBaseBranchNotFoundError(GitError):
+class GitBaseBranchNotFoundError(GitQueryError):
     """Raised when neither preferred nor fallback base branch exists."""
 
 
-def _is_branch_missing_error(exc: GitError) -> bool:
+def _is_branch_missing_error(exc: GitRunError) -> bool:
     """
     Heuristic: Detect errors that indicate the branch/ref does not exist.
 
@@ -46,15 +45,15 @@ def resolve_base_branch(
     fall back to `fallback` (default: master).
 
     Raises GitBaseBranchNotFoundError if neither exists.
-    Raises GitError for other git failures (e.g., not a git repository).
+    Raises GitRunError for other git failures (e.g., not a git repository).
     """
-    last_missing_error: GitError | None = None
+    last_missing_error: GitRunError | None = None
 
     for candidate in (preferred, fallback):
         try:
             run(["rev-parse", "--verify", candidate], cwd=cwd)
             return candidate
-        except GitError as exc:
+        except GitRunError as exc:
             if _is_branch_missing_error(exc):
                 last_missing_error = exc
                 continue

src/pkgmgr/core/git/run.py

@@ -3,7 +3,12 @@ from __future__ import annotations
 import subprocess
 from typing import List
 
-from .errors import GitError
+from .errors import GitRunError, GitNotRepositoryError
+
+
+def _is_not_repo_error(stderr: str) -> bool:
+    msg = (stderr or "").lower()
+    return "not a git repository" in msg
 
 
 def run(
@@ -17,7 +22,7 @@ def run(
 
     If preview=True, the command is printed but NOT executed.
 
-    Raises GitError if execution fails.
+    Raises GitRunError (or a subclass) if execution fails.
     """
     cmd = ["git"] + args
     cmd_str = " ".join(cmd)
@@ -36,11 +41,19 @@ def run(
             text=True,
         )
     except subprocess.CalledProcessError as exc:
-        raise GitError(
+        stderr = exc.stderr or ""
+        if _is_not_repo_error(stderr):
+            raise GitNotRepositoryError(
+                f"Not a git repository: {cwd!r}\n"
+                f"Command: {cmd_str}\n"
+                f"STDERR:\n{stderr}"
+            ) from exc
+
+        raise GitRunError(
             f"Git command failed in {cwd!r}: {cmd_str}\n"
             f"Exit code: {exc.returncode}\n"
             f"STDOUT:\n{exc.stdout}\n"
-            f"STDERR:\n{exc.stderr}"
+            f"STDERR:\n{stderr}"
         ) from exc
 
     return result.stdout.strip()

src/pkgmgr/core/repository/verify.py

@@ -1,48 +1,37 @@
-import subprocess
+from __future__ import annotations
+
+from pkgmgr.core.git.queries import (
+    get_head_commit,
+    get_latest_signing_key,
+    get_remote_head_commit,
+    GitLatestSigningKeyQueryError,
+    GitRemoteHeadCommitQueryError,
+)
+
 
 def verify_repository(repo, repo_dir, mode="local", no_verification=False):
-    """
+    _ = no_verification
-    Verifies the repository based on its 'verified' field.
 
-    The 'verified' field can be a dictionary with the following keys:
-      commit:   The expected commit hash.
-      gpg_keys: A list of valid GPG key IDs (at least one must match the signing key).
-
-    If mode == "pull", the remote HEAD commit is checked via "git ls-remote origin HEAD".
-    Otherwise (mode "local", used for install and clone), the local HEAD commit is checked via "git rev-parse HEAD".
-
-    Returns a tuple:
-      (verified_ok, error_details, commit_hash, signing_key)
-        - verified_ok: True if the verification passed (or no verification info is set), False otherwise.
-        - error_details: A list of error messages for any failed checks.
-        - commit_hash: The obtained commit hash.
-        - signing_key: The GPG key ID that signed the latest commit (obtained via "git log -1 --format=%GK").
-    """
     verified_info = repo.get("verified")
-    if not verified_info:
+
-        # Nothing to verify.
+    commit_hash = ""
-        commit_hash = ""
+    signing_key = ""
-        signing_key = ""
+
+    # best-effort info collection
+    try:
         if mode == "pull":
-            try:
+            commit_hash = get_remote_head_commit(cwd=repo_dir)
-                result = subprocess.run("git ls-remote origin HEAD", cwd=repo_dir, shell=True, check=True,
-                                          stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
-                commit_hash = result.stdout.split()[0].strip()
-            except Exception:
-                commit_hash = ""
         else:
-            try:
+            commit_hash = get_head_commit(cwd=repo_dir) or ""
-                result = subprocess.run("git rev-parse HEAD", cwd=repo_dir, shell=True, check=True,
+    except GitRemoteHeadCommitQueryError:
-                                          stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
+        commit_hash = ""
-                commit_hash = result.stdout.strip()
+
-            except Exception:
+    try:
-                commit_hash = ""
+        signing_key = get_latest_signing_key(cwd=repo_dir)
-        try:
+    except GitLatestSigningKeyQueryError:
-            result = subprocess.run(["git", "log", "-1", "--format=%GK"], cwd=repo_dir, shell=False, check=True,
+        signing_key = ""
-                                      stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
+
-            signing_key = result.stdout.strip()
+    if not verified_info:
-        except Exception:
-            signing_key = ""
         return True, [], commit_hash, signing_key
 
     expected_commit = None
@@ -51,47 +40,42 @@ def verify_repository(repo, repo_dir, mode="local", no_verification=False):
         expected_commit = verified_info.get("commit")
         expected_gpg_keys = verified_info.get("gpg_keys")
     else:
-        # If verified is a plain string, treat it as the expected commit.
         expected_commit = verified_info
 
-    error_details = []
+    error_details: list[str] = []
 
-    # Get commit hash according to the mode.
+    # strict retrieval when verification is configured
-    commit_hash = ""
     if mode == "pull":
         try:
-            result = subprocess.run("git ls-remote origin HEAD", cwd=repo_dir, shell=True, check=True,
+            commit_hash = get_remote_head_commit(cwd=repo_dir)
-                                      stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
+        except GitRemoteHeadCommitQueryError as exc:
-            commit_hash = result.stdout.split()[0].strip()
+            error_details.append(str(exc))
-        except Exception as e:
+            commit_hash = ""
-            error_details.append(f"Error retrieving remote commit: {e}")
     else:
-        try:
+        commit_hash = get_head_commit(cwd=repo_dir) or ""
-            result = subprocess.run("git rev-parse HEAD", cwd=repo_dir, shell=True, check=True,
-                                      stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
-            commit_hash = result.stdout.strip()
-        except Exception as e:
-            error_details.append(f"Error retrieving local commit: {e}")
 
-    # Get the signing key using "git log -1 --format=%GK"
-    signing_key = ""
     try:
-        result = subprocess.run(["git", "log", "-1", "--format=%GK"], cwd=repo_dir, shell=False, check=True,
+        signing_key = get_latest_signing_key(cwd=repo_dir)
-                                  stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True)
+    except GitLatestSigningKeyQueryError as exc:
-        signing_key = result.stdout.strip()
+        error_details.append(str(exc))
-    except Exception as e:
+        signing_key = ""
-        error_details.append(f"Error retrieving signing key: {e}")
 
     commit_check_passed = True
     gpg_check_passed = True
 
     if expected_commit:
-        if commit_hash != expected_commit:
+        if not commit_hash:
+            commit_check_passed = False
+            error_details.append(f"Expected commit: {expected_commit}, but could not determine current commit.")
+        elif commit_hash != expected_commit:
             commit_check_passed = False
             error_details.append(f"Expected commit: {expected_commit}, found: {commit_hash}")
 
     if expected_gpg_keys:
-        if signing_key not in expected_gpg_keys:
+        if not signing_key:
+            gpg_check_passed = False
+            error_details.append(f"Expected one of GPG keys: {expected_gpg_keys}, but no signing key was found.")
+        elif signing_key not in expected_gpg_keys:
             gpg_check_passed = False
             error_details.append(f"Expected one of GPG keys: {expected_gpg_keys}, found: {signing_key}")
 

tests/e2e/test_changelog_commands.py

@@ -89,7 +89,7 @@ class TestIntegrationChangelogCommands(unittest.TestCase):
         """
         Run 'pkgmgr changelog HEAD~5..HEAD' inside the pkgmgr repo.
         Selbst wenn HEAD~5 nicht existiert, sollte der Befehl den
-        GitError intern behandeln und mit Exit-Code 0 beenden
+        GitBaseError intern behandeln und mit Exit-Code 0 beenden
         (es wird dann eine [ERROR]-Zeile gedruckt).
 
         Wird übersprungen, wenn das pkgmgr-Repo nicht lokal vorhanden ist.

tests/integration/test_repos_create_pypi_not_in_git_config.py

@@ -75,12 +75,12 @@ class TestCreateRepoPypiNotInGitConfig(unittest.TestCase):
 
             mirrors_content = mirrors_file.read_text(encoding="utf-8")
             self.assertIn(
-                "pypi https://pypi.org/project/repo/",
+                "https://pypi.org/project/repo/",
                 mirrors_content,
                 "PyPI mirror entry must exist in MIRRORS",
             )
             self.assertIn(
-                "origin git@github.com:acme/repo.git",
+                "git@github.com:acme/repo.git",
                 mirrors_content,
                 "origin SSH URL must exist in MIRRORS",
             )

tests/unit/pkgmgr/actions/branch/test_close_branch.py

@@ -2,7 +2,7 @@ import unittest
 from unittest.mock import patch
 
 from pkgmgr.actions.branch.close_branch import close_branch
-from pkgmgr.core.git.errors import GitError
+from pkgmgr.core.git.errors import GitRunError
 from pkgmgr.core.git.commands import GitDeleteRemoteBranchError
 
 
@@ -90,7 +90,7 @@ class TestCloseBranch(unittest.TestCase):
         delete_local_branch.assert_called_once_with("feature-x", cwd=".", force=False)
         delete_remote_branch.assert_called_once_with("origin", "feature-x", cwd=".")
 
-    @patch("pkgmgr.actions.branch.close_branch.get_current_branch", side_effect=GitError("fail"))
+    @patch("pkgmgr.actions.branch.close_branch.get_current_branch", side_effect=GitRunError("fail"))
     def test_close_branch_errors_if_cannot_detect_branch(self, _current) -> None:
         with self.assertRaises(RuntimeError):
             close_branch(None)

tests/unit/pkgmgr/actions/branch/test_drop_branch.py

@@ -2,7 +2,7 @@ import unittest
 from unittest.mock import patch
 
 from pkgmgr.actions.branch.drop_branch import drop_branch
-from pkgmgr.core.git.errors import GitError
+from pkgmgr.core.git.errors import GitRunError
 from pkgmgr.core.git.commands import GitDeleteRemoteBranchError
 
 
@@ -50,7 +50,7 @@ class TestDropBranch(unittest.TestCase):
         delete_local.assert_called_once_with("feature-x", cwd=".", force=False)
         delete_remote.assert_called_once_with("origin", "feature-x", cwd=".")
 
-    @patch("pkgmgr.actions.branch.drop_branch.get_current_branch", side_effect=GitError("fail"))
+    @patch("pkgmgr.actions.branch.drop_branch.get_current_branch", side_effect=GitRunError("fail"))
     def test_drop_branch_errors_if_no_branch_detected(self, _current) -> None:
         with self.assertRaises(RuntimeError):
             drop_branch(None)

tests/unit/pkgmgr/cli/commands/test_tools.py

@@ -1,11 +1,9 @@
 from __future__ import annotations
 
-import json
-import os
-import tempfile
 import unittest
 from types import SimpleNamespace
 from typing import Any, Dict, List
+from unittest.mock import call, patch
 
 from pkgmgr.cli.commands.tools import handle_tools_command
 
@@ -26,36 +24,23 @@ class TestHandleToolsCommand(unittest.TestCase):
     Unit tests for pkgmgr.cli.commands.tools.handle_tools_command.
 
     We focus on:
-      - Correct path resolution for repositories that have a 'directory' key.
+      - Correct path resolution and shell commands for 'explore' and 'terminal'.
-      - Correct shell commands for 'explore' and 'terminal'.
+      - For 'code': delegation to pkgmgr.cli.tools.open_vscode_workspace.
-      - Proper workspace creation and invocation of 'code' for the 'code' command.
     """
 
     def setUp(self) -> None:
-        # Two fake repositories with explicit 'directory' entries so that
-        # _resolve_repository_path() does not need to call get_repo_dir().
         self.repos: List[Repository] = [
             {"alias": "repo1", "directory": "/tmp/repo1"},
             {"alias": "repo2", "directory": "/tmp/repo2"},
         ]
 
-        # Minimal CLI context; only attributes used in tools.py are provided.
         self.ctx = SimpleNamespace(
             config_merged={"directories": {"workspaces": "~/Workspaces"}},
             all_repositories=self.repos,
             repositories_base_dir="/base/dir",
         )
 
-    # ------------------------------------------------------------------ #
-    # Helper
-    # ------------------------------------------------------------------ #
-
     def _patch_run_command(self):
-        """
-        Convenience context manager for patching run_command in tools module.
-        """
-        from unittest.mock import patch
-
         return patch("pkgmgr.cli.commands.tools.run_command")
 
     # ------------------------------------------------------------------ #
@@ -63,12 +48,6 @@ class TestHandleToolsCommand(unittest.TestCase):
     # ------------------------------------------------------------------ #
 
     def test_explore_uses_directory_paths(self) -> None:
-        """
-        The 'explore' command should call Nautilus with the resolved
-        repository paths and use '& disown' as in the implementation.
-        """
-        from unittest.mock import call
-
         args = _Args(command="explore")
 
         with self._patch_run_command() as mock_run_command:
@@ -85,12 +64,6 @@ class TestHandleToolsCommand(unittest.TestCase):
     # ------------------------------------------------------------------ #
 
     def test_terminal_uses_directory_paths(self) -> None:
-        """
-        The 'terminal' command should open a GNOME Terminal tab with the
-        repository as its working directory.
-        """
-        from unittest.mock import call
-
         args = _Args(command="terminal")
 
         with self._patch_run_command() as mock_run_command:
@@ -106,63 +79,10 @@ class TestHandleToolsCommand(unittest.TestCase):
     # Tests for 'code'
     # ------------------------------------------------------------------ #
 
-    def test_code_creates_workspace_and_calls_code(self) -> None:
+    def test_code_delegates_to_open_vscode_workspace(self) -> None:
-        """
-        The 'code' command should:
-
-          - Build a workspace file name from sorted repository identifiers.
-          - Resolve the repository paths into VS Code 'folders'.
-          - Create the workspace file if it does not exist.
-          - Call 'code "<workspace_file>"' via run_command.
-        """
-        from unittest.mock import patch
-
         args = _Args(command="code")
 
-        with tempfile.TemporaryDirectory() as tmpdir:
+        with patch("pkgmgr.cli.commands.tools.open_vscode_workspace") as m:
-            # Patch expanduser so that the configured '~/Workspaces'
+            handle_tools_command(args, self.ctx, self.repos)
-            # resolves into our temporary directory.
-            with patch(
-                "pkgmgr.cli.commands.tools.os.path.expanduser"
-            ) as mock_expanduser:
-                mock_expanduser.return_value = tmpdir
 
-                # Patch get_repo_identifier so the resulting workspace file
+        m.assert_called_once_with(self.ctx, self.repos)
-                # name is deterministic and easy to assert.
-                with patch(
-                    "pkgmgr.cli.commands.tools.get_repo_identifier"
-                ) as mock_get_identifier:
-                    mock_get_identifier.side_effect = ["repo-b", "repo-a"]
-
-                    with self._patch_run_command() as mock_run_command:
-                        handle_tools_command(args, self.ctx, self.repos)
-
-                    # The identifiers are ['repo-b', 'repo-a'], which are
-                    # sorted to ['repo-a', 'repo-b'] and joined with '_'.
-                    expected_workspace_name = "repo-a_repo-b.code-workspace"
-                    expected_workspace_file = os.path.join(
-                        tmpdir, expected_workspace_name
-                    )
-
-                    # Workspace file should have been created.
-                    self.assertTrue(
-                        os.path.exists(expected_workspace_file),
-                        "Workspace file was not created.",
-                    )
-
-                    # The content of the workspace must be valid JSON with
-                    # the expected folder paths.
-                    with open(expected_workspace_file, "r", encoding="utf-8") as f:
-                        data = json.load(f)
-
-                    self.assertIn("folders", data)
-                    folder_paths = {f["path"] for f in data["folders"]}
-                    self.assertEqual(
-                        folder_paths,
-                        {"/tmp/repo1", "/tmp/repo2"},
-                    )
-
-                    # And VS Code must have been invoked with that workspace.
-                    mock_run_command.assert_called_once_with(
-                        f'code "{expected_workspace_file}"'
-                    )

tests/unit/pkgmgr/cli/tools/test_paths.py

@@ -0,0 +1,38 @@
+from __future__ import annotations
+
+import unittest
+from types import SimpleNamespace
+from unittest.mock import patch
+
+
+class TestResolveRepositoryPath(unittest.TestCase):
+    def test_explicit_directory_key_wins(self) -> None:
+        from pkgmgr.cli.tools.paths import resolve_repository_path
+
+        ctx = SimpleNamespace(repositories_base_dir="/base", repositories_dir="/base2")
+        repo = {"directory": "/explicit/repo"}
+
+        self.assertEqual(resolve_repository_path(repo, ctx), "/explicit/repo")
+
+    def test_fallback_uses_get_repo_dir_with_repositories_base_dir(self) -> None:
+        from pkgmgr.cli.tools.paths import resolve_repository_path
+
+        ctx = SimpleNamespace(repositories_base_dir="/base", repositories_dir="/base2")
+        repo = {"provider": "github.com", "account": "acme", "repository": "demo"}
+
+        with patch("pkgmgr.cli.tools.paths.get_repo_dir", return_value="/computed/repo") as m:
+            out = resolve_repository_path(repo, ctx)
+
+        self.assertEqual(out, "/computed/repo")
+        m.assert_called_once_with("/base", repo)
+
+    def test_raises_if_no_base_dir_in_context(self) -> None:
+        from pkgmgr.cli.tools.paths import resolve_repository_path
+
+        ctx = SimpleNamespace(repositories_base_dir=None, repositories_dir=None)
+        repo = {"provider": "github.com", "account": "acme", "repository": "demo"}
+
+        with self.assertRaises(RuntimeError) as cm:
+            resolve_repository_path(repo, ctx)
+
+        self.assertIn("Cannot resolve repositories base directory", str(cm.exception))

tests/unit/pkgmgr/cli/tools/test_vscode.py

@@ -0,0 +1,131 @@
+from __future__ import annotations
+
+import json
+import os
+import tempfile
+import unittest
+from types import SimpleNamespace
+from typing import Any, Dict, List
+from unittest.mock import patch
+
+Repository = Dict[str, Any]
+
+
+class TestOpenVSCodeWorkspace(unittest.TestCase):
+    def test_no_selected_repos_prints_message_and_returns(self) -> None:
+        from pkgmgr.cli.tools.vscode import open_vscode_workspace
+
+        ctx = SimpleNamespace(config_merged={}, all_repositories=[])
+
+        with patch("builtins.print") as p:
+            open_vscode_workspace(ctx, [])
+
+        p.assert_called_once()
+        self.assertIn("No repositories selected.", str(p.call_args[0][0]))
+
+    def test_raises_if_code_cli_missing(self) -> None:
+        from pkgmgr.cli.tools.vscode import open_vscode_workspace
+
+        ctx = SimpleNamespace(config_merged={}, all_repositories=[])
+        selected: List[Repository] = [{"provider": "github.com", "account": "x", "repository": "y"}]
+
+        with patch("pkgmgr.cli.tools.vscode.shutil.which", return_value=None):
+            with self.assertRaises(RuntimeError) as cm:
+                open_vscode_workspace(ctx, selected)
+
+        self.assertIn("VS Code CLI ('code') not found", str(cm.exception))
+
+    def test_raises_if_identifier_contains_slash(self) -> None:
+        from pkgmgr.cli.tools.vscode import open_vscode_workspace
+
+        ctx = SimpleNamespace(
+            config_merged={"directories": {"workspaces": "~/Workspaces"}},
+            all_repositories=[],
+        )
+        selected: List[Repository] = [{"provider": "github.com", "account": "x", "repository": "y"}]
+
+        with patch("pkgmgr.cli.tools.vscode.shutil.which", return_value="/usr/bin/code"), patch(
+            "pkgmgr.cli.tools.vscode.get_repo_identifier",
+            return_value="github.com/x/y",
+        ):
+            with self.assertRaises(RuntimeError) as cm:
+                open_vscode_workspace(ctx, selected)
+
+        msg = str(cm.exception)
+        self.assertIn("not yet identified", msg)
+        self.assertIn("identifier contains '/'", msg)
+
+    def test_creates_workspace_file_and_calls_code(self) -> None:
+        from pkgmgr.cli.tools.vscode import open_vscode_workspace
+
+        with tempfile.TemporaryDirectory() as tmp:
+            workspaces_dir = os.path.join(tmp, "Workspaces")
+            repo_path = os.path.join(tmp, "Repos", "dotlinker")
+
+            ctx = SimpleNamespace(
+                config_merged={"directories": {"workspaces": workspaces_dir}},
+                all_repositories=[],
+                repositories_base_dir=os.path.join(tmp, "Repos"),
+            )
+            selected: List[Repository] = [
+                {"provider": "github.com", "account": "kevin", "repository": "dotlinker"}
+            ]
+
+            with patch("pkgmgr.cli.tools.vscode.shutil.which", return_value="/usr/bin/code"), patch(
+                "pkgmgr.cli.tools.vscode.get_repo_identifier",
+                return_value="dotlinker",
+            ), patch(
+                "pkgmgr.cli.tools.vscode.resolve_repository_path",
+                return_value=repo_path,
+            ), patch(
+                "pkgmgr.cli.tools.vscode.run_command"
+            ) as run_cmd:
+                open_vscode_workspace(ctx, selected)
+
+            workspace_file = os.path.join(workspaces_dir, "dotlinker.code-workspace")
+            self.assertTrue(os.path.exists(workspace_file))
+
+            with open(workspace_file, "r", encoding="utf-8") as f:
+                data = json.load(f)
+
+            self.assertEqual(data["folders"], [{"path": repo_path}])
+            self.assertEqual(data["settings"], {})
+
+            run_cmd.assert_called_once_with(f'code "{workspace_file}"')
+
+    def test_uses_existing_workspace_file_without_overwriting(self) -> None:
+        from pkgmgr.cli.tools.vscode import open_vscode_workspace
+
+        with tempfile.TemporaryDirectory() as tmp:
+            workspaces_dir = os.path.join(tmp, "Workspaces")
+            os.makedirs(workspaces_dir, exist_ok=True)
+
+            workspace_file = os.path.join(workspaces_dir, "dotlinker.code-workspace")
+            original = {"folders": [{"path": "/original"}], "settings": {"x": 1}}
+            with open(workspace_file, "w", encoding="utf-8") as f:
+                json.dump(original, f)
+
+            ctx = SimpleNamespace(
+                config_merged={"directories": {"workspaces": workspaces_dir}},
+                all_repositories=[],
+            )
+            selected: List[Repository] = [
+                {"provider": "github.com", "account": "kevin", "repository": "dotlinker"}
+            ]
+
+            with patch("pkgmgr.cli.tools.vscode.shutil.which", return_value="/usr/bin/code"), patch(
+                "pkgmgr.cli.tools.vscode.get_repo_identifier",
+                return_value="dotlinker",
+            ), patch(
+                "pkgmgr.cli.tools.vscode.resolve_repository_path",
+                return_value="/new/path",
+            ), patch(
+                "pkgmgr.cli.tools.vscode.run_command"
+            ) as run_cmd:
+                open_vscode_workspace(ctx, selected)
+
+            with open(workspace_file, "r", encoding="utf-8") as f:
+                data = json.load(f)
+
+            self.assertEqual(data, original)
+            run_cmd.assert_called_once_with(f'code "{workspace_file}"')

tests/unit/pkgmgr/core/git/queries/test_get_latest_signing_key.py

@@ -0,0 +1,25 @@
+import unittest
+from unittest.mock import patch
+
+from pkgmgr.core.git.errors import GitNotRepositoryError, GitRunError
+from pkgmgr.core.git.queries.get_latest_signing_key import (
+    GitLatestSigningKeyQueryError,
+    get_latest_signing_key,
+)
+
+
+class TestGetLatestSigningKey(unittest.TestCase):
+    @patch("pkgmgr.core.git.queries.get_latest_signing_key.run", return_value="ABCDEF1234567890\n")
+    def test_strips_output(self, _mock_run) -> None:
+        out = get_latest_signing_key(cwd="/tmp/repo")
+        self.assertEqual(out, "ABCDEF1234567890")
+
+    @patch("pkgmgr.core.git.queries.get_latest_signing_key.run", side_effect=GitRunError("boom"))
+    def test_wraps_git_run_error(self, _mock_run) -> None:
+        with self.assertRaises(GitLatestSigningKeyQueryError):
+            get_latest_signing_key(cwd="/tmp/repo")
+
+    @patch("pkgmgr.core.git.queries.get_latest_signing_key.run", side_effect=GitNotRepositoryError("no repo"))
+    def test_does_not_catch_not_repository_error(self, _mock_run) -> None:
+        with self.assertRaises(GitNotRepositoryError):
+            get_latest_signing_key(cwd="/tmp/no-repo")

tests/unit/pkgmgr/core/git/queries/test_get_remote_head_commit.py

@@ -0,0 +1,32 @@
+import unittest
+from unittest.mock import patch
+
+from pkgmgr.core.git.errors import GitNotRepositoryError, GitRunError
+from pkgmgr.core.git.queries.get_remote_head_commit import (
+    GitRemoteHeadCommitQueryError,
+    get_remote_head_commit,
+)
+
+
+class TestGetRemoteHeadCommit(unittest.TestCase):
+    @patch("pkgmgr.core.git.queries.get_remote_head_commit.run", return_value="abc123\tHEAD\n")
+    def test_parses_first_token_as_hash(self, mock_run) -> None:
+        out = get_remote_head_commit(cwd="/tmp/repo")
+        self.assertEqual(out, "abc123")
+        mock_run.assert_called_once()
+
+    @patch("pkgmgr.core.git.queries.get_remote_head_commit.run", return_value="")
+    def test_returns_empty_string_on_empty_output(self, _mock_run) -> None:
+        out = get_remote_head_commit(cwd="/tmp/repo")
+        self.assertEqual(out, "")
+
+    @patch("pkgmgr.core.git.queries.get_remote_head_commit.run", side_effect=GitRunError("boom"))
+    def test_wraps_git_run_error(self, _mock_run) -> None:
+        with self.assertRaises(GitRemoteHeadCommitQueryError) as ctx:
+            get_remote_head_commit(cwd="/tmp/repo")
+        self.assertIn("Failed to query remote head commit", str(ctx.exception))
+
+    @patch("pkgmgr.core.git.queries.get_remote_head_commit.run", side_effect=GitNotRepositoryError("no repo"))
+    def test_does_not_catch_not_repository_error(self, _mock_run) -> None:
+        with self.assertRaises(GitNotRepositoryError):
+            get_remote_head_commit(cwd="/tmp/no-repo")

tests/unit/pkgmgr/core/git/queries/test_remote_check.py

@@ -6,7 +6,7 @@ from __future__ import annotations
 import unittest
 from unittest.mock import patch
 
-from pkgmgr.core.git import GitError
+from pkgmgr.core.git import GitRunError
 from pkgmgr.core.git.queries.probe_remote_reachable import probe_remote_reachable
 
 
@@ -32,7 +32,7 @@ class TestProbeRemoteReachable(unittest.TestCase):
 
     @patch("pkgmgr.core.git.queries.probe_remote_reachable.run")
     def test_probe_remote_reachable_failure_returns_false(self, mock_run) -> None:
-        mock_run.side_effect = GitError("Git command failed (simulated)")
+        mock_run.side_effect = GitRunError("Git command failed (simulated)")
 
         ok = probe_remote_reachable(
             "ssh://git@code.example.org:2201/alice/repo.git",

tests/unit/pkgmgr/core/git/queries/test_resolve_base_branch.py

@@ -3,7 +3,7 @@ from __future__ import annotations
 import unittest
 from unittest.mock import patch
 
-from pkgmgr.core.git import GitError
+from pkgmgr.core.git import GitRunError
 from pkgmgr.core.git.queries.resolve_base_branch import (
     GitBaseBranchNotFoundError,
     resolve_base_branch,
@@ -21,7 +21,7 @@ class TestResolveBaseBranch(unittest.TestCase):
     @patch("pkgmgr.core.git.queries.resolve_base_branch.run")
     def test_resolves_fallback(self, mock_run):
         mock_run.side_effect = [
-            GitError("fatal: Needed a single revision"),  # treat as "missing"
+            GitRunError("fatal: Needed a single revision"),  # treat as "missing"
             "dummy",
         ]
         result = resolve_base_branch("main", "master", cwd=".")
@@ -32,8 +32,8 @@ class TestResolveBaseBranch(unittest.TestCase):
     @patch("pkgmgr.core.git.queries.resolve_base_branch.run")
     def test_raises_when_no_branch_exists(self, mock_run):
         mock_run.side_effect = [
-            GitError("fatal: Needed a single revision"),
+            GitRunError("fatal: Needed a single revision"),
-            GitError("fatal: Needed a single revision"),
+            GitRunError("fatal: Needed a single revision"),
         ]
         with self.assertRaises(GitBaseBranchNotFoundError):
             resolve_base_branch("main", "master", cwd=".")

tests/unit/pkgmgr/core/git/test_run.py

@@ -1,7 +1,7 @@
 import unittest
 from unittest.mock import MagicMock, patch
 
-from pkgmgr.core.git.errors import GitError
+from pkgmgr.core.git.errors import GitRunError
 from pkgmgr.core.git.run import run
 
 
@@ -55,7 +55,7 @@ class TestGitRun(unittest.TestCase):
         exc.stderr = "ERR!"
 
         with patch("pkgmgr.core.git.run.subprocess.run", side_effect=exc):
-            with self.assertRaises(GitError) as ctx:
+            with self.assertRaises(GitRunError) as ctx:
                 run(["status"], cwd="/bad/repo", preview=False)
 
         msg = str(ctx.exception)

tests/unit/pkgmgr/core/repository/test_verify_repository.py

@@ -0,0 +1,87 @@
+import unittest
+from unittest.mock import patch
+
+from pkgmgr.core.git.errors import GitNotRepositoryError
+from pkgmgr.core.git.queries.get_latest_signing_key import GitLatestSigningKeyQueryError
+from pkgmgr.core.git.queries.get_remote_head_commit import GitRemoteHeadCommitQueryError
+from pkgmgr.core.repository.verify import verify_repository
+
+
+class TestVerifyRepository(unittest.TestCase):
+    def test_no_verified_info_returns_ok_and_best_effort_values(self) -> None:
+        repo = {"id": "demo"}  # no "verified"
+        with patch("pkgmgr.core.repository.verify.get_head_commit", return_value="deadbeef"), patch(
+            "pkgmgr.core.repository.verify.get_latest_signing_key",
+            return_value="KEYID",
+        ):
+            ok, errors, commit, key = verify_repository(repo, "/tmp/repo", mode="local")
+        self.assertTrue(ok)
+        self.assertEqual(errors, [])
+        self.assertEqual(commit, "deadbeef")
+        self.assertEqual(key, "KEYID")
+
+    def test_best_effort_swallows_query_errors_when_no_verified_info(self) -> None:
+        repo = {"id": "demo"}
+        with patch(
+            "pkgmgr.core.repository.verify.get_head_commit",
+            return_value=None,
+        ), patch(
+            "pkgmgr.core.repository.verify.get_latest_signing_key",
+            side_effect=GitLatestSigningKeyQueryError("fail signing key"),
+        ):
+            ok, errors, commit, key = verify_repository(repo, "/tmp/repo", mode="local")
+        self.assertTrue(ok)
+        self.assertEqual(errors, [])
+        self.assertEqual(commit, "")
+        self.assertEqual(key, "")
+
+    def test_verified_commit_mismatch_fails(self) -> None:
+        repo = {"verified": {"commit": "expected", "gpg_keys": None}}
+        with patch("pkgmgr.core.repository.verify.get_head_commit", return_value="actual"), patch(
+            "pkgmgr.core.repository.verify.get_latest_signing_key",
+            return_value="",
+        ):
+            ok, errors, commit, key = verify_repository(repo, "/tmp/repo", mode="local")
+
+        self.assertFalse(ok)
+        self.assertIn("Expected commit: expected, found: actual", errors)
+        self.assertEqual(commit, "actual")
+        self.assertEqual(key, "")
+
+    def test_verified_gpg_key_missing_fails(self) -> None:
+        repo = {"verified": {"commit": None, "gpg_keys": ["ABC"]}}
+        with patch("pkgmgr.core.repository.verify.get_head_commit", return_value=""), patch(
+            "pkgmgr.core.repository.verify.get_latest_signing_key",
+            return_value="",
+        ):
+            ok, errors, commit, key = verify_repository(repo, "/tmp/repo", mode="local")
+
+        self.assertFalse(ok)
+        self.assertTrue(any("no signing key was found" in e for e in errors))
+        self.assertEqual(commit, "")
+        self.assertEqual(key, "")
+
+    def test_strict_pull_collects_remote_error_message(self) -> None:
+        repo = {"verified": {"commit": "expected", "gpg_keys": None}}
+        with patch(
+            "pkgmgr.core.repository.verify.get_remote_head_commit",
+            side_effect=GitRemoteHeadCommitQueryError("remote fail"),
+        ), patch(
+            "pkgmgr.core.repository.verify.get_latest_signing_key",
+            return_value="",
+        ):
+            ok, errors, commit, key = verify_repository(repo, "/tmp/repo", mode="pull")
+
+        self.assertFalse(ok)
+        self.assertIn("remote fail", " ".join(errors))
+        self.assertEqual(commit, "")
+        self.assertEqual(key, "")
+
+    def test_not_repository_error_is_not_caught(self) -> None:
+        repo = {"verified": {"commit": "expected", "gpg_keys": None}}
+        with patch(
+            "pkgmgr.core.repository.verify.get_head_commit",
+            side_effect=GitNotRepositoryError("no repo"),
+        ):
+            with self.assertRaises(GitNotRepositoryError):
+                verify_repository(repo, "/tmp/no-repo", mode="local")

tests/unit/pkgmgr/core/test_git_utils.py

@@ -4,7 +4,7 @@
 import unittest
 from unittest.mock import patch
 
-from pkgmgr.core.git.errors import GitError
+from pkgmgr.core.git.errors import GitRunError
 from pkgmgr.core.git.run import run
 from pkgmgr.core.git.queries import get_tags, get_head_commit, get_current_branch
 
@@ -35,7 +35,7 @@ class TestGitRun(unittest.TestCase):
             stderr="error\n",
         )
 
-        with self.assertRaises(GitError) as ctx:
+        with self.assertRaises(GitRunError) as ctx:
             run(["status"], cwd="/tmp/repo")
 
         msg = str(ctx.exception)
@@ -66,7 +66,7 @@ class TestGitQueries(unittest.TestCase):
 
     @patch("pkgmgr.core.git.queries.get_head_commit.run")
     def test_get_head_commit_failure_returns_none(self, mock_run):
-        mock_run.side_effect = GitError("fail")
+        mock_run.side_effect = GitRunError("fail")
         commit = get_head_commit(cwd="/tmp/repo")
         self.assertIsNone(commit)
 
@@ -78,7 +78,7 @@ class TestGitQueries(unittest.TestCase):
 
     @patch("pkgmgr.core.git.queries.get_current_branch.run")
     def test_get_current_branch_failure_returns_none(self, mock_run):
-        mock_run.side_effect = GitError("fail")
+        mock_run.side_effect = GitRunError("fail")
         branch = get_current_branch(cwd="/tmp/repo")
         self.assertIsNone(branch)