16a9d55d4f
References: - Current ChatGPT conversation: https://chatgpt.com/share/6935d6d7-0ae4-800f-988a-44a50c17ba48 - Extended discussion: https://chatgpt.com/share/6935d734-fd84-800f-9755-290902b8cee8 Summary: This commit performs a major cleanup and modernization of the installation pipeline: 1. Introduced a new capability-detection subsystem: - Capabilities (python-runtime, make-install, nix-flake) are detected per installer/layer. - Installers run only when they add new capabilities. - Prevents duplicated work such as Python installers running when Nix already provides the runtime. 2. Removed deprecated pkgmgr.yml manifest installer: - Dependency resolution is now delegated entirely to real package managers (Nix, pip, make, distro build tools). - Simplifies layering and avoids unnecessary recursion. 3. Reworked OS-specific installers: - Arch PKGBUILD now uses 'makepkg --syncdeps --cleanbuild --install --noconfirm'. - Debian installer now builds proper .deb packages via dpkg-buildpackage + installs them. - RPM installer now builds packages using rpmbuild and installs them via rpm. 4. Switched from remote GitHub flakes to local-flake execution: - Wrapper now executes: nix run /usr/lib/package-manager#pkgmgr - Avoids lock-file write attempts and improves reliability in CI. 5. Added bash -i based integration test: - Correctly sources ~/.bashrc and evaluates alias + venv activation. - ‘pkgmgr --help’ is now printed for debugging without failing tests. 6. Updated unit tests across all installers: - Removed references to manifest installer. - Adjusted expectations for new behaviors (makepkg, dpkg-buildpackage, rpmbuild). - Added capability subsystem tests. 7. Improved flake.nix packaging logic: - The entire project source tree is copied into the runtime closure. - pkgmgr wrapper now executes runpy inside the packaged directory. Together, these changes create a predictable, layered, capability-driven installer pipeline with consistent behavior across Arch, Debian, RPM, Nix, and Python layers.
39 lines
1.1 KiB
Python
39 lines
1.1 KiB
Python
#!/usr/bin/env python3
|
|
# -*- coding: utf-8 -*-
|
|
|
|
"""
|
|
Installer that triggers `make install` if a Makefile is present.
|
|
|
|
This is useful for repositories that expose a standard Makefile-based
|
|
installation step.
|
|
"""
|
|
|
|
import os
|
|
|
|
from pkgmgr.context import RepoContext
|
|
from pkgmgr.installers.base import BaseInstaller
|
|
from pkgmgr.run_command import run_command
|
|
|
|
|
|
class MakefileInstaller(BaseInstaller):
|
|
"""Run `make install` if a Makefile exists in the repository."""
|
|
|
|
# Logical layer name, used by capability matchers.
|
|
layer = "makefile"
|
|
|
|
MAKEFILE_NAME = "Makefile"
|
|
|
|
def supports(self, ctx: RepoContext) -> bool:
|
|
makefile_path = os.path.join(ctx.repo_dir, self.MAKEFILE_NAME)
|
|
return os.path.exists(makefile_path)
|
|
|
|
def run(self, ctx: RepoContext) -> None:
|
|
"""
|
|
Execute `make install` in the repository directory.
|
|
|
|
Any failure in `make install` is treated as a fatal error and will
|
|
propagate as SystemExit from run_command().
|
|
"""
|
|
cmd = "make install"
|
|
run_command(cmd, cwd=ctx.repo_dir, preview=ctx.preview)
|