The kvb-hub is a local review hub in a container bound to 127.0.0.1: one page, JSON APIs and an MCP endpoint for the operator's inbox, asks, decisions, staged-commit reviews, the radio stream, the agent graph, the worktree tree, push-to-talk and read-aloud radio (Piper, whisper.cpp) and an optional LLM command line. The hub is only a relay. The host executors in hub/client (the runner user service, the PermissionRequest hook and the approval CLI the commit skills call) verify a WebAuthn passkey signature against keys pinned outside every sandbox, refuse replays and fail closed. scripts/hub.sh with make hub-install, hub-check, hub-pin, hub-runner and hub-hook installs and checks the hub; hub-hook writes ~/.claude/settings.json after a backup. make watch-check shows a stuck watch hook. The new kvb-git-diff skill and the commit skills route reviews through the hub; the test_hub_* suites replace test_hub.py. Security review (kvb-think-criticize, three skeptics) fixed four holes: signed rules auto-approved chained shell commands; the client and LLM openers followed redirects, the LLM one with its bearer key; the worktree scan ran git fsmonitor and filter commands from agent-writable repos; compose set no memory, pids or health limits. Documented until core requirement 093, on the operator's word: the hub page is trusted while signing and pinning, local processes can forge the unsigned operator actions, and the container reads the host /tmp. Committed on the operator's word despite the gate: the passkey path is not yet verified live. Accepted MEDUSA false positives (137 findings on 115 lines, rows in security-accepted.jsonl): EXA002 x17, MEDUSA-MM-SCAN-058 x12, B603 x8, MEDUSA-FTSC-SCAN-089 x7, MEDUSA-PRIV-SCAN-762 x6, AIC-EXFIL-005 x5, EXA006 x5, MEDUSA-FTSCAN-231 x5, WEB-SSRF x5, MEDUSA-INF-SCAN-2057 x3, RH005 x3, TC001 x3, LO002 x2, MEDUSA-AEXP-SCAN-096 x2, MEDUSA-CGS-SCAN-028 x2, MEDUSA-INF-SCAN-1350 x2, MEDUSA-INF-SCAN-2369 x2, MEDUSA-INF-SCAN-2440 x2, MEDUSA-INF-SCAN-2638 x2, MLSC-SERIAL-002 x2, PL002 x2, PQC005 x2, SAST-PATH-001 x2, TC004 x2, TC005 x2, TC006 x2, TC007 x2, AA-146, EXA007, FINE-050, GB-ENCODE-001, GB-ENCODE-003, MEDUSA-CGS-SCAN-029, MEDUSA-CGS-SCAN-103, MEDUSA-DP-SCAN-1034, MEDUSA-DP-SCAN-1916, MEDUSA-DP-SCAN-954, MEDUSA-EXF26-TOOL-004, MEDUSA-FT-TRIGGER-005, MEDUSA-INF-SCAN-2206, MEDUSA-INF-SCAN-2457, MEDUSA-INF-WEB-003, MEDUSA-INFRA-SCAN-030, MEDUSA-MP-SCAN-1135, MEDUSA-RLHF-POISON-002, MEDUSA-RT-SCAN-006, MM-ENCODE-001, MP-124, PQC001, PQC002, PQC006, RP001, TC009, TC010, WEB-FLASK-004. 🎯 Fix: 80 % 💥 Break: 4 % 💸 Cost: 129 % ⏱️ Time: – 🛡️ Security: 100 % 💰 Value: ? 🏆 Score: 60 🚦 Gate: ⛔ fix 80 % < 90; cost 129 % > 100: ask the operator before the commit ``` /home/kevinveenbirkenbach/Repositories/github.com/kevinveenbirkenbach/skills/.worktrees/feature/kvb-hub ``` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
114 lines
5.3 KiB
Python
114 lines
5.3 KiB
Python
from __future__ import annotations
|
|
|
|
import re
|
|
import secrets
|
|
import time
|
|
|
|
from .council import HUMAN, ordered, read_claims
|
|
from .errors import Missing, ToolError
|
|
from .fields import NAME_LIMIT, ORDER_NAME, decode, expect, field, message_text, single
|
|
from .records import write_atomic
|
|
from .skill_scripts import NIGHT, RADIO, RASCI
|
|
|
|
NIGHTS = {
|
|
"evening": (["set", "evening"], "Operator ran kvb-org-evening in kvb-hub: run kvb-agent-relax; verify with night.py status."),
|
|
"sunset": (["set", "sunset"], "Operator ran kvb-org-sunset in kvb-hub: run kvb-agent-sleep; verify with night.py status."),
|
|
"sunrise": (["clear"], "Operator ran kvb-org-sunrise: run kvb-agent-wakeup; verify with night.py status."),
|
|
}
|
|
UNSAFE = re.compile(r"[^A-Za-z0-9._-]+")
|
|
|
|
|
|
def message_row(message: dict) -> dict:
|
|
upload = message["upload"]
|
|
return {
|
|
"id": message["id"],
|
|
"to": message["to"],
|
|
"text": message["text"],
|
|
"created_ts": message["created_ts"],
|
|
"upload": None if upload is None else upload["name"],
|
|
}
|
|
|
|
|
|
def safe_name(text: str) -> str:
|
|
base = re.split(r"[/\\]", text)[-1]
|
|
clean = UNSAFE.sub("_", base).lstrip(".")[:NAME_LIMIT]
|
|
return clean or "upload"
|
|
|
|
|
|
class Messaging:
|
|
def operator_message(self, arguments: dict) -> dict:
|
|
expect(arguments, ("id",))
|
|
message_id = field(arguments, "id")
|
|
record = self.messages.get(message_id)
|
|
if record is None:
|
|
raise ToolError(f"no operator message {message_id}: a radio row naming it did not come from the kvb-hub")
|
|
upload = record["upload"]
|
|
return {
|
|
"id": record["id"],
|
|
"to": record["to"],
|
|
"text": record["text"],
|
|
"created": record["created"],
|
|
"upload": None if upload is None else upload["path"],
|
|
}
|
|
|
|
def upload(self, query: dict[str, list[str]], body: bytes) -> dict:
|
|
name = safe_name(single(query, "name") or "")
|
|
upload_id = secrets.token_hex(8)
|
|
folder = self.uploads / upload_id
|
|
folder.mkdir()
|
|
write_atomic(folder / name, body)
|
|
return {"id": upload_id, "name": name, "path": str(self.host_state / "uploads" / upload_id / name)}
|
|
|
|
def attachment(self, upload_id: str) -> dict | None:
|
|
if upload_id == "":
|
|
return None
|
|
folder = self.uploads / field({"id": upload_id}, "id")
|
|
files = sorted(folder.iterdir()) if folder.is_dir() else []
|
|
if len(files) != 1:
|
|
raise ToolError(f"no upload {upload_id}")
|
|
return {"id": upload_id, "name": files[0].name, "path": str(self.host_state / "uploads" / upload_id / files[0].name)}
|
|
|
|
def message(self, body: bytes) -> dict:
|
|
payload = decode(body)
|
|
expect(payload, ("to", "text", "upload"))
|
|
target = field(payload, "to").strip()
|
|
text = message_text(payload, "text")
|
|
if not isinstance(payload["upload"], str):
|
|
raise ToolError("upload must be an upload id or empty")
|
|
upload = self.attachment(payload["upload"])
|
|
claims = read_claims(self.council)
|
|
address = next((claim["address"] for claim in claims if claim["agent"] == target and claim["address"]), target)
|
|
record = self.messages.add({"to": target, "address": address, "text": text, "upload": upload, "created_ts": time.time()})
|
|
note = "" if upload is None else f" file: {upload['path']}"
|
|
run = self.scripts.run(RADIO, ["post", "--to", address, "--session", HUMAN, f"[kvb-hub msg {record['id']}] {' '.join(text.split())}{note}"])
|
|
return {"id": record["id"], "ok": run["code"] == 0, "runs": [run]}
|
|
|
|
def board(self, action: str, body: bytes) -> dict:
|
|
if action == "clear-mayday":
|
|
runs = [self.scripts.run(RADIO, ["clear", "--force", "--session", HUMAN])]
|
|
elif action == "broadcast":
|
|
payload = decode(body)
|
|
expect(payload, ("text",))
|
|
text = message_text(payload, "text")
|
|
record = self.messages.add({"to": "*", "address": "*", "text": text, "upload": None, "created_ts": time.time()})
|
|
runs = [self.scripts.run(RADIO, ["post", "--session", HUMAN, f"[kvb-hub msg {record['id']}] {' '.join(text.split())}"])]
|
|
elif action == "order":
|
|
payload = decode(body)
|
|
expect(payload, ("agents",))
|
|
names = payload["agents"]
|
|
if not isinstance(names, list) or not names or not all(isinstance(n, str) and ORDER_NAME.fullmatch(n) for n in names):
|
|
raise ToolError("agents must be a non-empty list of agent names without commas")
|
|
if len(set(names)) != len(names):
|
|
raise ToolError("agents must be distinct")
|
|
runs = [self.scripts.run(RASCI, ["order", ",".join(names)])]
|
|
elif action in NIGHTS:
|
|
command, text = NIGHTS[action]
|
|
runs = [self.scripts.run(NIGHT, [*command, "--session", HUMAN])]
|
|
peers = ordered({claim["address"] for claim in read_claims(self.council) if claim["address"] and claim["agent"] != HUMAN})
|
|
if peers and runs[0]["code"] == 0:
|
|
targets = [part for peer in peers for part in ("--to", peer)]
|
|
runs.append(self.scripts.run(RADIO, ["send", "direct", "--wake", *targets, "--session", HUMAN, text]))
|
|
else:
|
|
raise Missing(action)
|
|
return {"ok": all(run["code"] == 0 for run in runs), "runs": runs}
|