Files
skills/tests/test_hub_grant_mode.py
T
Kevin Veen-BirkenbachandClaude Opus 5.5 d695bb2b58 feat(hub): grant split menu, radio redesign and answerable decision rows
The Grant bar becomes one split control: Select, or Grant N with a menu for Deny, Grant all green, the picked list, Clear and Direct mode; picked items turn pale green. The radio drops its filter flyout and gains three-state bells per row, a test per row including Speak, Auto or Morse on a second click, mute on the sender avatar and the agent profile, Cancel MAYDAY beside Send only while one is active, a Send menu with a test message and hold-to-record push-to-talk. Decision rows read as questions with their options; the signed answer is Decision <id> plus Answer: <answer>, and the card names its recipient.

Security: the passkey-signed answer carries no agent-written text, the inbox lists answerable rows only when their id fullmatches the TASK rule of the installed rasci.py (skill_scripts.task_pattern), and rasci.py, operator.py and hotfix.py check task slugs with fullmatch, so a trailing newline no longer passes.

Accepted MEDUSA findings after kvb-think-criticize: page-inbox.js:116 EXA006 (by design after the fix), page-inbox.js:125 EXA010, operator.py:173, 618 and 633 RP001, FT-TRIGGER-005 and RLHF-POISON-002, operator.py:639 MEX-SCAN-346, operator.py:968 MM-SCAN-058, operator.py:974 ACP-SCAN-028 (false positives).

🎯 Fix: 85 %
💥 Break: 10 %
💸 Tokens: –
⏱️ Velocity: –
🛡️ Security: 100 %
🏆 Score: 77
🚦 Gate: ⛔ fix 85 % < 90, break 10 % > 5

Created-with: https://s.veen.world/skills
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-18 19:28:37 +00:00

197 lines
11 KiB
Python

from __future__ import annotations
import json
import subprocess
import unittest
from hub_support import HUB
TEMPLATES = HUB / "templates"
MODULES = ["page-constants.js", "page-reveal.js", "page-dom.js", "page-inbox.js", "page-grant.js"]
PROBE = r"""
const fs = require("fs");
const vm = require("vm");
const [dir, names] = [process.argv[1], JSON.parse(process.argv[2])];
class El {
constructor(tag) { Object.assign(this, {tag, children: [], attrs: {}, dataset: {}, style: {}, handlers: {}, hidden: false, textContent: ""}); }
setAttribute(key, value) {
this.attrs[key] = String(value);
if (key.startsWith("data-")) {
this.dataset[key.slice(5).replace(/-([a-z])/g, (_, letter) => letter.toUpperCase())] = String(value);
}
}
getAttribute(key) { return Object.hasOwn(this.attrs, key) ? this.attrs[key] : null; }
append(...nodes) { this.children.push(...nodes); }
replaceChildren(...nodes) { this.children = nodes; }
addEventListener(name, handler) { this.handlers[name] = handler; }
click() { this.handlers.click({stopPropagation() {}, preventDefault() {}}); }
remove() {}
}
const all = (node) => [node, ...(node.children || []).filter((child) => child instanceof El).flatMap(all)];
const text = (node) => (typeof node === "string" ? node : (node.children || []).map(text).join(""));
const buttons = (node) => all(node).filter((el) => el.tag === "button");
const document = {
currentScript: null, body: new El("body"), hidden: false, activeElement: null,
getElementById: (id) => Object.assign(new El("div"), {textContent: id === "emoji-bases" ? "[]" : ""}),
createElement: (tag) => new El(tag), createElementNS: (ns, tag) => new El(tag),
};
const now = 1_800_000_000;
const base = {agent: "Store", to: "Store", detail: "", green: false, gate: "", score: "", warnings: [], options: [], recommended: "", command: "", directory: "/repo", sha256: "s", runnable: false, deniable: false, job: null, rule: null, dry_run: null, diff: null, pinned: false, until: 0, held: false, ts: now};
const items = {
green: {...base, kind: "review", id: "r-green", title: "feat: green", gate: "pass", green: true},
red: {...base, kind: "review", id: "r-red", title: "feat: red", gate: "fail"},
ask: {...base, kind: "ask", id: "a-1", title: "git push: ask", command: "git push"},
run: {...base, kind: "operator", id: "operator/run", title: "make install", command: "make install", runnable: true, deniable: true},
pick: {...base, kind: "decision", id: "d-1", title: "Which?", recommended: "A", options: [{label: "A", description: ""}]},
rule: {...base, kind: "rule", id: "1123456789abcdef", title: "Rule ask Bash make deploy"},
};
const mode = {value: "select"};
const sets = [];
const listeners = [];
const context = {
console, document, JSON, Math, Date, Intl, Promise, Set, Map, Number, String, Array, Object, RegExp, Boolean, Error, setTimeout,
Node: El, Element: El, HTMLElement: El,
window: {location: {hash: "", hostname: "localhost", port: "8737", pathname: "/"}, setTimeout: () => 0, clearTimeout: () => {}, setInterval: () => 0, clearInterval: () => {}, getSelection: () => "", matchMedia: () => ({matches: false})},
state: {inbox: [], radio: [], messages: [], settings: {}, now},
ui: {screen: "inbox", busy: false, selected: new Set(), cursor: 0, snoozed: false, asOf: null},
known: {batches: new Set()},
ViewStore: {get: (path) => (path === "approval.mode" ? mode.value : null), set: (path, value) => { sets.push([path, value]); mode.value = value; }, on: (path, callback) => listeners.push([path, callback])},
denySplit: () => new El("deny"), jobOpen: () => false, load: async () => {}, openItem: () => {},
items, mode, sets, listeners, all, text, buttons,
};
const source = names.map((name) => fs.readFileSync(`${dir}/${name}`, "utf8")).join("\n");
const probe = `
const proofs = [];
const accepts = [];
let renders = 0;
let streams = 0;
proofFor = async (entries) => { proofs.push(entries.map((entry) => entry.kind + ":" + entry.id)); return null; };
acceptRule = (item) => { accepts.push(item.id); };
render = () => { renders += 1; };
drawStream = () => { streams += 1; };
toast = () => ({remove() {}});
const results = {};
const take = () => ({selected: [...ui.selected].sort(), proofs: proofs.splice(0), accepts: accepts.splice(0), renders, streams});
const press = (item) => {
const first = actionsFor(item)[0];
return {pressed: first.getAttribute("aria-pressed"), title: first.getAttribute("title"), disabled: Boolean(first.disabled), picked: (first.getAttribute("class") || "").split(" ").includes("picked")};
};
const labels = (node) => buttons(node).map((button) => button.getAttribute("aria-label"));
const byName = (node, label) => buttons(node).find((button) => button.getAttribute("aria-label") === label);
(async () => {
state.inbox = Object.values(items).map((item) => ({...item}));
const of = (key) => state.inbox.find((item) => item.id === items[key].id);
results.unpressed = press(of("green"));
await approveOne(of("green"));
results.added = take();
results.pressed = press(of("green"));
await approveOne(of("green"));
results.removed = take();
for (const key of ["green", "ask", "run", "pick"]) {
await approveOne(of(key));
}
results.collected = take();
await approveOne(of("red"));
results.red = {...take(), press: press(of("red"))};
await approveOne(of("rule"));
results.rule = {...take(), press: press(of("rule"))};
grantBoot();
const bar = grantView.tray;
const summary = () => all(bar).find((node) => node.tag === "summary").getAttribute("aria-label");
results.tray = {summary: summary(), labels: labels(bar), main: buttons(bar)[0].getAttribute("aria-label"), listen: listeners.map(([path]) => path)};
byName(bar, "Remove make install").click();
results.unpicked = take();
byName(bar, "Clear").click();
results.cleared = take();
byName(bar, "Direct").click();
results.switched = sets.splice(0);
drawGrant();
results.direct_tray = {summary: summary(), labels: labels(bar), main: buttons(bar)[0].getAttribute("id")};
results.direct_press = press(of("green"));
await approveOne(of("green"));
results.direct = take();
ui.selected.add(keyOf(of("ask")));
results.direct_picked = press(of("ask"));
drawGrant();
results.direct_selection = {main: buttons(bar)[0].getAttribute("aria-label"), labels: labels(bar)};
ui.selected.clear();
console.log(JSON.stringify(results));
})().catch((error) => { console.error(error && error.stack || error); process.exit(1); });
`;
vm.runInNewContext(`${source}\n${probe}`, {...context, process});
"""
class TestGrantMode(unittest.TestCase):
@classmethod
def setUpClass(cls):
done = subprocess.run(["node", "-e", PROBE, str(TEMPLATES), json.dumps(MODULES)], capture_output=True, text=True, timeout=60, check=False)
if done.returncode != 0:
raise AssertionError(done.stderr[-4000:])
cls.data = json.loads(done.stdout)
def test_a_grant_in_select_toggles_the_selection_without_a_signature(self):
self.assertEqual(self.data["added"]["selected"], ["review:r-green"])
self.assertEqual(self.data["added"]["proofs"], [])
self.assertEqual((self.data["added"]["renders"], self.data["added"]["streams"]), (1, 1))
self.assertEqual(self.data["removed"]["selected"], [])
self.assertEqual(self.data["removed"]["proofs"], [])
def test_every_selectable_kind_collects_in_select(self):
self.assertEqual(self.data["collected"]["selected"], ["ask:a-1", "decision:d-1", "operator:operator/run", "review:r-green"])
self.assertEqual(self.data["collected"]["proofs"], [])
def test_a_picked_item_shows_a_pale_green_disabled_grant_button(self):
self.assertEqual(self.data["unpressed"]["pressed"], "false")
self.assertTrue(self.data["unpressed"]["title"].startswith("Select: "), self.data["unpressed"])
self.assertEqual((self.data["unpressed"]["disabled"], self.data["unpressed"]["picked"]), (False, False))
pressed = self.data["pressed"]
self.assertEqual((pressed["pressed"], pressed["disabled"], pressed["picked"]), ("true", True, True))
self.assertEqual(pressed["title"], "In the selection: take it out with ✕ in the Grant menu")
def test_a_checkbox_pick_in_direct_also_turns_the_button_pale_and_opens_the_grant_split(self):
picked = self.data["direct_picked"]
self.assertEqual((picked["pressed"], picked["disabled"], picked["picked"]), (None, True, True))
self.assertEqual(self.data["direct_selection"]["main"], "Grant selection (1)")
self.assertEqual(self.data["direct_selection"]["labels"][-1], "Select")
def test_a_red_gate_and_a_rule_stay_direct_in_select_and_say_why(self):
self.assertEqual(self.data["red"]["proofs"], [["review:r-red"]])
self.assertEqual(self.data["red"]["press"]["pressed"], None)
self.assertEqual(self.data["red"]["press"]["title"], "Grant: acts at once, a red gate is never granted in a selection")
self.assertEqual(self.data["rule"]["accepts"], ["1123456789abcdef"])
self.assertEqual(self.data["rule"]["proofs"], [])
self.assertTrue(self.data["rule"]["press"]["title"].endswith(": acts at once, a rule is accepted one at a time"), self.data["rule"])
def test_one_split_grants_the_selection_and_its_menu_holds_the_rest(self):
tray = self.data["tray"]
self.assertEqual(tray["main"], "Grant selection (4)")
self.assertEqual(tray["summary"], "4 selected")
self.assertEqual(tray["labels"], [
"Grant selection (4)", "Deny selection (2)", "Grant all green (1)",
"Remove feat: green", "Remove git push: ask", "Remove make install", "Remove Which?",
"Clear", "Direct",
])
self.assertEqual(tray["listen"], ["approval"])
def test_a_picked_item_leaves_the_selection_through_its_menu_entry(self):
self.assertEqual(self.data["unpicked"]["selected"], ["ask:a-1", "decision:d-1", "review:r-green"])
self.assertEqual(self.data["unpicked"]["proofs"], [])
def test_clear_empties_the_selection(self):
self.assertEqual(self.data["cleared"]["selected"], [])
def test_the_switch_stores_the_mode_in_the_view_store(self):
self.assertEqual(self.data["switched"], [["approval.mode", "direct"]])
def test_direct_without_a_pick_shows_select_and_grants_at_once(self):
self.assertEqual(self.data["direct_tray"], {"summary": "0 selected", "labels": ["Select", "Deny selection (0)", "Grant all green (1)", "Clear"], "main": "grant-select"})
self.assertEqual(self.data["direct_press"]["pressed"], None)
self.assertEqual(self.data["direct_press"]["title"], "Grant")
self.assertEqual(self.data["direct"]["proofs"], [["review:r-green"]])
self.assertEqual(self.data["direct"]["selected"], [])
if __name__ == "__main__":
unittest.main()