A Direct/Select switch in the header (ids grant-direct, grant-select; ViewStore approval.mode) decides whether a grant button acts at once or adds its item to a selection that a tray grants under one passkey signature; rules and red gates still act at once. The review sheet shows every file in one scrolling stack whose next file opens as the previous one ends (openOnScroll moves to page-diff.js and serves Match too). The grant bar boots before the header is measured, so --head counts it. The inbox denial sheet takes an optional reason for every requester; it shares page-inbox.js hunks with the selection code, so both land in this one commit. Fix stays below 90: the header ids and the measure order fix e2e failures of the aborted final run of 2026-11-17 that the master gate has not rerun yet. Accepted MEDUSA false positives (security.py accept after kvb-think-criticize, 2026-11-17): page-inbox.js PQC007 EXA010; page-match.js EXA010. 🎯 Fix: 85 % 💥 Break: 5 % 💸 Tokens: – ⏱️ Velocity: – 🛡️ Security: 100 % 🏆 Score: 81 🚦 Gate: ⛔ fix 85 % < 90 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
104 lines
4.9 KiB
Markdown
104 lines
4.9 KiB
Markdown
# 020 - Bulk grant mode and continuous diff
|
|
|
|
## User Story
|
|
|
|
As the operator, I want one switch at the top right that turns every grant
|
|
button of the hub into "add to selection", with one tray that grants the
|
|
selection under one passkey signature, and a review diff that runs on into
|
|
the next file as I scroll, so that I can review and grant many items in one
|
|
pass.
|
|
|
|
## Decisions (operator-confirmed 2026-11-17; do not re-litigate)
|
|
|
|
1. **Continuous diff**: the review sheet stacks every file in one scroll; a
|
|
file opens when the end of the file before it comes into view (as
|
|
`openOnScroll` does in the Match deck); the tree marks the file in view
|
|
and a click in the tree scrolls to that file. Rejected: overscroll
|
|
advance (trackpad inertia skips files), a "Next file" button (not
|
|
automatic).
|
|
2. **Mode switch**: a segmented control "Direct | Select" in the header
|
|
tools at the top right; Direct keeps today's behaviour. Rejected: a
|
|
switch per view.
|
|
3. **What collects**: in Select, every grant button toggles its item into
|
|
one shared selection (pressed state): inbox rows, Home, stream rows, the
|
|
review sheet and the key `a`. A grant of an item `selectable()` refuses
|
|
(red-gate review, rule request, decision without a recommendation,
|
|
operator row without a command) stays direct and its title says why.
|
|
Deny always acts at once with its reason; the Match deck and the palette
|
|
keep their own confirmed release. Rejected: a unified tray where denials
|
|
collect too.
|
|
4. **Tray**: in Select, beside the switch: `n selected` with Grant n,
|
|
Deny n, Grant all green and Clear. Grant and Deny open the existing
|
|
selection sheet that lists every entry and full command; one passkey
|
|
signs, then 3 s remain to undo. The selection is the inbox selection
|
|
(`ui.selected`), kept in page memory until granted, denied or cleared.
|
|
5. **Memory**: the mode lives in the hub view store (`approval.mode`,
|
|
`direct` or `select`, default `direct`), like the legend toggles.
|
|
Rejected: per browser only.
|
|
6. **Trust unchanged**: nothing is granted without the passkey signature
|
|
over exactly the listed items; server and signing path stay as they are.
|
|
Rejected: a trust window of direct grants without a prompt.
|
|
7. **Timing**: after 018, reject-with-reason and the score chips.
|
|
|
|
## Approach
|
|
|
|
```mermaid
|
|
flowchart TD
|
|
subgraph P["🧭 0 · Preparation"]
|
|
P1["📋 Write requirement"] --> P2{"✅ Operator approves?"}
|
|
P2 -- "✏️ corrections" --> P1
|
|
end
|
|
P2 -- "🤖 yes" --> A1
|
|
subgraph A["📜 A · Continuous diff"]
|
|
A1["🧾 Stack files, open on scroll, tree follows"] --> A2{"🧪 Unit and E2E green?"}
|
|
A2 -- "🔴 no: fix" --> A1
|
|
end
|
|
A2 -- "🟢 yes" --> B1
|
|
subgraph B["🧺 B · Bulk mode"]
|
|
B1["🎚️ Switch, view store key, tray, grants toggle the selection"] --> B2{"🧪 Unit and E2E green?"}
|
|
B2 -- "🔴 no: fix" --> B1
|
|
B2 -- "🟢 yes" --> BF{"💬 Operator feedback on screenshots?"}
|
|
BF -- "✏️ changes" --> A1
|
|
end
|
|
BF -- "👍 fits" --> D1["🏁 Review, commit with operator OK, hand-over"]
|
|
```
|
|
|
|
## Acceptance Criteria
|
|
|
|
### Continuous diff
|
|
|
|
- [ ] A review of 3 files shows file 1 open, files 2 and 3 closed; scrolling
|
|
the diff pane to the end of file 1 opens file 2 without a click, and
|
|
the tree marks the file in view.
|
|
- [ ] A click on file 3 in the tree scrolls file 3 to the top of the pane
|
|
and opens it.
|
|
|
|
### Bulk mode
|
|
|
|
- [ ] The header tools hold a "Direct | Select" switch; its state is stored
|
|
as `approval.mode` in the view store, survives a reload, and the store
|
|
refuses any value but `direct` or `select`.
|
|
- [ ] In Select, the grant button of a green review, an ask and a runnable
|
|
operator row (inbox, Home, stream, review sheet, key `a`) sends nothing
|
|
to `/api/sign` and adds the item to the selection; a second press
|
|
removes it; the tray counts it.
|
|
- [ ] Tray "Grant n" opens the selection sheet with exactly the selected
|
|
entries; one passkey signature covers them all, and after the undo time
|
|
each is granted.
|
|
- [ ] In Select, the grant of a red-gate review and Accept on a rule request
|
|
act directly as in Direct; Deny acts at once in both modes.
|
|
- [ ] In Direct, every grant button acts as today and the tray is hidden.
|
|
|
|
### Tests
|
|
|
|
- [ ] Unit: view store validation of `approval.mode`; page vm: a grant in
|
|
Select toggles `ui.selected` without a post, a grant in Direct posts, a
|
|
grant of a non-selectable item stays direct, the tray counts.
|
|
- [ ] Integration: n/a: the server and the signing path stay unchanged
|
|
(decision 6).
|
|
- [ ] E2E: Chromium and Firefox at 1920, 1366 and 390: the continuous diff
|
|
opens file 2 on scroll and jumps to file 3 from the tree; the switch
|
|
persists over a reload; three grants in Select give a tray of 3;
|
|
Grant 3 makes one signed post listing 3 items; Direct posts at once; no
|
|
horizontal scroll; screenshots for the checkpoint.
|