Sandboxed agents cannot reach the hub on localhost:8737 (refused directly, timeout through the sandbox proxy), so approval.py verify failed and every kvb-git-diff approval fell back to the chat question (Quality: 3 reviews on 2026-11-17). The MCP tools review_status and review_wait, which run outside the sandbox, now also return the review's passkey proof, the record the HTTP proof route already served; approval.py verify --record <file> reads that object instead of fetching it and checks the signature against the pinned approvers, the replay store and the local tree as before, so trust stays with the operator's passkey, not the transport. kvb-git-diff names the sandbox path. 🎯 Fix: 93 % 💥 Break: 3 % 💸 Tokens: 100 % ⏱️ Velocity: 100 % 🛡️ Security: 100 % 🏆 Score: 90 🚦 Gate: ✅ 90/5, tokens and velocity <= 100, security 100 % Created-with: https://s.veen.world/skills Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
52 lines
2.4 KiB
Markdown
52 lines
2.4 KiB
Markdown
---
|
|
name: kvb-git-diff
|
|
description: >
|
|
Approve staged commits in the Agent Orchestrator; commit skills run it.
|
|
---
|
|
|
|
The commit skills run this where they ask for the commit approval. A hub
|
|
approval is the operator's word for one commit, the exact tree it names, only
|
|
once the operator's pinned passkey signature over it verifies here.
|
|
|
|
1. Render the page. `<repo>` is the repository's name, `<branch>` the
|
|
branch with every `/` as `-`, `<base>` the branch's base, `<table>` a
|
|
file under `/tmp` holding the kvb-check-score commit table, `<pages>`
|
|
and `<approvals>` the directories
|
|
`${CLAUDE_SKILL_DIR}/../kvb-org-organize/scripts/councilroot.py dir pages`
|
|
and `... dir approvals` print, in the council root the hub reads:
|
|
|
|
```bash
|
|
pkgmgr review --out <pages>/<repo>-<branch>.html --max-file-lines 400 --base <base> --note <table>
|
|
```
|
|
|
|
2. Request the review in the worktree; it ships the staged diff, every file
|
|
MEDUSA's secret rules or an armour line flag by stat only, so the hub
|
|
shows it on the card. `<gate>` is
|
|
`pass` when every gate the calling skill ran is green, else `fail`;
|
|
`<agent>` your agent name, which inline feedback is posted to:
|
|
|
|
```bash
|
|
python3 ~/.local/share/kvb-orchestrator/client/approval.py request --port 8737 --title "<subject>" --page <pages>/<repo>-<branch>.html --notes <table> --gate <gate> --score "<score line>" --agent "<agent>"
|
|
```
|
|
|
|
Only a `pass` review can be approved in bulk or by a rule. Tell the
|
|
operator the `url` it prints in one plain-text line; chat links do not
|
|
open for this operator. Without the script or port 8737, the MCP tool
|
|
`review_request` takes the same fields without the diff.
|
|
3. Call `review_wait` with its `id` and `timeout_seconds` 240 until the
|
|
status is no longer `pending`.
|
|
4. `approved`: in the worktree, verify the operator's passkey signature
|
|
first, `<gate>` being the `gate` from step 2:
|
|
|
|
```bash
|
|
python3 ~/.local/share/kvb-orchestrator/client/approval.py verify --port 8737 --approvers ~/.config/kvb-orchestrator/approvers.json --replay <approvals>/commit.json --review <id> --gate <gate>
|
|
```
|
|
|
|
Sandboxed without port 8737: save `review_wait`'s answer under `/tmp`,
|
|
add `--record <file>`.
|
|
Exit 0 only: commit as the calling skill says. Any other exit,
|
|
`rejected`, or the tree changed: no commit; report the printed reason.
|
|
|
|
No kvb-orchestrator tools, or the verify step refused: ask the calling
|
|
skill's approval question in chat.
|